)]}'
{"id":"openocd~master~I17dba0dcea311d394b303c587bc2dfaa99d67859","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1002160":{"account":{"_account_id":1002160,"name":"Artemiy Volkov","display_name":"Artemiy Volkov","email":"artemiy@synopsys.com","username":"artemiy-volkov","status":"Synopsys"},"last_update":"2024-01-13 14:40:27.000000000","reason":"Change was submitted"},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2023-12-31 17:27:36.000000000","reason":"\u003cGERRIT_ACCOUNT_1000021\u003e replied on the change","reason_account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}},"1001956":{"account":{"_account_id":1001956,"name":"Stephanos Ioannidis","email":"root@stephanos.io","username":"stephanosio"},"last_update":"2024-01-13 14:40:27.000000000","reason":"Change was submitted"},"1001674":{"account":{"_account_id":1001674,"name":"Evgeniy Didin","email":"didin@synopsys.com","username":"EvgeniiDidin"},"last_update":"2023-07-31 09:54:57.000000000","reason":"Reviewer/Cc was removed"}},"hashtags":[],"change_id":"I17dba0dcea311d394b303c587bc2dfaa99d67859","subject":"target/arc: skip over breakpoints in arc_resume()","status":"MERGED","created":"2023-07-17 13:42:08.000000000","updated":"2024-01-13 14:40:27.000000000","submitted":"2024-01-13 14:40:27.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":5,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7817","meta_rev_id":"3aae8ac4e5b4cca2fe6658d7b31560e5577be706","_number":7817,"owner":{"_account_id":1002160,"name":"Artemiy Volkov","display_name":"Artemiy Volkov","email":"artemiy@synopsys.com","username":"artemiy-volkov","status":"Synopsys"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1001674,"name":"Evgeniy Didin","email":"didin@synopsys.com","username":"EvgeniiDidin"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-01-13 14:40:27.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-01-13 14:40:27.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-01-13 14:40:27.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1001674,"name":"Evgeniy Didin","email":"didin@synopsys.com","username":"EvgeniiDidin"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1001956,"name":"Stephanos Ioannidis","email":"root@stephanos.io","username":"stephanosio"}],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1001674,"name":"Evgeniy Didin","email":"didin@synopsys.com","username":"EvgeniiDidin"},{"_account_id":1001956,"name":"Stephanos Ioannidis","email":"root@stephanos.io","username":"stephanosio"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-07-17 13:42:08.000000000","updated_by":{"_account_id":1002160,"name":"Artemiy Volkov","display_name":"Artemiy Volkov","email":"artemiy@synopsys.com","username":"artemiy-volkov","status":"Synopsys"},"reviewer":{"_account_id":1001956,"name":"Stephanos Ioannidis","email":"root@stephanos.io","username":"stephanosio"},"state":"REVIEWER"},{"updated":"2023-07-17 13:42:08.000000000","updated_by":{"_account_id":1002160,"name":"Artemiy Volkov","display_name":"Artemiy Volkov","email":"artemiy@synopsys.com","username":"artemiy-volkov","status":"Synopsys"},"reviewer":{"_account_id":1001674,"name":"Evgeniy Didin","email":"didin@synopsys.com","username":"EvgeniiDidin"},"state":"REVIEWER"},{"updated":"2023-07-17 14:05:18.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-07-23 14:35:04.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"CC"},{"updated":"2023-07-31 09:54:57.000000000","updated_by":{"_account_id":1002160,"name":"Artemiy Volkov","display_name":"Artemiy Volkov","email":"artemiy@synopsys.com","username":"artemiy-volkov","status":"Synopsys"},"reviewer":{"_account_id":1001674,"name":"Evgeniy Didin","email":"didin@synopsys.com","username":"EvgeniiDidin"},"state":"CC"},{"updated":"2023-08-04 14:18:18.000000000","updated_by":{"_account_id":1001674,"name":"Evgeniy Didin","email":"didin@synopsys.com","username":"EvgeniiDidin"},"reviewer":{"_account_id":1001674,"name":"Evgeniy Didin","email":"didin@synopsys.com","username":"EvgeniiDidin"},"state":"REVIEWER"},{"updated":"2023-12-31 17:27:36.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"3764be83e43f1f562b6dacf60523910af156c458","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002160,"name":"Artemiy Volkov","display_name":"Artemiy Volkov","email":"artemiy@synopsys.com","username":"artemiy-volkov","status":"Synopsys"},"real_author":{"_account_id":1002160,"name":"Artemiy Volkov","display_name":"Artemiy Volkov","email":"artemiy@synopsys.com","username":"artemiy-volkov","status":"Synopsys"},"date":"2023-07-17 13:42:08.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"03ad88fa47a36585fbd3dc3adf45d54e8f65fca6","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-07-17 14:05:18.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/17995/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/17195/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"0bbb2e8318f667280ef430687561703f931fafff","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-07-23 14:35:04.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"7f24a2a07e96a8e4381ae869417d5672a754755d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002160,"name":"Artemiy Volkov","display_name":"Artemiy Volkov","email":"artemiy@synopsys.com","username":"artemiy-volkov","status":"Synopsys"},"real_author":{"_account_id":1002160,"name":"Artemiy Volkov","display_name":"Artemiy Volkov","email":"artemiy@synopsys.com","username":"artemiy-volkov","status":"Synopsys"},"date":"2023-07-31 09:54:57.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"902db3501e0701b118f0966983af791412e6c1b2","author":{"_account_id":1002160,"name":"Artemiy Volkov","display_name":"Artemiy Volkov","email":"artemiy@synopsys.com","username":"artemiy-volkov","status":"Synopsys"},"real_author":{"_account_id":1002160,"name":"Artemiy Volkov","display_name":"Artemiy Volkov","email":"artemiy@synopsys.com","username":"artemiy-volkov","status":"Synopsys"},"date":"2023-07-31 09:57:10.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"5a0e6b9762105fe8befe82027b86b9fac75382b4","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-07-31 10:08:18.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/18036/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/17235/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"944a0153c663b249b73fa953fcaa55f4c8078112","author":{"_account_id":1001674,"name":"Evgeniy Didin","email":"didin@synopsys.com","username":"EvgeniiDidin"},"real_author":{"_account_id":1001674,"name":"Evgeniy Didin","email":"didin@synopsys.com","username":"EvgeniiDidin"},"date":"2023-08-04 14:18:18.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"57a7e4aaaf7b1636e78cbc7e75d736664e2192c8","author":{"_account_id":1002160,"name":"Artemiy Volkov","display_name":"Artemiy Volkov","email":"artemiy@synopsys.com","username":"artemiy-volkov","status":"Synopsys"},"real_author":{"_account_id":1002160,"name":"Artemiy Volkov","display_name":"Artemiy Volkov","email":"artemiy@synopsys.com","username":"artemiy-volkov","status":"Synopsys"},"date":"2023-09-11 07:31:35.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"8f864aa1025bfb3b7a6fa1630fde85e2c335ff3a","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-12-31 17:27:36.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"d7d10f38a7043311d35253b6e2d957bb30d42db3","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-01-13 14:40:17.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"3aae8ac4e5b4cca2fe6658d7b31560e5577be706","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-01-13 14:40:27.000000000","message":"Change has been successfully cherry-picked as 0de852f56130bfffa427bbc04bcea0370eecb0f3","accounts_in_message":[],"_revision_number":3}],"current_revision":"0de852f56130bfffa427bbc04bcea0370eecb0f3","revisions":{"b7d996d116805fe8e881338b36ab80a418fb2791":{"kind":"REWORK","_number":1,"created":"2023-07-17 13:42:08.000000000","uploader":{"_account_id":1002160,"name":"Artemiy Volkov","display_name":"Artemiy Volkov","email":"artemiy@synopsys.com","username":"artemiy-volkov","status":"Synopsys"},"ref":"refs/changes/17/7817/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/17/7817/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/17/7817/1 \u0026\u0026 git checkout -b change-7817 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/17/7817/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/17/7817/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/17/7817/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/17/7817/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/17/7817/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7ab25a2135c56fc42922e0e4b95e3236d357a746","subject":"target/arc: restore breakpoints in arc_resume()"}],"author":{"name":"Evgeniy Didin","email":"didin@synopsys.com","date":"2020-07-30 21:13:12.000000000","tz":180},"committer":{"name":"Artemiy Volkov","email":"artemiy@synopsys.com","date":"2023-07-17 13:23:57.000000000","tz":120},"subject":"target/arc: skip over breakpoints in arc_resume()","message":"target/arc: skip over breakpoints in arc_resume()\n\nWhen requested by the core code (handle_breakpoints \u003d true),\narc_resume() should be able to advance over a potential breakpoint set\nat the resume address instead of getting stuck in one place. This is\nachieved by removing the breakpoint, executing one instruction,\nresetting the breakpoint, then proceeding forward as normal.\n\nWith this patch applied, openocd is now able to resume from a\nbreakpoint halt when debugging ARCv2 targets via telnet.\n\nThis has previously been committed to the Zephyr project\u0027s openocd repo\n(see https://github.com/zephyrproject-rtos/openocd/pull/31).\n\nChange-Id: I17dba0dcea311d394b303c587bc2dfaa99d67859\nSigned-off-by: Evgeniy Didin \u003cdidin@synopsys.com\u003e\nSigned-off-by: Stephanos Ioannidis \u003croot@stephanos.io\u003e\nSigned-off-by: Artemiy Volkov \u003cartemiy@synopsys.com\u003e\n"}},"0de852f56130bfffa427bbc04bcea0370eecb0f3":{"kind":"REWORK","_number":3,"created":"2024-01-13 14:40:27.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/17/7817/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/17/7817/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/17/7817/3 \u0026\u0026 git checkout -b change-7817 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/17/7817/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/17/7817/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/17/7817/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/17/7817/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/17/7817/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2c10e3e2577604f5ec75b7f688f53fa2b3cbb0e7","subject":"target/arc: restore breakpoints in arc_resume()"}],"author":{"name":"Evgeniy Didin","email":"didin@synopsys.com","date":"2020-07-30 21:13:12.000000000","tz":180},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-01-13 14:40:27.000000000","tz":0},"subject":"target/arc: skip over breakpoints in arc_resume()","message":"target/arc: skip over breakpoints in arc_resume()\n\nWhen requested by the core code (handle_breakpoints \u003d true),\narc_resume() should be able to advance over a potential breakpoint set\nat the resume address instead of getting stuck in one place. This is\nachieved by removing the breakpoint, executing one instruction,\nresetting the breakpoint, then proceeding forward as normal.\n\nWith this patch applied, openocd is now able to resume from a\nbreakpoint halt when debugging ARCv2 targets via telnet.\n\nThis has previously been committed to the Zephyr project\u0027s openocd repo\n(see https://github.com/zephyrproject-rtos/openocd/pull/31).\n\nChange-Id: I17dba0dcea311d394b303c587bc2dfaa99d67859\nSigned-off-by: Evgeniy Didin \u003cdidin@synopsys.com\u003e\nSigned-off-by: Stephanos Ioannidis \u003croot@stephanos.io\u003e\nSigned-off-by: Artemiy Volkov \u003cartemiy@synopsys.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7817\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nTested-by: jenkins\n"}},"273e6bd3b48002dde0ef987289caf6610a4574f6":{"kind":"REWORK","_number":2,"created":"2023-07-31 09:54:57.000000000","uploader":{"_account_id":1002160,"name":"Artemiy Volkov","display_name":"Artemiy Volkov","email":"artemiy@synopsys.com","username":"artemiy-volkov","status":"Synopsys"},"ref":"refs/changes/17/7817/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/17/7817/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/17/7817/2 \u0026\u0026 git checkout -b change-7817 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/17/7817/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/17/7817/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/17/7817/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/17/7817/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/17/7817/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7ab25a2135c56fc42922e0e4b95e3236d357a746","subject":"target/arc: restore breakpoints in arc_resume()"}],"author":{"name":"Evgeniy Didin","email":"didin@synopsys.com","date":"2020-07-30 21:13:12.000000000","tz":180},"committer":{"name":"Artemiy Volkov","email":"artemiy@synopsys.com","date":"2023-07-31 08:51:46.000000000","tz":120},"subject":"target/arc: skip over breakpoints in arc_resume()","message":"target/arc: skip over breakpoints in arc_resume()\n\nWhen requested by the core code (handle_breakpoints \u003d true),\narc_resume() should be able to advance over a potential breakpoint set\nat the resume address instead of getting stuck in one place. This is\nachieved by removing the breakpoint, executing one instruction,\nresetting the breakpoint, then proceeding forward as normal.\n\nWith this patch applied, openocd is now able to resume from a\nbreakpoint halt when debugging ARCv2 targets via telnet.\n\nThis has previously been committed to the Zephyr project\u0027s openocd repo\n(see https://github.com/zephyrproject-rtos/openocd/pull/31).\n\nChange-Id: I17dba0dcea311d394b303c587bc2dfaa99d67859\nSigned-off-by: Evgeniy Didin \u003cdidin@synopsys.com\u003e\nSigned-off-by: Stephanos Ioannidis \u003croot@stephanos.io\u003e\nSigned-off-by: Artemiy Volkov \u003cartemiy@synopsys.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}