)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1001319,"name":"Liviu Ionescu","username":"ilg-ul"},"change_message_id":"2015d1ba3785dce7b532f22993862dfcd673f21c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"18c8458d_97073fdc","updated":"2023-07-20 19:17:14.000000000","message":"Hi Tomas, I took a quick look at the changes, and, if I understood it right, you prefixed some of the messages with the target name (which should be fine), and changed some error codes from ERROR_OK to ERROR_TARGET_NOT_HALTED, which I guess it should be fine too, but I don\u0027t know exactly how the errors are propagated up to the user.\n\nHowever, I did not understand the need for the separate command_print() in parallel with the LOG_*() functions.\n\nFor example:\n\n1: Info : gdb port disabled\n1: Info : Unable to match requested speed 2000 kHz, using 1800 kHz\n1: Info : Unable to match requested speed 2000 kHz, using 1800 kHz\n1: [stm32f7x.cpu] halted due to debug-request, current mode: Thread \n1: xPSR: 0x01000000 pc: 0x08000964 msp: 0x20080000\n1: Info : Unable to match requested speed 8000 kHz, using 4000 kHz\n1: Info : Unable to match requested speed 8000 kHz, using 4000 kHz\n1: ** Programming Started **\n1: Info : device id \u003d 0x10016451\n1: Info : flash size \u003d 2048 KiB\n1: Info : Single Bank 2048 kiB STM32F76x/77x found\n1: ** Programming Finished **\n1: ** Verify Started **\n1: ** Verified OK **\n1: semihosting is enabled\n1: \n1: semihosting command line is [rtos-apis-test]\n1: \n1: Info : Unable to match requested speed 2000 kHz, using 1800 kHz\n1: Info : Unable to match requested speed 2000 kHz, using 1800 kHz\n1: Info : tcl server disabled\n1: Info : telnet server disabled\n\nMore specifically, I expected a consistent output, but the messages related to semihosting are not printed via the LOG_*(), but via command_print(), and look differently. To make things worse, the messages related to programming the flash introduce a third look, being surrounded by \u0027**\u0027.\n\nWithout knowing the program internals, and why there are three different looks, I would say that the output is not consistent, and I would expect a uniform way of displaying messages.","commit_id":"8e3e5b3237c0e8562757a579cc8421ef7bdee902"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"76329ca9bfd395a30aa68a785995dbbd00d77fd2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e4b7b8cd_badb1fd3","updated":"2023-07-20 13:59:25.000000000","message":"Liviu,\ntry this patch with OpenOCD commandline:\n... -c \"init;cortex_m maskisr on\" ... -c reset\n\nI hope now it\u0027s not possible to miss the message as the properly returned error fails OpenOCD","commit_id":"8e3e5b3237c0e8562757a579cc8421ef7bdee902"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"8f7bad4c4b11acf30941f15f9085afa8773477c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"97d7ff50_a18e019a","updated":"2023-07-21 10:47:52.000000000","message":"Thanks.\nGerrit shows 155 conflicts, but not all of them are real.\nI think we can go ahead merging this patch and then eventually rework the patches with real conflicts.","commit_id":"8e3e5b3237c0e8562757a579cc8421ef7bdee902"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"c253e5a3313da525d53088cea5870cddc8550884","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"12bf97d4_90e7ee8c","in_reply_to":"18c8458d_97073fdc","updated":"2023-07-21 05:30:24.000000000","message":"This is out of scope of this change.\n\n\u003e However, I did not understand the need for the separate command_print() in parallel with the LOG_*() functions.\n\nLOG_*() used mainly for messages from low level services, does not\nneed a command context.\n\ncommand_print() builds the return string of a OpenOCD/Tcl command,\nit can be further processed in a Tcl script. Needs a command context.\n\n\u003e To make things worse, the messages related to programming the flash introduce a third look, being surrounded by \u0027**\u0027.\n\nThis is output of \u0027program\u0027 Tcl script\nhttps://review.openocd.org/c/openocd/+/7819/1/src/flash/startup.tcl#21\nTBH I don\u0027t like it either but nobody wants to change the output texts which could be parsed by an IDE or similar sw...","commit_id":"8e3e5b3237c0e8562757a579cc8421ef7bdee902"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"e1a650321bd1e10ba89a858f4a71f902a190602b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"70385cc1_dd755c1a","in_reply_to":"97d7ff50_a18e019a","updated":"2023-07-21 11:39:38.000000000","message":"Yes, kind of painful. And some of conflicting patches introduce new copies of\n LOG_WARNING(\"Target not halted\");\n return ERROR_TARGET_NOT_HALTED;\nI\u0027ll try to care of them.","commit_id":"8e3e5b3237c0e8562757a579cc8421ef7bdee902"}]}