)]}'
{"id":"openocd~master~I2fe4187c6025f0038956ab387edbf3f461c69398","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1001319":{"account":{"_account_id":1001319,"name":"Liviu Ionescu","username":"ilg-ul"},"last_update":"2023-07-29 05:17:44.000000000","reason":"Change was submitted"},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2023-07-29 05:17:44.000000000","reason":"Change was submitted"},"1000181":{"account":{"_account_id":1000181,"name":"Liviu Ionescu","email":"ilg@livius.net"},"last_update":"2023-07-29 05:17:44.000000000","reason":"Change was submitted"},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2023-07-21 11:39:38.000000000","reason":"\u003cGERRIT_ACCOUNT_1000687\u003e replied on the change","reason_account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}},"hashtags":[],"change_id":"I2fe4187c6025f0038956ab387edbf3f461c69398","subject":"target: fix messages and return values of failed op because not halted","status":"MERGED","created":"2023-07-20 13:39:11.000000000","updated":"2023-07-29 05:17:44.000000000","submitted":"2023-07-29 05:17:44.000000000","submitter":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"total_comment_count":5,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7819","meta_rev_id":"53529949b399e368afdbd7dfd26da3c913ebb490","_number":7819,"owner":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-07-29 05:17:44.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-07-29 05:17:44.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-07-29 05:17:44.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000181,"name":"Liviu Ionescu","email":"ilg@livius.net"}],"reviewers":{"CC":[{"_account_id":1001319,"name":"Liviu Ionescu","username":"ilg-ul"}],"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000181,"name":"Liviu Ionescu","email":"ilg@livius.net"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-07-20 13:55:59.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-07-20 13:59:25.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000181,"name":"Liviu Ionescu","email":"ilg@livius.net"},"state":"REVIEWER"},{"updated":"2023-07-20 19:17:14.000000000","updated_by":{"_account_id":1001319,"name":"Liviu Ionescu","username":"ilg-ul"},"reviewer":{"_account_id":1001319,"name":"Liviu Ionescu","username":"ilg-ul"},"state":"CC"},{"updated":"2023-07-21 10:47:52.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"6512197786e81734f47762a436e1f17b281ed909","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-07-20 13:39:11.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"138e083383bbbb84ea3fac53761ca17065c0b17e","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-07-20 13:55:59.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/18001/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/17200/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"76329ca9bfd395a30aa68a785995dbbd00d77fd2","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-07-20 13:59:25.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"2015d1ba3785dce7b532f22993862dfcd673f21c","author":{"_account_id":1001319,"name":"Liviu Ionescu","username":"ilg-ul"},"real_author":{"_account_id":1001319,"name":"Liviu Ionescu","username":"ilg-ul"},"date":"2023-07-20 19:17:14.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"c253e5a3313da525d53088cea5870cddc8550884","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-07-21 05:30:24.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"8f7bad4c4b11acf30941f15f9085afa8773477c9","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-07-21 10:47:52.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"e1a650321bd1e10ba89a858f4a71f902a190602b","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-07-21 11:39:38.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"53529949b399e368afdbd7dfd26da3c913ebb490","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-07-29 05:17:44.000000000","message":"Change has been successfully cherry-picked as a5108240f9e12633fea400f92d96cc75e03c86ca","accounts_in_message":[],"_revision_number":2}],"current_revision":"a5108240f9e12633fea400f92d96cc75e03c86ca","revisions":{"8e3e5b3237c0e8562757a579cc8421ef7bdee902":{"kind":"REWORK","_number":1,"created":"2023-07-20 13:39:11.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/19/7819/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/19/7819/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/19/7819/1 \u0026\u0026 git checkout -b change-7819 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/19/7819/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/19/7819/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/19/7819/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/19/7819/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/19/7819/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2c57d11c78108c6547f31ca07f1ff672fa855f10","subject":"tcl/board: add esp32s3-builtin.cfg file"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2023-07-20 12:52:54.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2023-07-20 13:15:19.000000000","tz":120},"subject":"target: fix messages and return values of failed op because not halted","message":"target: fix messages and return values of failed op because not halted\n\nLot of messages was logged as LOG_WARNING, but the operation failed\nimmediately. Sometimes no error message was logged at all.\nAdd missing messages, change warnings to errors.\n\nSometimes ERROR_TARGET_INVALID was returned. Some command handlers\nreturned ERROR_OK! Always return ERROR_TARGET_NOT_HALTED.\n\nWhile on it use LOG_TARGET_ERROR() whenever possible.\nPrefix command_print() message with \u0027Error:\u0027 to get closer\nto LOG_TARGET_ERROR() variant.\n\nError message was not added to get() and set() methods of\nstruct xxx_reg_type - the return value is properly checked and a message\nis logged by the caller in case of ERROR_TARGET_NOT_HALTED.\n\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nChange-Id: I2fe4187c6025f0038956ab387edbf3f461c69398\n"}},"a5108240f9e12633fea400f92d96cc75e03c86ca":{"kind":"REWORK","_number":2,"created":"2023-07-29 05:17:44.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/19/7819/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/19/7819/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/19/7819/2 \u0026\u0026 git checkout -b change-7819 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/19/7819/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/19/7819/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/19/7819/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/19/7819/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/19/7819/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7023deb06a8cac77fe50d341c9e34b80d4fc68fd","subject":"jtag/drivers/xds110: Fix compiler warning."}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2023-07-20 12:52:54.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2023-07-29 05:17:44.000000000","tz":0},"subject":"target: fix messages and return values of failed op because not halted","message":"target: fix messages and return values of failed op because not halted\n\nLot of messages was logged as LOG_WARNING, but the operation failed\nimmediately. Sometimes no error message was logged at all.\nAdd missing messages, change warnings to errors.\n\nSometimes ERROR_TARGET_INVALID was returned. Some command handlers\nreturned ERROR_OK! Always return ERROR_TARGET_NOT_HALTED.\n\nWhile on it use LOG_TARGET_ERROR() whenever possible.\nPrefix command_print() message with \u0027Error:\u0027 to get closer\nto LOG_TARGET_ERROR() variant.\n\nError message was not added to get() and set() methods of\nstruct xxx_reg_type - the return value is properly checked and a message\nis logged by the caller in case of ERROR_TARGET_NOT_HALTED.\n\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nChange-Id: I2fe4187c6025f0038956ab387edbf3f461c69398\nReviewed-on: https://review.openocd.org/c/openocd/+/7819\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}