)]}'
{"id":"openocd~master~Ib21366b2fdbf33ee06a958e52b725989114751f4","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1001810":{"account":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"last_update":"2023-08-05 08:25:09.000000000","reason":"Change was submitted"},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2023-08-05 08:25:04.000000000","reason":"removed on reply"},"1001839":{"account":{"_account_id":1001839,"name":"Antonio Borneo","email":"antonio.borneo@st.com"},"last_update":"2023-08-05 08:25:09.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ib21366b2fdbf33ee06a958e52b725989114751f4","subject":"pld/virtex2: allow calling set_instr_codes and set_user_codes before \u0027init\u0027","status":"MERGED","created":"2023-07-23 23:45:46.000000000","updated":"2023-08-05 08:25:09.000000000","submitted":"2023-08-05 08:25:09.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7821","meta_rev_id":"e7ca86928d6cb18baa1ea3405e4cad060163bf8b","_number":7821,"owner":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-08-05 08:25:09.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"value":0,"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-08-05 08:25:09.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1001839,"name":"Antonio Borneo","email":"antonio.borneo@st.com"}],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},{"_account_id":1001839,"name":"Antonio Borneo","email":"antonio.borneo@st.com"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-07-23 23:47:04.000000000","updated_by":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"reviewer":{"_account_id":1001839,"name":"Antonio Borneo","email":"antonio.borneo@st.com"},"state":"REVIEWER"},{"updated":"2023-07-23 23:58:12.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-07-24 15:48:27.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"cef38290d131f6e54c89d35c285794cb9255fdaa","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"real_author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"date":"2023-07-23 23:45:46.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1e6990254b99704649f338edb0004fb9dd50b080","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-07-23 23:58:12.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/18007/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/17206/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"b64607da09eaafddbd15a772bd6a3d783fdbd8bc","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-07-24 15:48:27.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"54c9e9f4a2092492ff9ecff115f70e45919e01a3","author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"real_author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"date":"2023-07-24 17:05:53.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"bbe71bcbcd6be82afd2cc4856331350b664db3a0","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"real_author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"date":"2023-07-25 21:34:45.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.\n\nOutdated Votes:\n* Code-Review+1 (copy condition: \"changekind:NO_CHANGE OR is:MIN\")\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"301406f7ffcb8b9ac07c4dea0dbed35dbf21de17","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-07-25 21:49:15.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/18023/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/17222/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"d44257c6c41c8c49246b3f8d128cac157791d540","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"real_author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"date":"2023-07-31 19:11:46.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"04180d8549b352a54eaf0c51e9a95540ebcdb4a3","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-07-31 19:35:23.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/18038/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/17238/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"604c33fc30c801524d3ee118adf731afdb2861a3","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-08-05 08:25:04.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"e7ca86928d6cb18baa1ea3405e4cad060163bf8b","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-08-05 08:25:09.000000000","message":"Change has been successfully cherry-picked as a64928c4e7dd36c57e4a137f93a49522c28f547a","accounts_in_message":[],"_revision_number":4}],"current_revision":"a64928c4e7dd36c57e4a137f93a49522c28f547a","revisions":{"a64928c4e7dd36c57e4a137f93a49522c28f547a":{"kind":"REWORK","_number":4,"created":"2023-08-05 08:25:09.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/21/7821/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/21/7821/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/21/7821/4 \u0026\u0026 git checkout -b change-7821 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/21/7821/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/21/7821/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/21/7821/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/21/7821/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/21/7821/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"bab8b8c9eb7c0e892eaa375cb1f388a75165c627","subject":"register: refactor register_cache_invalidate()"}],"author":{"name":"Daniel Anselmi","email":"danselmi@gmx.ch","date":"2023-07-23 23:43:58.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-08-05 08:25:09.000000000","tz":0},"subject":"pld/virtex2: allow calling set_instr_codes and set_user_codes before \u0027init\u0027","message":"pld/virtex2: allow calling set_instr_codes and set_user_codes before \u0027init\u0027\n\nChange-Id: Ib21366b2fdbf33ee06a958e52b725989114751f4\nSigned-off-by: Daniel Anselmi \u003cdanselmi@gmx.ch\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7821\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"e1a82fb993c78bfd3e015bb39ee3ed9c3383ef70":{"kind":"REWORK","_number":1,"created":"2023-07-23 23:45:46.000000000","uploader":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"ref":"refs/changes/21/7821/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/21/7821/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/21/7821/1 \u0026\u0026 git checkout -b change-7821 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/21/7821/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/21/7821/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/21/7821/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/21/7821/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/21/7821/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"218f6c0181633057a892a8724c506b10b9f6afaa","subject":"target/riscv: Add null pointer check before right shift for bscan tunneling."}],"author":{"name":"Daniel Anselmi","email":"danselmi@gmx.ch","date":"2023-07-23 23:43:58.000000000","tz":120},"committer":{"name":"Daniel Anselmi","email":"danselmi@gmx.ch","date":"2023-07-23 23:44:55.000000000","tz":120},"subject":"pld/virtex2: allow calling set_instr_codes and set_user_codes before \u0027init\u0027","message":"pld/virtex2: allow calling set_instr_codes and set_user_codes before \u0027init\u0027\n\nChange-Id: Ib21366b2fdbf33ee06a958e52b725989114751f4\nSigned-off-by: Daniel Anselmi \u003cdanselmi@gmx.ch\u003e\n"}},"92ee4e0aa05f53f4a504933f9036f6bdf00eb5f7":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2023-07-25 21:34:45.000000000","uploader":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"ref":"refs/changes/21/7821/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/21/7821/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/21/7821/2 \u0026\u0026 git checkout -b change-7821 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/21/7821/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/21/7821/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/21/7821/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/21/7821/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/21/7821/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7023deb06a8cac77fe50d341c9e34b80d4fc68fd","subject":"jtag/drivers/xds110: Fix compiler warning."}],"author":{"name":"Daniel Anselmi","email":"danselmi@gmx.ch","date":"2023-07-23 23:43:58.000000000","tz":120},"committer":{"name":"Daniel Anselmi","email":"danselmi@gmx.ch","date":"2023-07-24 23:37:55.000000000","tz":120},"subject":"pld/virtex2: allow calling set_instr_codes and set_user_codes before \u0027init\u0027","message":"pld/virtex2: allow calling set_instr_codes and set_user_codes before \u0027init\u0027\n\nChange-Id: Ib21366b2fdbf33ee06a958e52b725989114751f4\nSigned-off-by: Daniel Anselmi \u003cdanselmi@gmx.ch\u003e\n"}},"ea8b5c966a85c8d88b704ef93eb8280582027ce3":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2023-07-31 19:11:46.000000000","uploader":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"ref":"refs/changes/21/7821/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/21/7821/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/21/7821/3 \u0026\u0026 git checkout -b change-7821 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/21/7821/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/21/7821/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/21/7821/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/21/7821/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/21/7821/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a5108240f9e12633fea400f92d96cc75e03c86ca","subject":"target: fix messages and return values of failed op because not halted"}],"author":{"name":"Daniel Anselmi","email":"danselmi@gmx.ch","date":"2023-07-23 23:43:58.000000000","tz":120},"committer":{"name":"Daniel Anselmi","email":"danselmi@gmx.ch","date":"2023-07-29 08:47:10.000000000","tz":120},"subject":"pld/virtex2: allow calling set_instr_codes and set_user_codes before \u0027init\u0027","message":"pld/virtex2: allow calling set_instr_codes and set_user_codes before \u0027init\u0027\n\nChange-Id: Ib21366b2fdbf33ee06a958e52b725989114751f4\nSigned-off-by: Daniel Anselmi \u003cdanselmi@gmx.ch\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}