)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3eda46aed63ef04dff306342b507cbd5b06ce3ee","unresolved":true,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch adds a jtagspi-mode for these cases. It also adds the"},{"line_number":15,"context_line":"needed interfaces to jtagspi and the pld-driver so the driver"},{"line_number":16,"context_line":"can select the mode and provide the necessay procedures."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"For the cases where a proxy bitstream is needed, the pld driver"},{"line_number":19,"context_line":"will select the mode and provide instruction code needed in this"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"e8252bf7_97414cb2","line":16,"updated":"2023-08-15 15:29:06.000000000","message":"typo s/necessay/necessary/","commit_id":"df4fb27953881f10b1bc206b334b1d712230bee3"},{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"0dd78711ed9b64bba1cbfb80053f25e57029c3ee","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch adds a jtagspi-mode for these cases. It also adds the"},{"line_number":15,"context_line":"needed interfaces to jtagspi and the pld-driver so the driver"},{"line_number":16,"context_line":"can select the mode and provide the necessay procedures."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"For the cases where a proxy bitstream is needed, the pld driver"},{"line_number":19,"context_line":"will select the mode and provide instruction code needed in this"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"d1148188_f6235728","line":16,"in_reply_to":"e8252bf7_97414cb2","updated":"2023-08-15 20:09:01.000000000","message":"Done","commit_id":"df4fb27953881f10b1bc206b334b1d712230bee3"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"f959c299570b785ebec419a5baf664b3f9d93cc5","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"jtagspi/pld: add interface to get support from pld drivers"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Jagspi is using a proxy bitstream to \"connect\" JTAG to the"},{"line_number":10,"context_line":"SPI pins. This is not possible with all FPGA vendors/families."},{"line_number":11,"context_line":"In this cases a dedicated procedure is needed to establish such"},{"line_number":12,"context_line":"a connection."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"14b2f137_2a9bd6a1","line":9,"updated":"2023-09-09 16:24:50.000000000","message":"typo s/Jagspi/Jtagspi/","commit_id":"697acf28e6d7a68f97ed767b6e287e72c4b86ec6"},{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"b537ed3d3af56bafda9f1dcc2925316908ed5f38","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"jtagspi/pld: add interface to get support from pld drivers"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Jagspi is using a proxy bitstream to \"connect\" JTAG to the"},{"line_number":10,"context_line":"SPI pins. This is not possible with all FPGA vendors/families."},{"line_number":11,"context_line":"In this cases a dedicated procedure is needed to establish such"},{"line_number":12,"context_line":"a connection."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"0dbd2669_3250dbf7","line":9,"in_reply_to":"14b2f137_2a9bd6a1","updated":"2023-09-09 20:47:40.000000000","message":"Done","commit_id":"697acf28e6d7a68f97ed767b6e287e72c4b86ec6"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"0dd78711ed9b64bba1cbfb80053f25e57029c3ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"49a7d24b_1f26cd6a","updated":"2023-08-15 20:09:01.000000000","message":"Hi Antonio\nAgain, thanks for taking time to review!","commit_id":"df4fb27953881f10b1bc206b334b1d712230bee3"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3eda46aed63ef04dff306342b507cbd5b06ce3ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2197165a_5e94a238","updated":"2023-08-15 15:29:06.000000000","message":"This patch introduces a cross dependency between FLASH and PLD subsystems:\nsrc/flash/nor/jtagspi.c includes src/pld/pld.h\nsrc/pld/pld.h includes src/flash/nor/jtagspi.h\nWe always try to keep the subsystems independent, as far as this is possible.\nYou need to better separate them.\n\nFor me you should export some generic functions in src/pld/pld.h, e.g. pld_jtagspi_connect() that internally calls -\u003econnect_spi_to_jtag()\nAnd all the details should be inside the PLD subsystem.\n\nThis creates a dependency of FLASH from PLD, without the other way","commit_id":"df4fb27953881f10b1bc206b334b1d712230bee3"},{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"0dd78711ed9b64bba1cbfb80053f25e57029c3ee","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"bb77fc08_c2b8e726","in_reply_to":"2197165a_5e94a238","updated":"2023-08-15 20:09:01.000000000","message":"Not sure if I understand you right.\nI removed jtagspi.h with the last patchset. The enum is in pld.h now.\nPLD subsystem does not depend on FLASH headers anymore, but it still has knowledge about jtagspi internals... or not?\nAm I on the right track?","commit_id":"df4fb27953881f10b1bc206b334b1d712230bee3"},{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"07d111806beb8ff825c27913b01d22477acf405b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"eef5e14b_22537949","in_reply_to":"bb77fc08_c2b8e726","updated":"2023-08-22 22:39:10.000000000","message":"I hope the last patch-set is about what you expected.\nLet me know if I missed something.","commit_id":"df4fb27953881f10b1bc206b334b1d712230bee3"},{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"4917314117dc2fd1cf154896c0553ff84161f5a2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"e4c54391_ca53caa4","updated":"2023-08-28 21:19:54.000000000","message":"Thanks for reviewing!\nI hope I got all your points right.","commit_id":"697acf28e6d7a68f97ed767b6e287e72c4b86ec6"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"f959c299570b785ebec419a5baf664b3f9d93cc5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"8081a0c8_daaf4c23","updated":"2023-09-09 16:24:50.000000000","message":"Thanks for the rework to split pld from flash. I think it\u0027s fine.\nThere are two minor fixes left.\nI find the text in doc/openocd.texi is still not friendly for a newbie, but I cannot propose an easier-to-read change. Maybe can be improved later on, or maybe someone else can review this patch. Anyway, not a blocking point","commit_id":"697acf28e6d7a68f97ed767b6e287e72c4b86ec6"},{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"b537ed3d3af56bafda9f1dcc2925316908ed5f38","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"3e8d4c67_e0ea3984","updated":"2023-09-09 20:47:40.000000000","message":"thanks!","commit_id":"697acf28e6d7a68f97ed767b6e287e72c4b86ec6"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"01156258afc0840a267b827ce274c14700d21b98","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"df6c2628_64271b8b","updated":"2023-09-10 08:12:44.000000000","message":"thanks","commit_id":"a5b2a08baf389657a72182f876767723a6ca5f56"}],"doc/openocd.texi":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"d8a4bcf46d5fe148eba0b0fa264624b736aa0548","unresolved":true,"context_lines":[{"line_number":5834,"context_line":"@cindex jtagspi"},{"line_number":5835,"context_line":"@cindex bscan_spi"},{"line_number":5836,"context_line":"Several FPGAs and CPLDs can retrieve their configuration (bitstream) from a"},{"line_number":5837,"context_line":"SPI flash connected to them. To access this flash from the host, the device"},{"line_number":5838,"context_line":"is first programmed with a special proxy bitstream that exposes the SPI flash"},{"line_number":5839,"context_line":"on the device\u0027s JTAG interface or with dedicated JTAG instructions. The flash"},{"line_number":5840,"context_line":"can then be accessed through JTAG."},{"line_number":5841,"context_line":""},{"line_number":5842,"context_line":"Since signalling between JTAG and SPI is compatible, all that is required for"}],"source_content_type":"text/x-texinfo","patch_set":8,"id":"70b0296c_2deb3e53","line":5839,"range":{"start_line":5837,"start_character":29,"end_line":5839,"end_character":67},"updated":"2023-08-27 15:42:39.000000000","message":"the result is not really easy to understand for a newbie. What about:\n\n\"To access this flash from the host, some FPGA device provides dedicated JTAG instructions, while other FPGA devices should be programmed with a special proxy bitstream that exposes the SPI flash on the device\u0027s JTAG interface.\"","commit_id":"ec3fd53ac39c00a29ac01ccc4aa3313d27e85a5e"},{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"4917314117dc2fd1cf154896c0553ff84161f5a2","unresolved":false,"context_lines":[{"line_number":5834,"context_line":"@cindex jtagspi"},{"line_number":5835,"context_line":"@cindex bscan_spi"},{"line_number":5836,"context_line":"Several FPGAs and CPLDs can retrieve their configuration (bitstream) from a"},{"line_number":5837,"context_line":"SPI flash connected to them. To access this flash from the host, the device"},{"line_number":5838,"context_line":"is first programmed with a special proxy bitstream that exposes the SPI flash"},{"line_number":5839,"context_line":"on the device\u0027s JTAG interface or with dedicated JTAG instructions. The flash"},{"line_number":5840,"context_line":"can then be accessed through JTAG."},{"line_number":5841,"context_line":""},{"line_number":5842,"context_line":"Since signalling between JTAG and SPI is compatible, all that is required for"}],"source_content_type":"text/x-texinfo","patch_set":8,"id":"f1c11c1f_9f6721b5","line":5839,"range":{"start_line":5837,"start_character":29,"end_line":5839,"end_character":67},"in_reply_to":"70b0296c_2deb3e53","updated":"2023-08-28 21:19:54.000000000","message":"Done","commit_id":"ec3fd53ac39c00a29ac01ccc4aa3313d27e85a5e"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"d8a4bcf46d5fe148eba0b0fa264624b736aa0548","unresolved":true,"context_lines":[{"line_number":5852,"context_line":"and procedure to connect the JTAG to the SPI signals and don\u0027t need a proxy"},{"line_number":5853,"context_line":"bitstream. Support for these devices with dedicated procedure is provided by"},{"line_number":5854,"context_line":"the pld drivers. For convenience the PLD drivers will provide the USERx code"},{"line_number":5855,"context_line":"for FPGAs with a proxy bitstream. Currently the following PLD drives are able"},{"line_number":5856,"context_line":"to support jtagspi:"},{"line_number":5857,"context_line":"@itemize"},{"line_number":5858,"context_line":"@item Efinix: proxy-bitstream"}],"source_content_type":"text/x-texinfo","patch_set":8,"id":"1cc8eb2e_327149e2","line":5855,"updated":"2023-08-27 15:42:39.000000000","message":"typo s/drives/drivers/","commit_id":"ec3fd53ac39c00a29ac01ccc4aa3313d27e85a5e"},{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"4917314117dc2fd1cf154896c0553ff84161f5a2","unresolved":false,"context_lines":[{"line_number":5852,"context_line":"and procedure to connect the JTAG to the SPI signals and don\u0027t need a proxy"},{"line_number":5853,"context_line":"bitstream. Support for these devices with dedicated procedure is provided by"},{"line_number":5854,"context_line":"the pld drivers. For convenience the PLD drivers will provide the USERx code"},{"line_number":5855,"context_line":"for FPGAs with a proxy bitstream. Currently the following PLD drives are able"},{"line_number":5856,"context_line":"to support jtagspi:"},{"line_number":5857,"context_line":"@itemize"},{"line_number":5858,"context_line":"@item Efinix: proxy-bitstream"}],"source_content_type":"text/x-texinfo","patch_set":8,"id":"fc4c4dcd_8f98f87d","line":5855,"in_reply_to":"1cc8eb2e_327149e2","updated":"2023-08-28 21:19:54.000000000","message":"Done","commit_id":"ec3fd53ac39c00a29ac01ccc4aa3313d27e85a5e"}],"src/flash/nor/jtagspi.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"d8a4bcf46d5fe148eba0b0fa264624b736aa0548","unresolved":true,"context_lines":[{"line_number":25,"context_line":"\tbool always_4byte;\t\t\t/* use always 4-byte address except for basic read 0x03 */"},{"line_number":26,"context_line":"\tuint32_t ir;"},{"line_number":27,"context_line":"\tunsigned int addr_len;\t\t/* address length in bytes */"},{"line_number":28,"context_line":"\tstruct pld_device *pld_device;"},{"line_number":29,"context_line":"};"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"FLASH_BANK_COMMAND_HANDLER(jtagspi_flash_bank_command)"}],"source_content_type":"text/x-csrc","patch_set":8,"id":"517300fa_0c284497","line":28,"updated":"2023-08-27 15:42:39.000000000","message":"This field is special. Please document:\n/\\* if not NULL, the PLD has special intructions for JTAGSPI \\*/\nThen move \u0027ir\u0027 after this field and document it:\n/\\* when !pld_device, this is... \\*/","commit_id":"ec3fd53ac39c00a29ac01ccc4aa3313d27e85a5e"},{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"4917314117dc2fd1cf154896c0553ff84161f5a2","unresolved":false,"context_lines":[{"line_number":25,"context_line":"\tbool always_4byte;\t\t\t/* use always 4-byte address except for basic read 0x03 */"},{"line_number":26,"context_line":"\tuint32_t ir;"},{"line_number":27,"context_line":"\tunsigned int addr_len;\t\t/* address length in bytes */"},{"line_number":28,"context_line":"\tstruct pld_device *pld_device;"},{"line_number":29,"context_line":"};"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"FLASH_BANK_COMMAND_HANDLER(jtagspi_flash_bank_command)"}],"source_content_type":"text/x-csrc","patch_set":8,"id":"df57ccd0_4953255f","line":28,"in_reply_to":"517300fa_0c284497","updated":"2023-08-28 21:19:54.000000000","message":"Done","commit_id":"ec3fd53ac39c00a29ac01ccc4aa3313d27e85a5e"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"d8a4bcf46d5fe148eba0b0fa264624b736aa0548","unresolved":true,"context_lines":[{"line_number":62,"context_line":"\tinfo-\u003etap \u003d bank-\u003etarget-\u003etap;"},{"line_number":63,"context_line":"\tinfo-\u003eprobed \u003d false;"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"\tenum pld_jtagspi_mode_e mode \u003d JTAGSPI_MODE_PROXY_BITSTREAM;"},{"line_number":66,"context_line":"\tint retval \u003d ERROR_OK;"},{"line_number":67,"context_line":"\tif (device)"},{"line_number":68,"context_line":"\t\tretval \u003d pld_get_jtagspi_mode(device, \u0026mode, \u0026ir);"},{"line_number":69,"context_line":"\tif (mode \u003d\u003d JTAGSPI_MODE_PROXY_BITSTREAM)"},{"line_number":70,"context_line":"\t\tdevice \u003d NULL;"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"\tinfo-\u003eir \u003d ir;"},{"line_number":73,"context_line":"\tinfo-\u003epld_device \u003d device;"}],"source_content_type":"text/x-csrc","patch_set":8,"id":"ab90a29d_608ccd6a","line":70,"range":{"start_line":65,"start_character":1,"end_line":70,"end_character":16},"updated":"2023-08-27 15:42:39.000000000","message":"it looks to me over-engineered!\nWhy not adding above, once detected the flag \"-pld\", a call to a simpler\nbool pld_has_jtagspi_instruction(struct pld_device *device);\nand quit there, with error, if the syntax does not match the PLD spec?","commit_id":"ec3fd53ac39c00a29ac01ccc4aa3313d27e85a5e"},{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"4917314117dc2fd1cf154896c0553ff84161f5a2","unresolved":false,"context_lines":[{"line_number":62,"context_line":"\tinfo-\u003etap \u003d bank-\u003etarget-\u003etap;"},{"line_number":63,"context_line":"\tinfo-\u003eprobed \u003d false;"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"\tenum pld_jtagspi_mode_e mode \u003d JTAGSPI_MODE_PROXY_BITSTREAM;"},{"line_number":66,"context_line":"\tint retval \u003d ERROR_OK;"},{"line_number":67,"context_line":"\tif (device)"},{"line_number":68,"context_line":"\t\tretval \u003d pld_get_jtagspi_mode(device, \u0026mode, \u0026ir);"},{"line_number":69,"context_line":"\tif (mode \u003d\u003d JTAGSPI_MODE_PROXY_BITSTREAM)"},{"line_number":70,"context_line":"\t\tdevice \u003d NULL;"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"\tinfo-\u003eir \u003d ir;"},{"line_number":73,"context_line":"\tinfo-\u003epld_device \u003d device;"}],"source_content_type":"text/x-csrc","patch_set":8,"id":"9f022631_ef3ed911","line":70,"range":{"start_line":65,"start_character":1,"end_line":70,"end_character":16},"in_reply_to":"ab90a29d_608ccd6a","updated":"2023-08-28 21:19:54.000000000","message":"Not sure if the new patchset is better.\nHere we checked if a proxy-bitstream was used.\nIf yes,we got the user-instruction code from the pld driver.","commit_id":"ec3fd53ac39c00a29ac01ccc4aa3313d27e85a5e"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"d8a4bcf46d5fe148eba0b0fa264624b736aa0548","unresolved":true,"context_lines":[{"line_number":123,"context_line":"\tunsigned int facing_read_bits \u003d 0;"},{"line_number":124,"context_line":"\tunsigned int trailing_write_bits \u003d 0;"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"\tint retval \u003d pld_get_jtagspi_stuff_bits(info-\u003epld_device, \u0026facing_read_bits, \u0026trailing_write_bits);"},{"line_number":127,"context_line":"\tif (retval !\u003d ERROR_OK)"},{"line_number":128,"context_line":"\t\treturn retval;"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"\tint n \u003d 0;"},{"line_number":131,"context_line":"\tconst uint8_t marker \u003d 1;"}],"source_content_type":"text/x-csrc","patch_set":8,"id":"4d8c4551_795cbb32","line":128,"range":{"start_line":126,"start_character":1,"end_line":128,"end_character":15},"updated":"2023-08-27 15:42:39.000000000","message":"I see that the test is already done inside pld_get_jtagspi_stuff_bits(), but to improve the readability, please put here:\nif (info-\u003epld_device) {\nint retval \u003d pld_get_jtagspi_stuff_bits(...);\n...\n}","commit_id":"ec3fd53ac39c00a29ac01ccc4aa3313d27e85a5e"},{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"4917314117dc2fd1cf154896c0553ff84161f5a2","unresolved":false,"context_lines":[{"line_number":123,"context_line":"\tunsigned int facing_read_bits \u003d 0;"},{"line_number":124,"context_line":"\tunsigned int trailing_write_bits \u003d 0;"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"\tint retval \u003d pld_get_jtagspi_stuff_bits(info-\u003epld_device, \u0026facing_read_bits, \u0026trailing_write_bits);"},{"line_number":127,"context_line":"\tif (retval !\u003d ERROR_OK)"},{"line_number":128,"context_line":"\t\treturn retval;"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"\tint n \u003d 0;"},{"line_number":131,"context_line":"\tconst uint8_t marker \u003d 1;"}],"source_content_type":"text/x-csrc","patch_set":8,"id":"87b02961_dedc040a","line":128,"range":{"start_line":126,"start_character":1,"end_line":128,"end_character":15},"in_reply_to":"4d8c4551_795cbb32","updated":"2023-08-28 21:19:54.000000000","message":"Done","commit_id":"ec3fd53ac39c00a29ac01ccc4aa3313d27e85a5e"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"d8a4bcf46d5fe148eba0b0fa264624b736aa0548","unresolved":true,"context_lines":[{"line_number":187,"context_line":"\t\tn++;"},{"line_number":188,"context_line":"\t}"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"\tretval  \u003d connect_spi_to_jtag(info);"},{"line_number":191,"context_line":"\tif (retval !\u003d ERROR_OK)"},{"line_number":192,"context_line":"\t\treturn retval;"},{"line_number":193,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":8,"id":"beb4bcb4_c3255a18","line":190,"updated":"2023-08-27 15:42:39.000000000","message":"I think it\u0027s more readable if you inline the function:\nif (info-\u003epld_device) {\nretval \u003d pld_connect_spi_to_jtag(info-\u003epld_device);\nif (retval...)\n} else {\njtagspi_set_ir(bank);\n}","commit_id":"ec3fd53ac39c00a29ac01ccc4aa3313d27e85a5e"},{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"4917314117dc2fd1cf154896c0553ff84161f5a2","unresolved":false,"context_lines":[{"line_number":187,"context_line":"\t\tn++;"},{"line_number":188,"context_line":"\t}"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"\tretval  \u003d connect_spi_to_jtag(info);"},{"line_number":191,"context_line":"\tif (retval !\u003d ERROR_OK)"},{"line_number":192,"context_line":"\t\treturn retval;"},{"line_number":193,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":8,"id":"1db23428_43fa7b3d","line":190,"in_reply_to":"beb4bcb4_c3255a18","updated":"2023-08-28 21:19:54.000000000","message":"Done","commit_id":"ec3fd53ac39c00a29ac01ccc4aa3313d27e85a5e"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"d8a4bcf46d5fe148eba0b0fa264624b736aa0548","unresolved":true,"context_lines":[{"line_number":200,"context_line":"\tif (is_read)"},{"line_number":201,"context_line":"\t\tflip_u8(data_buffer, data_buffer, data_len);"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"\treturn pld_disconnect_spi_from_jtag(info-\u003epld_device);"},{"line_number":204,"context_line":"}"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"COMMAND_HANDLER(jtagspi_handle_set)"}],"source_content_type":"text/x-csrc","patch_set":8,"id":"2f345949_ea022016","line":203,"range":{"start_line":203,"start_character":13,"end_line":203,"end_character":14},"updated":"2023-08-27 15:42:39.000000000","message":"and also here explicit:\nif (info-\u003epld_device)\nreturn pld_disconnect_spi_from_jtag(info-\u003epld_device);\nreturn ERROR_OK;","commit_id":"ec3fd53ac39c00a29ac01ccc4aa3313d27e85a5e"},{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"4917314117dc2fd1cf154896c0553ff84161f5a2","unresolved":false,"context_lines":[{"line_number":200,"context_line":"\tif (is_read)"},{"line_number":201,"context_line":"\t\tflip_u8(data_buffer, data_buffer, data_len);"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"\treturn pld_disconnect_spi_from_jtag(info-\u003epld_device);"},{"line_number":204,"context_line":"}"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"COMMAND_HANDLER(jtagspi_handle_set)"}],"source_content_type":"text/x-csrc","patch_set":8,"id":"5e951041_3ad8e6ce","line":203,"range":{"start_line":203,"start_character":13,"end_line":203,"end_character":14},"in_reply_to":"2f345949_ea022016","updated":"2023-08-28 21:19:54.000000000","message":"Done","commit_id":"ec3fd53ac39c00a29ac01ccc4aa3313d27e85a5e"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"f959c299570b785ebec419a5baf664b3f9d93cc5","unresolved":true,"context_lines":[{"line_number":85,"context_line":"\tstruct scan_field field;"},{"line_number":86,"context_line":"\tuint8_t buf[4] \u003d { 0 };"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"\tLOG_DEBUG(\"loading jtagspi ir(0x%x)\", info-\u003eir);"},{"line_number":89,"context_line":"\tbuf_set_u32(buf, 0, info-\u003etap-\u003eir_length, info-\u003eir);"},{"line_number":90,"context_line":"\tfield.num_bits \u003d info-\u003etap-\u003eir_length;"},{"line_number":91,"context_line":"\tfield.out_value \u003d buf;"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"dc419d6e_dccdd637","line":88,"updated":"2023-09-09 16:24:50.000000000","message":"info-\u003eir is uint32_t. Use PRIx32 in the format string","commit_id":"697acf28e6d7a68f97ed767b6e287e72c4b86ec6"},{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"b537ed3d3af56bafda9f1dcc2925316908ed5f38","unresolved":false,"context_lines":[{"line_number":85,"context_line":"\tstruct scan_field field;"},{"line_number":86,"context_line":"\tuint8_t buf[4] \u003d { 0 };"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"\tLOG_DEBUG(\"loading jtagspi ir(0x%x)\", info-\u003eir);"},{"line_number":89,"context_line":"\tbuf_set_u32(buf, 0, info-\u003etap-\u003eir_length, info-\u003eir);"},{"line_number":90,"context_line":"\tfield.num_bits \u003d info-\u003etap-\u003eir_length;"},{"line_number":91,"context_line":"\tfield.out_value \u003d buf;"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"815a2823_f2e5eec9","line":88,"in_reply_to":"dc419d6e_dccdd637","updated":"2023-09-09 20:47:40.000000000","message":"Done","commit_id":"697acf28e6d7a68f97ed767b6e287e72c4b86ec6"}],"src/flash/nor/jtagspi.h":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3eda46aed63ef04dff306342b507cbd5b06ce3ee","unresolved":true,"context_lines":[{"line_number":7,"context_line":"enum jtagspi_mode_e {"},{"line_number":8,"context_line":"\tJTAGSPI_MODE_PROXY_BITSTREAM,      /* special bitream using the jtag user instruction */"},{"line_number":9,"context_line":"\tJTAGSPI_MODE_SPECIFIC_INSTRUCTION, /* jtag tap has specific instruction to access the spi port directly */"},{"line_number":10,"context_line":"};\t\t\t\t\t\t               /* (without special bitstream) */"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"#endif /* OPENOCD_JTAG_SPI_H */"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"a3a8fe52_15848a03","line":10,"updated":"2023-08-15 15:29:06.000000000","message":"please try to keep the comment in a single line, as here it looks like the comment is for the closed parenthesis only","commit_id":"df4fb27953881f10b1bc206b334b1d712230bee3"},{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"0dd78711ed9b64bba1cbfb80053f25e57029c3ee","unresolved":false,"context_lines":[{"line_number":7,"context_line":"enum jtagspi_mode_e {"},{"line_number":8,"context_line":"\tJTAGSPI_MODE_PROXY_BITSTREAM,      /* special bitream using the jtag user instruction */"},{"line_number":9,"context_line":"\tJTAGSPI_MODE_SPECIFIC_INSTRUCTION, /* jtag tap has specific instruction to access the spi port directly */"},{"line_number":10,"context_line":"};\t\t\t\t\t\t               /* (without special bitstream) */"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"#endif /* OPENOCD_JTAG_SPI_H */"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"e680699f_11b70af2","line":10,"in_reply_to":"a3a8fe52_15848a03","updated":"2023-08-15 20:09:01.000000000","message":"Done","commit_id":"df4fb27953881f10b1bc206b334b1d712230bee3"}]}