)]}'
{"id":"openocd~master~If8c4aa03754607be6c089f514ae300b09b067ffa","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000853":{"account":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"last_update":"2023-08-26 11:35:06.000000000","reason":"Change was submitted"},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2023-08-25 13:37:20.000000000","reason":"\u003cGERRIT_ACCOUNT_1000021\u003e replied on the change","reason_account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}},"1000859":{"account":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"last_update":"2023-08-26 11:35:06.000000000","reason":"Change was submitted"},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2023-08-26 11:35:06.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"If8c4aa03754607be6c089f514ae300b09b067ffa","subject":"efm32: drop unnecessary and incomplete checks","status":"MERGED","created":"2023-08-02 22:13:57.000000000","updated":"2023-08-26 11:35:06.000000000","submitted":"2023-08-26 11:35:06.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7844","meta_rev_id":"4109841536758d54f7d6c7d3133bb14e14e0bdf8","_number":7844,"owner":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-08-26 11:35:06.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-08-26 11:35:06.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-08-02 22:31:21.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-08-03 03:46:00.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"},{"updated":"2023-08-03 03:46:00.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"state":"REVIEWER"},{"updated":"2023-08-08 16:39:05.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"1c82bedacc54ba25f898d48214b97ad07681e274","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"real_author":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"date":"2023-08-02 22:13:57.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"06826d64d883c46fb1c8cfc7e8bcd04657752896","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-08-02 22:31:21.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/18069/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/17266/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"8a15f265378e1e78ff3791524d02b2f4637168ae","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-08-03 03:46:00.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"7ac4ce1b49d401d830b694f8e2283e6cf91c9beb","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"real_author":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"date":"2023-08-04 20:46:31.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.\n\nOutdated Votes:\n* Code-Review+1 (copy condition: \"changekind:NO_CHANGE OR is:MIN\")\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"fb064bc0c2b4d6fccfb70400f3d989e222562131","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-08-04 21:10:07.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/18078/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/17276/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"1b69c50021cfc77966fa0b52619f8d58bfc08e09","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2023-08-06 08:55:52.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"78a99136219297c1757c3619080dea5a8d246a1a","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-08-07 07:46:46.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"b8a6e087ee518e281b1dc4b1678b24595838e9ee","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-08-08 16:39:05.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"fb59d0bfd6002f3c9eb03c203e873ec28a86ea1f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"real_author":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"date":"2023-08-25 11:39:08.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.\n\nOutdated Votes:\n* Code-Review+1, Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR is:MIN\")\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"10ffbba4053bf0563d3dea258f378556d1bc003a","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-08-25 12:28:07.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/18197/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/17391/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"b821e0ae267e240bba2b109ec8ab4e55c0bef4c1","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-08-25 13:37:20.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"4109841536758d54f7d6c7d3133bb14e14e0bdf8","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-08-26 11:35:06.000000000","message":"Change has been successfully cherry-picked as a4b4750e3860fae620f51d34a43a655b5ccdd51d","accounts_in_message":[],"_revision_number":4}],"current_revision":"a4b4750e3860fae620f51d34a43a655b5ccdd51d","revisions":{"a4b4750e3860fae620f51d34a43a655b5ccdd51d":{"kind":"NO_CODE_CHANGE","_number":4,"created":"2023-08-26 11:35:06.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/44/7844/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/44/7844/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/44/7844/4 \u0026\u0026 git checkout -b change-7844 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/44/7844/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/44/7844/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/44/7844/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/44/7844/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/44/7844/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2e60e2eca9d06dcb99a4adb81ebe435a72ab0c7f","subject":"flash/nor/spi: Improve erase performance on zd25q16"}],"author":{"name":"Karl Palsson","email":"karlp@tweak.au","date":"2023-08-02 21:33:32.000000000","tz":0},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-08-26 11:35:06.000000000","tz":0},"subject":"efm32: drop unnecessary and incomplete checks","message":"efm32: drop unnecessary and incomplete checks\n\nThere\u0027s really no reason to try and add an extra layer of cpu\nverification here.\n\nChange-Id: If8c4aa03754607be6c089f514ae300b09b067ffa\nSigned-off-by: Karl Palsson \u003ckarlp@tweak.au\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7844\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"27d90de29f254adc065095c477a91bb04135649e":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2023-08-04 20:46:31.000000000","uploader":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"ref":"refs/changes/44/7844/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/44/7844/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/44/7844/2 \u0026\u0026 git checkout -b change-7844 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/44/7844/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/44/7844/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/44/7844/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/44/7844/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/44/7844/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"bab8b8c9eb7c0e892eaa375cb1f388a75165c627","subject":"register: refactor register_cache_invalidate()"}],"author":{"name":"Karl Palsson","email":"karlp@tweak.au","date":"2023-08-02 21:33:32.000000000","tz":0},"committer":{"name":"Karl Palsson","email":"karlp@tweak.au","date":"2023-08-04 20:38:32.000000000","tz":0},"subject":"efm32: drop unnecessary and incomplete checks","message":"efm32: drop unnecessary and incomplete checks\n\nThere\u0027s really no reason to try and add an extra layer of cpu\nverification here.\n\nChange-Id: If8c4aa03754607be6c089f514ae300b09b067ffa\nSigned-off-by: Karl Palsson \u003ckarlp@tweak.au\u003e\n"}},"3a8155be23eaa48b352ba9655e8448ce4296da05":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2023-08-25 11:39:08.000000000","uploader":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"ref":"refs/changes/44/7844/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/44/7844/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/44/7844/3 \u0026\u0026 git checkout -b change-7844 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/44/7844/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/44/7844/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/44/7844/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/44/7844/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/44/7844/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2e60e2eca9d06dcb99a4adb81ebe435a72ab0c7f","subject":"flash/nor/spi: Improve erase performance on zd25q16"}],"author":{"name":"Karl Palsson","email":"karlp@tweak.au","date":"2023-08-02 21:33:32.000000000","tz":0},"committer":{"name":"Karl Palsson","email":"karlp@tweak.au","date":"2023-08-25 11:38:59.000000000","tz":0},"subject":"efm32: drop unnecessary and incomplete checks","message":"efm32: drop unnecessary and incomplete checks\n\nThere\u0027s really no reason to try and add an extra layer of cpu\nverification here.\n\nChange-Id: If8c4aa03754607be6c089f514ae300b09b067ffa\nSigned-off-by: Karl Palsson \u003ckarlp@tweak.au\u003e\n"}},"a8cfade49776aac160b255e606f7d49bec273835":{"kind":"REWORK","_number":1,"created":"2023-08-02 22:13:57.000000000","uploader":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"ref":"refs/changes/44/7844/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/44/7844/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/44/7844/1 \u0026\u0026 git checkout -b change-7844 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/44/7844/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/44/7844/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/44/7844/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/44/7844/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/44/7844/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a5108240f9e12633fea400f92d96cc75e03c86ca","subject":"target: fix messages and return values of failed op because not halted"}],"author":{"name":"Karl Palsson","email":"karlp@tweak.au","date":"2023-08-02 21:33:32.000000000","tz":0},"committer":{"name":"Karl Palsson","email":"karlp@tweak.au","date":"2023-08-02 22:13:33.000000000","tz":0},"subject":"efm32: drop unnecessary and incomplete checks","message":"efm32: drop unnecessary and incomplete checks\n\nThere\u0027s really no reason to try and add an extra layer of cpu\nverification here.\n\nChange-Id: If8c4aa03754607be6c089f514ae300b09b067ffa\nSigned-off-by: Karl Palsson \u003ckarlp@tweak.au\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}
