)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"change_message_id":"aa3e301d349f90c6d647f2328ad29cd5fec02a6e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"43963326_2834b933","updated":"2023-08-08 20:22:12.000000000","message":"handled, but yeah, HLA handling this would be \"nice\"","commit_id":"9e006cf763c31ace57ef1acfb1615715b95791cd"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"ea2a7a65bacad1cba158af9ac87ccd258475a1a2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c8e0e017_c1e3efaf","updated":"2023-08-08 20:44:32.000000000","message":"thanks!","commit_id":"677c41b49e6decf444d91cb3326aad99f6f0d338"}],"tcl/target/rtl872xd.cfg":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"06476ef0c5273840cf24287eeb51f4844619040a","unresolved":true,"context_lines":[{"line_number":14,"context_line":"        set _CPUTAPID $CPUTAPID"},{"line_number":15,"context_line":"} else {"},{"line_number":16,"context_line":"        if { [using_jtag] } {"},{"line_number":17,"context_line":"\t\t# FIXME - never tried jtag, copy pasta alert!"},{"line_number":18,"context_line":"                # Corresponds to Cortex®-M33 JTAG debug port ID code"},{"line_number":19,"context_line":"                set _CPUTAPID 0x0ba04477"},{"line_number":20,"context_line":"        } {"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"375abab8_c75e29e8","line":17,"updated":"2023-08-03 08:49:47.000000000","message":"please be consistent with the indentation and remember that OpenOCD coding style uses TABs of 4 chars.\nThis line, line 23 and line 41 use TABs, while the rest of the file uses spaces.\nI suggest you to use TABs everywhere","commit_id":"4c1e028e1f4d464979d764746c1babe6ee3f09c2"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"9d83ce5ce9a08734ab57579874b5f30d3555c39c","unresolved":false,"context_lines":[{"line_number":14,"context_line":"        set _CPUTAPID $CPUTAPID"},{"line_number":15,"context_line":"} else {"},{"line_number":16,"context_line":"        if { [using_jtag] } {"},{"line_number":17,"context_line":"\t\t# FIXME - never tried jtag, copy pasta alert!"},{"line_number":18,"context_line":"                # Corresponds to Cortex®-M33 JTAG debug port ID code"},{"line_number":19,"context_line":"                set _CPUTAPID 0x0ba04477"},{"line_number":20,"context_line":"        } {"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"8a0eae87_d7d3482c","line":17,"in_reply_to":"375abab8_c75e29e8","updated":"2023-08-08 16:35:40.000000000","message":"Done","commit_id":"4c1e028e1f4d464979d764746c1babe6ee3f09c2"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"9d83ce5ce9a08734ab57579874b5f30d3555c39c","unresolved":true,"context_lines":[{"line_number":22,"context_line":"target create $_TARGETNAME.km0 cortex_m -endian little -dap $_CHIPNAME.dap -ap-num 1"},{"line_number":23,"context_line":"target create $_TARGETNAME.km4 cortex_m -endian little -dap $_CHIPNAME.dap -ap-num 2"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"if { ![using_hla] } {"},{"line_number":26,"context_line":"        cortex_m reset_config sysresetreq"},{"line_number":27,"context_line":"}"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":4,"id":"f18dbc57_a1e25ce4","line":25,"updated":"2023-08-08 16:35:40.000000000","message":"Today HLA supports only AP-NUM 0.\nYou have the cores in AP1 and AP2, so this will not work with HLA.\nI suggest you to have, somewhere at the beginning of this file:\nif { [using_hla] } {\necho \"ERROR: HLA transport cannot work with this target.\"\nshutdown\n}\nas it is done in tcl/target/stm32mp15x.cfg.\n\nThen, also the condition can be dropped and left only the body\ncortex_m reset_config sysresetreq","commit_id":"9e006cf763c31ace57ef1acfb1615715b95791cd"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"ea2a7a65bacad1cba158af9ac87ccd258475a1a2","unresolved":false,"context_lines":[{"line_number":22,"context_line":"target create $_TARGETNAME.km0 cortex_m -endian little -dap $_CHIPNAME.dap -ap-num 1"},{"line_number":23,"context_line":"target create $_TARGETNAME.km4 cortex_m -endian little -dap $_CHIPNAME.dap -ap-num 2"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"if { ![using_hla] } {"},{"line_number":26,"context_line":"        cortex_m reset_config sysresetreq"},{"line_number":27,"context_line":"}"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":4,"id":"435da6d5_4cd50439","line":25,"in_reply_to":"ed45e3b6_8968c7b6","updated":"2023-08-08 20:44:32.000000000","message":"Humm, to be investigated!","commit_id":"9e006cf763c31ace57ef1acfb1615715b95791cd"},{"author":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"change_message_id":"aa3e301d349f90c6d647f2328ad29cd5fec02a6e","unresolved":true,"context_lines":[{"line_number":22,"context_line":"target create $_TARGETNAME.km0 cortex_m -endian little -dap $_CHIPNAME.dap -ap-num 1"},{"line_number":23,"context_line":"target create $_TARGETNAME.km4 cortex_m -endian little -dap $_CHIPNAME.dap -ap-num 2"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"if { ![using_hla] } {"},{"line_number":26,"context_line":"        cortex_m reset_config sysresetreq"},{"line_number":27,"context_line":"}"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":4,"id":"ed45e3b6_8968c7b6","line":25,"in_reply_to":"f18dbc57_a1e25ce4","updated":"2023-08-08 20:22:12.000000000","message":"I\u0027ll fix this, but can we make HLA handle that rejection itself, so we don\u0027t have to sprinkle this over all target files with multiple APs?","commit_id":"9e006cf763c31ace57ef1acfb1615715b95791cd"}]}
