)]}'
{"id":"openocd~master~Icbec04585664aba8b217e8f9a75458e577f7617f","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2023-08-16 13:40:37.000000000","reason":"\u003cGERRIT_ACCOUNT_1000021\u003e replied on the change","reason_account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}},"1002107":{"account":{"_account_id":1002107,"name":"Marcin Niestroj","email":"m.niestroj@emb.dev","username":"mniestroj"},"last_update":"2023-08-26 11:44:00.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Icbec04585664aba8b217e8f9a75458e577f7617f","subject":"stlink: increase stlink v2 max speed to 2.25 Mbps","status":"MERGED","created":"2023-08-03 15:58:54.000000000","updated":"2023-08-26 11:44:00.000000000","submitted":"2023-08-26 11:44:00.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7848","meta_rev_id":"7ffdc0530603923eb6a4db8c2cb547d6795f0dd4","_number":7848,"owner":{"_account_id":1002107,"name":"Marcin Niestroj","email":"m.niestroj@emb.dev","username":"mniestroj"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-08-26 11:44:00.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-08-26 11:44:00.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-08-03 16:10:53.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-08-04 10:43:03.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"CC"},{"updated":"2023-08-16 13:40:37.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"25f273a23c47f30c5571ddc00ca76ace48b0c670","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002107,"name":"Marcin Niestroj","email":"m.niestroj@emb.dev","username":"mniestroj"},"real_author":{"_account_id":1002107,"name":"Marcin Niestroj","email":"m.niestroj@emb.dev","username":"mniestroj"},"date":"2023-08-03 15:58:54.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"db9a6284ef1f5daa980cf52a3186baa61e7add6d","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-08-03 16:10:53.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/18074/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/17273/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"0f41e82ecdb2dc63b37fc82c4b8f239b513dbfc6","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-08-04 10:43:03.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"55509ce70e6c11ec868262bed548636dead9236e","author":{"_account_id":1002107,"name":"Marcin Niestroj","email":"m.niestroj@emb.dev","username":"mniestroj"},"real_author":{"_account_id":1002107,"name":"Marcin Niestroj","email":"m.niestroj@emb.dev","username":"mniestroj"},"date":"2023-08-04 14:34:51.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"20eb9ac104935dff378d6c6c07b52cb083a7ed51","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-08-16 13:40:37.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"7ffdc0530603923eb6a4db8c2cb547d6795f0dd4","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-08-26 11:44:00.000000000","message":"Change has been successfully cherry-picked as 74325dc73d48eb9371fa9ba8d190c46d70abbce3","accounts_in_message":[],"_revision_number":2}],"current_revision":"74325dc73d48eb9371fa9ba8d190c46d70abbce3","revisions":{"74325dc73d48eb9371fa9ba8d190c46d70abbce3":{"kind":"REWORK","_number":2,"created":"2023-08-26 11:44:00.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/48/7848/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/48/7848/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/48/7848/2 \u0026\u0026 git checkout -b change-7848 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/48/7848/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/48/7848/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/48/7848/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/48/7848/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/48/7848/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"76f3351f4a0a3c315bd257a18bc1e2c158d397bb","subject":"tcl/board: Add j721e native swd configuration"}],"author":{"name":"Marcin Niestroj","email":"m.niestroj@emb.dev","date":"2023-08-03 15:43:39.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-08-26 11:44:00.000000000","tz":0},"subject":"stlink: increase stlink v2 max speed to 2.25 Mbps","message":"stlink: increase stlink v2 max speed to 2.25 Mbps\n\nstlink v2 on Nucleo-64 board (e.g. NUCLEO-L476RG) has target SWO signal\nconnected to STM32F103CB\u0027S PA10, which is UART1_RX. UART1 within this\nMCU in theory can be configured to 4.5 Mbps baudrate, which means this\nis the upper limit supported by HW. As a confirmation BMP (Black Magic\nProbe) project also states in documentation that UART1 can be used with\nup to 4.5 Mbps baudrate.\n\nTests have shown that configuring 4.5 Mbps baudrate on stlink v2\navailable on NUCLEO-L476RG board results in receiving corrupted data.\nUsing 2.25 Mbps however allows to successfully receive all data from\nSWO. This makes sense in terms of STM32F103CB capabilities, since 2.25\nMbps is the next supported baudrate due to division by 2.\n\nIncrease supported stlink v2 SWO speed from 2 to 2.25 Mbps.\n\nTested with NUCLEO-L476RG:\n\n  $ stm32l4x.tpiu configure -protocol uart \\\n    -traceclk 80000000 -pin-freq 2250000 \\\n    -output /dev/stdout\n  $ stm32l4x.tpiu enable\n\n2.25 Mbps speed confirmed with logic analyzer.\n\nSigned-off-by: Marcin Niestroj \u003cm.niestroj@emb.dev\u003e\nChange-Id: Icbec04585664aba8b217e8f9a75458e577f7617f\nReviewed-on: https://review.openocd.org/c/openocd/+/7848\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"2555e770331fedf6b149c9ac81c587832bd184ec":{"kind":"REWORK","_number":1,"created":"2023-08-03 15:58:54.000000000","uploader":{"_account_id":1002107,"name":"Marcin Niestroj","email":"m.niestroj@emb.dev","username":"mniestroj"},"ref":"refs/changes/48/7848/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/48/7848/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/48/7848/1 \u0026\u0026 git checkout -b change-7848 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/48/7848/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/48/7848/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/48/7848/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/48/7848/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/48/7848/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a5108240f9e12633fea400f92d96cc75e03c86ca","subject":"target: fix messages and return values of failed op because not halted"}],"author":{"name":"Marcin Niestroj","email":"m.niestroj@emb.dev","date":"2023-08-03 15:43:39.000000000","tz":120},"committer":{"name":"Marcin Niestroj","email":"m.niestroj@emb.dev","date":"2023-08-03 15:43:39.000000000","tz":120},"subject":"stlink: increase stlink v2 max speed to 2.25 Mbps","message":"stlink: increase stlink v2 max speed to 2.25 Mbps\n\nstlink v2 on Nucleo-64 board (e.g. NUCLEO-L476RG) has target SWO signal\nconnected to STM32F103CB\u0027S PA10, which is UART1_RX. UART1 within this\nMCU in theory can be configured to 4.5 Mbps baudrate, which means this\nis the upper limit supported by HW. As a confirmation BMP (Black Magic\nProbe) project also states in documentation that UART1 can be used with\nup to 4.5 Mbps baudrate.\n\nTests have shown that configuring 4.5 Mbps baudrate on stlink v2\navailable on NUCLEO-L476RG board results in receiving corrupted data.\nUsing 2.25 Mbps however allows to successfully receive all data from\nSWO. This makes sense in terms of STM32F103CB capabilities, since 2.25\nMbps is the next supported baudrate due to division by 2.\n\nIncrease supported stlink v2 SWO speed from 2 to 2.25 Mbps.\n\nTested with NUCLEO-L476RG:\n\n  $ stm32l4x.tpiu configure -protocol uart \\\n    -traceclk 80000000 -pin-freq 2250000 \\\n    -output /dev/stdout\n  $ stm32l4x.tpiu enable\n\n2.25 Mbps speed confirmed with logic analyzer.\n\nSigned-off-by: Marcin Niestroj \u003cm.niestroj@emb.dev\u003e\nChange-Id: Icbec04585664aba8b217e8f9a75458e577f7617f\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}