)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1002176,"name":"Nikolay Dimitrov","email":"nikolay.dimitrov@retrohub.org","username":"picmaster"},"change_message_id":"a2b3e66d6c385f6af70a164263514337ac90ec70","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"64e9e708_a61d9014","updated":"2023-08-04 20:20:48.000000000","message":"Hi Tomas,\n\nThis is what I did initially, but it broke the \"flash erase_sector\" command, here\u0027s how:\n\n\u003e flash erase_check 0\nsuccessfully checked erase state\n\t#  0: 0x00000000 (0x1000 4kB) not erased\n\t#  1: 0x00001000 (0x1000 4kB) not erased\n\t#  2: 0x00002000 (0x1000 4kB) not erased\n\t#  3: 0x00003000 (0x1000 4kB) not erased\n\t#  4: 0x00004000 (0x1000 4kB) not erased\n\t#  5: 0x00005000 (0x1000 4kB) not erased\n\t#  6: 0x00006000 (0x1000 4kB) not erased\n\t#  7: 0x00007000 (0x1000 4kB) not erased\n\t#  8: 0x00008000 (0x1000 4kB) not erased\n\t#  9: 0x00009000 (0x1000 4kB) not erased\n\t# 10: 0x0000a000 (0x1000 4kB) not erased\n\t# 11: 0x0000b000 (0x1000 4kB) not erased\n\t# 12: 0x0000c000 (0x1000 4kB) not erased\n\t# 13: 0x0000d000 (0x1000 4kB) not erased\n\t# 14: 0x0000e000 (0x1000 4kB) not erased\n\t# 15: 0x0000f000 (0x1000 4kB) not erased\n\t# 16: 0x00010000 (0x1000 4kB) not erased\n\t# 17: 0x00011000 (0x1000 4kB) not erased\n...\n\u003e flash erase_sector 0 0 0\nerased sectors 0 through 0 on flash bank 0 in 0.104826s\n\u003e flash erase_check 0\nsuccessfully checked erase state\n\t# 16: 0x00010000 (0x1000 4kB) not erased\n\t# 17: 0x00011000 (0x1000 4kB) not erased\n\t# 18: 0x00012000 (0x1000 4kB) not erased\n...\n\nThe command stated that it erased just the requested sector 0, but in reality it erased sectors 0-15, which I find unacceptable. Of course I agree that erasing blocks is faster, but I would always prefer correct over fast implementation, that\u0027s why I decided to go with 0x20. Please advice whether I should resubmit the patch with 0xD8 or leave it as it is.\n\nKind regards,\nNikolay","commit_id":"f140c151facde6e755039f4852ce0ec41a245f90"},{"author":{"_account_id":1001036,"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","username":"abmero"},"change_message_id":"7b612b6485e495dcc591a0c47c56a8983a0cc812","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"22a9bac4_68e09ed5","updated":"2023-08-04 16:41:19.000000000","message":"Maybe you could add the other current devices from Zetta, too?\nA whole bunch at once instead of drop by drop would be more convenient.","commit_id":"f140c151facde6e755039f4852ce0ec41a245f90"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"653470d9a6f2ce47fc4c7cbf09b5d1d473ee1309","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7eac6e7d_7eb5646a","updated":"2023-08-05 08:34:36.000000000","message":"Nikolay,\nnext time please use \u0027git commit --amend\u0027 to fix a not-yet-merged patch instead of submitting a new one. This time I\u0027ll merge these 2 patches as they are, this one is suboptimal but perfectly usable.\nThanks!","commit_id":"f140c151facde6e755039f4852ce0ec41a245f90"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"414b3626030d82d574c5ea447885ced796425d7f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"db9fc4fb_2fc663d3","updated":"2023-08-04 04:59:00.000000000","message":"Thanks!","commit_id":"f140c151facde6e755039f4852ce0ec41a245f90"},{"author":{"_account_id":1002176,"name":"Nikolay Dimitrov","email":"nikolay.dimitrov@retrohub.org","username":"picmaster"},"change_message_id":"3aa9930c3b1bb9ff51e508d7111d35f6f73be011","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"99ba059a_9dbd73cd","in_reply_to":"22a9bac4_68e09ed5","updated":"2023-08-04 20:26:32.000000000","message":"Hi Andreas,\n\nWould love to add several more Zetta devices, but I don\u0027t have the actual devices to test and I don\u0027t like sending untested code.\n\nKind regards,\nNikolay","commit_id":"f140c151facde6e755039f4852ce0ec41a245f90"},{"author":{"_account_id":1002176,"name":"Nikolay Dimitrov","email":"nikolay.dimitrov@retrohub.org","username":"picmaster"},"change_message_id":"d010f6fc706e64c177da3beb25c104487066c19f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b4c46cce_e799ca71","in_reply_to":"64e9e708_a61d9014","updated":"2023-08-04 20:43:51.000000000","message":"Hi Tomas,\n\nI understood what you meant. There was a mistake on my side (forgot to update the erase size. I\u0027ll send later a fix for the block erase. Thanks for reviewing my patch!\n\nRegards,\nNikolay","commit_id":"f140c151facde6e755039f4852ce0ec41a245f90"},{"author":{"_account_id":1002176,"name":"Nikolay Dimitrov","email":"nikolay.dimitrov@retrohub.org","username":"picmaster"},"change_message_id":"64bb73d44b35b2de266638ebedc87fc1b62702c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a3bca95e_e995e49d","in_reply_to":"7eac6e7d_7eb5646a","updated":"2023-08-05 18:19:43.000000000","message":"Hi Tomas,\n\nUnderstood. This is my 1st time using gerrit and it looked to me that the 1st patch was already accepted and I couldn\u0027t modify it anymore, that\u0027s why I submitted the other change as a 2nd patch. Sorry about that.\n\nThanks for helping out. Regards,\nNikolay","commit_id":"f140c151facde6e755039f4852ce0ec41a245f90"}],"src/flash/nor/spi.c":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"414b3626030d82d574c5ea447885ced796425d7f","unresolved":true,"context_lines":[{"line_number":171,"context_line":"\tFLASH_ID(\"xtx xt25q32b\",        0x03, 0x0b, 0x02, 0xd8, 0xc7, 0x0016600b, 0x100, 0x10000, 0x400000), /* exists ? */"},{"line_number":172,"context_line":"\tFLASH_ID(\"xtx xt25q64b\",        0x03, 0x0b, 0x02, 0xd8, 0xc7, 0x0017600b, 0x100, 0x10000, 0x800000),"},{"line_number":173,"context_line":"\tFLASH_ID(\"xtx xt25q128b\",       0x03, 0x0b, 0x02, 0xd8, 0xc7, 0x0018600b, 0x100, 0x10000, 0x1000000),"},{"line_number":174,"context_line":"\tFLASH_ID(\"zetta zd25q16\",       0x03, 0x00, 0x02, 0x20, 0xc7, 0x001560ba, 0x100, 0x1000, 0x200000),"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"\t/* FRAM, no erase commands, no write page or sectors */"},{"line_number":177,"context_line":"\tFRAM_ID(\"fu mb85rs16n\",         0x03, 0,    0x02, 0x00010104, 0x800),"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"e6e65183_a1254ef7","line":174,"range":{"start_line":174,"start_character":51,"end_line":174,"end_character":55},"updated":"2023-08-04 04:59:00.000000000","message":"We use block erase cmd (0xd8) for all devices \u003e 8 Mbit to keep erase speed reasonable.\nCould you please try to use block erase instead of sector erase (0x20) and change erase size appropriately?","commit_id":"f140c151facde6e755039f4852ce0ec41a245f90"},{"author":{"_account_id":1002176,"name":"Nikolay Dimitrov","email":"nikolay.dimitrov@retrohub.org","username":"picmaster"},"change_message_id":"b32ce51f1b6621ff1e05b343b61e2c16a3952438","unresolved":false,"context_lines":[{"line_number":171,"context_line":"\tFLASH_ID(\"xtx xt25q32b\",        0x03, 0x0b, 0x02, 0xd8, 0xc7, 0x0016600b, 0x100, 0x10000, 0x400000), /* exists ? */"},{"line_number":172,"context_line":"\tFLASH_ID(\"xtx xt25q64b\",        0x03, 0x0b, 0x02, 0xd8, 0xc7, 0x0017600b, 0x100, 0x10000, 0x800000),"},{"line_number":173,"context_line":"\tFLASH_ID(\"xtx xt25q128b\",       0x03, 0x0b, 0x02, 0xd8, 0xc7, 0x0018600b, 0x100, 0x10000, 0x1000000),"},{"line_number":174,"context_line":"\tFLASH_ID(\"zetta zd25q16\",       0x03, 0x00, 0x02, 0x20, 0xc7, 0x001560ba, 0x100, 0x1000, 0x200000),"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"\t/* FRAM, no erase commands, no write page or sectors */"},{"line_number":177,"context_line":"\tFRAM_ID(\"fu mb85rs16n\",         0x03, 0,    0x02, 0x00010104, 0x800),"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"cc0b4e94_e80dd271","line":174,"range":{"start_line":174,"start_character":51,"end_line":174,"end_character":55},"in_reply_to":"e6e65183_a1254ef7","updated":"2023-08-04 20:39:37.000000000","message":"Ack","commit_id":"f140c151facde6e755039f4852ce0ec41a245f90"}]}