)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"383edc98b32eaf19c5add0dd0cc26699bf0e0e85","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5fc8de7e_6e01e5f1","updated":"2023-08-08 16:12:43.000000000","message":"Thanks for the explanation. I have missed the ZEPHYR_VAL__KERNEL_OPENOCD_NUM_OFFSETS.\nLooks ok to merge it!","commit_id":"bf8cc5417f51f5504fd893f531347fe58c82f7e5"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"9f5ee94ceff86978e0b29f292f39caab2ca59276","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"83fd147c_93844be8","updated":"2023-08-08 15:19:24.000000000","message":"Thanks for your patch.\n\nThis patch aligns OpenOCD with Zephyr.\nThere is no code that uses it, so no behavior change.\n\nBut I have a question below...","commit_id":"bf8cc5417f51f5504fd893f531347fe58c82f7e5"}],"src/rtos/zephyr.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"9f5ee94ceff86978e0b29f292f39caab2ca59276","unresolved":true,"context_lines":[{"line_number":698,"context_line":"\t\t\t\t\tparam-\u003eoffsets[OFFSET_VERSION]);"},{"line_number":699,"context_line":"\t\t\treturn ERROR_FAIL;"},{"line_number":700,"context_line":"\t\t}"},{"line_number":701,"context_line":"\t\tswitch (param-\u003eoffsets[OFFSET_VERSION]) {"},{"line_number":702,"context_line":"\t\tcase 0:"},{"line_number":703,"context_line":"\t\t\tparam-\u003enum_offsets \u003d OFFSET_T_STACK_POINTER + 1;"},{"line_number":704,"context_line":"\t\t\tbreak;"},{"line_number":705,"context_line":"\t\tcase 1:"},{"line_number":706,"context_line":"\t\t\tparam-\u003enum_offsets \u003d OFFSET_T_COOP_FLOAT + 1;"},{"line_number":707,"context_line":"\t\t\tbreak;"},{"line_number":708,"context_line":"\t\t}"},{"line_number":709,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"36e7f097_314c7e9e","line":706,"range":{"start_line":701,"start_character":2,"end_line":706,"end_character":48},"updated":"2023-08-08 15:19:24.000000000","message":"this reports the max number of items to read. In line 69 we have:\nuint32_t offsets[OFFSET_MAX];\n\nFor version 0 it is OFFSET_T_STACK_POINTER + 1;\nFor version 1 it is OFFSET_T_COOP_FLOAT + 1; but now you have added one item.\nDo we need to read the new item too? Should this be changed to OFFSET_MAX so we don\u0027t have to change it every time?\nWhat about backward compatibility with old version of Zephyr that implement a shorter list? Are we allowed to read OFFSET_T_ARM_EXC_RETURN if it was not set by Zephyr?","commit_id":"bf8cc5417f51f5504fd893f531347fe58c82f7e5"},{"author":{"_account_id":1002178,"name":"Bruno Mendes","email":"bd_mendes@outlook.com","username":"bdmendes"},"change_message_id":"cc6b05deaf44614d5c99c82e267d1eb4e96bc642","unresolved":true,"context_lines":[{"line_number":698,"context_line":"\t\t\t\t\tparam-\u003eoffsets[OFFSET_VERSION]);"},{"line_number":699,"context_line":"\t\t\treturn ERROR_FAIL;"},{"line_number":700,"context_line":"\t\t}"},{"line_number":701,"context_line":"\t\tswitch (param-\u003eoffsets[OFFSET_VERSION]) {"},{"line_number":702,"context_line":"\t\tcase 0:"},{"line_number":703,"context_line":"\t\t\tparam-\u003enum_offsets \u003d OFFSET_T_STACK_POINTER + 1;"},{"line_number":704,"context_line":"\t\t\tbreak;"},{"line_number":705,"context_line":"\t\tcase 1:"},{"line_number":706,"context_line":"\t\t\tparam-\u003enum_offsets \u003d OFFSET_T_COOP_FLOAT + 1;"},{"line_number":707,"context_line":"\t\t\tbreak;"},{"line_number":708,"context_line":"\t\t}"},{"line_number":709,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"cfad7a73_d38432db","line":706,"range":{"start_line":701,"start_character":2,"end_line":706,"end_character":48},"in_reply_to":"36e7f097_314c7e9e","updated":"2023-08-08 15:44:27.000000000","message":"Thank your for your time.\n\nWe only hardcode the number of known offsets like this if we can\u0027t read the ZEPHYR_VAL__KERNEL_OPENOCD_NUM_OFFSETS symbol.\n\nIf we can\u0027t, we should stick with the minimum required offsets for Zephyr\u0027s \"offset version 1\". See subsys/debug/thread_info.c line 127:\n\"Version is still 1, but existence of following elements must be\nchecked with _kernel_thread_info_num_offsets.\"\n\nSo we end up with these scenarios:\n\n1. We read ZEPHYR_VAL__KERNEL_OPENOCD_NUM_OFFSETS: we read the new offset.\n2. We can\u0027t read ZEPHYR_VAL__KERNEL_OPENOCD_NUM_OFFSETS: even if the new offset is there, we cannot be sure so we skip it.\n\nHopefully I was not very confusing.","commit_id":"bf8cc5417f51f5504fd893f531347fe58c82f7e5"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"383edc98b32eaf19c5add0dd0cc26699bf0e0e85","unresolved":false,"context_lines":[{"line_number":698,"context_line":"\t\t\t\t\tparam-\u003eoffsets[OFFSET_VERSION]);"},{"line_number":699,"context_line":"\t\t\treturn ERROR_FAIL;"},{"line_number":700,"context_line":"\t\t}"},{"line_number":701,"context_line":"\t\tswitch (param-\u003eoffsets[OFFSET_VERSION]) {"},{"line_number":702,"context_line":"\t\tcase 0:"},{"line_number":703,"context_line":"\t\t\tparam-\u003enum_offsets \u003d OFFSET_T_STACK_POINTER + 1;"},{"line_number":704,"context_line":"\t\t\tbreak;"},{"line_number":705,"context_line":"\t\tcase 1:"},{"line_number":706,"context_line":"\t\t\tparam-\u003enum_offsets \u003d OFFSET_T_COOP_FLOAT + 1;"},{"line_number":707,"context_line":"\t\t\tbreak;"},{"line_number":708,"context_line":"\t\t}"},{"line_number":709,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"940e44d0_fe0a91b2","line":706,"range":{"start_line":701,"start_character":2,"end_line":706,"end_character":48},"in_reply_to":"cfad7a73_d38432db","updated":"2023-08-08 16:12:43.000000000","message":"Ack","commit_id":"bf8cc5417f51f5504fd893f531347fe58c82f7e5"}]}