)]}'
{"id":"openocd~master~I4fc7a8132a6b00c7f213ec9fd05c7bbb37ee5f20","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1002139":{"account":{"_account_id":1002139,"name":"Vincent Fazio","email":"vfazio@gmail.com","username":"vfazio"},"last_update":"2023-08-29 06:21:46.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I4fc7a8132a6b00c7f213ec9fd05c7bbb37ee5f20","subject":"jtag/drivers/bcm2835gpio: do not configure push-pull inputs as output","status":"MERGED","created":"2023-08-23 15:04:56.000000000","updated":"2023-08-29 06:21:46.000000000","submitted":"2023-08-29 06:21:46.000000000","submitter":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7862","meta_rev_id":"52b5f754119689dbf9676ea6f1c6ab737d480174","_number":7862,"owner":{"_account_id":1002139,"name":"Vincent Fazio","email":"vfazio@gmail.com","username":"vfazio"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-08-29 06:21:46.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-08-29 06:21:46.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-08-23 15:18:04.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-08-27 12:32:39.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"}],"messages":[{"id":"4ae9f46927f030916766e043257c6ae52e817713","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002139,"name":"Vincent Fazio","email":"vfazio@gmail.com","username":"vfazio"},"real_author":{"_account_id":1002139,"name":"Vincent Fazio","email":"vfazio@gmail.com","username":"vfazio"},"date":"2023-08-23 15:04:56.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f8c303e429af0d57caf74566897c4ca83bb04741","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-08-23 15:18:04.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/18180/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/17374/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"cdfee06b2a206e1cf737f77331ef9e244322070a","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-08-27 12:32:39.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"0aff9ca59c0ded245f14399f6f59573a74f6af0d","author":{"_account_id":1002139,"name":"Vincent Fazio","email":"vfazio@gmail.com","username":"vfazio"},"real_author":{"_account_id":1002139,"name":"Vincent Fazio","email":"vfazio@gmail.com","username":"vfazio"},"date":"2023-08-28 12:44:12.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"47b5a665b5570a386ff6428fe8dc6d35670d8b78","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-08-29 06:21:28.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"52b5f754119689dbf9676ea6f1c6ab737d480174","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-08-29 06:21:46.000000000","message":"Change has been successfully cherry-picked as ea0ac6dc779f09fd21e007d93987a6a7eca5149e","accounts_in_message":[],"_revision_number":2}],"current_revision":"ea0ac6dc779f09fd21e007d93987a6a7eca5149e","revisions":{"ea0ac6dc779f09fd21e007d93987a6a7eca5149e":{"kind":"REWORK","_number":2,"created":"2023-08-29 06:21:46.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/62/7862/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/62/7862/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/62/7862/2 \u0026\u0026 git checkout -b change-7862 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/62/7862/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/62/7862/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/62/7862/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/62/7862/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/62/7862/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"aee495e7859d0f19b52ba12cafaad2628d84f8e1","subject":"contrib/firmware: add new i2c bit-banging feature to angie\u0027s firmware"}],"author":{"name":"Brandon Pupp","email":"bpupp@xes-inc.com","date":"2023-08-18 14:51:06.000000000","tz":-300},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2023-08-29 06:21:46.000000000","tz":0},"subject":"jtag/drivers/bcm2835gpio: do not configure push-pull inputs as output","message":"jtag/drivers/bcm2835gpio: do not configure push-pull inputs as output\n\nPreviously, if a pin was configured as ADAPTER_GPIO_INIT_STATE_INPUT and\nits drive value was ADAPTER_GPIO_DRIVE_MODE_PUSH_PULL, initialize_gpio\nwould configure the pin as an output.\n\nThe set_gpio_value function is optimized to not set the direction for\npins configured as ADAPTER_GPIO_DRIVE_MODE_PUSH_PULL as it only needs to\nbe set once. When initialize_gpio performs this setup, it checked only\nthat the drive value was ADAPTER_GPIO_DRIVE_MODE_PUSH_PULL to set the\noutput direction but did not exclude input pins which have already had\ntheir direction set.\n\nNow, input pins are ignored when initialize_gpio checks for\nADAPTER_GPIO_DRIVE_MODE_PUSH_PULL to set the mode to output.\n\nChange-Id: I4fc7a8132a6b00c7f213ec9fd05c7bbb37ee5f20\nFixes: 0dd969d83bad (\"drivers/bcm2835gpio: Migrate to adapter gpio commands\")\nSigned-off-by: Brandon Pupp \u003cbpupp@xes-inc.com\u003e\n[vfazio: update commit message]\nSigned-off-by: Vincent Fazio \u003cvfazio@xes-inc.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7862\nTested-by: jenkins\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"826d04d330e97a8851dbbc9ddd06f23762372c16":{"kind":"REWORK","_number":1,"created":"2023-08-23 15:04:56.000000000","uploader":{"_account_id":1002139,"name":"Vincent Fazio","email":"vfazio@gmail.com","username":"vfazio"},"ref":"refs/changes/62/7862/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/62/7862/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/62/7862/1 \u0026\u0026 git checkout -b change-7862 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/62/7862/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/62/7862/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/62/7862/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/62/7862/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/62/7862/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2e60e2eca9d06dcb99a4adb81ebe435a72ab0c7f","subject":"flash/nor/spi: Improve erase performance on zd25q16"}],"author":{"name":"Brandon Pupp","email":"bpupp@xes-inc.com","date":"2023-08-18 14:51:06.000000000","tz":-300},"committer":{"name":"Vincent Fazio","email":"vfazio@xes-inc.com","date":"2023-08-23 14:58:19.000000000","tz":-300},"subject":"jtag/drivers/bcm2835gpio: do not configure push-pull inputs as output","message":"jtag/drivers/bcm2835gpio: do not configure push-pull inputs as output\n\nPreviously, if a pin was configured as ADAPTER_GPIO_INIT_STATE_INPUT and\nits drive value was ADAPTER_GPIO_DRIVE_MODE_PUSH_PULL, initialize_gpio\nwould configure the pin as an output.\n\nThe set_gpio_value function is optimized to not set the direction for\npins configured as ADAPTER_GPIO_DRIVE_MODE_PUSH_PULL as it only needs to\nbe set once. When initialize_gpio performs this setup, it checked only\nthat the drive value was ADAPTER_GPIO_DRIVE_MODE_PUSH_PULL to set the\noutput direction but did not exclude input pins which have already had\ntheir direction set.\n\nNow, input pins are ignored when initialize_gpio checks for\nADAPTER_GPIO_DRIVE_MODE_PUSH_PULL to set the mode to output.\n\nChange-Id: I4fc7a8132a6b00c7f213ec9fd05c7bbb37ee5f20\nFixes: 0dd969d83bad (\"drivers/bcm2835gpio: Migrate to adapter gpio commands\")\nSigned-off-by: Brandon Pupp \u003cbpupp@xes-inc.com\u003e\n[vfazio: update commit message]\nSigned-off-by: Vincent Fazio \u003cvfazio@xes-inc.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}