)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"change_message_id":"4caa19381f6fd2ab580d102f1dff0d2847904fcd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"99c0e487_4df150fa","updated":"2023-09-22 06:40:04.000000000","message":"Hi! Thanks for the advise, I have changed the code for dsp accesses as instructed.","commit_id":"125dae6f53eda1869615b668757e59cc57f429fe"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"5487593915d46c0bfea36e7e5da727398464ef2e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"a75834f7_43a37a89","updated":"2024-02-02 16:13:30.000000000","message":"Overall, it looks great. There are only some minor stile fixes.","commit_id":"edb229e0ae4c1e15b4d41e46bf8c486c56a87c99"},{"author":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"change_message_id":"7a3101874e23de379310bccad75e22dbef726f62","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"8fae15c7_1d4c54c6","in_reply_to":"a75834f7_43a37a89","updated":"2024-02-18 09:03:55.000000000","message":"Fixed, sorry for the late reply!","commit_id":"edb229e0ae4c1e15b4d41e46bf8c486c56a87c99"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"97090690128671fe0022c02f8747c1a9d4cd801e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"83b48af5_ffae2e5d","updated":"2024-02-18 22:50:06.000000000","message":"I\u0027m ok with this patch, apart for a possible typo below. Please check it\n\nQuestion:\nWith this path the DSP registers get accessible from OpenOCD. Good!\nWhat about GDB for MIPS? I see this file\nhttps://github.com/bminor/binutils-gdb/blob/master/gdb/features/mips-dsp.xml\nShould these dsp registers be handled as extension of the CPU registers and get accessible from GDB?\nOr, due to decreasing MIPS interest, this would requires too much work for a minor gain?","commit_id":"b3ed3dbce2de992ab8910c9050fa7ef2474afc8c"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"164f1903a88814367dae36e591128bee45baaf0e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"e9bb8887_a0bfb5b1","in_reply_to":"087ab014_a453bda5","updated":"2024-02-24 17:26:07.000000000","message":"So you also consider correct to add these DSP registers in the list for GDB.\nIn that case, these registers should be accessible from the normal OpenOCD commands ```reg```, ```get_reg``` and ```set_reg```, instead of the custom command ```mips32 dsp```.\nOleksij, what\u0027s your opinion? We merge this and later we drop the command?","commit_id":"b3ed3dbce2de992ab8910c9050fa7ef2474afc8c"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b161381bc1265951eb35cfac865ed133f0547a39","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"6103a8bf_07da2a61","in_reply_to":"4b96f56c_40e51a1a","updated":"2024-03-02 11:15:00.000000000","message":"I see that the fpu registers are already listed in:\nhttps://review.openocd.org/c/openocd/+/7867/28/src/target/mips32.c#79\nhttps://review.openocd.org/c/openocd/+/7867/28/src/target/mips64.c#133\nI don\u0027t have the HW to test the code, but the commit msg of 7866 reports:\n```GDB can now check the FPRs with `info reg f` and change them.```\nso I expect it would be ok there.","commit_id":"b3ed3dbce2de992ab8910c9050fa7ef2474afc8c"},{"author":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"change_message_id":"dca6465f41de29c01c241b7599fb8e0ac43efe5f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"087ab014_a453bda5","in_reply_to":"83b48af5_ffae2e5d","updated":"2024-02-22 08:50:57.000000000","message":"This patch was to implement a simple inspection command for dsp registers. As you mentioned, it would be better to implement the dsp support for gdb. I will do it later in another patch.","commit_id":"b3ed3dbce2de992ab8910c9050fa7ef2474afc8c"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"caf1828f455fc6048b4a5ecab7847bb5a0a6acb3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"beaef370_8a141763","in_reply_to":"8683c595_23e873a9","updated":"2024-02-26 21:55:09.000000000","message":"Well, also there is no \"show me all fpu regs\"!\nProbably this patch is better than nothing.\nLet\u0027s merge it, if nobody complains.","commit_id":"b3ed3dbce2de992ab8910c9050fa7ef2474afc8c"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"15fd55d3bc7a1e814426f8bc99dc6d00bc51d1f8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"4b96f56c_40e51a1a","in_reply_to":"beaef370_8a141763","updated":"2024-02-27 15:59:14.000000000","message":"heh, i assume we will have same discussion on fpu patch? :D \nShould I ack it if it is good from code perspective?","commit_id":"b3ed3dbce2de992ab8910c9050fa7ef2474afc8c"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"b27b49ebc06f7688462f41b3f024ff8c99ce0d5e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"8683c595_23e873a9","in_reply_to":"e9bb8887_a0bfb5b1","updated":"2024-02-24 18:21:09.000000000","message":"Good question. I lost this part of abstraction from my radar.\n\nreg sort of command do not provide an option to list only some implementation specific register. For example something like \"show me all dsp regs\" is not possible with current reg command. So, if some one need it, i have nothing against it.","commit_id":"b3ed3dbce2de992ab8910c9050fa7ef2474afc8c"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"c892d8291b30c43a422fa677e1a6514ba9f81077","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"d2704acc_2c9381de","updated":"2024-03-09 13:40:03.000000000","message":"Walter, can you please have a look at the errors below?","commit_id":"561ea48d83ae4b83ff823888a80cbcc282b61333"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b4e48fcf9071b3ef9132ad713ebff820e509c88d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"162e4411_7e88b9ff","in_reply_to":"0a2c2d0d_e532b482","updated":"2024-03-16 21:22:34.000000000","message":"Sorry for taking so long, I was looking for re-running locally scan-build to be sure.\nYes, they are false positive as scan-build gets confused by the unusual way, used in mips code, to put retval in ctx-\u003eretval.\nIt doesn\u0027t make sense re-writing all and get rid of ctx-\u003eretval.\n\nThe only valid workaround is to initialize ```value``` in the two cases.\nIf you can send a patch, it would be welcome.","commit_id":"561ea48d83ae4b83ff823888a80cbcc282b61333"},{"author":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"change_message_id":"c74bc3aa7da4b86605584ce225608ff76815f4ec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"0a2c2d0d_e532b482","in_reply_to":"d2704acc_2c9381de","updated":"2024-03-11 10:04:02.000000000","message":"Sorry for the late response! I have fixed these errors, shall I send another patch to resolve them or just amend this one.","commit_id":"561ea48d83ae4b83ff823888a80cbcc282b61333"}],"src/target/mips32.c":[{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"81fd7f7a7c81879a3df320769081594c5698d92b","unresolved":true,"context_lines":[{"line_number":1657,"context_line":"\tif (ctx.retval !\u003d ERROR_OK)"},{"line_number":1658,"context_line":"\t\tgoto exit;"},{"line_number":1659,"context_line":""},{"line_number":1660,"context_line":"\t/* Save Status Register */"},{"line_number":1661,"context_line":"\tpracc_add(\u0026ctx, 0, MIPS32_MFC0(isa, 9, 12, 0));\t\t\t\t\t/* move status to $9 (t1) */"},{"line_number":1662,"context_line":""},{"line_number":1663,"context_line":"\t/* Read it again in order to modify it */"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"f4e49a79_8bf8d3cc","line":1660,"updated":"2023-09-15 18:56:18.000000000","message":"starting from here is code duplication compared read function","commit_id":"186f35900d95f46d358b893a137802e15be75698"},{"author":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"change_message_id":"4caa19381f6fd2ab580d102f1dff0d2847904fcd","unresolved":false,"context_lines":[{"line_number":1657,"context_line":"\tif (ctx.retval !\u003d ERROR_OK)"},{"line_number":1658,"context_line":"\t\tgoto exit;"},{"line_number":1659,"context_line":""},{"line_number":1660,"context_line":"\t/* Save Status Register */"},{"line_number":1661,"context_line":"\tpracc_add(\u0026ctx, 0, MIPS32_MFC0(isa, 9, 12, 0));\t\t\t\t\t/* move status to $9 (t1) */"},{"line_number":1662,"context_line":""},{"line_number":1663,"context_line":"\t/* Read it again in order to modify it */"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"bea8743a_2b76131c","line":1660,"in_reply_to":"f4e49a79_8bf8d3cc","updated":"2023-09-22 06:40:04.000000000","message":"Done","commit_id":"186f35900d95f46d358b893a137802e15be75698"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"81fd7f7a7c81879a3df320769081594c5698d92b","unresolved":true,"context_lines":[{"line_number":1667,"context_line":"\tpracc_add(\u0026ctx, 0, MIPS32_LUI(isa, 15, UPPER16(MIPS32_DSP_ENABLE)));\t\t/* $15 \u003d MIPS32_PRACC_STACK */"},{"line_number":1668,"context_line":"\tpracc_add(\u0026ctx, 0, MIPS32_ORI(isa, 15, 15, LOWER16(MIPS32_DSP_ENABLE)));"},{"line_number":1669,"context_line":"\tpracc_add(\u0026ctx, 0, MIPS32_ISA_OR(8, 8, 15));"},{"line_number":1670,"context_line":"\tpracc_add(\u0026ctx, 0, MIPS32_MTC0(isa, 8, 12, 0));\t\t\t\t\t/* Enable DSP - update status registers */"},{"line_number":1671,"context_line":""},{"line_number":1672,"context_line":"\tpracc_add(\u0026ctx, 0, MIPS32_LUI(isa, 8, UPPER16(val)));\t\t\t/* Load val to $8 (t0) */"},{"line_number":1673,"context_line":"\tpracc_add(\u0026ctx, 0, MIPS32_ORI(isa, 8, 8, LOWER16(val)));"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"e14959c3_27c9568e","line":1670,"updated":"2023-09-15 18:56:18.000000000","message":"end here","commit_id":"186f35900d95f46d358b893a137802e15be75698"},{"author":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"change_message_id":"4caa19381f6fd2ab580d102f1dff0d2847904fcd","unresolved":false,"context_lines":[{"line_number":1667,"context_line":"\tpracc_add(\u0026ctx, 0, MIPS32_LUI(isa, 15, UPPER16(MIPS32_DSP_ENABLE)));\t\t/* $15 \u003d MIPS32_PRACC_STACK */"},{"line_number":1668,"context_line":"\tpracc_add(\u0026ctx, 0, MIPS32_ORI(isa, 15, 15, LOWER16(MIPS32_DSP_ENABLE)));"},{"line_number":1669,"context_line":"\tpracc_add(\u0026ctx, 0, MIPS32_ISA_OR(8, 8, 15));"},{"line_number":1670,"context_line":"\tpracc_add(\u0026ctx, 0, MIPS32_MTC0(isa, 8, 12, 0));\t\t\t\t\t/* Enable DSP - update status registers */"},{"line_number":1671,"context_line":""},{"line_number":1672,"context_line":"\tpracc_add(\u0026ctx, 0, MIPS32_LUI(isa, 8, UPPER16(val)));\t\t\t/* Load val to $8 (t0) */"},{"line_number":1673,"context_line":"\tpracc_add(\u0026ctx, 0, MIPS32_ORI(isa, 8, 8, LOWER16(val)));"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"fe34011e_e9e609b6","line":1670,"in_reply_to":"e14959c3_27c9568e","updated":"2023-09-22 06:40:04.000000000","message":"Done","commit_id":"186f35900d95f46d358b893a137802e15be75698"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"81fd7f7a7c81879a3df320769081594c5698d92b","unresolved":true,"context_lines":[{"line_number":1675,"context_line":"\tpracc_add(\u0026ctx, 0, dsp_write_code[regs]);\t\t\t\t\t /* move AC or Control to $8 (t0) */"},{"line_number":1676,"context_line":""},{"line_number":1677,"context_line":"\tpracc_add(\u0026ctx, 0, MIPS32_NOP);\t\t\t\t\t\t\t\t/* nop */"},{"line_number":1678,"context_line":"\tpracc_add(\u0026ctx, 0, MIPS32_MTC0(isa, 9, 12, 0));\t\t\t\t\t/* Restore status registers to previous setting */"},{"line_number":1679,"context_line":"\tpracc_add(\u0026ctx, 0, MIPS32_NOP);\t\t\t\t\t\t\t\t/* nop */"},{"line_number":1680,"context_line":""},{"line_number":1681,"context_line":"\tpracc_add(\u0026ctx, 0, MIPS32_MFC0(isa, 15, 31, 0));\t\t\t\t\t\t\t/* move COP0 DeSave to $15 */"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"14ab0a10_387ed5fb","line":1678,"updated":"2023-09-15 18:56:18.000000000","message":"here are more dups. Probably something like this can be done:\nstatic void config_dsp_access(struct pracc_queue_info *ctx, int isa) {\n    pracc_add(ctx, 0, MIPS32_MFC0(isa, 9, 12, 0)); // move status to $9 (t1)\n    pracc_add(ctx, 0, MIPS32_MFC0(isa, 8, 12, 0)); // move status to $0 (t0)\n    pracc_add(ctx, 0, MIPS32_LUI(isa, 15, UPPER16(MIPS32_DSP_ENABLE))); // $15 \u003d MIPS32_PRACC_STACK\n    pracc_add(ctx, 0, MIPS32_ORI(isa, 15, 15, LOWER16(MIPS32_DSP_ENABLE)));\n    pracc_add(ctx, 0, MIPS32_ISA_OR(8, 8, 15));\n    pracc_add(ctx, 0, MIPS32_MTC0(isa, 8, 12, 0)); // Enable DSP - update status registers\n}\n\nstatic void restore_status_register(struct pracc_queue_info *ctx, int isa) {\n    pracc_add(ctx, 0, MIPS32_MTC0(isa, 9, 12, 0)); // Restore status registers to previous setting\n    pracc_add(ctx, 0, MIPS32_NOP); // nop\n}","commit_id":"186f35900d95f46d358b893a137802e15be75698"},{"author":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"change_message_id":"4caa19381f6fd2ab580d102f1dff0d2847904fcd","unresolved":false,"context_lines":[{"line_number":1675,"context_line":"\tpracc_add(\u0026ctx, 0, dsp_write_code[regs]);\t\t\t\t\t /* move AC or Control to $8 (t0) */"},{"line_number":1676,"context_line":""},{"line_number":1677,"context_line":"\tpracc_add(\u0026ctx, 0, MIPS32_NOP);\t\t\t\t\t\t\t\t/* nop */"},{"line_number":1678,"context_line":"\tpracc_add(\u0026ctx, 0, MIPS32_MTC0(isa, 9, 12, 0));\t\t\t\t\t/* Restore status registers to previous setting */"},{"line_number":1679,"context_line":"\tpracc_add(\u0026ctx, 0, MIPS32_NOP);\t\t\t\t\t\t\t\t/* nop */"},{"line_number":1680,"context_line":""},{"line_number":1681,"context_line":"\tpracc_add(\u0026ctx, 0, MIPS32_MFC0(isa, 15, 31, 0));\t\t\t\t\t\t\t/* move COP0 DeSave to $15 */"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"527c93b7_1ef778d1","line":1678,"in_reply_to":"14ab0a10_387ed5fb","updated":"2023-09-22 06:40:04.000000000","message":"Done","commit_id":"186f35900d95f46d358b893a137802e15be75698"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"5487593915d46c0bfea36e7e5da727398464ef2e","unresolved":true,"context_lines":[{"line_number":1646,"context_line":" */"},{"line_number":1647,"context_line":"static void mips32_dsp_restore(struct pracc_queue_info *ctx, int isa)"},{"line_number":1648,"context_line":"{"},{"line_number":1649,"context_line":"\tpracc_add(ctx, 0, MIPS32_MTC0(isa, 9, 12, 0)); // Restore status registers to previous setting"},{"line_number":1650,"context_line":"\tpracc_add(ctx, 0, MIPS32_NOP); // nop"},{"line_number":1651,"context_line":"}"},{"line_number":1652,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":26,"id":"ae630c97_947ccb53","line":1649,"updated":"2024-02-02 16:13:30.000000000","message":"Please change the comment style from // to /**/","commit_id":"edb229e0ae4c1e15b4d41e46bf8c486c56a87c99"},{"author":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"change_message_id":"7a3101874e23de379310bccad75e22dbef726f62","unresolved":false,"context_lines":[{"line_number":1646,"context_line":" */"},{"line_number":1647,"context_line":"static void mips32_dsp_restore(struct pracc_queue_info *ctx, int isa)"},{"line_number":1648,"context_line":"{"},{"line_number":1649,"context_line":"\tpracc_add(ctx, 0, MIPS32_MTC0(isa, 9, 12, 0)); // Restore status registers to previous setting"},{"line_number":1650,"context_line":"\tpracc_add(ctx, 0, MIPS32_NOP); // nop"},{"line_number":1651,"context_line":"}"},{"line_number":1652,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":26,"id":"368cb0c2_92314936","line":1649,"in_reply_to":"ae630c97_947ccb53","updated":"2024-02-18 09:03:55.000000000","message":"Done","commit_id":"edb229e0ae4c1e15b4d41e46bf8c486c56a87c99"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"5487593915d46c0bfea36e7e5da727398464ef2e","unresolved":true,"context_lines":[{"line_number":1682,"context_line":"\t\tMIPS32_DSP_MFLO(t0, 1),\t/* mflo\tt0,$ac1 - OPCODE - 0x00204012 */"},{"line_number":1683,"context_line":"\t\tMIPS32_DSP_MFLO(t0, 2),\t/* mflo\tt0,$ac2 - OPCODE - 0x00404012 */"},{"line_number":1684,"context_line":"\t\tMIPS32_DSP_MFLO(t0, 3),\t\t/* mflo\tt0,$ac3 - OPCODE - 0x00604012 */"},{"line_number":1685,"context_line":"\t\tMIPS32_DSP_RDDSP(t0, 0x3F),\t/* OPCODE - 0x7c3f44b8 */"},{"line_number":1686,"context_line":"\t};"},{"line_number":1687,"context_line":""},{"line_number":1688,"context_line":"\t/* Check status register to determine if dsp register access is enabled */"}],"source_content_type":"text/x-csrc","patch_set":26,"id":"e2429cab_3020853c","line":1685,"updated":"2024-02-02 16:13:30.000000000","message":"here is missing assembler example of this operation","commit_id":"edb229e0ae4c1e15b4d41e46bf8c486c56a87c99"},{"author":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"change_message_id":"7a3101874e23de379310bccad75e22dbef726f62","unresolved":false,"context_lines":[{"line_number":1682,"context_line":"\t\tMIPS32_DSP_MFLO(t0, 1),\t/* mflo\tt0,$ac1 - OPCODE - 0x00204012 */"},{"line_number":1683,"context_line":"\t\tMIPS32_DSP_MFLO(t0, 2),\t/* mflo\tt0,$ac2 - OPCODE - 0x00404012 */"},{"line_number":1684,"context_line":"\t\tMIPS32_DSP_MFLO(t0, 3),\t\t/* mflo\tt0,$ac3 - OPCODE - 0x00604012 */"},{"line_number":1685,"context_line":"\t\tMIPS32_DSP_RDDSP(t0, 0x3F),\t/* OPCODE - 0x7c3f44b8 */"},{"line_number":1686,"context_line":"\t};"},{"line_number":1687,"context_line":""},{"line_number":1688,"context_line":"\t/* Check status register to determine if dsp register access is enabled */"}],"source_content_type":"text/x-csrc","patch_set":26,"id":"ae7f931a_09284b2e","line":1685,"in_reply_to":"e2429cab_3020853c","updated":"2024-02-18 09:03:55.000000000","message":"Done","commit_id":"edb229e0ae4c1e15b4d41e46bf8c486c56a87c99"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"5487593915d46c0bfea36e7e5da727398464ef2e","unresolved":true,"context_lines":[{"line_number":1696,"context_line":"\tif (ctx.retval !\u003d ERROR_OK)"},{"line_number":1697,"context_line":"\t\tgoto exit;"},{"line_number":1698,"context_line":""},{"line_number":1699,"context_line":"\t// Enables DSP whether its already enabled orrr not"},{"line_number":1700,"context_line":"\tmips32_dsp_enable(\u0026ctx, isa);"},{"line_number":1701,"context_line":""},{"line_number":1702,"context_line":"\t/* move AC or Control to $8 (t0) 8*/"}],"source_content_type":"text/x-csrc","patch_set":26,"id":"f8f1b85e_23305eb1","line":1699,"updated":"2024-02-02 16:13:30.000000000","message":"/**/, s/orrr/or","commit_id":"edb229e0ae4c1e15b4d41e46bf8c486c56a87c99"},{"author":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"change_message_id":"7a3101874e23de379310bccad75e22dbef726f62","unresolved":false,"context_lines":[{"line_number":1696,"context_line":"\tif (ctx.retval !\u003d ERROR_OK)"},{"line_number":1697,"context_line":"\t\tgoto exit;"},{"line_number":1698,"context_line":""},{"line_number":1699,"context_line":"\t// Enables DSP whether its already enabled orrr not"},{"line_number":1700,"context_line":"\tmips32_dsp_enable(\u0026ctx, isa);"},{"line_number":1701,"context_line":""},{"line_number":1702,"context_line":"\t/* move AC or Control to $8 (t0) 8*/"}],"source_content_type":"text/x-csrc","patch_set":26,"id":"e3776b98_c0a736c5","line":1699,"in_reply_to":"f8f1b85e_23305eb1","updated":"2024-02-18 09:03:55.000000000","message":"Done","commit_id":"edb229e0ae4c1e15b4d41e46bf8c486c56a87c99"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"5487593915d46c0bfea36e7e5da727398464ef2e","unresolved":true,"context_lines":[{"line_number":1759,"context_line":"\t\tMIPS32_DSP_MTLO(t0, 1),\t/* OPCODE - 0x01000813 */"},{"line_number":1760,"context_line":"\t\tMIPS32_DSP_MTLO(t0, 2),\t\t/* OPCODE - 0x01001013 */"},{"line_number":1761,"context_line":"\t\tMIPS32_DSP_MTLO(t0, 3),\t\t/* OPCODE - 0x01001813 */"},{"line_number":1762,"context_line":"\t\tMIPS32_DSP_WRDSP(t0, 0x1F),"},{"line_number":1763,"context_line":"\t};"},{"line_number":1764,"context_line":""},{"line_number":1765,"context_line":"\t/* Init context queue */"}],"source_content_type":"text/x-csrc","patch_set":26,"id":"eabd2ad0_34dbd55e","line":1762,"updated":"2024-02-02 16:13:30.000000000","message":"missing assembler examples for all operations","commit_id":"edb229e0ae4c1e15b4d41e46bf8c486c56a87c99"},{"author":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"change_message_id":"7a3101874e23de379310bccad75e22dbef726f62","unresolved":false,"context_lines":[{"line_number":1759,"context_line":"\t\tMIPS32_DSP_MTLO(t0, 1),\t/* OPCODE - 0x01000813 */"},{"line_number":1760,"context_line":"\t\tMIPS32_DSP_MTLO(t0, 2),\t\t/* OPCODE - 0x01001013 */"},{"line_number":1761,"context_line":"\t\tMIPS32_DSP_MTLO(t0, 3),\t\t/* OPCODE - 0x01001813 */"},{"line_number":1762,"context_line":"\t\tMIPS32_DSP_WRDSP(t0, 0x1F),"},{"line_number":1763,"context_line":"\t};"},{"line_number":1764,"context_line":""},{"line_number":1765,"context_line":"\t/* Init context queue */"}],"source_content_type":"text/x-csrc","patch_set":26,"id":"4b122b00_6db608c5","line":1762,"in_reply_to":"eabd2ad0_34dbd55e","updated":"2024-02-18 09:03:55.000000000","message":"Done","commit_id":"edb229e0ae4c1e15b4d41e46bf8c486c56a87c99"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"5487593915d46c0bfea36e7e5da727398464ef2e","unresolved":true,"context_lines":[{"line_number":1767,"context_line":"\tif (ctx.retval !\u003d ERROR_OK)"},{"line_number":1768,"context_line":"\t\tgoto exit;"},{"line_number":1769,"context_line":""},{"line_number":1770,"context_line":"\t// Enables DSP whether its already enabled orrr not"},{"line_number":1771,"context_line":"\tmips32_dsp_enable(\u0026ctx, isa);"},{"line_number":1772,"context_line":""},{"line_number":1773,"context_line":"\tpracc_add(\u0026ctx, 0, MIPS32_LUI(isa, 8, UPPER16(val)));\t\t\t/* Load val to $8 (t0) */"}],"source_content_type":"text/x-csrc","patch_set":26,"id":"f94e0eb8_98ddfa39","line":1770,"updated":"2024-02-02 16:13:30.000000000","message":"/**/","commit_id":"edb229e0ae4c1e15b4d41e46bf8c486c56a87c99"},{"author":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"change_message_id":"7a3101874e23de379310bccad75e22dbef726f62","unresolved":false,"context_lines":[{"line_number":1767,"context_line":"\tif (ctx.retval !\u003d ERROR_OK)"},{"line_number":1768,"context_line":"\t\tgoto exit;"},{"line_number":1769,"context_line":""},{"line_number":1770,"context_line":"\t// Enables DSP whether its already enabled orrr not"},{"line_number":1771,"context_line":"\tmips32_dsp_enable(\u0026ctx, isa);"},{"line_number":1772,"context_line":""},{"line_number":1773,"context_line":"\tpracc_add(\u0026ctx, 0, MIPS32_LUI(isa, 8, UPPER16(val)));\t\t\t/* Load val to $8 (t0) */"}],"source_content_type":"text/x-csrc","patch_set":26,"id":"d04c53cf_1f8d558f","line":1770,"in_reply_to":"f94e0eb8_98ddfa39","updated":"2024-02-18 09:03:55.000000000","message":"Done","commit_id":"edb229e0ae4c1e15b4d41e46bf8c486c56a87c99"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"5487593915d46c0bfea36e7e5da727398464ef2e","unresolved":true,"context_lines":[{"line_number":1770,"context_line":"\t// Enables DSP whether its already enabled orrr not"},{"line_number":1771,"context_line":"\tmips32_dsp_enable(\u0026ctx, isa);"},{"line_number":1772,"context_line":""},{"line_number":1773,"context_line":"\tpracc_add(\u0026ctx, 0, MIPS32_LUI(isa, 8, UPPER16(val)));\t\t\t/* Load val to $8 (t0) */"},{"line_number":1774,"context_line":"\tpracc_add(\u0026ctx, 0, MIPS32_ORI(isa, 8, 8, LOWER16(val)));"},{"line_number":1775,"context_line":""},{"line_number":1776,"context_line":"\tpracc_add(\u0026ctx, 0, dsp_write_code[reg]);\t\t\t\t\t /* move AC or Control to $8 (t0) */"}],"source_content_type":"text/x-csrc","patch_set":26,"id":"b295d824_7e1463aa","line":1773,"updated":"2024-02-02 16:13:30.000000000","message":"please move all following comments on the line before function. Same as in mips32_pracc_read_dsp_reg()","commit_id":"edb229e0ae4c1e15b4d41e46bf8c486c56a87c99"},{"author":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"change_message_id":"7a3101874e23de379310bccad75e22dbef726f62","unresolved":false,"context_lines":[{"line_number":1770,"context_line":"\t// Enables DSP whether its already enabled orrr not"},{"line_number":1771,"context_line":"\tmips32_dsp_enable(\u0026ctx, isa);"},{"line_number":1772,"context_line":""},{"line_number":1773,"context_line":"\tpracc_add(\u0026ctx, 0, MIPS32_LUI(isa, 8, UPPER16(val)));\t\t\t/* Load val to $8 (t0) */"},{"line_number":1774,"context_line":"\tpracc_add(\u0026ctx, 0, MIPS32_ORI(isa, 8, 8, LOWER16(val)));"},{"line_number":1775,"context_line":""},{"line_number":1776,"context_line":"\tpracc_add(\u0026ctx, 0, dsp_write_code[reg]);\t\t\t\t\t /* move AC or Control to $8 (t0) */"}],"source_content_type":"text/x-csrc","patch_set":26,"id":"4390caaa_a4b15b0f","line":1773,"in_reply_to":"b295d824_7e1463aa","updated":"2024-02-18 09:03:55.000000000","message":"Done","commit_id":"edb229e0ae4c1e15b4d41e46bf8c486c56a87c99"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"97090690128671fe0022c02f8747c1a9d4cd801e","unresolved":true,"context_lines":[{"line_number":2131,"context_line":"\t\treturn ERROR_OK;"},{"line_number":2132,"context_line":"\t}"},{"line_number":2133,"context_line":""},{"line_number":2134,"context_line":"\t/* Check for too many command arg.s */"},{"line_number":2135,"context_line":"\tif (CMD_ARGC \u003e\u003d 3)"},{"line_number":2136,"context_line":"\t\treturn ERROR_COMMAND_SYNTAX_ERROR;"},{"line_number":2137,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":27,"id":"a8f68653_a316de5c","line":2134,"updated":"2024-02-18 22:50:06.000000000","message":"is this a typo s/arg.s/args/ ???","commit_id":"b3ed3dbce2de992ab8910c9050fa7ef2474afc8c"},{"author":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"change_message_id":"dca6465f41de29c01c241b7599fb8e0ac43efe5f","unresolved":false,"context_lines":[{"line_number":2131,"context_line":"\t\treturn ERROR_OK;"},{"line_number":2132,"context_line":"\t}"},{"line_number":2133,"context_line":""},{"line_number":2134,"context_line":"\t/* Check for too many command arg.s */"},{"line_number":2135,"context_line":"\tif (CMD_ARGC \u003e\u003d 3)"},{"line_number":2136,"context_line":"\t\treturn ERROR_COMMAND_SYNTAX_ERROR;"},{"line_number":2137,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":27,"id":"abc2a259_3739699c","line":2134,"in_reply_to":"a8f68653_a316de5c","updated":"2024-02-22 08:50:57.000000000","message":"Done","commit_id":"b3ed3dbce2de992ab8910c9050fa7ef2474afc8c"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"c892d8291b30c43a422fa677e1a6514ba9f81077","unresolved":true,"context_lines":[{"line_number":1664,"context_line":" *"},{"line_number":1665,"context_line":" * @return ERROR_OK on success; error code on failure."},{"line_number":1666,"context_line":" */"},{"line_number":1667,"context_line":"static int mips32_pracc_read_dsp_reg(struct mips_ejtag *ejtag_info, uint32_t *val, uint32_t reg)"},{"line_number":1668,"context_line":"{"},{"line_number":1669,"context_line":"\tint isa \u003d 0;"},{"line_number":1670,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":29,"id":"8a33b45f_a7942523","line":1667,"updated":"2024-03-09 13:40:03.000000000","message":"This function triggers two clang build errors because apparently ```*val``` can be left not assigned while the function returns ERROR_OK.\nI have not investigated deeply.\nIf you need, you can find info in file HACKING on how to use ```scan-build``` to get more info together with a trace path that generates the error.\nIt could be a false positive, probably clang get confused from having the return value written in ```ctx.retval```; I don\u0027t know.\nWhile the trivial workaround would consist in initializing ```value \u003d 0``` in the two callers below, I would like you to run a deeper investigation to check if what clang claims are true.","commit_id":"561ea48d83ae4b83ff823888a80cbcc282b61333"},{"author":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"change_message_id":"c74bc3aa7da4b86605584ce225608ff76815f4ec","unresolved":false,"context_lines":[{"line_number":1664,"context_line":" *"},{"line_number":1665,"context_line":" * @return ERROR_OK on success; error code on failure."},{"line_number":1666,"context_line":" */"},{"line_number":1667,"context_line":"static int mips32_pracc_read_dsp_reg(struct mips_ejtag *ejtag_info, uint32_t *val, uint32_t reg)"},{"line_number":1668,"context_line":"{"},{"line_number":1669,"context_line":"\tint isa \u003d 0;"},{"line_number":1670,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":29,"id":"7f18b0be_a8288444","line":1667,"in_reply_to":"8a33b45f_a7942523","updated":"2024-03-11 10:04:02.000000000","message":"It looks like a false positive, the error is gone after initializing `value`.","commit_id":"561ea48d83ae4b83ff823888a80cbcc282b61333"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"c892d8291b30c43a422fa677e1a6514ba9f81077","unresolved":true,"context_lines":[{"line_number":2043,"context_line":"\t\t\tcommand_print(CMD, \"couldn\u0027t access reg %s\", mips32_dsp_regs[i].name);"},{"line_number":2044,"context_line":"\t\t\treturn retval;"},{"line_number":2045,"context_line":"\t\t}"},{"line_number":2046,"context_line":"\t\tcommand_print(CMD, \"%*s: 0x%8.8x\", 7, mips32_dsp_regs[i].name, value);"},{"line_number":2047,"context_line":"\t}"},{"line_number":2048,"context_line":"\treturn ERROR_OK;"},{"line_number":2049,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":29,"id":"70e305b7_37a05767","line":2046,"updated":"2024-03-09 13:40:03.000000000","message":"```5th function call argument is an uninitialized value```\nhttps://build.openocd.org/job/openocd-clang/1215/clang/new/fileName.2116878918/source.71aeb861-7963-4810-b2f0-ee9a4e3c9f24/#2046","commit_id":"561ea48d83ae4b83ff823888a80cbcc282b61333"},{"author":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"change_message_id":"c74bc3aa7da4b86605584ce225608ff76815f4ec","unresolved":false,"context_lines":[{"line_number":2043,"context_line":"\t\t\tcommand_print(CMD, \"couldn\u0027t access reg %s\", mips32_dsp_regs[i].name);"},{"line_number":2044,"context_line":"\t\t\treturn retval;"},{"line_number":2045,"context_line":"\t\t}"},{"line_number":2046,"context_line":"\t\tcommand_print(CMD, \"%*s: 0x%8.8x\", 7, mips32_dsp_regs[i].name, value);"},{"line_number":2047,"context_line":"\t}"},{"line_number":2048,"context_line":"\treturn ERROR_OK;"},{"line_number":2049,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":29,"id":"7da2aa65_4f1e4fd9","line":2046,"in_reply_to":"70e305b7_37a05767","updated":"2024-03-11 10:04:02.000000000","message":"Done","commit_id":"561ea48d83ae4b83ff823888a80cbcc282b61333"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"c892d8291b30c43a422fa677e1a6514ba9f81077","unresolved":true,"context_lines":[{"line_number":2072,"context_line":"\tif (retval !\u003d ERROR_OK)"},{"line_number":2073,"context_line":"\t\tcommand_print(CMD, \"ERROR: Could not access dsp register %s\", CMD_ARGV[0]);"},{"line_number":2074,"context_line":"\telse"},{"line_number":2075,"context_line":"\t\tcommand_print(CMD, \"0x%8.8x\", value);"},{"line_number":2076,"context_line":""},{"line_number":2077,"context_line":"\treturn retval;"},{"line_number":2078,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":29,"id":"3d8f0f1e_79cf577e","line":2075,"updated":"2024-03-09 13:40:03.000000000","message":"```3rd function call argument is an uninitialized value```\nhttps://build.openocd.org/job/openocd-clang/1215/clang/new/fileName.2116878918/source.76b9c2ac-cddb-46d1-bf28-14f45bf35056/#2075","commit_id":"561ea48d83ae4b83ff823888a80cbcc282b61333"},{"author":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"change_message_id":"c74bc3aa7da4b86605584ce225608ff76815f4ec","unresolved":false,"context_lines":[{"line_number":2072,"context_line":"\tif (retval !\u003d ERROR_OK)"},{"line_number":2073,"context_line":"\t\tcommand_print(CMD, \"ERROR: Could not access dsp register %s\", CMD_ARGV[0]);"},{"line_number":2074,"context_line":"\telse"},{"line_number":2075,"context_line":"\t\tcommand_print(CMD, \"0x%8.8x\", value);"},{"line_number":2076,"context_line":""},{"line_number":2077,"context_line":"\treturn retval;"},{"line_number":2078,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":29,"id":"d75440f0_025fba60","line":2075,"in_reply_to":"3d8f0f1e_79cf577e","updated":"2024-03-11 10:04:02.000000000","message":"Done","commit_id":"561ea48d83ae4b83ff823888a80cbcc282b61333"}]}