)]}'
{"id":"openocd~master~I9ea502c400ea4ffae37080b9cee891ca9176a47d","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1001975":{"account":{"_account_id":1001975,"name":"Steve Marple","email":"stevemarple@googlemail.com","username":"stevemarple"},"last_update":"2023-09-04 09:21:11.000000000","reason":"\u003cGERRIT_ACCOUNT_1001975\u003e replied on the change","reason_account":{"_account_id":1001975,"name":"Steve Marple","email":"stevemarple@googlemail.com","username":"stevemarple"}},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2023-09-09 09:59:41.000000000","reason":"Change was submitted"},"1002139":{"account":{"_account_id":1002139,"name":"Vincent Fazio","email":"vfazio@gmail.com","username":"vfazio"},"last_update":"2023-09-09 09:59:41.000000000","reason":"Change was submitted"},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2023-09-04 13:45:38.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I9ea502c400ea4ffae37080b9cee891ca9176a47d","subject":"jtag/drivers/am335xgpio: do not configure push-pull inputs as output","status":"MERGED","created":"2023-08-29 12:34:48.000000000","updated":"2023-09-09 09:59:41.000000000","submitted":"2023-09-09 09:59:41.000000000","submitter":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"total_comment_count":7,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7877","meta_rev_id":"40d6dfa241a03ed6229a37c0613cde141e2a7c69","_number":7877,"owner":{"_account_id":1002139,"name":"Vincent Fazio","email":"vfazio@gmail.com","username":"vfazio"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1001975,"name":"Steve Marple","email":"stevemarple@googlemail.com","username":"stevemarple"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-09-09 09:59:41.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-09-09 09:59:41.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1001975,"name":"Steve Marple","email":"stevemarple@googlemail.com","username":"stevemarple"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-09-09 09:59:41.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1001975,"name":"Steve Marple","email":"stevemarple@googlemail.com","username":"stevemarple"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-08-29 12:54:58.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"CC"},{"updated":"2023-08-29 12:54:58.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"},{"updated":"2023-08-29 12:54:58.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1001975,"name":"Steve Marple","email":"stevemarple@googlemail.com","username":"stevemarple"},"state":"REVIEWER"},{"updated":"2023-08-29 12:56:30.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-09-04 13:45:38.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"}],"messages":[{"id":"3873a942a292601cbd913518b91704aec02d5e97","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002139,"name":"Vincent Fazio","email":"vfazio@gmail.com","username":"vfazio"},"real_author":{"_account_id":1002139,"name":"Vincent Fazio","email":"vfazio@gmail.com","username":"vfazio"},"date":"2023-08-29 12:34:48.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"6d46403cd88058ed23b0b769d7ecbf7f3bf5884a","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-08-29 12:54:58.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"d0ce6beea8984674b7b456d1cc84d28053c6092b","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-08-29 12:56:30.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/18258/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/17449/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"a0d61ee3ade33a42fa675b6f0cb414a2e382f2d9","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-08-30 20:53:18.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"49bc33f408896076eb39c294ee9a337d46ff9e8a","author":{"_account_id":1001975,"name":"Steve Marple","email":"stevemarple@googlemail.com","username":"stevemarple"},"real_author":{"_account_id":1001975,"name":"Steve Marple","email":"stevemarple@googlemail.com","username":"stevemarple"},"date":"2023-09-03 09:53:51.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"c7a8a57c0e80ed7d10696f2731be67584d12f150","author":{"_account_id":1001975,"name":"Steve Marple","email":"stevemarple@googlemail.com","username":"stevemarple"},"real_author":{"_account_id":1001975,"name":"Steve Marple","email":"stevemarple@googlemail.com","username":"stevemarple"},"date":"2023-09-04 07:40:17.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"6313297c68f05d8e2766c403c68cca1428165efb","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-09-04 08:18:21.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"f369034652176ee340dcad27ff312be9892220e5","author":{"_account_id":1001975,"name":"Steve Marple","email":"stevemarple@googlemail.com","username":"stevemarple"},"real_author":{"_account_id":1001975,"name":"Steve Marple","email":"stevemarple@googlemail.com","username":"stevemarple"},"date":"2023-09-04 09:21:11.000000000","message":"Patch Set 1: Code-Review+1\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"f2793449d7bbd0a7b05b0dc0638cb4fbaa18115c","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-09-04 13:45:38.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"40d6dfa241a03ed6229a37c0613cde141e2a7c69","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-09-09 09:59:41.000000000","message":"Change has been successfully cherry-picked as 51d4996c5b48e2f871e98af982f7627e527e8683","accounts_in_message":[],"_revision_number":2}],"current_revision":"51d4996c5b48e2f871e98af982f7627e527e8683","revisions":{"51d4996c5b48e2f871e98af982f7627e527e8683":{"kind":"REWORK","_number":2,"created":"2023-09-09 09:59:41.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/77/7877/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/77/7877/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/77/7877/2 \u0026\u0026 git checkout -b change-7877 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/77/7877/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/77/7877/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/77/7877/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/77/7877/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/77/7877/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d41a204d8224dad66265e694e5ccf3379de0d494","subject":"image: fix binary detection for small files"}],"author":{"name":"Vincent Fazio","email":"vfazio@xes-inc.com","date":"2023-08-29 12:30:23.000000000","tz":-300},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2023-09-09 09:59:41.000000000","tz":0},"subject":"jtag/drivers/am335xgpio: do not configure push-pull inputs as output","message":"jtag/drivers/am335xgpio: do not configure push-pull inputs as output\n\nPreviously, if a pin was configured as ADAPTER_GPIO_INIT_STATE_INPUT and\nits drive value was ADAPTER_GPIO_DRIVE_MODE_PUSH_PULL, initialize_gpio\nwould configure the pin as an output.\n\nThe set_gpio_value function is optimized to not set the direction for\npins configured as ADAPTER_GPIO_DRIVE_MODE_PUSH_PULL as it only needs to\nbe set once. When initialize_gpio performs this setup, it checked only\nthat the drive value was ADAPTER_GPIO_DRIVE_MODE_PUSH_PULL to set the\noutput direction but did not exclude input pins which have already had\ntheir direction set.\n\nNow, input pins are ignored when initialize_gpio checks for\nADAPTER_GPIO_DRIVE_MODE_PUSH_PULL to set the mode to output.\n\nFixes: ace028262ba0 (\"drivers/am335xgpio: Migrate to adapter gpio commands\")\nChange-Id: I9ea502c400ea4ffae37080b9cee891ca9176a47d\nSigned-off-by: Vincent Fazio \u003cvfazio@xes-inc.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7877\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nTested-by: jenkins\nReviewed-by: Steve Marple \u003cstevemarple@googlemail.com\u003e\n"}},"159ca62bff3f37144f2081c4cf23836421191a82":{"kind":"REWORK","_number":1,"created":"2023-08-29 12:34:48.000000000","uploader":{"_account_id":1002139,"name":"Vincent Fazio","email":"vfazio@gmail.com","username":"vfazio"},"ref":"refs/changes/77/7877/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/77/7877/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/77/7877/1 \u0026\u0026 git checkout -b change-7877 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/77/7877/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/77/7877/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/77/7877/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/77/7877/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/77/7877/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ea0ac6dc779f09fd21e007d93987a6a7eca5149e","subject":"jtag/drivers/bcm2835gpio: do not configure push-pull inputs as output"}],"author":{"name":"Vincent Fazio","email":"vfazio@xes-inc.com","date":"2023-08-29 12:30:23.000000000","tz":-300},"committer":{"name":"Vincent Fazio","email":"vfazio@xes-inc.com","date":"2023-08-29 12:30:23.000000000","tz":-300},"subject":"jtag/drivers/am335xgpio: do not configure push-pull inputs as output","message":"jtag/drivers/am335xgpio: do not configure push-pull inputs as output\n\nPreviously, if a pin was configured as ADAPTER_GPIO_INIT_STATE_INPUT and\nits drive value was ADAPTER_GPIO_DRIVE_MODE_PUSH_PULL, initialize_gpio\nwould configure the pin as an output.\n\nThe set_gpio_value function is optimized to not set the direction for\npins configured as ADAPTER_GPIO_DRIVE_MODE_PUSH_PULL as it only needs to\nbe set once. When initialize_gpio performs this setup, it checked only\nthat the drive value was ADAPTER_GPIO_DRIVE_MODE_PUSH_PULL to set the\noutput direction but did not exclude input pins which have already had\ntheir direction set.\n\nNow, input pins are ignored when initialize_gpio checks for\nADAPTER_GPIO_DRIVE_MODE_PUSH_PULL to set the mode to output.\n\nFixes: ace028262ba0 (\"drivers/am335xgpio: Migrate to adapter gpio commands\")\nChange-Id: I9ea502c400ea4ffae37080b9cee891ca9176a47d\nSigned-off-by: Vincent Fazio \u003cvfazio@xes-inc.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}