)]}'
{"id":"openocd~master~I5b4dad2b547786246887812ac75907378fe58671","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1002143":{"account":{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"},"last_update":"2023-09-08 22:01:59.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I5b4dad2b547786246887812ac75907378fe58671","subject":"image: fix binary detection for small files","status":"MERGED","created":"2023-08-31 06:31:09.000000000","updated":"2023-09-08 22:01:59.000000000","submitted":"2023-09-08 22:01:59.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7880","meta_rev_id":"5292346c333167c9b7855c481a0f0b9d60a7bd9d","_number":7880,"owner":{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-09-08 22:01:59.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-09-08 22:01:59.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-09-08 22:01:59.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-08-31 06:31:48.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-08-31 14:55:19.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"},{"updated":"2023-09-08 22:01:43.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"bbcfef1ab2eb61fc411096526397fb96da360f8e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"},"real_author":{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"},"date":"2023-08-31 06:31:09.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c3c2d44b57979e92d0382f9e24f7ed7991447e1c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"},"real_author":{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"},"date":"2023-08-31 06:31:42.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"0b13caf2082e43c7fa901f0297c2362078f8d0f9","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-08-31 06:31:48.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit/18272/ : ABORTED\n\nhttps://build.openocd.org/job/openocd-gerrit-build/17463/ : ABORTED","accounts_in_message":[],"_revision_number":1},{"id":"44bd2b08fe6cb166f239140549d7aa00f94d0a01","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"},"real_author":{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"},"date":"2023-08-31 06:33:24.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"1a8986315d1044707b2576adb755952659f4ee52","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-08-31 06:33:29.000000000","message":"Patch Set 2: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit-build/17464/ : ABORTED\n\nhttps://build.openocd.org/job/openocd-gerrit/18273/ : FAILURE","accounts_in_message":[],"_revision_number":2},{"id":"a9a1e7b0feb74c5687505ce5453944a9b3d12b68","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-08-31 06:46:20.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/18274/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/17465/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"76b17d4592a3888408c1bfd10aa8198f9a594729","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-08-31 14:55:19.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"b6cfcb46a9ae9115079eefc5d193127617731ecf","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-09-08 22:01:43.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"5292346c333167c9b7855c481a0f0b9d60a7bd9d","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-09-08 22:01:59.000000000","message":"Change has been successfully cherry-picked as d41a204d8224dad66265e694e5ccf3379de0d494","accounts_in_message":[],"_revision_number":4}],"current_revision":"d41a204d8224dad66265e694e5ccf3379de0d494","revisions":{"d41a204d8224dad66265e694e5ccf3379de0d494":{"kind":"REWORK","_number":4,"created":"2023-09-08 22:01:59.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/80/7880/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/80/7880/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/80/7880/4 \u0026\u0026 git checkout -b change-7880 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/80/7880/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/80/7880/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/80/7880/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/80/7880/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/80/7880/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"62f76b2169302b9500deea737a017168271824ac","subject":"flash/nor: add support for Nuvoton NPCX4/K3 series flash"}],"author":{"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","date":"2023-08-31 06:30:37.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-09-08 22:01:59.000000000","tz":0},"subject":"image: fix binary detection for small files","message":"image: fix binary detection for small files\n\nPreviously, if the image file was less than 9 bytes long,\nit was assumed to be an error when it could be a binary\nimage file. This patch makes OpenOCD detect these cases\nas binary files.\n\nChange-Id: I5b4dad2b547786246887812ac75907378fe58671\nSigned-off-by: Marek Vrbka \u003cmarek.vrbka@codasip.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7880\nTested-by: jenkins\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"299ec57a1f28a0f87eff4a752eeab595244fd5a6":{"kind":"REWORK","_number":3,"created":"2023-08-31 06:33:24.000000000","uploader":{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"},"ref":"refs/changes/80/7880/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/80/7880/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/80/7880/3 \u0026\u0026 git checkout -b change-7880 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/80/7880/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/80/7880/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/80/7880/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/80/7880/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/80/7880/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ea0ac6dc779f09fd21e007d93987a6a7eca5149e","subject":"jtag/drivers/bcm2835gpio: do not configure push-pull inputs as output"}],"author":{"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","date":"2023-08-31 06:30:37.000000000","tz":120},"committer":{"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","date":"2023-08-31 06:32:12.000000000","tz":120},"subject":"image: fix binary detection for small files","message":"image: fix binary detection for small files\n\nPreviously, if the image file was less than 9 bytes long,\nit was assumed to be an error when it could be a binary\nimage file. This patch makes OpenOCD detect these cases\nas binary files.\n\nChange-Id: I5b4dad2b547786246887812ac75907378fe58671\nSigned-off-by: Marek Vrbka \u003cmarek.vrbka@codasip.com\u003e\n"}},"14a9d23cd126ff8e3465ba3d73a77e911f2cbe39":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2023-08-31 06:31:42.000000000","uploader":{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"},"ref":"refs/changes/80/7880/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/80/7880/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/80/7880/2 \u0026\u0026 git checkout -b change-7880 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/80/7880/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/80/7880/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/80/7880/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/80/7880/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/80/7880/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ea0ac6dc779f09fd21e007d93987a6a7eca5149e","subject":"jtag/drivers/bcm2835gpio: do not configure push-pull inputs as output"}],"author":{"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","date":"2023-08-31 06:30:37.000000000","tz":120},"committer":{"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","date":"2023-08-31 06:31:34.000000000","tz":120},"subject":"image: fix binary detection for small files","message":"image: fix binary detection for small files\n\nPreviously, if the image file was less than 9 bytes long,\nit was assumed to be an error when it could be a binary\nimage file. This patch makes OpenOCD detect these cases\nas binary files.\n\nChange-Id: I5b4dad2b547786246887812ac75907378fe58671\nSigned-off-by: Marek Vrbka \u003cmarek.vrbka@codasip.com\u003e\n"}},"efe2e5f3fbd5a626028c9bc55dd80db0290c25e6":{"kind":"REWORK","_number":1,"created":"2023-08-31 06:31:09.000000000","uploader":{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"},"ref":"refs/changes/80/7880/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/80/7880/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/80/7880/1 \u0026\u0026 git checkout -b change-7880 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/80/7880/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/80/7880/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/80/7880/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/80/7880/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/80/7880/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ea0ac6dc779f09fd21e007d93987a6a7eca5149e","subject":"jtag/drivers/bcm2835gpio: do not configure push-pull inputs as output"}],"author":{"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","date":"2023-08-31 06:30:37.000000000","tz":120},"committer":{"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","date":"2023-08-31 06:30:37.000000000","tz":120},"subject":"image: fix binary detection for small files","message":"image: fix binary detection for small files\n\nPreviously, if the image file was less than 9 bytes long,\nit was assumed to be an error when it could be a binary\nimage file. This makes OpenOCD detect these cases\nas binary files.\n\nChange-Id: I5b4dad2b547786246887812ac75907378fe58671\nSigned-off-by: Marek Vrbka \u003cmarek.vrbka@codasip.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}