)]}'
{"src/flash/nor/at91sam7.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"cb859f727a64d56b0edd494501bf45f4d6c5ee64","unresolved":false,"context_lines":[{"line_number":575,"context_line":"\t\t\t\t\tLOG_ERROR(\"No memory for flash driver priv\");"},{"line_number":576,"context_line":"\t\t\t\t\treturn ERROR_FAIL;"},{"line_number":577,"context_line":"\t\t\t\t}"},{"line_number":578,"context_line":"\t\t\t\tfb-\u003ename \u003d strdup(\"sam7_probed\");"},{"line_number":579,"context_line":"\t\t\t\tfb-\u003enext \u003d NULL;"},{"line_number":580,"context_line":""},{"line_number":581,"context_line":"\t\t\t\t/* link created bank in \u0027flash_banks\u0027 list */"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"abf57652_9ad7c562","line":578,"updated":"2023-09-06 17:22:57.000000000","message":"good, in flash_free_all_banks() we run free(bank-\u003ename) and here we had a free() on constant string!","commit_id":"57aaadfb2deec2075f37d020e61853e19ef35f5f"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"cb859f727a64d56b0edd494501bf45f4d6c5ee64","unresolved":true,"context_lines":[{"line_number":1131,"context_line":"\t.auto_probe \u003d at91sam7_probe,"},{"line_number":1132,"context_line":"\t.erase_check \u003d at91sam7_erase_check,"},{"line_number":1133,"context_line":"\t.protect_check \u003d at91sam7_protect_check,"},{"line_number":1134,"context_line":"\t.info \u003d get_at91sam7_info,"},{"line_number":1135,"context_line":"};"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"b891480a_5917bfee","line":1134,"updated":"2023-09-06 17:22:57.000000000","message":"you need to add\n.free_driver_priv \u003d default_flash_free_driver_priv,\notherwise fb-\u003edriver_priv will leak memory\nDo you plan to add it here or in a separate patch?","commit_id":"57aaadfb2deec2075f37d020e61853e19ef35f5f"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"2f33cc6a66ba1eec439790daf58c6893554ce6f1","unresolved":false,"context_lines":[{"line_number":1131,"context_line":"\t.auto_probe \u003d at91sam7_probe,"},{"line_number":1132,"context_line":"\t.erase_check \u003d at91sam7_erase_check,"},{"line_number":1133,"context_line":"\t.protect_check \u003d at91sam7_protect_check,"},{"line_number":1134,"context_line":"\t.info \u003d get_at91sam7_info,"},{"line_number":1135,"context_line":"};"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"58dfea48_41611786","line":1134,"in_reply_to":"64036fc1_822bbdb9","updated":"2023-09-06 20:12:28.000000000","message":"fine for me.\nThanks!","commit_id":"57aaadfb2deec2075f37d020e61853e19ef35f5f"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"6ffc16f90555cfc58066c1f54b6ced66660ce10c","unresolved":false,"context_lines":[{"line_number":1131,"context_line":"\t.auto_probe \u003d at91sam7_probe,"},{"line_number":1132,"context_line":"\t.erase_check \u003d at91sam7_erase_check,"},{"line_number":1133,"context_line":"\t.protect_check \u003d at91sam7_protect_check,"},{"line_number":1134,"context_line":"\t.info \u003d get_at91sam7_info,"},{"line_number":1135,"context_line":"};"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"64036fc1_822bbdb9","line":1134,"in_reply_to":"b891480a_5917bfee","updated":"2023-09-06 20:03:41.000000000","message":"Antonio,\nI\u0027m not familiar with at91sam7 code, I don\u0027t have a hw to test it.\nI just fixed the most obvious errors, mostly more severe errors than a mem leak. I have no plans to rewrite half of the old and probably almost unused code.\n\nThe driver does some nasty things like flash bank renumbering, so I was very unsure if we could use default_flash_free_driver_priv. I also had a feeling we already added default_flash_free_driver_priv to all flash drivers with the code healthy enough. Now I checked all allocations in the driver and it looks we can add it. I\u0027ll recheck couple of other drivers too and submit a separate patch.","commit_id":"57aaadfb2deec2075f37d020e61853e19ef35f5f"}]}