)]}'
{"id":"openocd~master~Id890496bfbadb7970ef583256aa4f30a7bff832f","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2023-09-06 20:12:28.000000000","reason":"\u003cGERRIT_ACCOUNT_1000021\u003e replied on the change","reason_account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2023-09-23 14:30:20.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Id890496bfbadb7970ef583256aa4f30a7bff832f","subject":"flash/nor/at91sam7: fix flash bank allocation","status":"MERGED","created":"2023-09-05 16:59:09.000000000","updated":"2023-09-23 14:30:20.000000000","submitted":"2023-09-23 14:30:20.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7884","meta_rev_id":"00f33658ef268986e70994fd9459a5d543e30a1a","_number":7884,"owner":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-09-23 14:30:20.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-09-23 14:30:20.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-09-05 17:24:31.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-09-06 17:22:57.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"CC"},{"updated":"2023-09-06 20:12:28.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"2086540dcb62ca9ef1d1b153e552d316719b94ab","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-09-05 16:59:09.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"4232c870faeab9412c9d2611463006bc8aa76546","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-09-05 17:24:31.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/18313/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/17504/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"cb859f727a64d56b0edd494501bf45f4d6c5ee64","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-09-06 17:22:57.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"6ffc16f90555cfc58066c1f54b6ced66660ce10c","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-09-06 20:03:41.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"2f33cc6a66ba1eec439790daf58c6893554ce6f1","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-09-06 20:12:28.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"3336926f2b06e4cb35787a27956b4265aaac7dd7","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-09-23 14:30:00.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"00f33658ef268986e70994fd9459a5d543e30a1a","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-09-23 14:30:20.000000000","message":"Change has been successfully cherry-picked as 040757b7e6d7bc4951af3d683f774f0660d002b5","accounts_in_message":[],"_revision_number":2}],"current_revision":"040757b7e6d7bc4951af3d683f774f0660d002b5","revisions":{"57aaadfb2deec2075f37d020e61853e19ef35f5f":{"kind":"REWORK","_number":1,"created":"2023-09-05 16:59:09.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/84/7884/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/84/7884/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/84/7884/1 \u0026\u0026 git checkout -b change-7884 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/84/7884/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/84/7884/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/84/7884/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/84/7884/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/84/7884/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"18281b0c497694d91c5608be54583172838be75c","subject":"tcl/arc: Fix ARC v2 registers r22/r23"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2023-09-05 16:32:57.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2023-09-05 16:48:29.000000000","tz":120},"subject":"flash/nor/at91sam7: fix flash bank allocation","message":"flash/nor/at91sam7: fix flash bank allocation\n\nat91sam7 flash driver allocates a flash bank based on detected flash\nstructure.\nUse calloc() instead of malloc() - struct flash_bank has to be zeroed.\n\nWhile on this:\nReturn error in case of struct flash_bank or driver_priv allocation fail.\nSet default_padded_value and erased_value.\nUse strdup() on bank-\u003ename, pointer is freed in flash_free_all_banks()\n\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nChange-Id: Id890496bfbadb7970ef583256aa4f30a7bff832f\n"}},"040757b7e6d7bc4951af3d683f774f0660d002b5":{"kind":"REWORK","_number":2,"created":"2023-09-23 14:30:20.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/84/7884/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/84/7884/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/84/7884/2 \u0026\u0026 git checkout -b change-7884 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/84/7884/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/84/7884/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/84/7884/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/84/7884/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/84/7884/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"870769b0ba9f4dae6ada9d8b1a40d75bd83aaa06","subject":"flash/stm32l4x: support STM32WBA5xx devices"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2023-09-05 16:32:57.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-09-23 14:30:20.000000000","tz":0},"subject":"flash/nor/at91sam7: fix flash bank allocation","message":"flash/nor/at91sam7: fix flash bank allocation\n\nat91sam7 flash driver allocates a flash bank based on detected flash\nstructure.\nUse calloc() instead of malloc() - struct flash_bank has to be zeroed.\n\nWhile on this:\nReturn error in case of struct flash_bank or driver_priv allocation fail.\nSet default_padded_value and erased_value.\nUse strdup() on bank-\u003ename, pointer is freed in flash_free_all_banks()\n\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nChange-Id: Id890496bfbadb7970ef583256aa4f30a7bff832f\nReviewed-on: https://review.openocd.org/c/openocd/+/7884\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}