)]}'
{"id":"openocd~master~Icd47d93c19a9e1694a7b51bbc5ca7e21a578df41","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1001765":{"account":{"_account_id":1001765,"name":"Kevin Yang","email":"kangyang@google.com","username":"kangyang_google"},"last_update":"2023-10-07 14:39:12.000000000","reason":"Change was submitted"},"1001013":{"account":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"last_update":"2023-10-07 14:39:12.000000000","reason":"Change was submitted"},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2023-09-17 14:15:22.000000000","reason":"\u003cGERRIT_ACCOUNT_1000021\u003e replied on the change","reason_account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2023-10-07 14:39:12.000000000","reason":"Change was submitted"},"1000863":{"account":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"last_update":"2023-10-07 14:39:12.000000000","reason":"Change was submitted"},"1001853":{"account":{"_account_id":1001853,"name":"Weijie Gao","email":"hackpascal@gmail.com","username":"hackpascal"},"last_update":"2023-10-07 14:39:12.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Icd47d93c19a9e1694a7b51bbc5ca7e21a578df41","subject":"armv8_dpm: fix registers read at debug entry","status":"MERGED","created":"2023-09-07 10:14:29.000000000","updated":"2023-10-07 14:39:12.000000000","submitted":"2023-10-07 14:39:12.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7887","meta_rev_id":"bdb546c7bddf2a7bef18b862ece98f6e33deeded","_number":7887,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-10-07 14:39:12.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-10-07 14:39:12.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},{"_account_id":1001765,"name":"Kevin Yang","email":"kangyang@google.com","username":"kangyang_google"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"_account_id":1001853,"name":"Weijie Gao","email":"hackpascal@gmail.com","username":"hackpascal"}],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},{"_account_id":1001765,"name":"Kevin Yang","email":"kangyang@google.com","username":"kangyang_google"},{"_account_id":1001853,"name":"Weijie Gao","email":"hackpascal@gmail.com","username":"hackpascal"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-09-07 10:55:44.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-09-07 11:47:13.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"state":"REVIEWER"},{"updated":"2023-09-07 11:47:13.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1001853,"name":"Weijie Gao","email":"hackpascal@gmail.com","username":"hackpascal"},"state":"REVIEWER"},{"updated":"2023-09-07 11:47:13.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1001765,"name":"Kevin Yang","email":"kangyang@google.com","username":"kangyang_google"},"state":"REVIEWER"},{"updated":"2023-09-07 11:47:13.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"},{"updated":"2023-09-07 11:47:13.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"state":"REVIEWER"}],"messages":[{"id":"6141b3beb2010cf8fd58e225dba06994d25f913f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-09-07 10:14:29.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"556914705f8fedaad2ebebe4d7eb8751d3a4a541","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-09-07 10:55:44.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/18325/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/17516/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"1b3e8929729c54a09d54153f3daae233479179b5","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-09-07 11:47:13.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"415f2c744b0e5648fb570167d66f45a8011bfe18","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-09-11 08:17:28.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"2b271e2c9bece97768c909f6f963b9546974ca48","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-09-17 14:15:22.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"8cf33cdb3d7ae9972da1d37dfd58b5e9a603ae60","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-10-07 14:39:03.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"bdb546c7bddf2a7bef18b862ece98f6e33deeded","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-10-07 14:39:12.000000000","message":"Change has been successfully cherry-picked as bdf73617e774b0791f9efec6659c78c1f60c03b5","accounts_in_message":[],"_revision_number":2}],"current_revision":"bdf73617e774b0791f9efec6659c78c1f60c03b5","revisions":{"bdf73617e774b0791f9efec6659c78c1f60c03b5":{"kind":"REWORK","_number":2,"created":"2023-10-07 14:39:12.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/87/7887/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/87/7887/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/87/7887/2 \u0026\u0026 git checkout -b change-7887 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/87/7887/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/87/7887/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/87/7887/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/87/7887/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/87/7887/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f76c8de910e1e12f4b180956d0189c9483e949a5","subject":"target/cortex_m: support Infineon Cortex-M33 from SLx2 MCU"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-09-07 07:58:25.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-10-07 14:39:12.000000000","tz":0},"subject":"armv8_dpm: fix registers read at debug entry","message":"armv8_dpm: fix registers read at debug entry\n\nThe comment above armv8_dpm_read_current_registers() doesn\u0027t match\nthe implementation, as the function reads all the registers from\nARMV8_PC and above.\nThe registers currently read are not relevant to answer to the\nusual GDB initial request through the \u0027g\u0027 packet. Plus the lack of\ndifferentiation per core state (AArch32 vs AArch64) causes the\nread of not existing registers in AArch32 triggering errors, as\ntentatively fixed by https://review.openocd.org/5517/\n\nFix the code to read the registers initially required by GDB.\nModify the comment to report the register list in AArch32 and in\nAArch64.\nKeep the extra checks inside the read loop, even if they are\nmostly irrelevant; this could prevent errors if someone needs to\nextend the number of registers to read.\n\nThe current implementation of the register\u0027s description in\nOpenOCD does not allow to discriminate among AArch32 and AArch64\nregisters. Add a TODO comment to highlight it.\n\nChange-Id: Icd47d93c19a9e1694a7b51bbc5ca7e21a578df41\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7887\nTested-by: jenkins\n"}},"2dcdd4888b29c00ce9673f2546c9cda67397b178":{"kind":"REWORK","_number":1,"created":"2023-09-07 10:14:29.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/87/7887/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/87/7887/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/87/7887/1 \u0026\u0026 git checkout -b change-7887 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/87/7887/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/87/7887/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/87/7887/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/87/7887/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/87/7887/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"18281b0c497694d91c5608be54583172838be75c","subject":"tcl/arc: Fix ARC v2 registers r22/r23"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-09-07 07:58:25.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-09-07 10:02:29.000000000","tz":120},"subject":"armv8_dpm: fix registers read at debug entry","message":"armv8_dpm: fix registers read at debug entry\n\nThe comment above armv8_dpm_read_current_registers() doesn\u0027t match\nthe implementation, as the function reads all the registers from\nARMV8_PC and above.\nThe registers currently read are not relevant to answer to the\nusual GDB initial request through the \u0027g\u0027 packet. Plus the lack of\ndifferentiation per core state (AArch32 vs AArch64) causes the\nread of not existing registers in AArch32 triggering errors, as\ntentatively fixed by https://review.openocd.org/5517/\n\nFix the code to read the registers initially required by GDB.\nModify the comment to report the register list in AArch32 and in\nAArch64.\nKeep the extra checks inside the read loop, even if they are\nmostly irrelevant; this could prevent errors if someone needs to\nextend the number of registers to read.\n\nThe current implementation of the register\u0027s description in\nOpenOCD does not allow to discriminate among AArch32 and AArch64\nregisters. Add a TODO comment to highlight it.\n\nChange-Id: Icd47d93c19a9e1694a7b51bbc5ca7e21a578df41\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}