)]}'
{"id":"openocd~master~Iffe5fd2703bed6a9c840284285e70b8a8ce84e17","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2023-10-07 14:44:34.000000000","reason":"removed on reply"},"1001678":{"account":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"last_update":"2023-10-07 14:44:41.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Iffe5fd2703bed6a9c840284285e70b8a8ce84e17","subject":"tcl/target/ti_k3: Fix smp target description","status":"MERGED","created":"2023-09-13 23:07:30.000000000","updated":"2023-10-07 14:44:41.000000000","submitted":"2023-10-07 14:44:41.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7896","meta_rev_id":"0f25553c842fe1e247cef708b8324813b76de559","_number":7896,"owner":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-10-07 14:44:41.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-10-07 14:44:41.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-09-13 23:33:34.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-09-17 14:37:36.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"CC"},{"updated":"2023-09-18 21:24:25.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"171128e5d9b3c681a0c43787c2957c31bd1bcdb9","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"real_author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"date":"2023-09-13 23:07:30.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"70420f72f22fd1375ef09063ae749f92aae04b69","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-09-13 23:33:34.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/18367/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/17556/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"f51003ad1c8102425da93c3dacb7c6b57106a3b2","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-09-17 14:37:36.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"e0ada099d200873ef2904dcf1e9966dc57effbae","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"real_author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"date":"2023-09-18 13:25:14.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"5ddf4df003d9afd5eb29f0de9bd9d4875a1fcc9a","author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"real_author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"date":"2023-09-18 13:25:32.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"b4aed2566f8e378e801b5636cc3abbcf32067e70","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-09-18 14:15:48.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/18395/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/17586/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"82df2e193f95c3355a05047a4717214729c1b423","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-09-18 21:24:25.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"61cb8e8f2c920cdaf7509636848f6959dc019905","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"real_author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"date":"2023-09-25 12:55:17.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.\n\nOutdated Votes:\n* Code-Review+1 (copy condition: \"changekind:NO_CHANGE OR is:MIN\")\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"ed97c4691e898a6ecc7cb8af9980f90780195fdd","author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"real_author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"date":"2023-09-25 12:56:13.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"e1902d392f5aabf2113b8cc05fcb439c3dbbef5e","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-09-25 13:44:22.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/18440/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/17630/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"987f98a16f2aacf3ee98adfef89878589647cb8c","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-10-07 14:44:34.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"0f25553c842fe1e247cef708b8324813b76de559","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-10-07 14:44:41.000000000","message":"Change has been successfully cherry-picked as 871276cfead7d1ebf11492a1c82691835e1f135a","accounts_in_message":[],"_revision_number":4}],"current_revision":"871276cfead7d1ebf11492a1c82691835e1f135a","revisions":{"1adc5a9b18f3f4033e7168e4f3fa441173c3942f":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2023-09-25 12:55:17.000000000","uploader":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"ref":"refs/changes/96/7896/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/96/7896/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/96/7896/3 \u0026\u0026 git checkout -b change-7896 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/96/7896/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/96/7896/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/96/7896/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/96/7896/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/96/7896/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"21f17260d438704deb1591777222e542efb8383d","subject":"jtag/drivers/bcm2835gpio: fix bcm2835_peri_base output format"}],"author":{"name":"Dubravko Srsan","email":"dubravko.srsan@dolotron.com","date":"2023-09-13 19:02:09.000000000","tz":-300},"committer":{"name":"Nishanth Menon","email":"nm@ti.com","date":"2023-09-25 12:51:43.000000000","tz":-300},"subject":"tcl/target/ti_k3: Fix smp target description","message":"tcl/target/ti_k3: Fix smp target description\n\nWhen _v8_smp_targets is used with V8_SMP_DEBUG\u003d1, describe the targets\nas SMP targets. However, the variable expansion is not in the context of\na proc, and a typo in referring to global $_v8_smp_targets causes this\nto fail. Just refer to $_v8_smp_targets directly.\n\nChange-Id: Iffe5fd2703bed6a9c840284285e70b8a8ce84e17\nSigned-off-by: Dubravko Srsan \u003cdubravko.srsan@dolotron.com\u003e\nSigned-off-by: Nishanth Menon \u003cnm@ti.com\u003e\n"}},"d3746617bbf3529cdf14b8b42c16e0aad75f3535":{"kind":"REWORK","_number":2,"created":"2023-09-18 13:25:14.000000000","uploader":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"ref":"refs/changes/96/7896/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/96/7896/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/96/7896/2 \u0026\u0026 git checkout -b change-7896 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/96/7896/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/96/7896/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/96/7896/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/96/7896/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/96/7896/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"51d4996c5b48e2f871e98af982f7627e527e8683","subject":"jtag/drivers/am335xgpio: do not configure push-pull inputs as output"}],"author":{"name":"Dubravko Srsan","email":"dubravko.srsan@dolotron.com","date":"2023-09-13 19:02:09.000000000","tz":-300},"committer":{"name":"Nishanth Menon","email":"nm@ti.com","date":"2023-09-18 13:20:07.000000000","tz":-300},"subject":"tcl/target/ti_k3: Fix smp target description","message":"tcl/target/ti_k3: Fix smp target description\n\nWhen _v8_smp_targets is used with V8_SMP_DEBUG\u003d1, describe the targets\nas SMP targets. However, the variable expansion is not in the context of\na proc, and a typo in referring to global $_v8_smp_targets causes this\nto fail. Just refer to $_v8_smp_targets directly.\n\nChange-Id: Iffe5fd2703bed6a9c840284285e70b8a8ce84e17\nSigned-off-by: Dubravko Srsan \u003cdubravko.srsan@dolotron.com\u003e\nSigned-off-by: Nishanth Menon \u003cnm@ti.com\u003e\n"}},"3c655247e0553d51510c14e8c58ddea05ba65079":{"kind":"REWORK","_number":1,"created":"2023-09-13 23:07:30.000000000","uploader":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"ref":"refs/changes/96/7896/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/96/7896/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/96/7896/1 \u0026\u0026 git checkout -b change-7896 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/96/7896/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/96/7896/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/96/7896/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/96/7896/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/96/7896/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"51d4996c5b48e2f871e98af982f7627e527e8683","subject":"jtag/drivers/am335xgpio: do not configure push-pull inputs as output"}],"author":{"name":"Dubravko Srsan","email":"dubravko.srsan@dolotron.com","date":"2023-09-13 19:02:09.000000000","tz":-300},"committer":{"name":"Nishanth Menon","email":"nm@ti.com","date":"2023-09-13 23:05:05.000000000","tz":-300},"subject":"tcl/target/ti_k3: Fix smp target description","message":"tcl/target/ti_k3: Fix smp target description\n\nWhen _v8_smp_targets is used with V8_SMP_DEBUG\u003d1, use eval to force\nthe expansion of all the variables set previously.\n\nChange-Id: Iffe5fd2703bed6a9c840284285e70b8a8ce84e17\nSigned-off-by: Dubravko Srsan \u003cdubravko.srsan@dolotron.com\u003e\nSigned-off-by: Nishanth Menon \u003cnm@ti.com\u003e\n"}},"871276cfead7d1ebf11492a1c82691835e1f135a":{"kind":"REWORK","_number":4,"created":"2023-10-07 14:44:41.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/96/7896/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/96/7896/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/96/7896/4 \u0026\u0026 git checkout -b change-7896 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/96/7896/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/96/7896/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/96/7896/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/96/7896/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/96/7896/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2f17449dff3272e08f509e0f06aa08d3acf7e105","subject":"target: return error if attempting to access non-existing registers"}],"author":{"name":"Dubravko Srsan","email":"dubravko.srsan@dolotron.com","date":"2023-09-13 19:02:09.000000000","tz":-300},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-10-07 14:44:41.000000000","tz":0},"subject":"tcl/target/ti_k3: Fix smp target description","message":"tcl/target/ti_k3: Fix smp target description\n\nWhen _v8_smp_targets is used with V8_SMP_DEBUG\u003d1, describe the targets\nas SMP targets. However, the variable expansion is not in the context of\na proc, and a typo in referring to global $_v8_smp_targets causes this\nto fail. Just refer to $_v8_smp_targets directly.\n\nChange-Id: Iffe5fd2703bed6a9c840284285e70b8a8ce84e17\nSigned-off-by: Dubravko Srsan \u003cdubravko.srsan@dolotron.com\u003e\nSigned-off-by: Nishanth Menon \u003cnm@ti.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7896\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nTested-by: jenkins\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}