)]}'
{"id":"openocd~master~I3e85d0b063ed38c1552f6af9ea9eea2e76aa9025","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2024-06-08 21:27:36.000000000","reason":"\u003cGERRIT_ACCOUNT_1000021\u003e replied on the change","reason_account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}},"hashtags":[],"change_id":"I3e85d0b063ed38c1552f6af9ea9eea2e76aa9025","subject":"itm: fix default initialization","status":"MERGED","created":"2023-09-17 09:22:40.000000000","updated":"2024-06-23 09:30:43.000000000","submitted":"2024-06-23 09:30:43.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7900","meta_rev_id":"6ca30b0754f4a23d3b6a511116dd1e03b6b2e777","_number":7900,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1002192,"name":"frankplow","email":"post@frankplowman.com","username":"frankplow"},{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-06-23 09:30:43.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-06-23 09:30:43.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1002192,"name":"frankplow","email":"post@frankplowman.com","username":"frankplow"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-06-23 09:30:43.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1002192,"name":"frankplow","email":"post@frankplowman.com","username":"frankplow"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-09-17 09:44:06.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-09-17 13:31:03.000000000","updated_by":{"_account_id":1002192,"name":"frankplow","email":"post@frankplowman.com","username":"frankplow"},"reviewer":{"_account_id":1002192,"name":"frankplow","email":"post@frankplowman.com","username":"frankplow"},"state":"REVIEWER"}],"messages":[{"id":"f171c2d007921004a7d3013428b4118f6bd80376","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-09-17 09:22:40.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"38d3ab151c81452d94c8f1300a4d233dc95bec6e","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-09-17 09:28:49.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"297f86ab6bb5a876d6e443e281c68215b3d701cc","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-09-17 09:44:06.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/18383/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/17572/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"edeb9c70521974e8299efd826ef7bc578e5c6469","author":{"_account_id":1002192,"name":"frankplow","email":"post@frankplowman.com","username":"frankplow"},"real_author":{"_account_id":1002192,"name":"frankplow","email":"post@frankplowman.com","username":"frankplow"},"date":"2023-09-17 13:31:03.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"375c89d8687362f086f4ccd846bc050707c8e659","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-06-08 21:27:36.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"db0a32cf862a6ae51996093c8323daf3d1f80426","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-06-23 09:30:40.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"6ca30b0754f4a23d3b6a511116dd1e03b6b2e777","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-06-23 09:30:43.000000000","message":"Change has been successfully cherry-picked as dde096e03fa4912aa44b2b72cfbdb7676340a3d1","accounts_in_message":[],"_revision_number":2}],"current_revision":"dde096e03fa4912aa44b2b72cfbdb7676340a3d1","revisions":{"d28e34cedb98400ee0449bfce7d8f40d409b6113":{"kind":"REWORK","_number":1,"created":"2023-09-17 09:22:40.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/00/7900/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/00/7900/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/00/7900/1 \u0026\u0026 git checkout -b change-7900 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/00/7900/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/00/7900/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/00/7900/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/00/7900/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/00/7900/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"51d4996c5b48e2f871e98af982f7627e527e8683","subject":"jtag/drivers/am335xgpio: do not configure push-pull inputs as output"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-09-17 09:15:22.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-09-17 09:15:22.000000000","tz":120},"subject":"itm: fix default initialization","message":"itm: fix default initialization\n\nCommit f9509c92dba3 (\"itm: rework itm commands before \u0027init\u0027\")\nignores the default enable of ITM channel 0, that is applied when\nno \u0027itm port[s]\u0027 is issued.\n\nCall armv7m_trace_itm_config() unconditionally to handle it.\n\nChange-Id: I3e85d0b063ed38c1552f6af9ea9eea2e76aa9025\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReported-by: Paul Fertser \u003cfercerpav@gmail.com\u003e\nFixes: f9509c92dba3 (\"itm: rework itm commands before \u0027init\u0027\")\n"}},"dde096e03fa4912aa44b2b72cfbdb7676340a3d1":{"kind":"REWORK","_number":2,"created":"2024-06-23 09:30:43.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/00/7900/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/00/7900/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/00/7900/2 \u0026\u0026 git checkout -b change-7900 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/00/7900/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/00/7900/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/00/7900/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/00/7900/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/00/7900/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"198fecf5e4b03c2024c9d75fd5e6045daf681ed5","subject":"target: aarch64: access reg SPSR_EL1 only in EL1, EL2 and EL3"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-09-17 09:15:22.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-06-23 09:30:43.000000000","tz":0},"subject":"itm: fix default initialization","message":"itm: fix default initialization\n\nCommit f9509c92dba3 (\"itm: rework itm commands before \u0027init\u0027\")\nignores the default enable of ITM channel 0, that is applied when\nno \u0027itm port[s]\u0027 is issued.\n\nCall armv7m_trace_itm_config() unconditionally to handle it.\n\nChange-Id: I3e85d0b063ed38c1552f6af9ea9eea2e76aa9025\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReported-by: Paul Fertser \u003cfercerpav@gmail.com\u003e\nFixes: f9509c92dba3 (\"itm: rework itm commands before \u0027init\u0027\")\nReviewed-on: https://review.openocd.org/c/openocd/+/7900\nReviewed-by: \u003cpost@frankplowman.com\u003e\nTested-by: jenkins\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}