)]}'
{"id":"openocd~master~I408b20fc03dc2060c21bad0c21ed713eee55a113","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1002192":{"account":{"_account_id":1002192,"name":"frankplow","email":"post@frankplowman.com","username":"frankplow"},"last_update":"2023-10-07 14:46:52.000000000","reason":"Change was submitted"},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2023-09-19 10:17:56.000000000","reason":"\u003cGERRIT_ACCOUNT_1000021\u003e replied on the change","reason_account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}},"hashtags":[],"change_id":"I408b20fc03dc2060c21bad0c21ed713eee55a113","subject":"target/nrf52: Create and configure TPIU","status":"MERGED","created":"2023-09-17 18:29:07.000000000","updated":"2023-10-07 14:46:52.000000000","submitted":"2023-10-07 14:46:52.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7901","meta_rev_id":"4e71e3ee4159ad252dfd698c7c930d979cda87a5","_number":7901,"owner":{"_account_id":1002192,"name":"frankplow","email":"post@frankplowman.com","username":"frankplow"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-10-07 14:46:52.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-10-07 14:46:52.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-09-17 18:41:49.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-09-18 09:08:31.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"fa55af678fb57ba11749cf760d84df4c5f0458c6","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002192,"name":"frankplow","email":"post@frankplowman.com","username":"frankplow"},"real_author":{"_account_id":1002192,"name":"frankplow","email":"post@frankplowman.com","username":"frankplow"},"date":"2023-09-17 18:29:07.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2d5d663b411a65390b52678253c93ba746eee53e","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-09-17 18:41:49.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/18384/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/17573/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"0b02c65bd0fd9938c74792d734407becae66cbf2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002192,"name":"frankplow","email":"post@frankplowman.com","username":"frankplow"},"real_author":{"_account_id":1002192,"name":"frankplow","email":"post@frankplowman.com","username":"frankplow"},"date":"2023-09-18 08:03:57.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"8fefb19128be2fc92b4a177a7a2a5355d6c090d3","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-09-18 08:18:03.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/18385/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/17574/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"bd01287c3da75983fcb3470b7cde9466608d2655","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-09-18 09:08:31.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"2c2594347c51310b9359b2ae0960a1c84db2aa10","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002192,"name":"frankplow","email":"post@frankplowman.com","username":"frankplow"},"real_author":{"_account_id":1002192,"name":"frankplow","email":"post@frankplowman.com","username":"frankplow"},"date":"2023-09-19 09:27:22.000000000","message":"Uploaded patch set 3.\n\nOutdated Votes:\n* Code-Review+1 (copy condition: \"changekind:NO_CHANGE OR is:MIN\")\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"e2e19b73f261148fd586c0fd71653333a169199c","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-09-19 09:41:04.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/18404/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/17593/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"9b5211a42f23f5f07aee15180e3dc5a8f71ebd05","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-09-19 10:17:56.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"49ee84b973c929b8311d34b44a74fe7662d86d7b","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-10-07 14:46:48.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"4e71e3ee4159ad252dfd698c7c930d979cda87a5","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-10-07 14:46:52.000000000","message":"Change has been successfully cherry-picked as 1bc4182cebcbdf93d68d9759f4b4579ea4df7887","accounts_in_message":[],"_revision_number":4}],"current_revision":"1bc4182cebcbdf93d68d9759f4b4579ea4df7887","revisions":{"1bc4182cebcbdf93d68d9759f4b4579ea4df7887":{"kind":"REWORK","_number":4,"created":"2023-10-07 14:46:52.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/01/7901/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/01/7901/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/01/7901/4 \u0026\u0026 git checkout -b change-7901 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/01/7901/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/01/7901/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/01/7901/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/01/7901/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/01/7901/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9c7c5ca4eb04b110f66b4e3c2494a1d55a962b33","subject":"tcl/target/ti_k3: Add AXI-AP port for direct SoC memory map access"}],"author":{"name":"Frank Plowman","email":"post@frankplowman.com","date":"2023-09-17 18:20:04.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-10-07 14:46:52.000000000","tz":0},"subject":"target/nrf52: Create and configure TPIU","message":"target/nrf52: Create and configure TPIU\n\nFirstly, create the TPIU nrf52.tpiu if using the nrf52 target. This is\nstandard, using AP 0 and TPIU base address 0xE0040000.\nSecondly, add a pre_enable handler for this TPIU which configures the\nTRACEMUX field of the TRACECONFIG register. This register is reset\nevery time the MCU resets, so the pre_enable handler creates a\nreset-end handler to ensure the register remains set.\n\nChange-Id: I408b20fc03dc2060c21bad0c21ed713eee55a113\nSigned-off-by: Frank Plowman \u003cpost@frankplowman.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7901\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nTested-by: jenkins\n"}},"797ff39ab1d0911f7a5b03536f5471798fd11093":{"kind":"REWORK","_number":3,"created":"2023-09-19 09:27:22.000000000","uploader":{"_account_id":1002192,"name":"frankplow","email":"post@frankplowman.com","username":"frankplow"},"ref":"refs/changes/01/7901/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/01/7901/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/01/7901/3 \u0026\u0026 git checkout -b change-7901 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/01/7901/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/01/7901/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/01/7901/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/01/7901/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/01/7901/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"51d4996c5b48e2f871e98af982f7627e527e8683","subject":"jtag/drivers/am335xgpio: do not configure push-pull inputs as output"}],"author":{"name":"Frank Plowman","email":"post@frankplowman.com","date":"2023-09-17 18:20:04.000000000","tz":60},"committer":{"name":"Frank Plowman","email":"post@frankplowman.com","date":"2023-09-19 09:27:13.000000000","tz":60},"subject":"target/nrf52: Create and configure TPIU","message":"target/nrf52: Create and configure TPIU\n\nFirstly, create the TPIU nrf52.tpiu if using the nrf52 target. This is\nstandard, using AP 0 and TPIU base address 0xE0040000.\nSecondly, add a pre_enable handler for this TPIU which configures the\nTRACEMUX field of the TRACECONFIG register. This register is reset\nevery time the MCU resets, so the pre_enable handler creates a\nreset-end handler to ensure the register remains set.\n\nChange-Id: I408b20fc03dc2060c21bad0c21ed713eee55a113\nSigned-off-by: Frank Plowman \u003cpost@frankplowman.com\u003e\n"}},"58b82c95215be61d3f1fad3c035bebac6e4200f2":{"kind":"REWORK","_number":2,"created":"2023-09-18 08:03:57.000000000","uploader":{"_account_id":1002192,"name":"frankplow","email":"post@frankplowman.com","username":"frankplow"},"ref":"refs/changes/01/7901/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/01/7901/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/01/7901/2 \u0026\u0026 git checkout -b change-7901 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/01/7901/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/01/7901/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/01/7901/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/01/7901/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/01/7901/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"51d4996c5b48e2f871e98af982f7627e527e8683","subject":"jtag/drivers/am335xgpio: do not configure push-pull inputs as output"}],"author":{"name":"Frank Plowman","email":"post@frankplowman.com","date":"2023-09-17 18:20:04.000000000","tz":60},"committer":{"name":"Frank Plowman","email":"post@frankplowman.com","date":"2023-09-18 08:03:28.000000000","tz":60},"subject":"target/nrf52: Create and configure TPIU","message":"target/nrf52: Create and configure TPIU\n\nFirstly, create the TPIU nrf52.tpiu if using the nrf52 target. This is\nstandard, using AP 0 and TPIU base address 0xE0040000.\nSecondly, add a pre_enable handler for this TPIU which configures the\nTRACEMUX field of the TRACECONFIG register. This register is reset\nevery time the MCU resets, so the pre_enable handler creates a\nreset-end handler to ensure the register remains set.\n\nChange-Id: I408b20fc03dc2060c21bad0c21ed713eee55a113\nSigned-off-by: Frank Plowman \u003cpost@frankplowman.com\u003e\n"}},"a12529572df52265cb044d151a60c2eeae0ebab4":{"kind":"REWORK","_number":1,"created":"2023-09-17 18:29:07.000000000","uploader":{"_account_id":1002192,"name":"frankplow","email":"post@frankplowman.com","username":"frankplow"},"ref":"refs/changes/01/7901/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/01/7901/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/01/7901/1 \u0026\u0026 git checkout -b change-7901 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/01/7901/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/01/7901/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/01/7901/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/01/7901/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/01/7901/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"51d4996c5b48e2f871e98af982f7627e527e8683","subject":"jtag/drivers/am335xgpio: do not configure push-pull inputs as output"}],"author":{"name":"Frank Plowman","email":"post@frankplowman.com","date":"2023-09-17 18:20:04.000000000","tz":60},"committer":{"name":"Frank Plowman","email":"post@frankplowman.com","date":"2023-09-17 18:29:00.000000000","tz":60},"subject":"Create and configure TPIU for nRF52 MCUs","message":"Create and configure TPIU for nRF52 MCUs\n\nFirstly, create the TPIU nrf52.tpiu if using the nrf52 target. This is\nstandard, using AP 0 and TPIU base address 0xE0040000.\nSecondly, add a pre_enable handler for this TPIU which configures the\nTRACEMUX field of the TRACECONFIG register. This register is reset\nevery time the MCU resets, so the pre_enable handler creates a\nreset-end handler to ensure the register remains set.\n\nChange-Id: I408b20fc03dc2060c21bad0c21ed713eee55a113\nSigned-off-by: Frank Plowman \u003cpost@frankplowman.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}
