)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"99cb2d627ff79a001fa052a11a3142b5d92b208e","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"target/mips32: update coprocessor 0 command"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Update mips32 cp0 command, it accetps cp0 reg names now."},{"line_number":10,"context_line":"Updated mips32 cp0 description."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ib23dd13519def77a657c9c5bb039276746207b9b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"b0c3978a_0847755c","line":9,"updated":"2023-12-28 13:53:31.000000000","message":"typo s/accetps/accepts/","commit_id":"fd3ff8ee18909b511bbfb3c038cac35eb2cee5be"},{"author":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"change_message_id":"186880f5a9bce7b1dcbba7bf17731743e2506a19","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"target/mips32: update coprocessor 0 command"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Update mips32 cp0 command, it accetps cp0 reg names now."},{"line_number":10,"context_line":"Updated mips32 cp0 description."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ib23dd13519def77a657c9c5bb039276746207b9b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"9b76f71e_2d568dcc","line":9,"in_reply_to":"b0c3978a_0847755c","updated":"2023-12-29 09:23:48.000000000","message":"Done","commit_id":"fd3ff8ee18909b511bbfb3c038cac35eb2cee5be"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"change_message_id":"da5e608ffa5e802ada6b0801a00317ddd092cb6d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"3db31430_51a6b53d","updated":"2023-11-17 07:24:22.000000000","message":"I couldn\u0027t find the one who wrote this part originally, and I could not find a reasonable explanation myself either. Therefore I have changed this to return error core instead of just return OK as this makes more sense.","commit_id":"789d6984f16e34743673acb3f9d7e1f30b42bd47"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"10d650bd9f4d03f87eef2a6986af357d875e2fa0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"749936e2_aefae1fa","updated":"2023-11-16 06:10:42.000000000","message":"PLease replace LOG_INFO() in most cases to command_print(). If error is happened, you wont to notify user directly about it.","commit_id":"789d6984f16e34743673acb3f9d7e1f30b42bd47"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"fc90f14ccb6cc2c30350bdcf509437b4fd114f7b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"e46883cf_6eb4812b","updated":"2023-11-16 06:12:44.000000000","message":"Please add comments to new functions. This should be done on all you patches.\nHere some comments for this patch:\n/**\n * mips32_cp0_find_register_by_name - Find CP0 register by its name.\n * @cp0_mask: Mask to filter out irrelevant registers.\n * @reg_name: Name of the register to find.\n *\n * This function iterates through mips32_cp0_regs to find a register\n * matching reg_name, considering cp0_mask to filter out registers\n * not relevant for the current core.\n *\n * Return: Pointer to the found register, or NULL if not found.\n */\nstatic const struct mips32_cp0 *mips32_cp0_find_register_by_name(uint32_t cp0_mask, const char *reg_name)\n{\n    // Function body\n}\n\n/**\n * mips32_cp0_get_all_regs - Print all CP0 registers and their values.\n * @cmd: Command invocation context.\n * @ejtag_info: EJTAG interface information.\n * @cp0_mask: Mask to identify relevant registers.\n *\n * Iterates over all CP0 registers, reads their values, and prints them.\n * Only considers registers relevant to the current core, as defined by cp0_mask.\n *\n * Return: ERROR_OK on success; error code on failure.\n */\nstatic int mips32_cp0_get_all_regs(struct command_invocation *cmd, struct mips_ejtag *ejtag_info, uint32_t cp0_mask)\n{\n    // Function body\n}\n\n/**\n * mips32_cp0_get_reg_by_name - Read and print a CP0 register\u0027s value by name.\n * @cmd: Command invocation context.\n * @ejtag_info: EJTAG interface information.\n * @cp0_mask: Mask to identify relevant registers.\n *\n * Finds a CP0 register by name, reads its value, and prints it.\n * Handles error scenarios like register not found or read failure.\n *\n * Return: ERROR_OK on success; error code on failure.\n */\nstatic int mips32_cp0_get_reg_by_name(struct command_invocation *cmd, struct mips_ejtag *ejtag_info, uint32_t cp0_mask)\n{\n    // Function body\n}\n\n/**\n * mips32_cp0_get_reg_by_number - Read and print a CP0 register\u0027s value by number.\n * @cmd: Command invocation context.\n * @ejtag_info: EJTAG interface information.\n *\n * Reads a specific CP0 register (identified by number and selection) and prints its value.\n * The register number and selection are parsed from the command arguments.\n *\n * Return: ERROR_OK on success; error code on failure.\n */\nstatic int mips32_cp0_get_reg_by_number(struct command_invocation *cmd, struct mips_ejtag *ejtag_info)\n{\n    // Function body\n}\n\n/**\n * mips32_cp0_set_reg_by_name - Write to a CP0 register identified by name.\n * @cmd: Command invocation context.\n * @mips32: Common MIPS32 data structure.\n * @ejtag_info: EJTAG interface information.\n *\n * Writes a value to a CP0 register specified by name. Updates internal\n * cache if specific registers (STATUS, CAUSE, DEPC, GUESTCTL1) are modified.\n *\n * Return: ERROR_OK on success; error code on failure.\n */\nstatic int mips32_cp0_set_reg_by_name(struct command_invocation *cmd, struct mips32_common *mips32, struct mips_ejtag *ejtag_info)\n{\n    // Function body\n}\n\n/**\n * mips32_cp0_set_reg_by_number - Write to a CP0 register identified by number.\n * @cmd: Command invocation context.\n * @mips32: Common MIPS32 data structure.\n * @ejtag_info: EJTAG interface information.\n *\n * Writes a value to a CP0 register specified by number and selection.\n * Handles special cases like updating the internal cache for certain registers.\n *\n * Return: ERROR_OK on success; error code on failure.\n */\nstatic int mips32_cp0_set_reg_by_number(struct command_invocation *cmd, struct mips32_common *mips32, struct mips_ejtag *ejtag_info)\n{\n    // Function body\n}\n\n/**\n * mips32_handle_cp0_command - Handle commands related to CP0 registers.\n * @cmd: Command invocation context.\n *\n * Orchestrates different operations on CP0 registers based on the command arguments.\n * Supports operations like reading all registers, reading/writing a specific register\n * by name or number.\n *\n * Return: ERROR_OK on success; error code on failure.\n */\nCOMMAND_HANDLER(mips32_handle_cp0_command)\n{\n    // Function body\n}","commit_id":"789d6984f16e34743673acb3f9d7e1f30b42bd47"},{"author":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"change_message_id":"278455edb605019627ed198d43da9d9a48aec2d8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"7b5414dd_28bbc13c","updated":"2023-11-28 02:07:00.000000000","message":"Changed back, I was wondering where this weird mechanics is documented. Thanks!","commit_id":"66c6c58604c3242004149234b8684c6217aececb"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"5f07acb180b9f63a9d429f3625151ef87bad2a28","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"bfce3a69_253cf8b3","updated":"2023-11-24 22:41:25.000000000","message":"Sorry, I have made a mistake in the review.\nWould you mind addressing the two points below?","commit_id":"66c6c58604c3242004149234b8684c6217aececb"},{"author":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"change_message_id":"b9f50531f24c8d4b305586a81c55f741cc2f5c0a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"8f4264c5_047c6a33","updated":"2023-11-22 09:48:51.000000000","message":"This patch updates `docs/openocd.texi`, too.","commit_id":"66c6c58604c3242004149234b8684c6217aececb"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"99cb2d627ff79a001fa052a11a3142b5d92b208e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"eaf2dcdf_16627e8b","updated":"2023-12-28 13:53:31.000000000","message":"some minor comments below.","commit_id":"fd3ff8ee18909b511bbfb3c038cac35eb2cee5be"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"eba57366f157edc8d13a623910625c6f716fe3bd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"71529e4e_b2a39434","updated":"2023-12-29 10:12:02.000000000","message":"Thanks!","commit_id":"a7416b73c223f69e82e475710936407c247376c1"}],"src/target/mips32.c":[{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"4f33a7ff95467dab01e5cd18472b7698ddc2b47e","unresolved":true,"context_lines":[{"line_number":1239,"context_line":""},{"line_number":1240,"context_line":"\t\t\tif (isdigit(tmp) \u003d\u003d false) {"},{"line_number":1241,"context_line":"\t\t\t\tfor (int i \u003d 0; i \u003c MIPS32NUMCP0REGS; i++) {"},{"line_number":1242,"context_line":"\t\t\t\t\t/* find register name */"},{"line_number":1243,"context_line":"\t\t\t\t\tif (mips32_cp0_regs[i].core \u0026 mips32-\u003ecp0_mask) {"},{"line_number":1244,"context_line":"\t\t\t\t\t\tif (strcmp(mips32_cp0_regs[i].name, CMD_ARGV[0]) \u003d\u003d 0) {"},{"line_number":1245,"context_line":"\t\t\t\t\t\t\tuint32_t cp0_reg \u003d mips32_cp0_regs[i].reg;"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"0e947576_0a4fde1e","line":1242,"updated":"2023-11-07 10:06:46.000000000","message":"If you need more then 3 tabs in you code, it\u0027s time to thing about new function.\nPlease split the code to readable functions.","commit_id":"ffcce143c23fd72e36d2741587c0fa8919baae7b"},{"author":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"change_message_id":"dfd4e9f093a9cadeeaded7547bf976f0b572352a","unresolved":false,"context_lines":[{"line_number":1239,"context_line":""},{"line_number":1240,"context_line":"\t\t\tif (isdigit(tmp) \u003d\u003d false) {"},{"line_number":1241,"context_line":"\t\t\t\tfor (int i \u003d 0; i \u003c MIPS32NUMCP0REGS; i++) {"},{"line_number":1242,"context_line":"\t\t\t\t\t/* find register name */"},{"line_number":1243,"context_line":"\t\t\t\t\tif (mips32_cp0_regs[i].core \u0026 mips32-\u003ecp0_mask) {"},{"line_number":1244,"context_line":"\t\t\t\t\t\tif (strcmp(mips32_cp0_regs[i].name, CMD_ARGV[0]) \u003d\u003d 0) {"},{"line_number":1245,"context_line":"\t\t\t\t\t\t\tuint32_t cp0_reg \u003d mips32_cp0_regs[i].reg;"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"bb98e289_5a68be40","line":1242,"in_reply_to":"0e947576_0a4fde1e","updated":"2023-11-15 05:09:22.000000000","message":"I don\u0027t see any refractors other than finding cp0 register can be splited, as they only appeared once, and the brackets are only here because of if-statements.","commit_id":"ffcce143c23fd72e36d2741587c0fa8919baae7b"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"4f33a7ff95467dab01e5cd18472b7698ddc2b47e","unresolved":true,"context_lines":[{"line_number":820,"context_line":""},{"line_number":821,"context_line":"\tstruct cpu_entry *entry \u003d mips32_find_cpu_by_prid(mips32-\u003eprid);"},{"line_number":822,"context_line":""},{"line_number":823,"context_line":"\t/* CP0 mask should be he same as MK4 by default*/"},{"line_number":824,"context_line":"\tmips32-\u003ecp0_mask \u003d MIPS_CP0_MK4;"},{"line_number":825,"context_line":""},{"line_number":826,"context_line":"\tswitch (mips32-\u003eprid \u0026 PRID_COMP_MASK) {"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"ff84d7b3_c99f974f","line":823,"updated":"2023-11-07 10:06:46.000000000","message":"s/he/the","commit_id":"a447fba263c893043ac0036743a16728e5a9b76d"},{"author":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"change_message_id":"dfd4e9f093a9cadeeaded7547bf976f0b572352a","unresolved":false,"context_lines":[{"line_number":820,"context_line":""},{"line_number":821,"context_line":"\tstruct cpu_entry *entry \u003d mips32_find_cpu_by_prid(mips32-\u003eprid);"},{"line_number":822,"context_line":""},{"line_number":823,"context_line":"\t/* CP0 mask should be he same as MK4 by default*/"},{"line_number":824,"context_line":"\tmips32-\u003ecp0_mask \u003d MIPS_CP0_MK4;"},{"line_number":825,"context_line":""},{"line_number":826,"context_line":"\tswitch (mips32-\u003eprid \u0026 PRID_COMP_MASK) {"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"1075cbeb_c0320c47","line":823,"in_reply_to":"ff84d7b3_c99f974f","updated":"2023-11-15 05:09:22.000000000","message":"Done","commit_id":"a447fba263c893043ac0036743a16728e5a9b76d"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"4f33a7ff95467dab01e5cd18472b7698ddc2b47e","unresolved":true,"context_lines":[{"line_number":848,"context_line":"\t\tcase PRID_IMP_IAPTIV_CM:"},{"line_number":849,"context_line":"\t\t\tmips32-\u003ecp0_mask \u003d MIPS_CP0_IAPTIV;"},{"line_number":850,"context_line":"\t\t\tbreak;"},{"line_number":851,"context_line":"\t\tdefault:"},{"line_number":852,"context_line":"\t\t\tbreak;"},{"line_number":853,"context_line":"\t\t}"},{"line_number":854,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":9,"id":"f8ab86c1_a7138788","line":851,"updated":"2023-11-07 10:06:46.000000000","message":"A default is empty. If this is intentional, it might be helpful to add a comment stating that no action is required for the default case to avoid confusion.","commit_id":"a447fba263c893043ac0036743a16728e5a9b76d"},{"author":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"change_message_id":"dfd4e9f093a9cadeeaded7547bf976f0b572352a","unresolved":false,"context_lines":[{"line_number":848,"context_line":"\t\tcase PRID_IMP_IAPTIV_CM:"},{"line_number":849,"context_line":"\t\t\tmips32-\u003ecp0_mask \u003d MIPS_CP0_IAPTIV;"},{"line_number":850,"context_line":"\t\t\tbreak;"},{"line_number":851,"context_line":"\t\tdefault:"},{"line_number":852,"context_line":"\t\t\tbreak;"},{"line_number":853,"context_line":"\t\t}"},{"line_number":854,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":9,"id":"a90b09e2_2e866242","line":851,"in_reply_to":"f8ab86c1_a7138788","updated":"2023-11-15 05:09:22.000000000","message":"I have moved the default value assignment before the switch block to here.","commit_id":"a447fba263c893043ac0036743a16728e5a9b76d"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"4f33a7ff95467dab01e5cd18472b7698ddc2b47e","unresolved":true,"context_lines":[{"line_number":1257,"context_line":"\t\t\t\t}"},{"line_number":1258,"context_line":"\t\t\t}"},{"line_number":1259,"context_line":""},{"line_number":1260,"context_line":"\t\t\tLOG_ERROR(\"BUG: register \u0027%s\u0027 not found\", CMD_ARGV[0]);"},{"line_number":1261,"context_line":"\t\t\treturn ERROR_COMMAND_SYNTAX_ERROR;"},{"line_number":1262,"context_line":"\t\t}"},{"line_number":1263,"context_line":"\t} else {"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"dd279476_3a396b03","line":1260,"updated":"2023-11-07 10:06:46.000000000","message":"Should we use command_print() instead?","commit_id":"a447fba263c893043ac0036743a16728e5a9b76d"},{"author":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"change_message_id":"dfd4e9f093a9cadeeaded7547bf976f0b572352a","unresolved":false,"context_lines":[{"line_number":1257,"context_line":"\t\t\t\t}"},{"line_number":1258,"context_line":"\t\t\t}"},{"line_number":1259,"context_line":""},{"line_number":1260,"context_line":"\t\t\tLOG_ERROR(\"BUG: register \u0027%s\u0027 not found\", CMD_ARGV[0]);"},{"line_number":1261,"context_line":"\t\t\treturn ERROR_COMMAND_SYNTAX_ERROR;"},{"line_number":1262,"context_line":"\t\t}"},{"line_number":1263,"context_line":"\t} else {"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"e9c55af9_e7fea5fc","line":1260,"in_reply_to":"dd279476_3a396b03","updated":"2023-11-15 05:09:22.000000000","message":"Done","commit_id":"a447fba263c893043ac0036743a16728e5a9b76d"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"4f33a7ff95467dab01e5cd18472b7698ddc2b47e","unresolved":true,"context_lines":[{"line_number":1265,"context_line":"\t\t\tuint32_t value;"},{"line_number":1266,"context_line":"\t\t\tint tmp \u003d *CMD_ARGV[0];"},{"line_number":1267,"context_line":""},{"line_number":1268,"context_line":"\t\t\tif (isdigit(tmp) \u003d\u003d false) {"},{"line_number":1269,"context_line":"\t\t\t\tfor (int i \u003d 0; i \u003c MIPS32NUMCP0REGS; i++) {"},{"line_number":1270,"context_line":"\t\t\t\t\t/* find register name */"},{"line_number":1271,"context_line":"\t\t\t\t\tif (mips32_cp0_regs[i].core \u0026 mips32-\u003ecp0_mask) {"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"738892ca_f78ebf12","line":1268,"updated":"2023-11-07 10:06:46.000000000","message":"if(!isdigit(tmp))","commit_id":"a447fba263c893043ac0036743a16728e5a9b76d"},{"author":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"change_message_id":"dfd4e9f093a9cadeeaded7547bf976f0b572352a","unresolved":false,"context_lines":[{"line_number":1265,"context_line":"\t\t\tuint32_t value;"},{"line_number":1266,"context_line":"\t\t\tint tmp \u003d *CMD_ARGV[0];"},{"line_number":1267,"context_line":""},{"line_number":1268,"context_line":"\t\t\tif (isdigit(tmp) \u003d\u003d false) {"},{"line_number":1269,"context_line":"\t\t\t\tfor (int i \u003d 0; i \u003c MIPS32NUMCP0REGS; i++) {"},{"line_number":1270,"context_line":"\t\t\t\t\t/* find register name */"},{"line_number":1271,"context_line":"\t\t\t\t\tif (mips32_cp0_regs[i].core \u0026 mips32-\u003ecp0_mask) {"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"df611a9e_dc54a9b7","line":1268,"in_reply_to":"738892ca_f78ebf12","updated":"2023-11-15 05:09:22.000000000","message":"Done","commit_id":"a447fba263c893043ac0036743a16728e5a9b76d"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"4f33a7ff95467dab01e5cd18472b7698ddc2b47e","unresolved":true,"context_lines":[{"line_number":1271,"context_line":"\t\t\t\t\tif (mips32_cp0_regs[i].core \u0026 mips32-\u003ecp0_mask) {"},{"line_number":1272,"context_line":"\t\t\t\t\t\tif (strcmp(mips32_cp0_regs[i].name, CMD_ARGV[0]) \u003d\u003d 0) {"},{"line_number":1273,"context_line":"\t\t\t\t\t\t\tuint32_t cp0_reg \u003d mips32_cp0_regs[i].reg;"},{"line_number":1274,"context_line":"\t\t\t\t\t\t\tuint32_t cp0_sel \u003d mips32_cp0_regs[i].sel;"},{"line_number":1275,"context_line":""},{"line_number":1276,"context_line":"\t\t\t\t\t\t\tCOMMAND_PARSE_NUMBER(u32, CMD_ARGV[1], value);"},{"line_number":1277,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":9,"id":"9d6231a6_7e80e4e6","line":1274,"updated":"2023-11-07 10:06:46.000000000","message":"There\u0027s no need to declare uint32_t cp0_reg, cp0_sel; twice","commit_id":"a447fba263c893043ac0036743a16728e5a9b76d"},{"author":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"change_message_id":"dfd4e9f093a9cadeeaded7547bf976f0b572352a","unresolved":false,"context_lines":[{"line_number":1271,"context_line":"\t\t\t\t\tif (mips32_cp0_regs[i].core \u0026 mips32-\u003ecp0_mask) {"},{"line_number":1272,"context_line":"\t\t\t\t\t\tif (strcmp(mips32_cp0_regs[i].name, CMD_ARGV[0]) \u003d\u003d 0) {"},{"line_number":1273,"context_line":"\t\t\t\t\t\t\tuint32_t cp0_reg \u003d mips32_cp0_regs[i].reg;"},{"line_number":1274,"context_line":"\t\t\t\t\t\t\tuint32_t cp0_sel \u003d mips32_cp0_regs[i].sel;"},{"line_number":1275,"context_line":""},{"line_number":1276,"context_line":"\t\t\t\t\t\t\tCOMMAND_PARSE_NUMBER(u32, CMD_ARGV[1], value);"},{"line_number":1277,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":9,"id":"5c878bb6_1b28868b","line":1274,"in_reply_to":"9d6231a6_7e80e4e6","updated":"2023-11-15 05:09:22.000000000","message":"Done","commit_id":"a447fba263c893043ac0036743a16728e5a9b76d"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"4f33a7ff95467dab01e5cd18472b7698ddc2b47e","unresolved":true,"context_lines":[{"line_number":1284,"context_line":"\t\t\t\t\t\t\t\tmips32-\u003ecore_regs.cp0[MIPS32_REG_C0_CAUSE_INDEX] \u003d value;"},{"line_number":1285,"context_line":"\t\t\t\t\t\t\t\tmips32-\u003ecore_cache-\u003ereg_list[MIPS32_REGLIST_C0_CAUSE_INDEX].dirty \u003d 1;"},{"line_number":1286,"context_line":"\t\t\t\t\t\t\t} else if (cp0_reg \u003d\u003d MIPS32_C0_DEPC \u0026\u0026 cp0_sel \u003d\u003d 0) {"},{"line_number":1287,"context_line":"\t\t\t\t\t\t\t\t/* DEPC ? Update cached PC */"},{"line_number":1288,"context_line":"\t\t\t\t\t\t\t\tmips32-\u003ecore_regs.cp0[MIPS32_REG_C0_PC_INDEX] \u003d value;"},{"line_number":1289,"context_line":"\t\t\t\t\t\t\t\tmips32-\u003ecore_cache-\u003ereg_list[MIPS32_REGLIST_C0_PC_INDEX].dirty \u003d 1;"},{"line_number":1290,"context_line":"\t\t\t\t\t\t\t} else if (cp0_reg \u003d\u003d MIPS32_C0_GUESTCTL1 \u0026\u0026 cp0_sel \u003d\u003d 4) {"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"c3341fcd_c6ae9f6c","line":1287,"updated":"2023-11-07 10:06:46.000000000","message":"Redundant comments like /* Cause register ?? Update register cache with new value */ should be clarified or removed if they do not contribute useful information.","commit_id":"a447fba263c893043ac0036743a16728e5a9b76d"},{"author":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"change_message_id":"dfd4e9f093a9cadeeaded7547bf976f0b572352a","unresolved":false,"context_lines":[{"line_number":1284,"context_line":"\t\t\t\t\t\t\t\tmips32-\u003ecore_regs.cp0[MIPS32_REG_C0_CAUSE_INDEX] \u003d value;"},{"line_number":1285,"context_line":"\t\t\t\t\t\t\t\tmips32-\u003ecore_cache-\u003ereg_list[MIPS32_REGLIST_C0_CAUSE_INDEX].dirty \u003d 1;"},{"line_number":1286,"context_line":"\t\t\t\t\t\t\t} else if (cp0_reg \u003d\u003d MIPS32_C0_DEPC \u0026\u0026 cp0_sel \u003d\u003d 0) {"},{"line_number":1287,"context_line":"\t\t\t\t\t\t\t\t/* DEPC ? Update cached PC */"},{"line_number":1288,"context_line":"\t\t\t\t\t\t\t\tmips32-\u003ecore_regs.cp0[MIPS32_REG_C0_PC_INDEX] \u003d value;"},{"line_number":1289,"context_line":"\t\t\t\t\t\t\t\tmips32-\u003ecore_cache-\u003ereg_list[MIPS32_REGLIST_C0_PC_INDEX].dirty \u003d 1;"},{"line_number":1290,"context_line":"\t\t\t\t\t\t\t} else if (cp0_reg \u003d\u003d MIPS32_C0_GUESTCTL1 \u0026\u0026 cp0_sel \u003d\u003d 4) {"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"cef9d5f5_38a5cfad","line":1287,"in_reply_to":"c3341fcd_c6ae9f6c","updated":"2023-11-15 05:09:22.000000000","message":"That was not uncertainty, it was a rhetorical question. I have rephrased that(and following) to a more verbose sentence.","commit_id":"a447fba263c893043ac0036743a16728e5a9b76d"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"6e33a60820f034b7d9903e452ad0233e3bdab755","unresolved":true,"context_lines":[{"line_number":1230,"context_line":"\t}"},{"line_number":1231,"context_line":""},{"line_number":1232,"context_line":"\t/* two or more argument, access a single register/select (write if third argument is given) */"},{"line_number":1233,"context_line":"\tif (CMD_ARGC \u003c 2) {"},{"line_number":1234,"context_line":"\t\tuint32_t value;"},{"line_number":1235,"context_line":""},{"line_number":1236,"context_line":"\t\tif (CMD_ARGC \u003d\u003d 0) {"}],"source_content_type":"text/x-csrc","patch_set":11,"id":"6ba02f58_2a902ff0","line":1233,"updated":"2023-11-15 18:31:25.000000000","message":"This if spliting makes no sense:\nif (arg \u003c 2) {\n  if (arg \u003d\u003d 0) {\n    0\n  } else {\n    1\n  }\n} else {\n  if (arg \u003d\u003d 2)\n    2\n  else if (arg \u003d\u003d 3)\n    3\n}\n\nIt makes reviewing and maintenance too complicate.\n\nPlease, use switch() case, instead. Move each of scopes to separate functions.","commit_id":"82d340aa68c29d551dd122b4bdc34b65ec5cfdc9"},{"author":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"change_message_id":"9a3b1222e80e36bb38a07a9aefd226a45055cd3b","unresolved":false,"context_lines":[{"line_number":1230,"context_line":"\t}"},{"line_number":1231,"context_line":""},{"line_number":1232,"context_line":"\t/* two or more argument, access a single register/select (write if third argument is given) */"},{"line_number":1233,"context_line":"\tif (CMD_ARGC \u003c 2) {"},{"line_number":1234,"context_line":"\t\tuint32_t value;"},{"line_number":1235,"context_line":""},{"line_number":1236,"context_line":"\t\tif (CMD_ARGC \u003d\u003d 0) {"}],"source_content_type":"text/x-csrc","patch_set":11,"id":"61045d8f_e437beb6","line":1233,"in_reply_to":"6ba02f58_2a902ff0","updated":"2023-11-16 04:42:50.000000000","message":"Done","commit_id":"82d340aa68c29d551dd122b4bdc34b65ec5cfdc9"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"10d650bd9f4d03f87eef2a6986af357d875e2fa0","unresolved":true,"context_lines":[{"line_number":1202,"context_line":"\t\tif ((mips32_cp0_regs[i].core \u0026 cp0_mask) \u003d\u003d 0)"},{"line_number":1203,"context_line":"\t\t\tcontinue;"},{"line_number":1204,"context_line":""},{"line_number":1205,"context_line":"\t\tif (strcmp(mips32_cp0_regs[i].name, reg_name) \u003d\u003d 0)"},{"line_number":1206,"context_line":"\t\t\treturn \u0026mips32_cp0_regs[i];"},{"line_number":1207,"context_line":"\t}"},{"line_number":1208,"context_line":"\treturn NULL;"}],"source_content_type":"text/x-csrc","patch_set":12,"id":"94454965_0bd0d437","line":1205,"updated":"2023-11-16 06:10:42.000000000","message":"strcmp is not protected against NULL pointer. Can you please test pointer before using it.","commit_id":"789d6984f16e34743673acb3f9d7e1f30b42bd47"},{"author":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"change_message_id":"da5e608ffa5e802ada6b0801a00317ddd092cb6d","unresolved":false,"context_lines":[{"line_number":1202,"context_line":"\t\tif ((mips32_cp0_regs[i].core \u0026 cp0_mask) \u003d\u003d 0)"},{"line_number":1203,"context_line":"\t\t\tcontinue;"},{"line_number":1204,"context_line":""},{"line_number":1205,"context_line":"\t\tif (strcmp(mips32_cp0_regs[i].name, reg_name) \u003d\u003d 0)"},{"line_number":1206,"context_line":"\t\t\treturn \u0026mips32_cp0_regs[i];"},{"line_number":1207,"context_line":"\t}"},{"line_number":1208,"context_line":"\treturn NULL;"}],"source_content_type":"text/x-csrc","patch_set":12,"id":"22914a59_158c04b4","line":1205,"in_reply_to":"94454965_0bd0d437","updated":"2023-11-17 07:24:22.000000000","message":"Done","commit_id":"789d6984f16e34743673acb3f9d7e1f30b42bd47"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"10d650bd9f4d03f87eef2a6986af357d875e2fa0","unresolved":true,"context_lines":[{"line_number":1220,"context_line":"\t\tint retval \u003d mips32_cp0_read(ejtag_info, \u0026value, mips32_cp0_regs[i].reg, mips32_cp0_regs[i].sel);"},{"line_number":1221,"context_line":"\t\tif (retval !\u003d ERROR_OK) {"},{"line_number":1222,"context_line":"\t\t\tcommand_print(CMD, \"Error: couldn\u0027t access reg %s\", mips32_cp0_regs[i].name);"},{"line_number":1223,"context_line":"\t\t\treturn ERROR_OK;"},{"line_number":1224,"context_line":"\t\t}"},{"line_number":1225,"context_line":""},{"line_number":1226,"context_line":"\t\tcommand_print(CMD, \"%*s: 0x%8.8x\", 14, mips32_cp0_regs[i].name, value);"}],"source_content_type":"text/x-csrc","patch_set":12,"id":"e3232f28_b31f0a88","line":1223,"updated":"2023-11-16 06:10:42.000000000","message":"Why initial error code is overwritten? If it is expected, please add comment.","commit_id":"789d6984f16e34743673acb3f9d7e1f30b42bd47"},{"author":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"change_message_id":"da5e608ffa5e802ada6b0801a00317ddd092cb6d","unresolved":false,"context_lines":[{"line_number":1220,"context_line":"\t\tint retval \u003d mips32_cp0_read(ejtag_info, \u0026value, mips32_cp0_regs[i].reg, mips32_cp0_regs[i].sel);"},{"line_number":1221,"context_line":"\t\tif (retval !\u003d ERROR_OK) {"},{"line_number":1222,"context_line":"\t\t\tcommand_print(CMD, \"Error: couldn\u0027t access reg %s\", mips32_cp0_regs[i].name);"},{"line_number":1223,"context_line":"\t\t\treturn ERROR_OK;"},{"line_number":1224,"context_line":"\t\t}"},{"line_number":1225,"context_line":""},{"line_number":1226,"context_line":"\t\tcommand_print(CMD, \"%*s: 0x%8.8x\", 14, mips32_cp0_regs[i].name, value);"}],"source_content_type":"text/x-csrc","patch_set":12,"id":"c668103c_769db4f9","line":1223,"in_reply_to":"e3232f28_b31f0a88","updated":"2023-11-17 07:24:22.000000000","message":"Done","commit_id":"789d6984f16e34743673acb3f9d7e1f30b42bd47"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"10d650bd9f4d03f87eef2a6986af357d875e2fa0","unresolved":true,"context_lines":[{"line_number":1240,"context_line":"\tint retval \u003d mips32_cp0_read(ejtag_info, \u0026value, cp0_regs-\u003ereg, cp0_regs-\u003esel);"},{"line_number":1241,"context_line":"\tif (retval !\u003d ERROR_OK)"},{"line_number":1242,"context_line":"\t\tLOG_INFO(\"Encounter an Error while reading cp0 reg %d sel %d\","},{"line_number":1243,"context_line":"\t\t\t\t\tcp0_regs-\u003ereg, cp0_regs-\u003esel);"},{"line_number":1244,"context_line":""},{"line_number":1245,"context_line":"\tcommand_print(CMD, \"0x%8.8x\", value);"},{"line_number":1246,"context_line":"\treturn ERROR_OK;"}],"source_content_type":"text/x-csrc","patch_set":12,"id":"9e936513_2c868ebb","line":1243,"updated":"2023-11-16 06:10:42.000000000","message":"initial error code is overwritten. If needed, comment should be added.","commit_id":"789d6984f16e34743673acb3f9d7e1f30b42bd47"},{"author":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"change_message_id":"da5e608ffa5e802ada6b0801a00317ddd092cb6d","unresolved":false,"context_lines":[{"line_number":1240,"context_line":"\tint retval \u003d mips32_cp0_read(ejtag_info, \u0026value, cp0_regs-\u003ereg, cp0_regs-\u003esel);"},{"line_number":1241,"context_line":"\tif (retval !\u003d ERROR_OK)"},{"line_number":1242,"context_line":"\t\tLOG_INFO(\"Encounter an Error while reading cp0 reg %d sel %d\","},{"line_number":1243,"context_line":"\t\t\t\t\tcp0_regs-\u003ereg, cp0_regs-\u003esel);"},{"line_number":1244,"context_line":""},{"line_number":1245,"context_line":"\tcommand_print(CMD, \"0x%8.8x\", value);"},{"line_number":1246,"context_line":"\treturn ERROR_OK;"}],"source_content_type":"text/x-csrc","patch_set":12,"id":"d9f7be8d_ecd8d75b","line":1243,"in_reply_to":"9e936513_2c868ebb","updated":"2023-11-17 07:24:22.000000000","message":"Done","commit_id":"789d6984f16e34743673acb3f9d7e1f30b42bd47"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"10d650bd9f4d03f87eef2a6986af357d875e2fa0","unresolved":true,"context_lines":[{"line_number":1257,"context_line":"\t\tcommand_print(CMD,"},{"line_number":1258,"context_line":"\t\t\t\t\"couldn\u0027t access reg %\" PRIu32,"},{"line_number":1259,"context_line":"\t\t\t\tcp0_reg);"},{"line_number":1260,"context_line":"\t\treturn ERROR_OK;"},{"line_number":1261,"context_line":"\t}"},{"line_number":1262,"context_line":""},{"line_number":1263,"context_line":"\tcommand_print(CMD, \"cp0 reg %\" PRIu32 \", select %\" PRIu32 \": %8.8\" PRIx32,"}],"source_content_type":"text/x-csrc","patch_set":12,"id":"17cd06ab_300375db","line":1260,"updated":"2023-11-16 06:10:42.000000000","message":"again, error code is overwritten","commit_id":"789d6984f16e34743673acb3f9d7e1f30b42bd47"},{"author":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"change_message_id":"da5e608ffa5e802ada6b0801a00317ddd092cb6d","unresolved":false,"context_lines":[{"line_number":1257,"context_line":"\t\tcommand_print(CMD,"},{"line_number":1258,"context_line":"\t\t\t\t\"couldn\u0027t access reg %\" PRIu32,"},{"line_number":1259,"context_line":"\t\t\t\tcp0_reg);"},{"line_number":1260,"context_line":"\t\treturn ERROR_OK;"},{"line_number":1261,"context_line":"\t}"},{"line_number":1262,"context_line":""},{"line_number":1263,"context_line":"\tcommand_print(CMD, \"cp0 reg %\" PRIu32 \", select %\" PRIu32 \": %8.8\" PRIx32,"}],"source_content_type":"text/x-csrc","patch_set":12,"id":"a8780e7d_c18b4abb","line":1260,"in_reply_to":"17cd06ab_300375db","updated":"2023-11-17 07:24:22.000000000","message":"Done","commit_id":"789d6984f16e34743673acb3f9d7e1f30b42bd47"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"10d650bd9f4d03f87eef2a6986af357d875e2fa0","unresolved":true,"context_lines":[{"line_number":1300,"context_line":"\t\t\t\t\t\t\t\tcp0_regs-\u003esel);"},{"line_number":1301,"context_line":"\tif (retval !\u003d ERROR_OK)"},{"line_number":1302,"context_line":"\t\tLOG_INFO(\"Encounter an Error while writing to cp0 reg %d, sel %d\","},{"line_number":1303,"context_line":"\t\t\t\t\tcp0_regs-\u003ereg, cp0_regs-\u003esel);"},{"line_number":1304,"context_line":""},{"line_number":1305,"context_line":"\treturn ERROR_OK;"},{"line_number":1306,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":12,"id":"e6773ebe_276cde60","line":1303,"updated":"2023-11-16 06:10:42.000000000","message":"Here is the same, error code is overwritten","commit_id":"789d6984f16e34743673acb3f9d7e1f30b42bd47"},{"author":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"change_message_id":"da5e608ffa5e802ada6b0801a00317ddd092cb6d","unresolved":false,"context_lines":[{"line_number":1300,"context_line":"\t\t\t\t\t\t\t\tcp0_regs-\u003esel);"},{"line_number":1301,"context_line":"\tif (retval !\u003d ERROR_OK)"},{"line_number":1302,"context_line":"\t\tLOG_INFO(\"Encounter an Error while writing to cp0 reg %d, sel %d\","},{"line_number":1303,"context_line":"\t\t\t\t\tcp0_regs-\u003ereg, cp0_regs-\u003esel);"},{"line_number":1304,"context_line":""},{"line_number":1305,"context_line":"\treturn ERROR_OK;"},{"line_number":1306,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":12,"id":"96357e8a_d70d3d56","line":1303,"in_reply_to":"e6773ebe_276cde60","updated":"2023-11-17 07:24:22.000000000","message":"Done","commit_id":"789d6984f16e34743673acb3f9d7e1f30b42bd47"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"10d650bd9f4d03f87eef2a6986af357d875e2fa0","unresolved":true,"context_lines":[{"line_number":1336,"context_line":"\t\tcommand_print(CMD,"},{"line_number":1337,"context_line":"\t\t\t\t\"couldn\u0027t access cp0 reg %\" PRIu32 \", select %\" PRIu32,"},{"line_number":1338,"context_line":"\t\t\t\tcp0_reg,  cp0_sel);"},{"line_number":1339,"context_line":"\t\treturn ERROR_OK;"},{"line_number":1340,"context_line":"\t}"},{"line_number":1341,"context_line":""},{"line_number":1342,"context_line":"\tcommand_print(CMD, \"cp0 reg %\" PRIu32 \", select %\" PRIu32 \": %8.8\" PRIx32,"}],"source_content_type":"text/x-csrc","patch_set":12,"id":"6ffbd833_aa83cd09","line":1339,"updated":"2023-11-16 06:10:42.000000000","message":"and here, error code is overwritten","commit_id":"789d6984f16e34743673acb3f9d7e1f30b42bd47"},{"author":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"change_message_id":"da5e608ffa5e802ada6b0801a00317ddd092cb6d","unresolved":false,"context_lines":[{"line_number":1336,"context_line":"\t\tcommand_print(CMD,"},{"line_number":1337,"context_line":"\t\t\t\t\"couldn\u0027t access cp0 reg %\" PRIu32 \", select %\" PRIu32,"},{"line_number":1338,"context_line":"\t\t\t\tcp0_reg,  cp0_sel);"},{"line_number":1339,"context_line":"\t\treturn ERROR_OK;"},{"line_number":1340,"context_line":"\t}"},{"line_number":1341,"context_line":""},{"line_number":1342,"context_line":"\tcommand_print(CMD, \"cp0 reg %\" PRIu32 \", select %\" PRIu32 \": %8.8\" PRIx32,"}],"source_content_type":"text/x-csrc","patch_set":12,"id":"1acf4c52_98df7e39","line":1339,"in_reply_to":"6ffbd833_aa83cd09","updated":"2023-11-17 07:24:22.000000000","message":"Done","commit_id":"789d6984f16e34743673acb3f9d7e1f30b42bd47"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"9acac7781b06e812409fb151a674c27d76742345","unresolved":true,"context_lines":[{"line_number":1247,"context_line":"static const struct mips32_cp0 *mips32_cp0_find_register_by_name(uint32_t cp0_mask, const char *reg_name)"},{"line_number":1248,"context_line":"{"},{"line_number":1249,"context_line":"\tif (reg_name)"},{"line_number":1250,"context_line":"\t\tfor (int i \u003d 0; i \u003c MIPS32NUMCP0REGS; i++) {"},{"line_number":1251,"context_line":"\t\t\tif ((mips32_cp0_regs[i].core \u0026 cp0_mask) \u003d\u003d 0)"},{"line_number":1252,"context_line":"\t\t\t\tcontinue;"},{"line_number":1253,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":15,"id":"9ed8eae5_fb7706cc","line":1250,"updated":"2023-11-18 17:03:18.000000000","message":"maybe in a separate patch, remove the cast (int) from\n#define MIPS32NUMCP0REGS ((int)ARRAY_SIZE(mips32_cp0_regs))\nand use \"unsigned int i\" here and in the other places","commit_id":"19d934356a441495133eb890d894bd7b7f637d82"},{"author":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"change_message_id":"b9f50531f24c8d4b305586a81c55f741cc2f5c0a","unresolved":false,"context_lines":[{"line_number":1247,"context_line":"static const struct mips32_cp0 *mips32_cp0_find_register_by_name(uint32_t cp0_mask, const char *reg_name)"},{"line_number":1248,"context_line":"{"},{"line_number":1249,"context_line":"\tif (reg_name)"},{"line_number":1250,"context_line":"\t\tfor (int i \u003d 0; i \u003c MIPS32NUMCP0REGS; i++) {"},{"line_number":1251,"context_line":"\t\t\tif ((mips32_cp0_regs[i].core \u0026 cp0_mask) \u003d\u003d 0)"},{"line_number":1252,"context_line":"\t\t\t\tcontinue;"},{"line_number":1253,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":15,"id":"8e9e0464_354d1230","line":1250,"in_reply_to":"9ed8eae5_fb7706cc","updated":"2023-11-22 09:48:51.000000000","message":"Done","commit_id":"19d934356a441495133eb890d894bd7b7f637d82"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"9acac7781b06e812409fb151a674c27d76742345","unresolved":true,"context_lines":[{"line_number":1303,"context_line":"{"},{"line_number":1304,"context_line":"\tconst struct mips32_cp0 *cp0_regs \u003d mips32_cp0_find_register_by_name(cp0_mask, CMD_ARGV[0]);"},{"line_number":1305,"context_line":"\tif (!cp0_regs) {"},{"line_number":1306,"context_line":"\t\tcommand_print(CMD, \"Error: Register \u0027%s\u0027 not found\", CMD_ARGV[0]);"},{"line_number":1307,"context_line":"\t\treturn ERROR_COMMAND_SYNTAX_ERROR;"},{"line_number":1308,"context_line":"\t}"},{"line_number":1309,"context_line":""},{"line_number":1310,"context_line":"\tuint32_t value;"}],"source_content_type":"text/x-csrc","patch_set":15,"id":"c9f29856_b7152a9e","line":1307,"range":{"start_line":1306,"start_character":2,"end_line":1307,"end_character":36},"updated":"2023-11-18 17:03:18.000000000","message":"The command_print() will be ignored due to return ERROR_COMMAND_SYNTAX_ERROR.\nPlease drop it","commit_id":"19d934356a441495133eb890d894bd7b7f637d82"},{"author":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"change_message_id":"b9f50531f24c8d4b305586a81c55f741cc2f5c0a","unresolved":false,"context_lines":[{"line_number":1303,"context_line":"{"},{"line_number":1304,"context_line":"\tconst struct mips32_cp0 *cp0_regs \u003d mips32_cp0_find_register_by_name(cp0_mask, CMD_ARGV[0]);"},{"line_number":1305,"context_line":"\tif (!cp0_regs) {"},{"line_number":1306,"context_line":"\t\tcommand_print(CMD, \"Error: Register \u0027%s\u0027 not found\", CMD_ARGV[0]);"},{"line_number":1307,"context_line":"\t\treturn ERROR_COMMAND_SYNTAX_ERROR;"},{"line_number":1308,"context_line":"\t}"},{"line_number":1309,"context_line":""},{"line_number":1310,"context_line":"\tuint32_t value;"}],"source_content_type":"text/x-csrc","patch_set":15,"id":"cbd1dd7b_ad2c962a","line":1307,"range":{"start_line":1306,"start_character":2,"end_line":1307,"end_character":36},"in_reply_to":"c9f29856_b7152a9e","updated":"2023-11-22 09:48:51.000000000","message":"Done","commit_id":"19d934356a441495133eb890d894bd7b7f637d82"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"5f07acb180b9f63a9d429f3625151ef87bad2a28","unresolved":true,"context_lines":[{"line_number":1303,"context_line":"{"},{"line_number":1304,"context_line":"\tconst struct mips32_cp0 *cp0_regs \u003d mips32_cp0_find_register_by_name(cp0_mask, CMD_ARGV[0]);"},{"line_number":1305,"context_line":"\tif (!cp0_regs) {"},{"line_number":1306,"context_line":"\t\tcommand_print(CMD, \"Error: Register \u0027%s\u0027 not found\", CMD_ARGV[0]);"},{"line_number":1307,"context_line":"\t\treturn ERROR_COMMAND_SYNTAX_ERROR;"},{"line_number":1308,"context_line":"\t}"},{"line_number":1309,"context_line":""},{"line_number":1310,"context_line":"\tuint32_t value;"}],"source_content_type":"text/x-csrc","patch_set":15,"id":"e72623ee_cd5bf335","line":1307,"range":{"start_line":1306,"start_character":2,"end_line":1307,"end_character":36},"in_reply_to":"cbd1dd7b_ad2c962a","updated":"2023-11-24 22:41:25.000000000","message":"Sorry, I have made a mistake!\nHere the code looks for a register named CMD_ARGC[0] and if it cannot find it the correct behavior is to print the message, as you have already done, and return ERROR_COMMAND_ARGUMENT_INVALID.","commit_id":"19d934356a441495133eb890d894bd7b7f637d82"},{"author":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"change_message_id":"278455edb605019627ed198d43da9d9a48aec2d8","unresolved":false,"context_lines":[{"line_number":1303,"context_line":"{"},{"line_number":1304,"context_line":"\tconst struct mips32_cp0 *cp0_regs \u003d mips32_cp0_find_register_by_name(cp0_mask, CMD_ARGV[0]);"},{"line_number":1305,"context_line":"\tif (!cp0_regs) {"},{"line_number":1306,"context_line":"\t\tcommand_print(CMD, \"Error: Register \u0027%s\u0027 not found\", CMD_ARGV[0]);"},{"line_number":1307,"context_line":"\t\treturn ERROR_COMMAND_SYNTAX_ERROR;"},{"line_number":1308,"context_line":"\t}"},{"line_number":1309,"context_line":""},{"line_number":1310,"context_line":"\tuint32_t value;"}],"source_content_type":"text/x-csrc","patch_set":15,"id":"4227e6c3_a2c217fb","line":1307,"range":{"start_line":1306,"start_character":2,"end_line":1307,"end_character":36},"in_reply_to":"e72623ee_cd5bf335","updated":"2023-11-28 02:07:00.000000000","message":"Done","commit_id":"19d934356a441495133eb890d894bd7b7f637d82"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"9acac7781b06e812409fb151a674c27d76742345","unresolved":true,"context_lines":[{"line_number":1364,"context_line":"{"},{"line_number":1365,"context_line":"\tconst struct mips32_cp0 *cp0_regs \u003d mips32_cp0_find_register_by_name(mips32-\u003ecp0_mask, CMD_ARGV[0]);"},{"line_number":1366,"context_line":"\tif (!cp0_regs) {"},{"line_number":1367,"context_line":"\t\tcommand_print(CMD, \"Error: Register \u0027%s\u0027 not found\", CMD_ARGV[0]);"},{"line_number":1368,"context_line":"\t\treturn ERROR_COMMAND_SYNTAX_ERROR;"},{"line_number":1369,"context_line":"\t}"},{"line_number":1370,"context_line":""},{"line_number":1371,"context_line":"\tuint32_t value;"}],"source_content_type":"text/x-csrc","patch_set":15,"id":"e4777962_42934afc","line":1368,"range":{"start_line":1367,"start_character":2,"end_line":1368,"end_character":36},"updated":"2023-11-18 17:03:18.000000000","message":"ditto","commit_id":"19d934356a441495133eb890d894bd7b7f637d82"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"5f07acb180b9f63a9d429f3625151ef87bad2a28","unresolved":true,"context_lines":[{"line_number":1364,"context_line":"{"},{"line_number":1365,"context_line":"\tconst struct mips32_cp0 *cp0_regs \u003d mips32_cp0_find_register_by_name(mips32-\u003ecp0_mask, CMD_ARGV[0]);"},{"line_number":1366,"context_line":"\tif (!cp0_regs) {"},{"line_number":1367,"context_line":"\t\tcommand_print(CMD, \"Error: Register \u0027%s\u0027 not found\", CMD_ARGV[0]);"},{"line_number":1368,"context_line":"\t\treturn ERROR_COMMAND_SYNTAX_ERROR;"},{"line_number":1369,"context_line":"\t}"},{"line_number":1370,"context_line":""},{"line_number":1371,"context_line":"\tuint32_t value;"}],"source_content_type":"text/x-csrc","patch_set":15,"id":"fa2ffbaa_a9796780","line":1368,"range":{"start_line":1367,"start_character":2,"end_line":1368,"end_character":36},"in_reply_to":"6df3bbb2_fd98aef3","updated":"2023-11-24 22:41:25.000000000","message":"Also here","commit_id":"19d934356a441495133eb890d894bd7b7f637d82"},{"author":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"change_message_id":"b9f50531f24c8d4b305586a81c55f741cc2f5c0a","unresolved":false,"context_lines":[{"line_number":1364,"context_line":"{"},{"line_number":1365,"context_line":"\tconst struct mips32_cp0 *cp0_regs \u003d mips32_cp0_find_register_by_name(mips32-\u003ecp0_mask, CMD_ARGV[0]);"},{"line_number":1366,"context_line":"\tif (!cp0_regs) {"},{"line_number":1367,"context_line":"\t\tcommand_print(CMD, \"Error: Register \u0027%s\u0027 not found\", CMD_ARGV[0]);"},{"line_number":1368,"context_line":"\t\treturn ERROR_COMMAND_SYNTAX_ERROR;"},{"line_number":1369,"context_line":"\t}"},{"line_number":1370,"context_line":""},{"line_number":1371,"context_line":"\tuint32_t value;"}],"source_content_type":"text/x-csrc","patch_set":15,"id":"6df3bbb2_fd98aef3","line":1368,"range":{"start_line":1367,"start_character":2,"end_line":1368,"end_character":36},"in_reply_to":"e4777962_42934afc","updated":"2023-11-22 09:48:51.000000000","message":"Done","commit_id":"19d934356a441495133eb890d894bd7b7f637d82"},{"author":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"change_message_id":"278455edb605019627ed198d43da9d9a48aec2d8","unresolved":false,"context_lines":[{"line_number":1364,"context_line":"{"},{"line_number":1365,"context_line":"\tconst struct mips32_cp0 *cp0_regs \u003d mips32_cp0_find_register_by_name(mips32-\u003ecp0_mask, CMD_ARGV[0]);"},{"line_number":1366,"context_line":"\tif (!cp0_regs) {"},{"line_number":1367,"context_line":"\t\tcommand_print(CMD, \"Error: Register \u0027%s\u0027 not found\", CMD_ARGV[0]);"},{"line_number":1368,"context_line":"\t\treturn ERROR_COMMAND_SYNTAX_ERROR;"},{"line_number":1369,"context_line":"\t}"},{"line_number":1370,"context_line":""},{"line_number":1371,"context_line":"\tuint32_t value;"}],"source_content_type":"text/x-csrc","patch_set":15,"id":"7310cd44_a801b990","line":1368,"range":{"start_line":1367,"start_character":2,"end_line":1368,"end_character":36},"in_reply_to":"fa2ffbaa_a9796780","updated":"2023-11-28 02:07:00.000000000","message":"Done","commit_id":"19d934356a441495133eb890d894bd7b7f637d82"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"9acac7781b06e812409fb151a674c27d76742345","unresolved":true,"context_lines":[{"line_number":1499,"context_line":"\t\t\tretval \u003d mips32_cp0_set_reg_by_number(CMD, mips32, ejtag_info);"},{"line_number":1500,"context_line":"\t\t\tbreak;"},{"line_number":1501,"context_line":"\t\tdefault: /* Other argc \u003d\u003e err */"},{"line_number":1502,"context_line":"\t\t\tcommand_print(CMD, \"Error: invalid argument format, required 0-3, given %d\", CMD_ARGC);"},{"line_number":1503,"context_line":"\t\t\tretval \u003d ERROR_COMMAND_ARGUMENT_INVALID;"},{"line_number":1504,"context_line":"\t\t\tbreak;"},{"line_number":1505,"context_line":"\t}"},{"line_number":1506,"context_line":""},{"line_number":1507,"context_line":"\treturn retval;"}],"source_content_type":"text/x-csrc","patch_set":15,"id":"ccb41705_788bd032","line":1504,"range":{"start_line":1502,"start_character":3,"end_line":1504,"end_character":9},"updated":"2023-11-18 17:03:18.000000000","message":"This is a syntax error. No need for command_print(), directly\nreturn ERROR_COMMAND_SYNTAX_ERROR;","commit_id":"19d934356a441495133eb890d894bd7b7f637d82"},{"author":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"change_message_id":"b9f50531f24c8d4b305586a81c55f741cc2f5c0a","unresolved":false,"context_lines":[{"line_number":1499,"context_line":"\t\t\tretval \u003d mips32_cp0_set_reg_by_number(CMD, mips32, ejtag_info);"},{"line_number":1500,"context_line":"\t\t\tbreak;"},{"line_number":1501,"context_line":"\t\tdefault: /* Other argc \u003d\u003e err */"},{"line_number":1502,"context_line":"\t\t\tcommand_print(CMD, \"Error: invalid argument format, required 0-3, given %d\", CMD_ARGC);"},{"line_number":1503,"context_line":"\t\t\tretval \u003d ERROR_COMMAND_ARGUMENT_INVALID;"},{"line_number":1504,"context_line":"\t\t\tbreak;"},{"line_number":1505,"context_line":"\t}"},{"line_number":1506,"context_line":""},{"line_number":1507,"context_line":"\treturn retval;"}],"source_content_type":"text/x-csrc","patch_set":15,"id":"6ce990df_96867d9d","line":1504,"range":{"start_line":1502,"start_character":3,"end_line":1504,"end_character":9},"in_reply_to":"ccb41705_788bd032","updated":"2023-11-22 09:48:51.000000000","message":"Done","commit_id":"19d934356a441495133eb890d894bd7b7f637d82"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"99cb2d627ff79a001fa052a11a3142b5d92b208e","unresolved":true,"context_lines":[{"line_number":1282,"context_line":"\t\t\treturn retval;"},{"line_number":1283,"context_line":"\t\t}"},{"line_number":1284,"context_line":""},{"line_number":1285,"context_line":"\t\tcommand_print(CMD, \"%*s: 0x%8.8x\", 14, mips32_cp0_regs[i].name, value);"},{"line_number":1286,"context_line":"\t}"},{"line_number":1287,"context_line":"\treturn ERROR_OK;"},{"line_number":1288,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":19,"id":"1acce032_d1768b2a","line":1285,"updated":"2023-12-28 13:53:31.000000000","message":"\u0027value\u0027 is of type uint32_t. Please change the format string with\n\"... 0x%8.8\" PRIx32","commit_id":"fd3ff8ee18909b511bbfb3c038cac35eb2cee5be"},{"author":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"change_message_id":"186880f5a9bce7b1dcbba7bf17731743e2506a19","unresolved":false,"context_lines":[{"line_number":1282,"context_line":"\t\t\treturn retval;"},{"line_number":1283,"context_line":"\t\t}"},{"line_number":1284,"context_line":""},{"line_number":1285,"context_line":"\t\tcommand_print(CMD, \"%*s: 0x%8.8x\", 14, mips32_cp0_regs[i].name, value);"},{"line_number":1286,"context_line":"\t}"},{"line_number":1287,"context_line":"\treturn ERROR_OK;"},{"line_number":1288,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":19,"id":"77068040_ee01401b","line":1285,"in_reply_to":"1acce032_d1768b2a","updated":"2023-12-29 09:23:48.000000000","message":"Done","commit_id":"fd3ff8ee18909b511bbfb3c038cac35eb2cee5be"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"99cb2d627ff79a001fa052a11a3142b5d92b208e","unresolved":true,"context_lines":[{"line_number":1303,"context_line":"\tconst struct mips32_cp0 *cp0_regs \u003d mips32_cp0_find_register_by_name(cp0_mask, CMD_ARGV[0]);"},{"line_number":1304,"context_line":"\tif (!cp0_regs) {"},{"line_number":1305,"context_line":"\t\tcommand_print(CMD, \"Error: Register \u0027%s\u0027 not found\", CMD_ARGV[0]);"},{"line_number":1306,"context_line":"\t\treturn ERROR_COMMAND_SYNTAX_ERROR;"},{"line_number":1307,"context_line":"\t}"},{"line_number":1308,"context_line":""},{"line_number":1309,"context_line":"\tuint32_t value;"}],"source_content_type":"text/x-csrc","patch_set":19,"id":"46c86088_ea649e9e","line":1306,"updated":"2023-12-28 13:53:31.000000000","message":"Please use ERROR_COMMAND_ARGUMENT_INVALID","commit_id":"fd3ff8ee18909b511bbfb3c038cac35eb2cee5be"},{"author":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"change_message_id":"186880f5a9bce7b1dcbba7bf17731743e2506a19","unresolved":false,"context_lines":[{"line_number":1303,"context_line":"\tconst struct mips32_cp0 *cp0_regs \u003d mips32_cp0_find_register_by_name(cp0_mask, CMD_ARGV[0]);"},{"line_number":1304,"context_line":"\tif (!cp0_regs) {"},{"line_number":1305,"context_line":"\t\tcommand_print(CMD, \"Error: Register \u0027%s\u0027 not found\", CMD_ARGV[0]);"},{"line_number":1306,"context_line":"\t\treturn ERROR_COMMAND_SYNTAX_ERROR;"},{"line_number":1307,"context_line":"\t}"},{"line_number":1308,"context_line":""},{"line_number":1309,"context_line":"\tuint32_t value;"}],"source_content_type":"text/x-csrc","patch_set":19,"id":"4ddfe000_9ce25470","line":1306,"in_reply_to":"46c86088_ea649e9e","updated":"2023-12-29 09:23:48.000000000","message":"Done","commit_id":"fd3ff8ee18909b511bbfb3c038cac35eb2cee5be"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"99cb2d627ff79a001fa052a11a3142b5d92b208e","unresolved":true,"context_lines":[{"line_number":1314,"context_line":"\t\treturn retval;"},{"line_number":1315,"context_line":"\t}"},{"line_number":1316,"context_line":""},{"line_number":1317,"context_line":"\tcommand_print(CMD, \"0x%8.8x\", value);"},{"line_number":1318,"context_line":"\treturn ERROR_OK;"},{"line_number":1319,"context_line":"}"},{"line_number":1320,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":19,"id":"b02c7ec2_1ed595aa","line":1317,"updated":"2023-12-28 13:53:31.000000000","message":"PRIx32","commit_id":"fd3ff8ee18909b511bbfb3c038cac35eb2cee5be"},{"author":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"change_message_id":"186880f5a9bce7b1dcbba7bf17731743e2506a19","unresolved":false,"context_lines":[{"line_number":1314,"context_line":"\t\treturn retval;"},{"line_number":1315,"context_line":"\t}"},{"line_number":1316,"context_line":""},{"line_number":1317,"context_line":"\tcommand_print(CMD, \"0x%8.8x\", value);"},{"line_number":1318,"context_line":"\treturn ERROR_OK;"},{"line_number":1319,"context_line":"}"},{"line_number":1320,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":19,"id":"1444a23c_0886d33d","line":1317,"in_reply_to":"b02c7ec2_1ed595aa","updated":"2023-12-29 09:23:48.000000000","message":"Done","commit_id":"fd3ff8ee18909b511bbfb3c038cac35eb2cee5be"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"99cb2d627ff79a001fa052a11a3142b5d92b208e","unresolved":true,"context_lines":[{"line_number":1364,"context_line":"\tconst struct mips32_cp0 *cp0_regs \u003d mips32_cp0_find_register_by_name(mips32-\u003ecp0_mask, CMD_ARGV[0]);"},{"line_number":1365,"context_line":"\tif (!cp0_regs) {"},{"line_number":1366,"context_line":"\t\tcommand_print(CMD, \"Error: Register \u0027%s\u0027 not found\", CMD_ARGV[0]);"},{"line_number":1367,"context_line":"\t\treturn ERROR_COMMAND_SYNTAX_ERROR;"},{"line_number":1368,"context_line":"\t}"},{"line_number":1369,"context_line":""},{"line_number":1370,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":19,"id":"3d8addbb_e0106ec2","line":1367,"updated":"2023-12-28 13:53:31.000000000","message":"Please use ERROR_COMMAND_ARGUMENT_INVALID","commit_id":"fd3ff8ee18909b511bbfb3c038cac35eb2cee5be"},{"author":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"change_message_id":"186880f5a9bce7b1dcbba7bf17731743e2506a19","unresolved":false,"context_lines":[{"line_number":1364,"context_line":"\tconst struct mips32_cp0 *cp0_regs \u003d mips32_cp0_find_register_by_name(mips32-\u003ecp0_mask, CMD_ARGV[0]);"},{"line_number":1365,"context_line":"\tif (!cp0_regs) {"},{"line_number":1366,"context_line":"\t\tcommand_print(CMD, \"Error: Register \u0027%s\u0027 not found\", CMD_ARGV[0]);"},{"line_number":1367,"context_line":"\t\treturn ERROR_COMMAND_SYNTAX_ERROR;"},{"line_number":1368,"context_line":"\t}"},{"line_number":1369,"context_line":""},{"line_number":1370,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":19,"id":"efb673ca_35f7efdf","line":1367,"in_reply_to":"3d8addbb_e0106ec2","updated":"2023-12-29 09:23:48.000000000","message":"Done","commit_id":"fd3ff8ee18909b511bbfb3c038cac35eb2cee5be"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"99cb2d627ff79a001fa052a11a3142b5d92b208e","unresolved":true,"context_lines":[{"line_number":1398,"context_line":"\t\treturn retval;"},{"line_number":1399,"context_line":"\t}"},{"line_number":1400,"context_line":""},{"line_number":1401,"context_line":"\tcommand_print(CMD, \"cp0 reg %s (%\" PRIu32 \", select %\" PRIu32 \": %8.8\" PRIx32 \")\","},{"line_number":1402,"context_line":"\t\t\tCMD_ARGV[0], cp0_regs-\u003ereg, cp0_regs-\u003esel, value);"},{"line_number":1403,"context_line":"\treturn ERROR_OK;"},{"line_number":1404,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":19,"id":"9631a908_55fcec4e","line":1401,"updated":"2023-12-28 13:53:31.000000000","message":"cp0_regs-\u003ereg and cp0_regs-\u003esel are unsigned int.\n\"cp0 reg %s (%u, select %u: %8.8\" PRIx32 \")\"\nFor the moment we do not enforce %u on unsigned and %d on signed, so %d is ok too","commit_id":"fd3ff8ee18909b511bbfb3c038cac35eb2cee5be"},{"author":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"change_message_id":"186880f5a9bce7b1dcbba7bf17731743e2506a19","unresolved":false,"context_lines":[{"line_number":1398,"context_line":"\t\treturn retval;"},{"line_number":1399,"context_line":"\t}"},{"line_number":1400,"context_line":""},{"line_number":1401,"context_line":"\tcommand_print(CMD, \"cp0 reg %s (%\" PRIu32 \", select %\" PRIu32 \": %8.8\" PRIx32 \")\","},{"line_number":1402,"context_line":"\t\t\tCMD_ARGV[0], cp0_regs-\u003ereg, cp0_regs-\u003esel, value);"},{"line_number":1403,"context_line":"\treturn ERROR_OK;"},{"line_number":1404,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":19,"id":"2c34c642_912e4405","line":1401,"in_reply_to":"9631a908_55fcec4e","updated":"2023-12-29 09:23:48.000000000","message":"Understood, I will keep this in mind in future commits.","commit_id":"fd3ff8ee18909b511bbfb3c038cac35eb2cee5be"}],"src/target/mips32.h":[{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"4f33a7ff95467dab01e5cd18472b7698ddc2b47e","unresolved":true,"context_lines":[{"line_number":398,"context_line":""},{"line_number":399,"context_line":"\tint fdc;"},{"line_number":400,"context_line":"\tint semihosting;"},{"line_number":401,"context_line":"\tuint32_t cp0_mask;"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"\t/* FPU enabled (cp0.status.cu1) */"},{"line_number":404,"context_line":"\tbool fpu_enabled;"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"84c190f6_95434a8b","line":401,"updated":"2023-11-07 10:06:46.000000000","message":"A comment explaining this variable will be helpful","commit_id":"a447fba263c893043ac0036743a16728e5a9b76d"},{"author":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"change_message_id":"dfd4e9f093a9cadeeaded7547bf976f0b572352a","unresolved":false,"context_lines":[{"line_number":398,"context_line":""},{"line_number":399,"context_line":"\tint fdc;"},{"line_number":400,"context_line":"\tint semihosting;"},{"line_number":401,"context_line":"\tuint32_t cp0_mask;"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"\t/* FPU enabled (cp0.status.cu1) */"},{"line_number":404,"context_line":"\tbool fpu_enabled;"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"5308d95c_6582154d","line":401,"in_reply_to":"84c190f6_95434a8b","updated":"2023-11-15 05:09:22.000000000","message":"I have added comment for it, same as following.\n\u003e The cp0 registers implemented on different processor cores could be different, too. Here you can see most of the registers are implemented on interAptiv, which is a 2c4t SMP processor and has more features that M-class processors do not have, like vpe and other config registers for multhreading.","commit_id":"a447fba263c893043ac0036743a16728e5a9b76d"}]}