)]}'
{"src/target/mips32.c":[{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"42ed0de9e245412fc5c0f37bb22a4b4b540de46f","unresolved":true,"context_lines":[{"line_number":1574,"context_line":"\tuint32_t dcr;"},{"line_number":1575,"context_line":"\tint retval;"},{"line_number":1576,"context_line":""},{"line_number":1577,"context_line":"\tretval \u003d mips_ejtag_get_idcode(ejtag_info);"},{"line_number":1578,"context_line":"\tidcode \u003d ejtag_info-\u003eidcode;"},{"line_number":1579,"context_line":"\tretval \u003d mips_ejtag_get_impcode(ejtag_info);"},{"line_number":1580,"context_line":"\timpcode \u003d ejtag_info-\u003eimpcode;"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"d34ad582_30f1557d","line":1577,"updated":"2023-11-07 10:25:42.000000000","message":"retval is not tested","commit_id":"72c0c4cbff7f0e420599518e30522f0be5d26bb7"},{"author":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"change_message_id":"b3f02c4d782596067d281b783ad1ebb7f1f7ef4c","unresolved":false,"context_lines":[{"line_number":1574,"context_line":"\tuint32_t dcr;"},{"line_number":1575,"context_line":"\tint retval;"},{"line_number":1576,"context_line":""},{"line_number":1577,"context_line":"\tretval \u003d mips_ejtag_get_idcode(ejtag_info);"},{"line_number":1578,"context_line":"\tidcode \u003d ejtag_info-\u003eidcode;"},{"line_number":1579,"context_line":"\tretval \u003d mips_ejtag_get_impcode(ejtag_info);"},{"line_number":1580,"context_line":"\timpcode \u003d ejtag_info-\u003eimpcode;"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"84eb43be_0434eff4","line":1577,"in_reply_to":"d34ad582_30f1557d","updated":"2023-11-15 05:09:38.000000000","message":"Done","commit_id":"72c0c4cbff7f0e420599518e30522f0be5d26bb7"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"42ed0de9e245412fc5c0f37bb22a4b4b540de46f","unresolved":true,"context_lines":[{"line_number":1576,"context_line":""},{"line_number":1577,"context_line":"\tretval \u003d mips_ejtag_get_idcode(ejtag_info);"},{"line_number":1578,"context_line":"\tidcode \u003d ejtag_info-\u003eidcode;"},{"line_number":1579,"context_line":"\tretval \u003d mips_ejtag_get_impcode(ejtag_info);"},{"line_number":1580,"context_line":"\timpcode \u003d ejtag_info-\u003eimpcode;"},{"line_number":1581,"context_line":"\tmips_ejtag_set_instr(ejtag_info, EJTAG_INST_CONTROL);"},{"line_number":1582,"context_line":"\tejtag_ctrl \u003d ejtag_info-\u003eejtag_ctrl;"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"585845ab_edcd5f43","line":1579,"updated":"2023-11-07 10:25:42.000000000","message":"retval is not tested","commit_id":"72c0c4cbff7f0e420599518e30522f0be5d26bb7"},{"author":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"change_message_id":"b3f02c4d782596067d281b783ad1ebb7f1f7ef4c","unresolved":false,"context_lines":[{"line_number":1576,"context_line":""},{"line_number":1577,"context_line":"\tretval \u003d mips_ejtag_get_idcode(ejtag_info);"},{"line_number":1578,"context_line":"\tidcode \u003d ejtag_info-\u003eidcode;"},{"line_number":1579,"context_line":"\tretval \u003d mips_ejtag_get_impcode(ejtag_info);"},{"line_number":1580,"context_line":"\timpcode \u003d ejtag_info-\u003eimpcode;"},{"line_number":1581,"context_line":"\tmips_ejtag_set_instr(ejtag_info, EJTAG_INST_CONTROL);"},{"line_number":1582,"context_line":"\tejtag_ctrl \u003d ejtag_info-\u003eejtag_ctrl;"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"332e3431_07e756b3","line":1579,"in_reply_to":"585845ab_edcd5f43","updated":"2023-11-15 05:09:38.000000000","message":"Done","commit_id":"72c0c4cbff7f0e420599518e30522f0be5d26bb7"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"42ed0de9e245412fc5c0f37bb22a4b4b540de46f","unresolved":true,"context_lines":[{"line_number":1581,"context_line":"\tmips_ejtag_set_instr(ejtag_info, EJTAG_INST_CONTROL);"},{"line_number":1582,"context_line":"\tejtag_ctrl \u003d ejtag_info-\u003eejtag_ctrl;"},{"line_number":1583,"context_line":"\tretval \u003d mips_ejtag_drscan_32(ejtag_info, \u0026ejtag_ctrl);"},{"line_number":1584,"context_line":""},{"line_number":1585,"context_line":"\tif (retval !\u003d ERROR_OK)"},{"line_number":1586,"context_line":"\t\tLOG_INFO(\"Encounter an Error\");"},{"line_number":1587,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":9,"id":"61c66219_9a286d3e","line":1584,"updated":"2023-11-07 10:25:42.000000000","message":"this empty line should be removed","commit_id":"72c0c4cbff7f0e420599518e30522f0be5d26bb7"},{"author":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"change_message_id":"b3f02c4d782596067d281b783ad1ebb7f1f7ef4c","unresolved":false,"context_lines":[{"line_number":1581,"context_line":"\tmips_ejtag_set_instr(ejtag_info, EJTAG_INST_CONTROL);"},{"line_number":1582,"context_line":"\tejtag_ctrl \u003d ejtag_info-\u003eejtag_ctrl;"},{"line_number":1583,"context_line":"\tretval \u003d mips_ejtag_drscan_32(ejtag_info, \u0026ejtag_ctrl);"},{"line_number":1584,"context_line":""},{"line_number":1585,"context_line":"\tif (retval !\u003d ERROR_OK)"},{"line_number":1586,"context_line":"\t\tLOG_INFO(\"Encounter an Error\");"},{"line_number":1587,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":9,"id":"e45d66a5_5366e9b0","line":1584,"in_reply_to":"61c66219_9a286d3e","updated":"2023-11-15 05:09:38.000000000","message":"Done","commit_id":"72c0c4cbff7f0e420599518e30522f0be5d26bb7"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"42ed0de9e245412fc5c0f37bb22a4b4b540de46f","unresolved":true,"context_lines":[{"line_number":1583,"context_line":"\tretval \u003d mips_ejtag_drscan_32(ejtag_info, \u0026ejtag_ctrl);"},{"line_number":1584,"context_line":""},{"line_number":1585,"context_line":"\tif (retval !\u003d ERROR_OK)"},{"line_number":1586,"context_line":"\t\tLOG_INFO(\"Encounter an Error\");"},{"line_number":1587,"context_line":""},{"line_number":1588,"context_line":"\tLOG_USER(\"       idcode: 0x%8.8x\", idcode);"},{"line_number":1589,"context_line":"\tLOG_USER(\"      impcode: 0x%8.8x\", impcode);"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"ccf6ea3f_4ebdcacb","line":1586,"updated":"2023-11-07 10:25:42.000000000","message":"If an error occurs, it should provide more context about what the error was or where it happened.","commit_id":"72c0c4cbff7f0e420599518e30522f0be5d26bb7"},{"author":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"change_message_id":"b3f02c4d782596067d281b783ad1ebb7f1f7ef4c","unresolved":false,"context_lines":[{"line_number":1583,"context_line":"\tretval \u003d mips_ejtag_drscan_32(ejtag_info, \u0026ejtag_ctrl);"},{"line_number":1584,"context_line":""},{"line_number":1585,"context_line":"\tif (retval !\u003d ERROR_OK)"},{"line_number":1586,"context_line":"\t\tLOG_INFO(\"Encounter an Error\");"},{"line_number":1587,"context_line":""},{"line_number":1588,"context_line":"\tLOG_USER(\"       idcode: 0x%8.8x\", idcode);"},{"line_number":1589,"context_line":"\tLOG_USER(\"      impcode: 0x%8.8x\", impcode);"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"f8226265_b3e4e19e","line":1586,"in_reply_to":"ccf6ea3f_4ebdcacb","updated":"2023-11-15 05:09:38.000000000","message":"Done","commit_id":"72c0c4cbff7f0e420599518e30522f0be5d26bb7"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"42ed0de9e245412fc5c0f37bb22a4b4b540de46f","unresolved":true,"context_lines":[{"line_number":1617,"context_line":"\t\tLOG_USER(\"Complex Breakpoints supported\");"},{"line_number":1618,"context_line":""},{"line_number":1619,"context_line":"\tif (((dcr \u003e\u003e 9) \u0026 0x1) \u003d\u003d 1)"},{"line_number":1620,"context_line":"\t\tLOG_USER(\"PC Sampling supported\");"},{"line_number":1621,"context_line":""},{"line_number":1622,"context_line":"\treturn ERROR_OK;"},{"line_number":1623,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"3e89ee62_4f08b230","line":1620,"updated":"2023-11-07 10:25:42.000000000","message":"Hm.. meay be instead of checking each bit separately, so something like this?\nstatic const struct dcr_feature {\n    const char *name;\n    int bit;\n} dcr_features[] \u003d {\n    {\"DAS\", 22},\n    {\"FDC\", 18},\n    {\"DataBrk\", 17},\n    {\"InstBrk\", 16},\n    {\"Inverted Data value\", 15},\n    {\"Data value stored\", 14},\n    {\"Complex Breakpoints\", 10},\n    {\"PC Sampling\", 9},\n    // Add more features here if needed\n};\n\n/* Display current DCR */\nretval \u003d target_read_u32(target, EJTAG_DCR, \u0026dcr);\nLOG_USER(\"          DCR: 0x%8.8x\", dcr);\n\nfor (unsigned int i \u003d 0; i \u003c (sizeof(dcr_features) / sizeof(dcr_features[0])); i++) {\n    if ((dcr \u003e\u003e dcr_features[i].bit) \u0026 0x1) {\n        LOG_USER(\"%s supported\", dcr_features[i].name);\n    }\n}","commit_id":"72c0c4cbff7f0e420599518e30522f0be5d26bb7"},{"author":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"change_message_id":"b3f02c4d782596067d281b783ad1ebb7f1f7ef4c","unresolved":false,"context_lines":[{"line_number":1617,"context_line":"\t\tLOG_USER(\"Complex Breakpoints supported\");"},{"line_number":1618,"context_line":""},{"line_number":1619,"context_line":"\tif (((dcr \u003e\u003e 9) \u0026 0x1) \u003d\u003d 1)"},{"line_number":1620,"context_line":"\t\tLOG_USER(\"PC Sampling supported\");"},{"line_number":1621,"context_line":""},{"line_number":1622,"context_line":"\treturn ERROR_OK;"},{"line_number":1623,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"806235b0_27670c84","line":1620,"in_reply_to":"3e89ee62_4f08b230","updated":"2023-11-15 05:09:38.000000000","message":"Done","commit_id":"72c0c4cbff7f0e420599518e30522f0be5d26bb7"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"a0bb42ca61317d09f29dd4ca1a946295f9ec865f","unresolved":true,"context_lines":[{"line_number":1553,"context_line":"}"},{"line_number":1554,"context_line":""},{"line_number":1555,"context_line":"extern void ejtag_main_print_imp(struct mips_ejtag *ejtag_info);"},{"line_number":1556,"context_line":"extern int mips_ejtag_get_impcode(struct mips_ejtag *ejtag_info);"},{"line_number":1557,"context_line":""},{"line_number":1558,"context_line":"COMMAND_HANDLER(mips32_handle_ejtag_reg_command)"},{"line_number":1559,"context_line":"{"}],"source_content_type":"text/x-csrc","patch_set":11,"id":"8f451ab3_f8803f57","line":1556,"updated":"2023-11-17 13:41:14.000000000","message":"Please remove \"extern\" flags and move function declarations in to the header file.","commit_id":"13f138e5940e15fd65601f5dd9fa4d5696089b42"},{"author":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"change_message_id":"989b0d3657ab4c96cdb69d81a4e331ab504dc960","unresolved":false,"context_lines":[{"line_number":1553,"context_line":"}"},{"line_number":1554,"context_line":""},{"line_number":1555,"context_line":"extern void ejtag_main_print_imp(struct mips_ejtag *ejtag_info);"},{"line_number":1556,"context_line":"extern int mips_ejtag_get_impcode(struct mips_ejtag *ejtag_info);"},{"line_number":1557,"context_line":""},{"line_number":1558,"context_line":"COMMAND_HANDLER(mips32_handle_ejtag_reg_command)"},{"line_number":1559,"context_line":"{"}],"source_content_type":"text/x-csrc","patch_set":11,"id":"f7d5f99a_e42baeee","line":1556,"in_reply_to":"8f451ab3_f8803f57","updated":"2023-11-22 09:49:15.000000000","message":"Done","commit_id":"13f138e5940e15fd65601f5dd9fa4d5696089b42"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"a0bb42ca61317d09f29dd4ca1a946295f9ec865f","unresolved":true,"context_lines":[{"line_number":1733,"context_line":""},{"line_number":1734,"context_line":"\tretval \u003d mips_ejtag_get_idcode(ejtag_info);"},{"line_number":1735,"context_line":"\tif (retval !\u003d ERROR_OK)"},{"line_number":1736,"context_line":"\t\tcommand_print(CMD, \"Error: Encounter an Error while getting idcode\");"},{"line_number":1737,"context_line":""},{"line_number":1738,"context_line":"\tidcode \u003d ejtag_info-\u003eidcode;"},{"line_number":1739,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":15,"id":"fcda5de9_9cdc8ed1","line":1736,"updated":"2023-11-17 13:41:14.000000000","message":"error is ignored. We will use broken value","commit_id":"5e1dafa9175db6d081e12550bc25c5f9842fc0e3"},{"author":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"change_message_id":"989b0d3657ab4c96cdb69d81a4e331ab504dc960","unresolved":false,"context_lines":[{"line_number":1733,"context_line":""},{"line_number":1734,"context_line":"\tretval \u003d mips_ejtag_get_idcode(ejtag_info);"},{"line_number":1735,"context_line":"\tif (retval !\u003d ERROR_OK)"},{"line_number":1736,"context_line":"\t\tcommand_print(CMD, \"Error: Encounter an Error while getting idcode\");"},{"line_number":1737,"context_line":""},{"line_number":1738,"context_line":"\tidcode \u003d ejtag_info-\u003eidcode;"},{"line_number":1739,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":15,"id":"3c8c14fd_e45d3259","line":1736,"in_reply_to":"fcda5de9_9cdc8ed1","updated":"2023-11-22 09:49:15.000000000","message":"Done","commit_id":"5e1dafa9175db6d081e12550bc25c5f9842fc0e3"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"a0bb42ca61317d09f29dd4ca1a946295f9ec865f","unresolved":true,"context_lines":[{"line_number":1739,"context_line":""},{"line_number":1740,"context_line":"\tretval \u003d mips_ejtag_get_impcode(ejtag_info);"},{"line_number":1741,"context_line":"\tif (retval !\u003d ERROR_OK)"},{"line_number":1742,"context_line":"\t\tcommand_print(CMD, \"Error: Encounter an Error while getting impcode\");"},{"line_number":1743,"context_line":""},{"line_number":1744,"context_line":"\timpcode \u003d ejtag_info-\u003eimpcode;"},{"line_number":1745,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":15,"id":"add5fd08_4680c939","line":1742,"updated":"2023-11-17 13:41:14.000000000","message":"here too","commit_id":"5e1dafa9175db6d081e12550bc25c5f9842fc0e3"},{"author":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"change_message_id":"989b0d3657ab4c96cdb69d81a4e331ab504dc960","unresolved":false,"context_lines":[{"line_number":1739,"context_line":""},{"line_number":1740,"context_line":"\tretval \u003d mips_ejtag_get_impcode(ejtag_info);"},{"line_number":1741,"context_line":"\tif (retval !\u003d ERROR_OK)"},{"line_number":1742,"context_line":"\t\tcommand_print(CMD, \"Error: Encounter an Error while getting impcode\");"},{"line_number":1743,"context_line":""},{"line_number":1744,"context_line":"\timpcode \u003d ejtag_info-\u003eimpcode;"},{"line_number":1745,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":15,"id":"d84045db_38e5e5b3","line":1742,"in_reply_to":"add5fd08_4680c939","updated":"2023-11-22 09:49:15.000000000","message":"Done","commit_id":"5e1dafa9175db6d081e12550bc25c5f9842fc0e3"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"a0bb42ca61317d09f29dd4ca1a946295f9ec865f","unresolved":true,"context_lines":[{"line_number":1747,"context_line":"\tejtag_ctrl \u003d ejtag_info-\u003eejtag_ctrl;"},{"line_number":1748,"context_line":"\tretval \u003d mips_ejtag_drscan_32(ejtag_info, \u0026ejtag_ctrl);"},{"line_number":1749,"context_line":"\tif (retval !\u003d ERROR_OK)"},{"line_number":1750,"context_line":"\t\tcommand_print(CMD, \"Error: Encounter an Error while executing drscan\");"},{"line_number":1751,"context_line":""},{"line_number":1752,"context_line":"\tcommand_print(CMD, \"       idcode: 0x%8.8x\", idcode);"},{"line_number":1753,"context_line":"\tcommand_print(CMD, \"      impcode: 0x%8.8x\", impcode);"}],"source_content_type":"text/x-csrc","patch_set":15,"id":"8e9e5e0f_fbed439f","line":1750,"updated":"2023-11-17 13:41:14.000000000","message":"And here too. All of errors are ignored. If you still wont to try hard, they probably better do something like:\nif (retval !\u003d ERROR_OK)\n   print error\nelse\n   print value","commit_id":"5e1dafa9175db6d081e12550bc25c5f9842fc0e3"},{"author":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"change_message_id":"989b0d3657ab4c96cdb69d81a4e331ab504dc960","unresolved":false,"context_lines":[{"line_number":1747,"context_line":"\tejtag_ctrl \u003d ejtag_info-\u003eejtag_ctrl;"},{"line_number":1748,"context_line":"\tretval \u003d mips_ejtag_drscan_32(ejtag_info, \u0026ejtag_ctrl);"},{"line_number":1749,"context_line":"\tif (retval !\u003d ERROR_OK)"},{"line_number":1750,"context_line":"\t\tcommand_print(CMD, \"Error: Encounter an Error while executing drscan\");"},{"line_number":1751,"context_line":""},{"line_number":1752,"context_line":"\tcommand_print(CMD, \"       idcode: 0x%8.8x\", idcode);"},{"line_number":1753,"context_line":"\tcommand_print(CMD, \"      impcode: 0x%8.8x\", impcode);"}],"source_content_type":"text/x-csrc","patch_set":15,"id":"f56f4239_96f89e1d","line":1750,"in_reply_to":"8e9e5e0f_fbed439f","updated":"2023-11-22 09:49:15.000000000","message":"Yes, that was the idea. The errors here is not fatal and the function should print out any available information.","commit_id":"5e1dafa9175db6d081e12550bc25c5f9842fc0e3"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"ef3d13c6833190fd28ed5301015308eca3b7a1d9","unresolved":true,"context_lines":[{"line_number":1729,"context_line":"\tif (retval !\u003d ERROR_OK)"},{"line_number":1730,"context_line":"\t\tcommand_print(CMD, \"Error: Encounter an Error while getting idcode\");"},{"line_number":1731,"context_line":"\telse"},{"line_number":1732,"context_line":"\t\tcommand_print(CMD, \"       idcode: 0x%8.8x\", ejtag_info-\u003eidcode);"},{"line_number":1733,"context_line":""},{"line_number":1734,"context_line":"\tretval \u003d mips_ejtag_get_impcode(ejtag_info);"},{"line_number":1735,"context_line":"\tif (retval !\u003d ERROR_OK)"}],"source_content_type":"text/x-csrc","patch_set":19,"id":"7fb5cf88_0ba9ff85","line":1732,"updated":"2023-12-28 14:02:24.000000000","message":"PRIx32","commit_id":"bc2cf9382d284dbf65d1039c405c33fe9e550369"},{"author":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"change_message_id":"e5b827d58677e59fbcc863bda785dfec3b8c79b9","unresolved":false,"context_lines":[{"line_number":1729,"context_line":"\tif (retval !\u003d ERROR_OK)"},{"line_number":1730,"context_line":"\t\tcommand_print(CMD, \"Error: Encounter an Error while getting idcode\");"},{"line_number":1731,"context_line":"\telse"},{"line_number":1732,"context_line":"\t\tcommand_print(CMD, \"       idcode: 0x%8.8x\", ejtag_info-\u003eidcode);"},{"line_number":1733,"context_line":""},{"line_number":1734,"context_line":"\tretval \u003d mips_ejtag_get_impcode(ejtag_info);"},{"line_number":1735,"context_line":"\tif (retval !\u003d ERROR_OK)"}],"source_content_type":"text/x-csrc","patch_set":19,"id":"8c36f2a1_f044996d","line":1732,"in_reply_to":"7fb5cf88_0ba9ff85","updated":"2023-12-29 09:24:14.000000000","message":"Done","commit_id":"bc2cf9382d284dbf65d1039c405c33fe9e550369"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"ef3d13c6833190fd28ed5301015308eca3b7a1d9","unresolved":true,"context_lines":[{"line_number":1735,"context_line":"\tif (retval !\u003d ERROR_OK)"},{"line_number":1736,"context_line":"\t\tcommand_print(CMD, \"Error: Encounter an Error while getting impcode\");"},{"line_number":1737,"context_line":"\telse"},{"line_number":1738,"context_line":"\t\tcommand_print(CMD, \"      impcode: 0x%8.8x\", ejtag_info-\u003eimpcode);"},{"line_number":1739,"context_line":""},{"line_number":1740,"context_line":"\tmips_ejtag_set_instr(ejtag_info, EJTAG_INST_CONTROL);"},{"line_number":1741,"context_line":"\tejtag_ctrl \u003d ejtag_info-\u003eejtag_ctrl;"}],"source_content_type":"text/x-csrc","patch_set":19,"id":"a569f277_f8a38d15","line":1738,"updated":"2023-12-28 14:02:24.000000000","message":"PRIx32","commit_id":"bc2cf9382d284dbf65d1039c405c33fe9e550369"},{"author":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"change_message_id":"e5b827d58677e59fbcc863bda785dfec3b8c79b9","unresolved":false,"context_lines":[{"line_number":1735,"context_line":"\tif (retval !\u003d ERROR_OK)"},{"line_number":1736,"context_line":"\t\tcommand_print(CMD, \"Error: Encounter an Error while getting impcode\");"},{"line_number":1737,"context_line":"\telse"},{"line_number":1738,"context_line":"\t\tcommand_print(CMD, \"      impcode: 0x%8.8x\", ejtag_info-\u003eimpcode);"},{"line_number":1739,"context_line":""},{"line_number":1740,"context_line":"\tmips_ejtag_set_instr(ejtag_info, EJTAG_INST_CONTROL);"},{"line_number":1741,"context_line":"\tejtag_ctrl \u003d ejtag_info-\u003eejtag_ctrl;"}],"source_content_type":"text/x-csrc","patch_set":19,"id":"d7baeccb_b84e0a9b","line":1738,"in_reply_to":"a569f277_f8a38d15","updated":"2023-12-29 09:24:14.000000000","message":"Done","commit_id":"bc2cf9382d284dbf65d1039c405c33fe9e550369"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"ef3d13c6833190fd28ed5301015308eca3b7a1d9","unresolved":true,"context_lines":[{"line_number":1743,"context_line":"\tif (retval !\u003d ERROR_OK)"},{"line_number":1744,"context_line":"\t\tcommand_print(CMD, \"Error: Encounter an Error while executing drscan reading EJTAG Control register\");"},{"line_number":1745,"context_line":"\telse"},{"line_number":1746,"context_line":"\t\tcommand_print(CMD, \"ejtag control: 0x%8.8x\", ejtag_ctrl);"},{"line_number":1747,"context_line":""},{"line_number":1748,"context_line":"\tejtag_main_print_imp(ejtag_info);"},{"line_number":1749,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":19,"id":"8539877a_67f6918e","line":1746,"updated":"2023-12-28 14:02:24.000000000","message":"PRIx32","commit_id":"bc2cf9382d284dbf65d1039c405c33fe9e550369"},{"author":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"change_message_id":"e5b827d58677e59fbcc863bda785dfec3b8c79b9","unresolved":false,"context_lines":[{"line_number":1743,"context_line":"\tif (retval !\u003d ERROR_OK)"},{"line_number":1744,"context_line":"\t\tcommand_print(CMD, \"Error: Encounter an Error while executing drscan reading EJTAG Control register\");"},{"line_number":1745,"context_line":"\telse"},{"line_number":1746,"context_line":"\t\tcommand_print(CMD, \"ejtag control: 0x%8.8x\", ejtag_ctrl);"},{"line_number":1747,"context_line":""},{"line_number":1748,"context_line":"\tejtag_main_print_imp(ejtag_info);"},{"line_number":1749,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":19,"id":"ad7b93bc_83a8ab5e","line":1746,"in_reply_to":"8539877a_67f6918e","updated":"2023-12-29 09:24:14.000000000","message":"Done","commit_id":"bc2cf9382d284dbf65d1039c405c33fe9e550369"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"ef3d13c6833190fd28ed5301015308eca3b7a1d9","unresolved":true,"context_lines":[{"line_number":1752,"context_line":"\tif (retval !\u003d ERROR_OK)"},{"line_number":1753,"context_line":"\t\tcommand_print(CMD, \"Error: Encounter an Error while reading Debug Control Register\");"},{"line_number":1754,"context_line":"\telse"},{"line_number":1755,"context_line":"\t\tcommand_print(CMD, \"          DCR: 0x%8.8x\", dcr);"},{"line_number":1756,"context_line":""},{"line_number":1757,"context_line":"\tfor (int i \u003d 0; i \u003c EJTAG_DCR_ENTRIES; i++) {"},{"line_number":1758,"context_line":"\t\tif ((dcr \u003e\u003e dcr_features[i].bit) \u0026 1)"}],"source_content_type":"text/x-csrc","patch_set":19,"id":"21ce4655_85c2d73c","line":1755,"updated":"2023-12-28 14:02:24.000000000","message":"PRIx32","commit_id":"bc2cf9382d284dbf65d1039c405c33fe9e550369"},{"author":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"change_message_id":"e5b827d58677e59fbcc863bda785dfec3b8c79b9","unresolved":false,"context_lines":[{"line_number":1752,"context_line":"\tif (retval !\u003d ERROR_OK)"},{"line_number":1753,"context_line":"\t\tcommand_print(CMD, \"Error: Encounter an Error while reading Debug Control Register\");"},{"line_number":1754,"context_line":"\telse"},{"line_number":1755,"context_line":"\t\tcommand_print(CMD, \"          DCR: 0x%8.8x\", dcr);"},{"line_number":1756,"context_line":""},{"line_number":1757,"context_line":"\tfor (int i \u003d 0; i \u003c EJTAG_DCR_ENTRIES; i++) {"},{"line_number":1758,"context_line":"\t\tif ((dcr \u003e\u003e dcr_features[i].bit) \u0026 1)"}],"source_content_type":"text/x-csrc","patch_set":19,"id":"4e20bc96_7c2aba8d","line":1755,"in_reply_to":"21ce4655_85c2d73c","updated":"2023-12-29 09:24:14.000000000","message":"Done","commit_id":"bc2cf9382d284dbf65d1039c405c33fe9e550369"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"ef3d13c6833190fd28ed5301015308eca3b7a1d9","unresolved":true,"context_lines":[{"line_number":1754,"context_line":"\telse"},{"line_number":1755,"context_line":"\t\tcommand_print(CMD, \"          DCR: 0x%8.8x\", dcr);"},{"line_number":1756,"context_line":""},{"line_number":1757,"context_line":"\tfor (int i \u003d 0; i \u003c EJTAG_DCR_ENTRIES; i++) {"},{"line_number":1758,"context_line":"\t\tif ((dcr \u003e\u003e dcr_features[i].bit) \u0026 1)"},{"line_number":1759,"context_line":"\t\t\tcommand_print(CMD, \"%s supported\", dcr_features[i].name);"},{"line_number":1760,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":19,"id":"820565b1_9a0b4bc1","line":1757,"updated":"2023-12-28 14:02:24.000000000","message":"please use unsigned int for \u0027i\u0027, so you can drop the cast (int) in the definition of EJTAG_DCR_ENTRIES","commit_id":"bc2cf9382d284dbf65d1039c405c33fe9e550369"},{"author":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"change_message_id":"e5b827d58677e59fbcc863bda785dfec3b8c79b9","unresolved":false,"context_lines":[{"line_number":1754,"context_line":"\telse"},{"line_number":1755,"context_line":"\t\tcommand_print(CMD, \"          DCR: 0x%8.8x\", dcr);"},{"line_number":1756,"context_line":""},{"line_number":1757,"context_line":"\tfor (int i \u003d 0; i \u003c EJTAG_DCR_ENTRIES; i++) {"},{"line_number":1758,"context_line":"\t\tif ((dcr \u003e\u003e dcr_features[i].bit) \u0026 1)"},{"line_number":1759,"context_line":"\t\t\tcommand_print(CMD, \"%s supported\", dcr_features[i].name);"},{"line_number":1760,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":19,"id":"de36c692_920d0e9f","line":1757,"in_reply_to":"820565b1_9a0b4bc1","updated":"2023-12-29 09:24:14.000000000","message":"Done, and changed definition of EJTAG_DCR_ENTRIES, too.","commit_id":"bc2cf9382d284dbf65d1039c405c33fe9e550369"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"ef3d13c6833190fd28ed5301015308eca3b7a1d9","unresolved":true,"context_lines":[{"line_number":1755,"context_line":"\t\tcommand_print(CMD, \"          DCR: 0x%8.8x\", dcr);"},{"line_number":1756,"context_line":""},{"line_number":1757,"context_line":"\tfor (int i \u003d 0; i \u003c EJTAG_DCR_ENTRIES; i++) {"},{"line_number":1758,"context_line":"\t\tif ((dcr \u003e\u003e dcr_features[i].bit) \u0026 1)"},{"line_number":1759,"context_line":"\t\t\tcommand_print(CMD, \"%s supported\", dcr_features[i].name);"},{"line_number":1760,"context_line":"\t}"},{"line_number":1761,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":19,"id":"9083e137_111d0409","line":1758,"updated":"2023-12-28 14:02:24.000000000","message":"Do you think it could be more readable by using\nif (dcr \u0026 BIT(dcr_features[i].bit))\n?","commit_id":"bc2cf9382d284dbf65d1039c405c33fe9e550369"},{"author":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"change_message_id":"e5b827d58677e59fbcc863bda785dfec3b8c79b9","unresolved":false,"context_lines":[{"line_number":1755,"context_line":"\t\tcommand_print(CMD, \"          DCR: 0x%8.8x\", dcr);"},{"line_number":1756,"context_line":""},{"line_number":1757,"context_line":"\tfor (int i \u003d 0; i \u003c EJTAG_DCR_ENTRIES; i++) {"},{"line_number":1758,"context_line":"\t\tif ((dcr \u003e\u003e dcr_features[i].bit) \u0026 1)"},{"line_number":1759,"context_line":"\t\t\tcommand_print(CMD, \"%s supported\", dcr_features[i].name);"},{"line_number":1760,"context_line":"\t}"},{"line_number":1761,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":19,"id":"d95ac660_bb17f656","line":1758,"in_reply_to":"9083e137_111d0409","updated":"2023-12-29 09:24:14.000000000","message":"Yes, that is more readable, thanks for the advise!","commit_id":"bc2cf9382d284dbf65d1039c405c33fe9e550369"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"61320ae1c7cc41ed1632c150ebb3fd194ecfc0a0","unresolved":false,"context_lines":[{"line_number":1282,"context_line":"\t\t\treturn retval;"},{"line_number":1283,"context_line":"\t\t}"},{"line_number":1284,"context_line":""},{"line_number":1285,"context_line":"\t\tcommand_print(CMD, \"%*s: 0x%8.8\" PRIx32, 14, mips32_cp0_regs[i].name, value);"},{"line_number":1286,"context_line":"\t}"},{"line_number":1287,"context_line":"\treturn ERROR_OK;"},{"line_number":1288,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":20,"id":"8ed1aaeb_8d072d50","line":1285,"updated":"2023-12-29 10:15:15.000000000","message":"I have missed it as it was not part of this patch! Thanks for the fix!","commit_id":"3fae8bacfce9730ff218545ae332d3ea69e7bcad"}]}