)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"change_message_id":"15b39a2ad589462b9f0f82c9785ec4c4c67e2523","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"491c703f_b15ca082","updated":"2023-10-05 18:31:28.000000000","message":"This is a nice improvement. I have just one suggestion.","commit_id":"8045d6aabcabc02ce0f47f030f8b07dc4c6dae82"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"202d43c2489a62945e6df66b545477808774a963","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d0798203_393e2d2d","updated":"2023-10-07 21:34:35.000000000","message":"I don\u0027t love the enum breakpoint_watchpoint, but I have to admit that using a single breakpoint_watchpoint_remove_all() can help keeping in sync breakpoint and watchpoint code.","commit_id":"7d59a10d6af58d97442a5cf675d3ae47024e5e02"},{"author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"change_message_id":"54441fd777e5695701de34f481c4bdb609f9ac22","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"b8c16c76_ae481e9a","updated":"2023-10-06 11:16:12.000000000","message":"LGTM, thank you.","commit_id":"7d59a10d6af58d97442a5cf675d3ae47024e5e02"}],"src/target/breakpoints.c":[{"author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"change_message_id":"15b39a2ad589462b9f0f82c9785ec4c4c67e2523","unresolved":true,"context_lines":[{"line_number":438,"context_line":"\t\t\telse if (bp_wp \u003d\u003d WATCHPOINT)"},{"line_number":439,"context_line":"\t\t\t\tstatus \u003d watchpoint_remove_all_internal(curr);"},{"line_number":440,"context_line":"\t\t\telse"},{"line_number":441,"context_line":"\t\t\t\tassert(false \u0026\u0026 \"Function called with nether breakpoint or watchpoint\");"},{"line_number":442,"context_line":""},{"line_number":443,"context_line":"\t\t\tif (status !\u003d ERROR_OK)"},{"line_number":444,"context_line":"\t\t\t\tretval \u003d status;"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"f72bd61f_3aadd054","line":441,"updated":"2023-10-05 18:31:28.000000000","message":"Typo: neither\n\nOr even better, you can use `assert(bp_wp \u003d\u003d BREAKPOINT | bp_wp \u003d\u003d WATCHPOINT);` at the very beginning of the function. Then you can drop the two \"else\" branches (with just the assert) altogether.","commit_id":"8045d6aabcabc02ce0f47f030f8b07dc4c6dae82"},{"author":{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"},"change_message_id":"1f167b8bdd08de8b25ed02d718d12a564a1767e9","unresolved":false,"context_lines":[{"line_number":438,"context_line":"\t\t\telse if (bp_wp \u003d\u003d WATCHPOINT)"},{"line_number":439,"context_line":"\t\t\t\tstatus \u003d watchpoint_remove_all_internal(curr);"},{"line_number":440,"context_line":"\t\t\telse"},{"line_number":441,"context_line":"\t\t\t\tassert(false \u0026\u0026 \"Function called with nether breakpoint or watchpoint\");"},{"line_number":442,"context_line":""},{"line_number":443,"context_line":"\t\t\tif (status !\u003d ERROR_OK)"},{"line_number":444,"context_line":"\t\t\t\tretval \u003d status;"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"b8275695_9a8e1ea6","line":441,"in_reply_to":"f72bd61f_3aadd054","updated":"2023-10-06 10:58:05.000000000","message":"Done","commit_id":"8045d6aabcabc02ce0f47f030f8b07dc4c6dae82"}]}