)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"change_message_id":"addb28dbab08714344a03602eea1256777e70db2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"bc2cfeaf_1189c31c","updated":"2023-10-06 06:05:51.000000000","message":"LGTM, thanks.","commit_id":"6dfbfb3113887b3749f454f2fd82b0fa64b2dc1e"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"e559861932568cb5a69896314f940310d4b30459","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f06dac78_8ac28141","updated":"2023-10-08 08:30:32.000000000","message":"thanks","commit_id":"6dfbfb3113887b3749f454f2fd82b0fa64b2dc1e"}],"src/target/target.c":[{"author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"change_message_id":"62114df19fc748087a12ea7eb3e2659db312ef2b","unresolved":true,"context_lines":[{"line_number":4075,"context_line":"\t\t\t\t\t\", mask: 0x%8.8\" PRIx64,"},{"line_number":4076,"context_line":"\t\t\t\t\twatchpoint-\u003eaddress,"},{"line_number":4077,"context_line":"\t\t\t\t\twatchpoint-\u003elength,"},{"line_number":4078,"context_line":"\t\t\t\t\t(watchpoint-\u003erw \u003d\u003d WPT_READ ? \u0027r\u0027 : (watchpoint-\u003erw \u003d\u003d WPT_WRITE ? \u0027w\u0027 : \u0027a\u0027)),"},{"line_number":4079,"context_line":"\t\t\t\t\twatchpoint-\u003evalue,"},{"line_number":4080,"context_line":"\t\t\t\t\twatchpoint-\u003emask);"},{"line_number":4081,"context_line":"\t\t\twatchpoint \u003d watchpoint-\u003enext;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"a154cb00_5963cd0d","line":4078,"updated":"2023-10-05 18:25:38.000000000","message":"Just a detail: For clarity and readability, I\u0027d recommend to take this expression out and use a helper variable.\n\n```\nchar wp_type \u003d (watchpoint-\u003erw \u003d\u003d WPT_READ) ? \u0027r\u0027 : \n        (watchpoint-\u003erw \u003d\u003d WPT_WRITE) ? \u0027w\u0027 : \u0027a\u0027;\ncommand_print(..., wp_type, ...);\n```","commit_id":"86d1d408147f640d488af133004e1abe43b848b6"},{"author":{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"},"change_message_id":"814f7a1ee0357cfd58d6b00fb4fe9dc9730673f7","unresolved":false,"context_lines":[{"line_number":4075,"context_line":"\t\t\t\t\t\", mask: 0x%8.8\" PRIx64,"},{"line_number":4076,"context_line":"\t\t\t\t\twatchpoint-\u003eaddress,"},{"line_number":4077,"context_line":"\t\t\t\t\twatchpoint-\u003elength,"},{"line_number":4078,"context_line":"\t\t\t\t\t(watchpoint-\u003erw \u003d\u003d WPT_READ ? \u0027r\u0027 : (watchpoint-\u003erw \u003d\u003d WPT_WRITE ? \u0027w\u0027 : \u0027a\u0027)),"},{"line_number":4079,"context_line":"\t\t\t\t\twatchpoint-\u003evalue,"},{"line_number":4080,"context_line":"\t\t\t\t\twatchpoint-\u003emask);"},{"line_number":4081,"context_line":"\t\t\twatchpoint \u003d watchpoint-\u003enext;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"80a2428e_c0ee33bc","line":4078,"in_reply_to":"a154cb00_5963cd0d","updated":"2023-10-06 06:05:21.000000000","message":"Done","commit_id":"86d1d408147f640d488af133004e1abe43b848b6"}]}