)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1002152,"name":"Kirill Radkin","email":"kirill.radkin@syntacore.com","username":"kr-sc"},"change_message_id":"aff1fdc061d29e29c7f3bc7b94c2b2df2e8c47d2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3a22a4c8_cc045c26","updated":"2023-09-26 14:03:25.000000000","message":"Found this issue in my patch https://review.openocd.org/c/openocd/+/7738","commit_id":"5595611c0624ace33dfc6b3677aa9e3ed137304b"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"28d9ec379739164c05ea3701371188970e3e8dba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"92225f7d_c8c4b1af","updated":"2023-10-07 15:22:04.000000000","message":"Jan, are you ok with this last version?\n\nKirill, would you mind adding in the commit message:\nFixes: 022e438292de (\"target: Change policy of removing watchpoints/breakpoints.\")\nYou don\u0027t need to push a new patch; there is an \"Edit\" button in the Gerrit Web interface below the commit message","commit_id":"64e4ff170e659b6bb4a43b82894732e48e6df54a"},{"author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"change_message_id":"ced0c6d7e2c3168233e5b5f17992d35148cefd68","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fbd45f16_14d4b418","updated":"2023-10-09 05:27:52.000000000","message":"This looks all right to me - thanks.","commit_id":"64e4ff170e659b6bb4a43b82894732e48e6df54a"},{"author":{"_account_id":1002152,"name":"Kirill Radkin","email":"kirill.radkin@syntacore.com","username":"kr-sc"},"change_message_id":"85d713ce30fec1bea8e6cd3fb486c1b5a12afd6e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"848df43a_a97db039","in_reply_to":"92225f7d_c8c4b1af","updated":"2023-10-09 09:59:11.000000000","message":"Done","commit_id":"64e4ff170e659b6bb4a43b82894732e48e6df54a"}],"src/target/breakpoints.c":[{"author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"change_message_id":"b49b3c8aa62767a8510d59d7994a519699763a0e","unresolved":true,"context_lines":[{"line_number":592,"context_line":"\t\t\t}"},{"line_number":593,"context_line":""},{"line_number":594,"context_line":"\t\t\tif (status !\u003d ERROR_OK) {"},{"line_number":595,"context_line":"\t\t\t\tLOG_TARGET_ERROR(curr, \"failed to remove watchpoint at address\" TARGET_ADDR_FMT, address);"},{"line_number":596,"context_line":"\t\t\t\tretval \u003d status;"},{"line_number":597,"context_line":"\t\t\t}"},{"line_number":598,"context_line":"\t\t}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"d5cc57ef_78baa550","line":595,"updated":"2023-10-05 19:49:13.000000000","message":"Do I understand correctly that you\u0027re trying to prevent returning ERROR_OK in case there is no watchpoint at the given address in any of the SMP-grouped targets?\n\nThis changed code would produce the \"failed to remove watchpoint ...\" error even if the watchpoint is not there (when `status \u003d\u003d ERROR_WATCHPOINT_NOT_FOUND`). I am afraid that such errors would be misleading to users.\n\nHow about fixing it differently:\n\n```\n\tif (num_found_watchpoints \u003d\u003d 0) {\n\t\tLOG_TARGET_ERROR(target, \"no watchpoint at address \" TARGET_ADDR_FMT \" found\", address);\n\t\treturn ERROR_WATCHPOINT_NOT_FOUND;\n\t}\n```\n\nAnalogously for breakpoints.","commit_id":"5595611c0624ace33dfc6b3677aa9e3ed137304b"},{"author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"change_message_id":"b49b3c8aa62767a8510d59d7994a519699763a0e","unresolved":true,"context_lines":[{"line_number":592,"context_line":"\t\t\t}"},{"line_number":593,"context_line":""},{"line_number":594,"context_line":"\t\t\tif (status !\u003d ERROR_OK) {"},{"line_number":595,"context_line":"\t\t\t\tLOG_TARGET_ERROR(curr, \"failed to remove watchpoint at address\" TARGET_ADDR_FMT, address);"},{"line_number":596,"context_line":"\t\t\t\tretval \u003d status;"},{"line_number":597,"context_line":"\t\t\t}"},{"line_number":598,"context_line":"\t\t}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"0d0fa29a_b54408c7","line":595,"updated":"2023-10-05 19:49:13.000000000","message":"Not introduced in this merge request, but related:\n\nThere is a typo in the error message - missing space after the word \"address\".\n\nThere is also one more occurrence below.","commit_id":"5595611c0624ace33dfc6b3677aa9e3ed137304b"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"28d9ec379739164c05ea3701371188970e3e8dba","unresolved":false,"context_lines":[{"line_number":592,"context_line":"\t\t\t}"},{"line_number":593,"context_line":""},{"line_number":594,"context_line":"\t\t\tif (status !\u003d ERROR_OK) {"},{"line_number":595,"context_line":"\t\t\t\tLOG_TARGET_ERROR(curr, \"failed to remove watchpoint at address\" TARGET_ADDR_FMT, address);"},{"line_number":596,"context_line":"\t\t\t\tretval \u003d status;"},{"line_number":597,"context_line":"\t\t\t}"},{"line_number":598,"context_line":"\t\t}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"e79adac5_2b477db9","line":595,"in_reply_to":"0d0fa29a_b54408c7","updated":"2023-10-07 15:22:04.000000000","message":"Done","commit_id":"5595611c0624ace33dfc6b3677aa9e3ed137304b"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"28d9ec379739164c05ea3701371188970e3e8dba","unresolved":false,"context_lines":[{"line_number":592,"context_line":"\t\t\t}"},{"line_number":593,"context_line":""},{"line_number":594,"context_line":"\t\t\tif (status !\u003d ERROR_OK) {"},{"line_number":595,"context_line":"\t\t\t\tLOG_TARGET_ERROR(curr, \"failed to remove watchpoint at address\" TARGET_ADDR_FMT, address);"},{"line_number":596,"context_line":"\t\t\t\tretval \u003d status;"},{"line_number":597,"context_line":"\t\t\t}"},{"line_number":598,"context_line":"\t\t}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"d9f35285_1e3df2ae","line":595,"in_reply_to":"d5cc57ef_78baa550","updated":"2023-10-07 15:22:04.000000000","message":"Done","commit_id":"5595611c0624ace33dfc6b3677aa9e3ed137304b"}]}