)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"0e51fe6752450f0027cf8c8a095184095b642e25","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"64de6851_52a691fb","updated":"2023-09-27 19:47:09.000000000","message":"Given the complexity of mips32_read_config_regs, consider breaking it down into smaller helper functions for readability and maintenance.\n\nCommit message can be reworded. Something like this:\nEnhance `mips32_read_config_regs` to better detect and log MIPS32 ISA,\nDSP, and FPU features, allowing more accurate target information.\nMost of this information will be used in patches adding MIPS m/iAptive support.\n\nOtherwise, with some reworks it looks good.","commit_id":"fb4b031d0746dadfb132d5a890d286573eeda89f"},{"author":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"change_message_id":"396c6a43d52cc68474f9f940de4e8d0835674706","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3046eb66_a962b68e","updated":"2023-10-09 03:26:16.000000000","message":"I have updated the commit message and moved dsp\u0026fpu\u0026cdmm parts to separate functions.","commit_id":"3c71e7de7197f700da810591145e8cf93ffccedd"},{"author":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"change_message_id":"a4c875dafa2a4bda58aee1af6f06ffa39b59e5ca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"64641c41_92da9fb6","updated":"2023-11-02 09:27:49.000000000","message":"I have updated the code, the fpu part will be updated by following fpu support patch (which apprantly spuashed with the dsp support patch, I am looking into it)","commit_id":"30da0223820902578bbb4a651f8a5d06bf0f1d2c"}],"src/target/mips32.c":[{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"0e51fe6752450f0027cf8c8a095184095b642e25","unresolved":true,"context_lines":[{"line_number":851,"context_line":"\t\tLOG_USER(\"ISA implemented: %s%s\", \"MIPS32\", buf);"},{"line_number":852,"context_line":"\t}"},{"line_number":853,"context_line":"\tmemset(buf, 0, sizeof(buf));"},{"line_number":854,"context_line":""},{"line_number":855,"context_line":"\t/* Retrieve DSP info */"},{"line_number":856,"context_line":"\tmips32-\u003edsp_imp \u003d ((ejtag_info-\u003econfig[3] \u0026 MIPS32_CONFIG3_DSPP_MASK) \u003e\u003e MIPS32_CONFIG3_DSPP_SHIFT);"},{"line_number":857,"context_line":"\tif (mips32-\u003edsp_imp) {"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"fb87bbee_0ce9b8ae","line":854,"updated":"2023-09-27 19:47:09.000000000","message":"please split the code in to following functions:\nmips32_read_config_dsp()\nmips32_read_config_fp()\nmips32_read_config_fdc_cdmm()\n\nFeel free make own grouping if you thing it is better","commit_id":"fb4b031d0746dadfb132d5a890d286573eeda89f"},{"author":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"change_message_id":"396c6a43d52cc68474f9f940de4e8d0835674706","unresolved":false,"context_lines":[{"line_number":851,"context_line":"\t\tLOG_USER(\"ISA implemented: %s%s\", \"MIPS32\", buf);"},{"line_number":852,"context_line":"\t}"},{"line_number":853,"context_line":"\tmemset(buf, 0, sizeof(buf));"},{"line_number":854,"context_line":""},{"line_number":855,"context_line":"\t/* Retrieve DSP info */"},{"line_number":856,"context_line":"\tmips32-\u003edsp_imp \u003d ((ejtag_info-\u003econfig[3] \u0026 MIPS32_CONFIG3_DSPP_MASK) \u003e\u003e MIPS32_CONFIG3_DSPP_SHIFT);"},{"line_number":857,"context_line":"\tif (mips32-\u003edsp_imp) {"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"5630881c_92cfbc18","line":854,"in_reply_to":"fb87bbee_0ce9b8ae","updated":"2023-10-09 03:26:16.000000000","message":"Done, the code is much clear now, thanks for the advice!","commit_id":"fb4b031d0746dadfb132d5a890d286573eeda89f"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"4be9c3bb5e6aaf9f63c0af78b8645ae39e43c142","unresolved":true,"context_lines":[{"line_number":811,"context_line":"\tuint32_t dsp_imp \u003d ((ejtag_info-\u003econfig[3] \u0026 MIPS32_CONFIG3_DSPP_MASK) \u003e\u003e MIPS32_CONFIG3_DSPP_SHIFT);"},{"line_number":812,"context_line":"\tif (dsp_imp) {"},{"line_number":813,"context_line":"\t\tmips32-\u003edsp_imp \u003d ((ejtag_info-\u003econfig[3] \u0026 MIPS32_CONFIG3_DSPREV_MASK) \u003e\u003e MIPS32_CONFIG3_DSPREV_SHIFT) + 1;"},{"line_number":814,"context_line":"\t\tLOG_USER(\"DSP implemented: %s, rev %d\", \"yes\", dsp_imp);"},{"line_number":815,"context_line":"\t} else {"},{"line_number":816,"context_line":"\t\tLOG_USER(\"DSP implemented: %s\", \"no\");"},{"line_number":817,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"21bae11c_9c2f295d","line":814,"updated":"2023-10-20 14:24:51.000000000","message":"you are using same variable for dsp_present bit and dsp_revision. This is probably the reason why you print accidentally only one bit instead of revision.\n\nIn general, i expect for every new part of code following coding model:\nif (error || not_present)\n    do something and exit\n\nand then long part of code doing normal things","commit_id":"e65c991b35240f7f297cbc9db5974fba0bb83a94"},{"author":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"change_message_id":"a4c875dafa2a4bda58aee1af6f06ffa39b59e5ca","unresolved":false,"context_lines":[{"line_number":811,"context_line":"\tuint32_t dsp_imp \u003d ((ejtag_info-\u003econfig[3] \u0026 MIPS32_CONFIG3_DSPP_MASK) \u003e\u003e MIPS32_CONFIG3_DSPP_SHIFT);"},{"line_number":812,"context_line":"\tif (dsp_imp) {"},{"line_number":813,"context_line":"\t\tmips32-\u003edsp_imp \u003d ((ejtag_info-\u003econfig[3] \u0026 MIPS32_CONFIG3_DSPREV_MASK) \u003e\u003e MIPS32_CONFIG3_DSPREV_SHIFT) + 1;"},{"line_number":814,"context_line":"\t\tLOG_USER(\"DSP implemented: %s, rev %d\", \"yes\", dsp_imp);"},{"line_number":815,"context_line":"\t} else {"},{"line_number":816,"context_line":"\t\tLOG_USER(\"DSP implemented: %s\", \"no\");"},{"line_number":817,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"40b346a8_ffd1030c","line":814,"in_reply_to":"21bae11c_9c2f295d","updated":"2023-11-02 09:27:49.000000000","message":"Done","commit_id":"e65c991b35240f7f297cbc9db5974fba0bb83a94"},{"author":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"change_message_id":"a4c875dafa2a4bda58aee1af6f06ffa39b59e5ca","unresolved":false,"context_lines":[{"line_number":811,"context_line":"\tuint32_t dsp_imp \u003d ((ejtag_info-\u003econfig[3] \u0026 MIPS32_CONFIG3_DSPP_MASK) \u003e\u003e MIPS32_CONFIG3_DSPP_SHIFT);"},{"line_number":812,"context_line":"\tif (dsp_imp) {"},{"line_number":813,"context_line":"\t\tmips32-\u003edsp_imp \u003d ((ejtag_info-\u003econfig[3] \u0026 MIPS32_CONFIG3_DSPREV_MASK) \u003e\u003e MIPS32_CONFIG3_DSPREV_SHIFT) + 1;"},{"line_number":814,"context_line":"\t\tLOG_USER(\"DSP implemented: %s, rev %d\", \"yes\", dsp_imp);"},{"line_number":815,"context_line":"\t} else {"},{"line_number":816,"context_line":"\t\tLOG_USER(\"DSP implemented: %s\", \"no\");"},{"line_number":817,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"accd8e0f_3d0d6515","line":814,"in_reply_to":"21bae11c_9c2f295d","updated":"2023-11-02 09:27:49.000000000","message":"Done","commit_id":"e65c991b35240f7f297cbc9db5974fba0bb83a94"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"4be9c3bb5e6aaf9f63c0af78b8645ae39e43c142","unresolved":true,"context_lines":[{"line_number":823,"context_line":"\tint retval;"},{"line_number":824,"context_line":"\tuint32_t fp_imp \u003d (ejtag_info-\u003econfig[1] \u0026 MIPS32_CONFIG1_FP_MASK) \u003e\u003e MIPS32_CONFIG1_FP_SHIFT;"},{"line_number":825,"context_line":"\tchar buf[60] \u003d {0};"},{"line_number":826,"context_line":"\tif (fp_imp) {"},{"line_number":827,"context_line":"\t\tuint32_t status_value;"},{"line_number":828,"context_line":"\t\tbool status_fr, status_cu1;"},{"line_number":829,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":4,"id":"4dfeab31_7387ec4b","line":826,"updated":"2023-10-20 14:24:51.000000000","message":"if (!fp_present)\n   return...","commit_id":"e65c991b35240f7f297cbc9db5974fba0bb83a94"},{"author":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"change_message_id":"a4c875dafa2a4bda58aee1af6f06ffa39b59e5ca","unresolved":false,"context_lines":[{"line_number":823,"context_line":"\tint retval;"},{"line_number":824,"context_line":"\tuint32_t fp_imp \u003d (ejtag_info-\u003econfig[1] \u0026 MIPS32_CONFIG1_FP_MASK) \u003e\u003e MIPS32_CONFIG1_FP_SHIFT;"},{"line_number":825,"context_line":"\tchar buf[60] \u003d {0};"},{"line_number":826,"context_line":"\tif (fp_imp) {"},{"line_number":827,"context_line":"\t\tuint32_t status_value;"},{"line_number":828,"context_line":"\t\tbool status_fr, status_cu1;"},{"line_number":829,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":4,"id":"d2dae0bd_6907c393","line":826,"in_reply_to":"4dfeab31_7387ec4b","updated":"2023-11-02 09:27:49.000000000","message":"Done","commit_id":"e65c991b35240f7f297cbc9db5974fba0bb83a94"},{"author":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"change_message_id":"a4c875dafa2a4bda58aee1af6f06ffa39b59e5ca","unresolved":false,"context_lines":[{"line_number":823,"context_line":"\tint retval;"},{"line_number":824,"context_line":"\tuint32_t fp_imp \u003d (ejtag_info-\u003econfig[1] \u0026 MIPS32_CONFIG1_FP_MASK) \u003e\u003e MIPS32_CONFIG1_FP_SHIFT;"},{"line_number":825,"context_line":"\tchar buf[60] \u003d {0};"},{"line_number":826,"context_line":"\tif (fp_imp) {"},{"line_number":827,"context_line":"\t\tuint32_t status_value;"},{"line_number":828,"context_line":"\t\tbool status_fr, status_cu1;"},{"line_number":829,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":4,"id":"d78a3cd2_9382ef8d","line":826,"in_reply_to":"4dfeab31_7387ec4b","updated":"2023-11-02 09:27:49.000000000","message":"Done","commit_id":"e65c991b35240f7f297cbc9db5974fba0bb83a94"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"4be9c3bb5e6aaf9f63c0af78b8645ae39e43c142","unresolved":true,"context_lines":[{"line_number":836,"context_line":"\t\tstatus_fr \u003d (status_value \u003e\u003e MIPS32_CP0_STATUS_FR_SHIFT) \u0026 0x1;"},{"line_number":837,"context_line":"\t\tstatus_cu1 \u003d (status_value \u003e\u003e MIPS32_CP0_STATUS_CU1_SHIFT) \u0026 0x1;"},{"line_number":838,"context_line":"\t\tif (status_cu1) {"},{"line_number":839,"context_line":"\t\t\tstrcpy(buf, \"yes, unknown\");"},{"line_number":840,"context_line":"\t\t\tfp_imp \u003d MIPS32_FP_IMP_NONE;"},{"line_number":841,"context_line":"\t\t} else {"},{"line_number":842,"context_line":"\t\t\tstrcpy(buf, \"yes, disabled\");"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"722a035a_f8a4a0fb","line":839,"updated":"2023-10-20 14:24:51.000000000","message":"snprintf() instead of strcpy()","commit_id":"e65c991b35240f7f297cbc9db5974fba0bb83a94"},{"author":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"change_message_id":"a4c875dafa2a4bda58aee1af6f06ffa39b59e5ca","unresolved":false,"context_lines":[{"line_number":836,"context_line":"\t\tstatus_fr \u003d (status_value \u003e\u003e MIPS32_CP0_STATUS_FR_SHIFT) \u0026 0x1;"},{"line_number":837,"context_line":"\t\tstatus_cu1 \u003d (status_value \u003e\u003e MIPS32_CP0_STATUS_CU1_SHIFT) \u0026 0x1;"},{"line_number":838,"context_line":"\t\tif (status_cu1) {"},{"line_number":839,"context_line":"\t\t\tstrcpy(buf, \"yes, unknown\");"},{"line_number":840,"context_line":"\t\t\tfp_imp \u003d MIPS32_FP_IMP_NONE;"},{"line_number":841,"context_line":"\t\t} else {"},{"line_number":842,"context_line":"\t\t\tstrcpy(buf, \"yes, disabled\");"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"bcc8d8af_28ecc31a","line":839,"in_reply_to":"722a035a_f8a4a0fb","updated":"2023-11-02 09:27:49.000000000","message":"Done","commit_id":"e65c991b35240f7f297cbc9db5974fba0bb83a94"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"4be9c3bb5e6aaf9f63c0af78b8645ae39e43c142","unresolved":true,"context_lines":[{"line_number":846,"context_line":"\t\tmips32-\u003efpu_in_64bit \u003d status_fr;"},{"line_number":847,"context_line":"\t\tmips32-\u003efpu_enabled \u003d status_cu1;"},{"line_number":848,"context_line":""},{"line_number":849,"context_line":"\t\tif (!buf[0])"},{"line_number":850,"context_line":"\t\t\tsnprintf(buf, sizeof(buf), \"yes, %sbit (%s, working in %sbit)\","},{"line_number":851,"context_line":"\t\t\t\tfp_imp \u003d\u003d MIPS32_FP_IMP_64 ? \"64\" : \"32\","},{"line_number":852,"context_line":"\t\t\t\tstatus_cu1 ? \"enabled\" : \"disabled\","}],"source_content_type":"text/x-csrc","patch_set":4,"id":"b4d26fc5_535c501a","line":849,"updated":"2023-10-20 14:24:51.000000000","message":"Do i\u0027m missing some thing? In which case buf[0] will be 0?","commit_id":"e65c991b35240f7f297cbc9db5974fba0bb83a94"},{"author":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"change_message_id":"a4c875dafa2a4bda58aee1af6f06ffa39b59e5ca","unresolved":false,"context_lines":[{"line_number":846,"context_line":"\t\tmips32-\u003efpu_in_64bit \u003d status_fr;"},{"line_number":847,"context_line":"\t\tmips32-\u003efpu_enabled \u003d status_cu1;"},{"line_number":848,"context_line":""},{"line_number":849,"context_line":"\t\tif (!buf[0])"},{"line_number":850,"context_line":"\t\t\tsnprintf(buf, sizeof(buf), \"yes, %sbit (%s, working in %sbit)\","},{"line_number":851,"context_line":"\t\t\t\tfp_imp \u003d\u003d MIPS32_FP_IMP_64 ? \"64\" : \"32\","},{"line_number":852,"context_line":"\t\t\t\tstatus_cu1 ? \"enabled\" : \"disabled\","}],"source_content_type":"text/x-csrc","patch_set":4,"id":"2d7b40ef_c440da1d","line":849,"in_reply_to":"b4d26fc5_535c501a","updated":"2023-11-02 09:27:49.000000000","message":"Done","commit_id":"e65c991b35240f7f297cbc9db5974fba0bb83a94"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"4be9c3bb5e6aaf9f63c0af78b8645ae39e43c142","unresolved":true,"context_lines":[{"line_number":922,"context_line":"\t\t/* initial default value */"},{"line_number":923,"context_line":"\t\tLOG_USER(\"ISA implemented: %s%s\", \"MIPS32\", buf);"},{"line_number":924,"context_line":"\t}"},{"line_number":925,"context_line":"\tmemset(buf, 0, sizeof(buf));"},{"line_number":926,"context_line":""},{"line_number":927,"context_line":"\t/* Retrieve DSP info */"},{"line_number":928,"context_line":"\tmips32_read_config_dsp(mips32, ejtag_info);"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"d16399fd_bc60d5bf","line":925,"updated":"2023-10-20 14:24:51.000000000","message":"buf is not used after this part. Why it should be set to 0?","commit_id":"e65c991b35240f7f297cbc9db5974fba0bb83a94"},{"author":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"change_message_id":"a4c875dafa2a4bda58aee1af6f06ffa39b59e5ca","unresolved":false,"context_lines":[{"line_number":922,"context_line":"\t\t/* initial default value */"},{"line_number":923,"context_line":"\t\tLOG_USER(\"ISA implemented: %s%s\", \"MIPS32\", buf);"},{"line_number":924,"context_line":"\t}"},{"line_number":925,"context_line":"\tmemset(buf, 0, sizeof(buf));"},{"line_number":926,"context_line":""},{"line_number":927,"context_line":"\t/* Retrieve DSP info */"},{"line_number":928,"context_line":"\tmips32_read_config_dsp(mips32, ejtag_info);"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"48c7e253_26ab7ab5","line":925,"in_reply_to":"d16399fd_bc60d5bf","updated":"2023-11-02 09:27:49.000000000","message":"Done","commit_id":"e65c991b35240f7f297cbc9db5974fba0bb83a94"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"8871e7b732c707b35b148313afa7594681e91a09","unresolved":true,"context_lines":[{"line_number":825,"context_line":"\tchar buf[60] \u003d {0};"},{"line_number":826,"context_line":"\tif (!fp_imp) {"},{"line_number":827,"context_line":"\t\tLOG_USER(\"FPU implemented: %s\", \"no\");"},{"line_number":828,"context_line":"\t\tmips32-\u003efp_imp \u003d fp_imp;"},{"line_number":829,"context_line":"\t\treturn ERROR_OK;"},{"line_number":830,"context_line":"\t}"},{"line_number":831,"context_line":"\tuint32_t status_value;"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"7b3ef18d_56fe2ee7","line":828,"updated":"2023-10-30 08:57:50.000000000","message":"mips32-\u003efp_imp \u003d MIPS32_FP_IMP_NONE; ?","commit_id":"3c271d9fdca31a2a6ce7d1f85b4e59ca3bac8c35"},{"author":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"change_message_id":"a4c875dafa2a4bda58aee1af6f06ffa39b59e5ca","unresolved":false,"context_lines":[{"line_number":825,"context_line":"\tchar buf[60] \u003d {0};"},{"line_number":826,"context_line":"\tif (!fp_imp) {"},{"line_number":827,"context_line":"\t\tLOG_USER(\"FPU implemented: %s\", \"no\");"},{"line_number":828,"context_line":"\t\tmips32-\u003efp_imp \u003d fp_imp;"},{"line_number":829,"context_line":"\t\treturn ERROR_OK;"},{"line_number":830,"context_line":"\t}"},{"line_number":831,"context_line":"\tuint32_t status_value;"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"5a5dd43f_b0753e84","line":828,"in_reply_to":"7b3ef18d_56fe2ee7","updated":"2023-11-02 09:27:49.000000000","message":"Sorry for the unclear assign, yes it should be `MIPS32_FP_IMP_NONE`, it was written that way is because of when the condition is met, `fp_imp` is 0 which is the same as `MIPS32_FP_IMP_NONE`. I have changed this to the enum value.","commit_id":"3c271d9fdca31a2a6ce7d1f85b4e59ca3bac8c35"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"8871e7b732c707b35b148313afa7594681e91a09","unresolved":true,"context_lines":[{"line_number":841,"context_line":"\tstatus_cu1 \u003d (status_value \u003e\u003e MIPS32_CP0_STATUS_CU1_SHIFT) \u0026 0x1;"},{"line_number":842,"context_line":"\tif (status_cu1) {"},{"line_number":843,"context_line":"\t\tsnprintf(buf, sizeof(buf), \"yes\");"},{"line_number":844,"context_line":"\t\tfp_imp \u003d MIPS32_FP_IMP_NONE;"},{"line_number":845,"context_line":"\t} else {"},{"line_number":846,"context_line":"\t\tsnprintf(buf, sizeof(buf), \"yes, disabled\");"},{"line_number":847,"context_line":"\t\tfp_imp \u003d MIPS32_FP_IMP_UNKNOWN;"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"2378f4a2_288c8192","line":844,"updated":"2023-10-30 08:57:50.000000000","message":"It feels confusing. MIPS32_FP_IMP_NONE \u003d 0, so, it is same value for:\n- not present at all\n- present and enabled","commit_id":"3c271d9fdca31a2a6ce7d1f85b4e59ca3bac8c35"},{"author":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"change_message_id":"a4c875dafa2a4bda58aee1af6f06ffa39b59e5ca","unresolved":false,"context_lines":[{"line_number":841,"context_line":"\tstatus_cu1 \u003d (status_value \u003e\u003e MIPS32_CP0_STATUS_CU1_SHIFT) \u0026 0x1;"},{"line_number":842,"context_line":"\tif (status_cu1) {"},{"line_number":843,"context_line":"\t\tsnprintf(buf, sizeof(buf), \"yes\");"},{"line_number":844,"context_line":"\t\tfp_imp \u003d MIPS32_FP_IMP_NONE;"},{"line_number":845,"context_line":"\t} else {"},{"line_number":846,"context_line":"\t\tsnprintf(buf, sizeof(buf), \"yes, disabled\");"},{"line_number":847,"context_line":"\t\tfp_imp \u003d MIPS32_FP_IMP_UNKNOWN;"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"4c2b5f10_cabd08b2","line":844,"in_reply_to":"2378f4a2_288c8192","updated":"2023-11-02 09:27:49.000000000","message":"I am setting this to 32 bit temporarily, with a todo for explaining the reason. The patch for reading FPU(cp1) config registers is coming later in this patch chain, and the operating mode is determined from FPU Implementation Register(FIR register, cp1, reg0) and this part will be corrected in that patch.","commit_id":"3c271d9fdca31a2a6ce7d1f85b4e59ca3bac8c35"}]}