)]}'
{"id":"openocd~master~I7c1de68d33f6b3ed627cbb1e2401d43185e4c1e3","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2023-11-05 20:21:57.000000000","reason":"\u003cGERRIT_ACCOUNT_1000021\u003e replied on the change","reason_account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}},"1001992":{"account":{"_account_id":1001992,"name":"Peter Collingbourne","email":"pcc@google.com","username":"pcc"},"last_update":"2023-11-18 11:20:56.000000000","reason":"Change was submitted"},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2023-11-18 11:20:56.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I7c1de68d33f6b3ed627cbb1e2401d43185e4c1e3","subject":"openocd: src/target: Correctly handle CCSIDR_EL1.Associativity\u003d0","status":"MERGED","created":"2023-09-28 00:12:16.000000000","updated":"2023-11-18 11:20:56.000000000","submitted":"2023-11-18 11:20:56.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7916","meta_rev_id":"7df6761236fe1b21affa77bdc75db88d9c373aa5","_number":7916,"owner":{"_account_id":1001992,"name":"Peter Collingbourne","email":"pcc@google.com","username":"pcc"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-11-18 11:20:56.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-11-18 11:20:56.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-09-28 00:14:30.000000000","updated_by":{"_account_id":1001992,"name":"Peter Collingbourne","email":"pcc@google.com","username":"pcc"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"},{"updated":"2023-09-28 00:14:30.000000000","updated_by":{"_account_id":1001992,"name":"Peter Collingbourne","email":"pcc@google.com","username":"pcc"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"},{"updated":"2023-09-28 00:28:12.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"7022d906d2ac2d3d3b1b50444016df120bf3837e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001992,"name":"Peter Collingbourne","email":"pcc@google.com","username":"pcc"},"real_author":{"_account_id":1001992,"name":"Peter Collingbourne","email":"pcc@google.com","username":"pcc"},"date":"2023-09-28 00:12:16.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"4b93415ac54e40d5d6af00890794689c12d34b43","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-09-28 00:28:12.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/18470/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/17657/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"5b4b6c43acb59d5c7089a42c9d7cd28a34e9689c","author":{"_account_id":1001992,"name":"Peter Collingbourne","email":"pcc@google.com","username":"pcc"},"real_author":{"_account_id":1001992,"name":"Peter Collingbourne","email":"pcc@google.com","username":"pcc"},"date":"2023-10-18 17:07:50.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"5c458e3ad641330347ce12a12b767ffa4fc14aa3","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-11-05 20:21:57.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"895671a202811a4345621f6c263c3d91d21bbb68","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-11-18 11:20:40.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"7df6761236fe1b21affa77bdc75db88d9c373aa5","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-11-18 11:20:56.000000000","message":"Change has been successfully cherry-picked as ee96a95d44322aa109847e35b86aed5ad3066cf8","accounts_in_message":[],"_revision_number":2}],"current_revision":"ee96a95d44322aa109847e35b86aed5ad3066cf8","revisions":{"1f1d5a40676ee7a12ba962e1dc774988e9b5b4d0":{"kind":"REWORK","_number":1,"created":"2023-09-28 00:12:16.000000000","uploader":{"_account_id":1001992,"name":"Peter Collingbourne","email":"pcc@google.com","username":"pcc"},"ref":"refs/changes/16/7916/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/16/7916/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/16/7916/1 \u0026\u0026 git checkout -b change-7916 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/16/7916/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/16/7916/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/16/7916/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/16/7916/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/16/7916/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"21f17260d438704deb1591777222e542efb8383d","subject":"jtag/drivers/bcm2835gpio: fix bcm2835_peri_base output format"}],"author":{"name":"Peter Collingbourne","email":"pcc@google.com","date":"2023-09-28 00:02:03.000000000","tz":-420},"committer":{"name":"Peter Collingbourne","email":"pcc@google.com","date":"2023-09-28 00:12:08.000000000","tz":-420},"subject":"openocd: src/target: Correctly handle CCSIDR_EL1.Associativity\u003d0","message":"openocd: src/target: Correctly handle CCSIDR_EL1.Associativity\u003d0\n\nAssociativity\u003d0 means that only one CMO is needed for all ways.\nIt could also mean that the cache is 1-way, but this is less likely.\n\nCurrently Associativity\u003d0 causes us to hang in the while loop in\ndecode_cache_reg. Fix it by skipping the loop in this case. We can let\nway_shift be set to the arbitrary value of 0 because in the case where\nAssociativity\u003d0 we only ever shift 0 by it before ORing it into the\nCMO operand.\n\nChange-Id: I7c1de68d33f6b3ed627cbb1e2401d43185e4c1e3\nSigned-off-by: Peter Collingbourne \u003cpcc@google.com\u003e\n"}},"ee96a95d44322aa109847e35b86aed5ad3066cf8":{"kind":"REWORK","_number":2,"created":"2023-11-18 11:20:56.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/16/7916/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/16/7916/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/16/7916/2 \u0026\u0026 git checkout -b change-7916 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/16/7916/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/16/7916/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/16/7916/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/16/7916/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/16/7916/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"851d1ad87a6e9f1ae1b44b8ac395138031290488","subject":"breakpoints: Add target logging to breakpoints and watchpoints"}],"author":{"name":"Peter Collingbourne","email":"pcc@google.com","date":"2023-09-28 00:02:03.000000000","tz":-420},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-11-18 11:20:56.000000000","tz":0},"subject":"openocd: src/target: Correctly handle CCSIDR_EL1.Associativity\u003d0","message":"openocd: src/target: Correctly handle CCSIDR_EL1.Associativity\u003d0\n\nAssociativity\u003d0 means that only one CMO is needed for all ways.\nIt could also mean that the cache is 1-way, but this is less likely.\n\nCurrently Associativity\u003d0 causes us to hang in the while loop in\ndecode_cache_reg. Fix it by skipping the loop in this case. We can let\nway_shift be set to the arbitrary value of 0 because in the case where\nAssociativity\u003d0 we only ever shift 0 by it before ORing it into the\nCMO operand.\n\nChange-Id: I7c1de68d33f6b3ed627cbb1e2401d43185e4c1e3\nSigned-off-by: Peter Collingbourne \u003cpcc@google.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7916\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}