)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1002152,"name":"Kirill Radkin","email":"kirill.radkin@syntacore.com","username":"kr-sc"},"change_message_id":"db1a5c3f625837f2c5caa60773d53a607219a9d7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cceb8405_33a48072","updated":"2023-10-03 11:12:20.000000000","message":"Recently I faced with issue with unstable connection between OpenOCD and GDB and the only error message that I could see was: \"attempted \u0027gdb\u0027 connection rejected\". So I think we need this to clarify such situations.","commit_id":"8978826b86329da5a3035b15c8c028eda2c0a486"},{"author":{"_account_id":1002152,"name":"Kirill Radkin","email":"kirill.radkin@syntacore.com","username":"kr-sc"},"change_message_id":"73291ea677084cc6ce4f0cf9f8d4f9e8724ccf82","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"158aebc2_b5f6c581","updated":"2023-11-14 08:20:41.000000000","message":"Antonio, can you please take a look here?","commit_id":"8691a3f83149c5ebe887d486110a01a9001a4ec3"},{"author":{"_account_id":1002152,"name":"Kirill Radkin","email":"kirill.radkin@syntacore.com","username":"kr-sc"},"change_message_id":"e2a2b87686b53bd9527a7b88eb915f83d25167ec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7897fb77_6151304d","updated":"2024-02-01 11:12:12.000000000","message":"Gentle ping.","commit_id":"8691a3f83149c5ebe887d486110a01a9001a4ec3"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"66f15526a0bc8874ae091d4bbcc449aba0f22e46","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f2c32696_a4afa585","updated":"2024-02-18 18:31:24.000000000","message":"Sorry for seeing this so late.","commit_id":"8691a3f83149c5ebe887d486110a01a9001a4ec3"},{"author":{"_account_id":1002152,"name":"Kirill Radkin","email":"kirill.radkin@syntacore.com","username":"kr-sc"},"change_message_id":"6d9b80ecdedbcc8cfc9eebc7141b48d887e03c0b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"aea22764_4d1e535f","in_reply_to":"158aebc2_b5f6c581","updated":"2023-11-27 09:52:38.000000000","message":"ping","commit_id":"8691a3f83149c5ebe887d486110a01a9001a4ec3"}],"src/server/gdb_server.c":[{"author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"change_message_id":"a7e6d0d043704d4a32550528ad83cb284e318fb9","unresolved":true,"context_lines":[{"line_number":997,"context_line":"\t/* send ACK to GDB for debug request */"},{"line_number":998,"context_line":"\tretval \u003d gdb_write(connection, \"+\", 1);"},{"line_number":999,"context_line":"\tif (retval !\u003d ERROR_OK) {"},{"line_number":1000,"context_line":"\t\tLOG_ERROR(\"Could not send GDB Ack packet. gdb_write() error: %d\", retval);"},{"line_number":1001,"context_line":"\t\treturn retval;"},{"line_number":1002,"context_line":"\t}"},{"line_number":1003,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":2,"id":"48b9d520_4c790283","line":1000,"updated":"2023-10-09 14:36:12.000000000","message":"I\u0027d propose this wording:\n\nFailed to send the first GDB ACK packet. gdb_write() error: %d","commit_id":"00a392c0e9f764cfe1a4a1084b7dc7dccfb31cc2"},{"author":{"_account_id":1002152,"name":"Kirill Radkin","email":"kirill.radkin@syntacore.com","username":"kr-sc"},"change_message_id":"7dae3c8f64537b20081f348bd34c49e81bfea2aa","unresolved":true,"context_lines":[{"line_number":997,"context_line":"\t/* send ACK to GDB for debug request */"},{"line_number":998,"context_line":"\tretval \u003d gdb_write(connection, \"+\", 1);"},{"line_number":999,"context_line":"\tif (retval !\u003d ERROR_OK) {"},{"line_number":1000,"context_line":"\t\tLOG_ERROR(\"Could not send GDB Ack packet. gdb_write() error: %d\", retval);"},{"line_number":1001,"context_line":"\t\treturn retval;"},{"line_number":1002,"context_line":"\t}"},{"line_number":1003,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":2,"id":"6b718d8f_b9493e8a","line":1000,"in_reply_to":"48b9d520_4c790283","updated":"2023-10-10 13:46:29.000000000","message":"Done","commit_id":"00a392c0e9f764cfe1a4a1084b7dc7dccfb31cc2"},{"author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"change_message_id":"de934a7ee31cd3fbfc647403b7dc029a21e10298","unresolved":false,"context_lines":[{"line_number":997,"context_line":"\t/* send ACK to GDB for debug request */"},{"line_number":998,"context_line":"\tretval \u003d gdb_write(connection, \"+\", 1);"},{"line_number":999,"context_line":"\tif (retval !\u003d ERROR_OK) {"},{"line_number":1000,"context_line":"\t\tLOG_ERROR(\"Could not send GDB Ack packet. gdb_write() error: %d\", retval);"},{"line_number":1001,"context_line":"\t\treturn retval;"},{"line_number":1002,"context_line":"\t}"},{"line_number":1003,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":2,"id":"7ae4be5f_5da7f1ca","line":1000,"in_reply_to":"6b718d8f_b9493e8a","updated":"2023-10-10 14:59:50.000000000","message":"Done","commit_id":"00a392c0e9f764cfe1a4a1084b7dc7dccfb31cc2"},{"author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"change_message_id":"a7e6d0d043704d4a32550528ad83cb284e318fb9","unresolved":true,"context_lines":[{"line_number":999,"context_line":"\tif (retval !\u003d ERROR_OK) {"},{"line_number":1000,"context_line":"\t\tLOG_ERROR(\"Could not send GDB Ack packet. gdb_write() error: %d\", retval);"},{"line_number":1001,"context_line":"\t\treturn retval;"},{"line_number":1002,"context_line":"\t}"},{"line_number":1003,"context_line":""},{"line_number":1004,"context_line":"\t/* output goes through gdb connection */"},{"line_number":1005,"context_line":"\tcommand_set_output_handler(connection-\u003ecmd_ctx, gdb_output, connection);"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"b5ee21cd_480cc709","line":1002,"updated":"2023-10-09 14:36:12.000000000","message":"Side note about sending this first ACK character:\n\nWe believe that sending the initial ACK is not needed and in some cases it is actually even harmful (!). In past, on a slower network connection, we had encountered a situation where LLDB, due to the network delay, thought that this extra ACK is a response for its first real message, which then lead to incorrect request-response pairing for the remainder of the session, and the session collapsed for that reason shortly after. \n\nWe need to investigate and double-check this case a bit more, and once confirmed, we will submit a patch that completely removes the sending of this first (unsolicited) ACK.\n\nThis is just an FYI. No need to change anything in this merge request.","commit_id":"00a392c0e9f764cfe1a4a1084b7dc7dccfb31cc2"},{"author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"change_message_id":"b796f0dddb1ba266943b1520873844e795618643","unresolved":false,"context_lines":[{"line_number":999,"context_line":"\tif (retval !\u003d ERROR_OK) {"},{"line_number":1000,"context_line":"\t\tLOG_ERROR(\"Could not send GDB Ack packet. gdb_write() error: %d\", retval);"},{"line_number":1001,"context_line":"\t\treturn retval;"},{"line_number":1002,"context_line":"\t}"},{"line_number":1003,"context_line":""},{"line_number":1004,"context_line":"\t/* output goes through gdb connection */"},{"line_number":1005,"context_line":"\tcommand_set_output_handler(connection-\u003ecmd_ctx, gdb_output, connection);"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"8d927341_7380881e","line":1002,"in_reply_to":"ad159e89_812d2e59","updated":"2023-10-10 05:38:39.000000000","message":"Thank you for the pointer to the existing (unmerged) merge request! We will do the remainder of our investigation, and if all checks out, we will support that merge request.","commit_id":"00a392c0e9f764cfe1a4a1084b7dc7dccfb31cc2"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"7ef75f86b6077178b02a7c4e8a972283b46b9de0","unresolved":true,"context_lines":[{"line_number":999,"context_line":"\tif (retval !\u003d ERROR_OK) {"},{"line_number":1000,"context_line":"\t\tLOG_ERROR(\"Could not send GDB Ack packet. gdb_write() error: %d\", retval);"},{"line_number":1001,"context_line":"\t\treturn retval;"},{"line_number":1002,"context_line":"\t}"},{"line_number":1003,"context_line":""},{"line_number":1004,"context_line":"\t/* output goes through gdb connection */"},{"line_number":1005,"context_line":"\tcommand_set_output_handler(connection-\u003ecmd_ctx, gdb_output, connection);"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"ad159e89_812d2e59","line":1002,"in_reply_to":"b5ee21cd_480cc709","updated":"2023-10-09 15:36:04.000000000","message":"You can check this old commit about the ACK\nhttps://review.openocd.org/c/openocd/+/6768","commit_id":"00a392c0e9f764cfe1a4a1084b7dc7dccfb31cc2"},{"author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"change_message_id":"a7e6d0d043704d4a32550528ad83cb284e318fb9","unresolved":true,"context_lines":[{"line_number":1019,"context_line":"\t */"},{"line_number":1020,"context_line":"\tretval \u003d gdb_get_char(connection, \u0026initial_ack);"},{"line_number":1021,"context_line":"\tif (retval !\u003d ERROR_OK) {"},{"line_number":1022,"context_line":"\t\tLOG_ERROR(\"Could not receive GDB Ack packet. gdb_get_char() error: %d\", retval);"},{"line_number":1023,"context_line":"\t\treturn retval;"},{"line_number":1024,"context_line":"\t}"},{"line_number":1025,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":2,"id":"4f3bb3d0_891c9861","line":1022,"updated":"2023-10-09 14:36:12.000000000","message":"I\u0027d propose this wording:\n\nFailed when trying to received the iniial ACK packet from GDB. ggdb_get_char() error: %d","commit_id":"00a392c0e9f764cfe1a4a1084b7dc7dccfb31cc2"},{"author":{"_account_id":1002152,"name":"Kirill Radkin","email":"kirill.radkin@syntacore.com","username":"kr-sc"},"change_message_id":"7dae3c8f64537b20081f348bd34c49e81bfea2aa","unresolved":true,"context_lines":[{"line_number":1019,"context_line":"\t */"},{"line_number":1020,"context_line":"\tretval \u003d gdb_get_char(connection, \u0026initial_ack);"},{"line_number":1021,"context_line":"\tif (retval !\u003d ERROR_OK) {"},{"line_number":1022,"context_line":"\t\tLOG_ERROR(\"Could not receive GDB Ack packet. gdb_get_char() error: %d\", retval);"},{"line_number":1023,"context_line":"\t\treturn retval;"},{"line_number":1024,"context_line":"\t}"},{"line_number":1025,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":2,"id":"e3f2b5c8_c2a7903a","line":1022,"in_reply_to":"034b54b5_11031124","updated":"2023-10-10 13:46:29.000000000","message":"Done","commit_id":"00a392c0e9f764cfe1a4a1084b7dc7dccfb31cc2"},{"author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"change_message_id":"cd0b633e19d34451dfa0a0b9980e4d3e36d62e96","unresolved":true,"context_lines":[{"line_number":1019,"context_line":"\t */"},{"line_number":1020,"context_line":"\tretval \u003d gdb_get_char(connection, \u0026initial_ack);"},{"line_number":1021,"context_line":"\tif (retval !\u003d ERROR_OK) {"},{"line_number":1022,"context_line":"\t\tLOG_ERROR(\"Could not receive GDB Ack packet. gdb_get_char() error: %d\", retval);"},{"line_number":1023,"context_line":"\t\treturn retval;"},{"line_number":1024,"context_line":"\t}"},{"line_number":1025,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":2,"id":"034b54b5_11031124","line":1022,"in_reply_to":"4f3bb3d0_891c9861","updated":"2023-10-09 14:37:44.000000000","message":"Sorry for my typos. Corrected:\n\nFailed when trying to received the initial ACK packet from GDB. gdb_get_char() error: %d","commit_id":"00a392c0e9f764cfe1a4a1084b7dc7dccfb31cc2"},{"author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"change_message_id":"de934a7ee31cd3fbfc647403b7dc029a21e10298","unresolved":false,"context_lines":[{"line_number":1019,"context_line":"\t */"},{"line_number":1020,"context_line":"\tretval \u003d gdb_get_char(connection, \u0026initial_ack);"},{"line_number":1021,"context_line":"\tif (retval !\u003d ERROR_OK) {"},{"line_number":1022,"context_line":"\t\tLOG_ERROR(\"Could not receive GDB Ack packet. gdb_get_char() error: %d\", retval);"},{"line_number":1023,"context_line":"\t\treturn retval;"},{"line_number":1024,"context_line":"\t}"},{"line_number":1025,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":2,"id":"40e5b703_cc5eaa03","line":1022,"in_reply_to":"e3f2b5c8_c2a7903a","updated":"2023-10-10 14:59:50.000000000","message":"Done","commit_id":"00a392c0e9f764cfe1a4a1084b7dc7dccfb31cc2"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"66f15526a0bc8874ae091d4bbcc449aba0f22e46","unresolved":true,"context_lines":[{"line_number":995,"context_line":"\tgdb_connection-\u003eoutput_flag \u003d GDB_OUTPUT_NO;"},{"line_number":996,"context_line":""},{"line_number":997,"context_line":"\t/* send ACK to GDB for debug request */"},{"line_number":998,"context_line":"\tretval \u003d gdb_write(connection, \"+\", 1);"},{"line_number":999,"context_line":"\tif (retval !\u003d ERROR_OK) {"},{"line_number":1000,"context_line":"\t\tLOG_ERROR(\"Failed to send the first GDB ACK packet. gdb_write() error: %d\", retval);"},{"line_number":1001,"context_line":"\t\treturn retval;"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"ad03b2f2_aedaf095","line":998,"updated":"2024-02-18 18:31:24.000000000","message":"Humm, this suddenly remembers me about this old patch from me\nhttps://review.openocd.org/c/openocd/+/6768\nI want to recover that old series\nWould you mind re-posting your patch without this part, so we can merge this and 6768 in any order?","commit_id":"8691a3f83149c5ebe887d486110a01a9001a4ec3"},{"author":{"_account_id":1002152,"name":"Kirill Radkin","email":"kirill.radkin@syntacore.com","username":"kr-sc"},"change_message_id":"2ad553f86370cd1f099458ce93984bd588da4033","unresolved":true,"context_lines":[{"line_number":995,"context_line":"\tgdb_connection-\u003eoutput_flag \u003d GDB_OUTPUT_NO;"},{"line_number":996,"context_line":""},{"line_number":997,"context_line":"\t/* send ACK to GDB for debug request */"},{"line_number":998,"context_line":"\tretval \u003d gdb_write(connection, \"+\", 1);"},{"line_number":999,"context_line":"\tif (retval !\u003d ERROR_OK) {"},{"line_number":1000,"context_line":"\t\tLOG_ERROR(\"Failed to send the first GDB ACK packet. gdb_write() error: %d\", retval);"},{"line_number":1001,"context_line":"\t\treturn retval;"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"1bf5a06e_2e46b022","line":998,"in_reply_to":"ad03b2f2_aedaf095","updated":"2024-02-21 10:56:32.000000000","message":"Addressed","commit_id":"8691a3f83149c5ebe887d486110a01a9001a4ec3"}]}