)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"4350b2b2b33fc29cfccd15020ae42bdbfda6da91","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"aed6041a_d546cb5c","updated":"2023-10-14 15:48:34.000000000","message":"Thanks, well spotted.\nDo you think you could extend the fix as I suggest below?","commit_id":"228ce4ad4859123b760a47c0b32c7cd6cd10b0c6"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"8218fdb9f1fba8ff19283d613985fab36f43d5f2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"bd64b8a9_7357eeef","updated":"2023-11-04 15:38:04.000000000","message":"Thanks!","commit_id":"4776ec065e652a4fafa7add0331e9a66d517c6ef"}],"src/target/image.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"4350b2b2b33fc29cfccd15020ae42bdbfda6da91","unresolved":true,"context_lines":[{"line_number":989,"context_line":"\t} else if (image-\u003etype \u003d\u003d IMAGE_IHEX) {"},{"line_number":990,"context_line":"\t\tstruct image_ihex *image_ihex;"},{"line_number":991,"context_line":""},{"line_number":992,"context_line":"\t\timage_ihex \u003d image-\u003etype_private \u003d malloc(sizeof(struct image_ihex));"},{"line_number":993,"context_line":""},{"line_number":994,"context_line":"\t\tretval \u003d fileio_open(\u0026image_ihex-\u003efileio, url, FILEIO_READ, FILEIO_TEXT);"},{"line_number":995,"context_line":"\t\tif (retval !\u003d ERROR_OK)"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"50e98b99_9170158a","line":992,"updated":"2023-10-14 15:48:34.000000000","message":"I see that the memory leak is not only for image-\u003etype\u003d\u003dIMAGE_BINARY, but it\u0027s a generic problem of this function.\nTo avoid replicating the fix everywhere I suggest you to add, at the end of this function a label:\n\nerror_free_mem:\nfree(image-\u003etype_private);\nimage-\u003etype_private \u003d NULL;\nreturn retval;\n\nand put when needed:\n\ngoto error_free_mem;","commit_id":"228ce4ad4859123b760a47c0b32c7cd6cd10b0c6"},{"author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"change_message_id":"f5f8061ef8a59ece7de35d5c0e81db7582c88f87","unresolved":true,"context_lines":[{"line_number":989,"context_line":"\t} else if (image-\u003etype \u003d\u003d IMAGE_IHEX) {"},{"line_number":990,"context_line":"\t\tstruct image_ihex *image_ihex;"},{"line_number":991,"context_line":""},{"line_number":992,"context_line":"\t\timage_ihex \u003d image-\u003etype_private \u003d malloc(sizeof(struct image_ihex));"},{"line_number":993,"context_line":""},{"line_number":994,"context_line":"\t\tretval \u003d fileio_open(\u0026image_ihex-\u003efileio, url, FILEIO_READ, FILEIO_TEXT);"},{"line_number":995,"context_line":"\t\tif (retval !\u003d ERROR_OK)"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"ebf3929c_3bf19b1c","line":992,"in_reply_to":"50e98b99_9170158a","updated":"2023-10-17 09:03:52.000000000","message":"Thanks for the great suggestion! Addressed.","commit_id":"228ce4ad4859123b760a47c0b32c7cd6cd10b0c6"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"8218fdb9f1fba8ff19283d613985fab36f43d5f2","unresolved":false,"context_lines":[{"line_number":989,"context_line":"\t} else if (image-\u003etype \u003d\u003d IMAGE_IHEX) {"},{"line_number":990,"context_line":"\t\tstruct image_ihex *image_ihex;"},{"line_number":991,"context_line":""},{"line_number":992,"context_line":"\t\timage_ihex \u003d image-\u003etype_private \u003d malloc(sizeof(struct image_ihex));"},{"line_number":993,"context_line":""},{"line_number":994,"context_line":"\t\tretval \u003d fileio_open(\u0026image_ihex-\u003efileio, url, FILEIO_READ, FILEIO_TEXT);"},{"line_number":995,"context_line":"\t\tif (retval !\u003d ERROR_OK)"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"a88bf3c7_ccfc2fb1","line":992,"in_reply_to":"b9bffdc7_bd821222","updated":"2023-11-04 15:38:04.000000000","message":"Done","commit_id":"228ce4ad4859123b760a47c0b32c7cd6cd10b0c6"},{"author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"change_message_id":"e70a149c27852f162317567e110e775748d62368","unresolved":true,"context_lines":[{"line_number":989,"context_line":"\t} else if (image-\u003etype \u003d\u003d IMAGE_IHEX) {"},{"line_number":990,"context_line":"\t\tstruct image_ihex *image_ihex;"},{"line_number":991,"context_line":""},{"line_number":992,"context_line":"\t\timage_ihex \u003d image-\u003etype_private \u003d malloc(sizeof(struct image_ihex));"},{"line_number":993,"context_line":""},{"line_number":994,"context_line":"\t\tretval \u003d fileio_open(\u0026image_ihex-\u003efileio, url, FILEIO_READ, FILEIO_TEXT);"},{"line_number":995,"context_line":"\t\tif (retval !\u003d ERROR_OK)"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"b9bffdc7_bd821222","line":992,"in_reply_to":"ebf3929c_3bf19b1c","updated":"2023-10-25 09:14:58.000000000","message":"Antonio, could you please review the fix?","commit_id":"228ce4ad4859123b760a47c0b32c7cd6cd10b0c6"}]}