)]}'
{"id":"openocd~master~I6143d48f7efd765b7752a12fdc337da3496d896f","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000853":{"account":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"last_update":"2023-11-18 11:16:53.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I6143d48f7efd765b7752a12fdc337da3496d896f","subject":"target: Remove break/watchpoints in target_destroy()","status":"MERGED","created":"2023-11-01 08:37:32.000000000","updated":"2023-11-18 11:16:53.000000000","submitted":"2023-11-18 11:16:53.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7956","meta_rev_id":"1248a46b3c7b49b1ab44237110a5b1c7cb701f0d","_number":7956,"owner":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-11-18 11:16:53.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-11-18 11:16:53.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-11-18 11:16:53.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-11-18 11:16:53.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-11-01 09:03:17.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-11-01 15:36:11.000000000","updated_by":{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"},"reviewer":{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"},"state":"REVIEWER"},{"updated":"2023-11-05 17:47:42.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"},{"updated":"2023-11-07 10:52:06.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"}],"messages":[{"id":"d1164bad187aa1a78eab73c77288ed780605f31f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2023-11-01 08:37:32.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"6cb8f571f0368460c5b338ccb44e54f5d11fc1aa","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-11-01 09:03:17.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/18635/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/17820/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"68516123e5c737d28b05ae7325f852046ce4cff8","author":{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"},"real_author":{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"},"date":"2023-11-01 15:36:11.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"f31664fe9875230d0f901cd571429651f6e291eb","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-11-05 17:47:42.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"d783341fa7282a46ce19708c3d4d4252cb99712b","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-11-07 10:52:06.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"1248a46b3c7b49b1ab44237110a5b1c7cb701f0d","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-11-18 11:16:53.000000000","message":"Change has been successfully cherry-picked as 3862e07688ea68298841891145deddd226c3c7e5","accounts_in_message":[],"_revision_number":2}],"current_revision":"3862e07688ea68298841891145deddd226c3c7e5","revisions":{"3862e07688ea68298841891145deddd226c3c7e5":{"kind":"REWORK","_number":2,"created":"2023-11-18 11:16:53.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/56/7956/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/56/7956/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/56/7956/2 \u0026\u0026 git checkout -b change-7956 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/56/7956/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/56/7956/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/56/7956/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/56/7956/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/56/7956/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d4575b647a3603200a9bb4a784d170f792ab88d0","subject":"target: fix segmentation fault on target create"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2023-11-01 08:27:05.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-11-18 11:16:53.000000000","tz":0},"subject":"target: Remove break/watchpoints in target_destroy()","message":"target: Remove break/watchpoints in target_destroy()\n\nBreak- and watchpoints are not removed when a target is destroyed\nwhich introduces a memory leak.\n\nChange-Id: I6143d48f7efd765b7752a12fdc337da3496d896f\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7956\nReviewed-by: Marek Vrbka \u003cmarek.vrbka@codasip.com\u003e\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"0e2cc521bbdda371e7ef7dbb4ff4fd405b514766":{"kind":"REWORK","_number":1,"created":"2023-11-01 08:37:32.000000000","uploader":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"ref":"refs/changes/56/7956/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/56/7956/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/56/7956/1 \u0026\u0026 git checkout -b change-7956 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/56/7956/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/56/7956/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/56/7956/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/56/7956/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/56/7956/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b388f4805c3ce6e0b7ce7e5995c9305529db8e46","subject":"OpenOCD memory leak in `hwthread_update_threads()`"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2023-11-01 08:27:05.000000000","tz":60},"committer":{"name":"Marc Schink","email":"dev@zapb.de","date":"2023-11-01 08:35:20.000000000","tz":60},"subject":"target: Remove break/watchpoints in target_destroy()","message":"target: Remove break/watchpoints in target_destroy()\n\nBreak- and watchpoints are not removed when a target is destroyed\nwhich introduces a memory leak.\n\nChange-Id: I6143d48f7efd765b7752a12fdc337da3496d896f\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}
