)]}'
{"id":"openocd~master~I9796a7e92196ef3df5c7152b27c34102045dc9e7","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2023-11-18 11:16:27.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I9796a7e92196ef3df5c7152b27c34102045dc9e7","subject":"target: fix segmentation fault on target create","status":"MERGED","created":"2023-11-05 16:08:48.000000000","updated":"2023-11-18 11:16:27.000000000","submitted":"2023-11-18 11:16:27.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7962","meta_rev_id":"45e4a2004154b3c03e875b9ba85aca02a1a19aa0","_number":7962,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-11-18 11:16:27.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-11-18 11:16:27.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-11-18 11:16:27.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-11-05 16:22:21.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-11-07 10:23:16.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"}],"messages":[{"id":"3304a83dff511bee358c85eff5e431ef91c482c9","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-11-05 16:08:48.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"315c6000c410a17bdeaf4769cfdf130a9ed0a15b","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-11-05 16:22:21.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/18671/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/17855/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"4ba0cfeb27e32a74bc7d7e6d1fc6711f8ba23052","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-11-05 17:21:05.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"62f9be0ee5f0453dd3b22dcb5aba0f20106d80f6","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-11-07 10:23:16.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"45e4a2004154b3c03e875b9ba85aca02a1a19aa0","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-11-18 11:16:27.000000000","message":"Change has been successfully cherry-picked as d4575b647a3603200a9bb4a784d170f792ab88d0","accounts_in_message":[],"_revision_number":2}],"current_revision":"d4575b647a3603200a9bb4a784d170f792ab88d0","revisions":{"168abeaad625fa75dbba294f83251237b8b82101":{"kind":"REWORK","_number":1,"created":"2023-11-05 16:08:48.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/62/7962/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/62/7962/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/62/7962/1 \u0026\u0026 git checkout -b change-7962 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/62/7962/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/62/7962/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/62/7962/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/62/7962/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/62/7962/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b388f4805c3ce6e0b7ce7e5995c9305529db8e46","subject":"OpenOCD memory leak in `hwthread_update_threads()`"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-11-05 16:02:26.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-11-05 16:07:02.000000000","tz":60},"subject":"target: fix segmentation fault on target create","message":"target: fix segmentation fault on target create\n\nIn the unusual (and even incorrect) case of running the command\ntarget create ...\nbefore defining an adapter and the associated transport, the\ncommand causes a segmentation fault. E.g.:\n\topenocd -c \u0027target create cpu cortex-m -endian little\u0027\n\nCheck that get_current_transport() returns a valid pointer before\nreferencing it.\n\nChange-Id: I9796a7e92196ef3df5c7152b27c34102045dc9e7\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"d4575b647a3603200a9bb4a784d170f792ab88d0":{"kind":"REWORK","_number":2,"created":"2023-11-18 11:16:27.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/62/7962/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/62/7962/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/62/7962/2 \u0026\u0026 git checkout -b change-7962 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/62/7962/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/62/7962/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/62/7962/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/62/7962/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/62/7962/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b39072f2ef72f02601b40931d3a38c465804a906","subject":"target: use boolean values for \u0027valid\u0027 and \u0027dirty\u0027 flags"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-11-05 16:02:26.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-11-18 11:16:27.000000000","tz":0},"subject":"target: fix segmentation fault on target create","message":"target: fix segmentation fault on target create\n\nIn the unusual (and even incorrect) case of running the command\ntarget create ...\nbefore defining an adapter and the associated transport, the\ncommand causes a segmentation fault. E.g.:\n\topenocd -c \u0027target create cpu cortex-m -endian little\u0027\n\nCheck that get_current_transport() returns a valid pointer before\nreferencing it.\n\nChange-Id: I9796a7e92196ef3df5c7152b27c34102045dc9e7\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7962\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nTested-by: jenkins\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}