)]}'
{"id":"openocd~master~I971a579014c1eaf13b1932f7fa87c020a8eba69c","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000853":{"account":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"last_update":"2023-11-18 11:31:41.000000000","reason":"Change was submitted"},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2023-11-12 20:18:24.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I971a579014c1eaf13b1932f7fa87c020a8eba69c","subject":"jtag/drivers/jtag_vpi: Remove redundant error messages","status":"MERGED","created":"2023-11-09 09:45:57.000000000","updated":"2023-11-18 11:31:41.000000000","submitted":"2023-11-18 11:31:41.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7971","meta_rev_id":"26775595b0e250c48cfa5d8da45980ac329a64ee","_number":7971,"owner":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-11-18 11:31:41.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-11-18 11:31:41.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-11-18 11:31:41.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-11-09 10:16:55.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-11-09 20:02:58.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"},{"updated":"2023-11-12 17:53:13.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"565761a5284b701bf00f53b451dd36196b7f9f84","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2023-11-09 09:45:57.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"759bed3f973fdcd3b7b177d0e068e403d7a18ff7","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-11-09 10:16:55.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/18686/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/17870/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"f10083948a76746b7ecf7d868457553baa16240d","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-11-09 20:02:58.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"bcbb407d7ee2d941246047765dc60efa95047297","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2023-11-12 10:20:49.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.\n\nOutdated Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR is:MIN\")\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"c7eecae2d782dce1262a6839e0cf345a2ec606f5","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-11-12 11:44:15.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/18713/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/17900/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"495d7c09e21d572b21f385d0a24b743d8344b8d8","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-11-12 17:53:13.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"5b0308819a59e55fec53b6afc57f4d092fabb013","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-11-12 20:18:24.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"26775595b0e250c48cfa5d8da45980ac329a64ee","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-11-18 11:31:41.000000000","message":"Change has been successfully cherry-picked as dc0f79d45d4ea1fec9f31557478ef0d0cdba1d01","accounts_in_message":[],"_revision_number":3}],"current_revision":"dc0f79d45d4ea1fec9f31557478ef0d0cdba1d01","revisions":{"8c87f7d7bd2bc8bd82bf40f0f0b6757a1ad7c478":{"kind":"REWORK","_number":1,"created":"2023-11-09 09:45:57.000000000","uploader":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"ref":"refs/changes/71/7971/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/71/7971/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/71/7971/1 \u0026\u0026 git checkout -b change-7971 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/71/7971/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/71/7971/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/71/7971/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/71/7971/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/71/7971/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"202ba254214e19ef8874f71a6688616896b1d00a","subject":"jtag/drivers/ftdi: Use correct command error"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2023-11-09 09:12:51.000000000","tz":60},"committer":{"name":"Marc Schink","email":"dev@zapb.de","date":"2023-11-09 09:43:04.000000000","tz":60},"subject":"jtag/drivers/jtag_vpi: Remove redundant error messages","message":"jtag/drivers/jtag_vpi: Remove redundant error messages\n\nThe correct syntax is already suggested due to the return\nvalue used.\n\nChange-Id: I971a579014c1eaf13b1932f7fa87c020a8eba69c\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\n"}},"dc0f79d45d4ea1fec9f31557478ef0d0cdba1d01":{"kind":"REWORK","_number":3,"created":"2023-11-18 11:31:41.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/71/7971/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/71/7971/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/71/7971/3 \u0026\u0026 git checkout -b change-7971 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/71/7971/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/71/7971/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/71/7971/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/71/7971/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/71/7971/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"acc1717970d42344812542f72ab7b17349e71242","subject":"jtag/drivers/ftdi: Use correct command error"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2023-11-09 09:12:51.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-11-18 11:31:41.000000000","tz":0},"subject":"jtag/drivers/jtag_vpi: Remove redundant error messages","message":"jtag/drivers/jtag_vpi: Remove redundant error messages\n\nThe correct syntax is already suggested due to the return\nvalue used.\n\nChange-Id: I971a579014c1eaf13b1932f7fa87c020a8eba69c\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7971\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nTested-by: jenkins\n"}},"0b1db290e0da3ce2c290c9fd116e65db3b538790":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2023-11-12 10:20:49.000000000","uploader":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"ref":"refs/changes/71/7971/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/71/7971/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/71/7971/2 \u0026\u0026 git checkout -b change-7971 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/71/7971/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/71/7971/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/71/7971/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/71/7971/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/71/7971/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ee07c6e734dedc2cfdfb4909d299bd56fc69985d","subject":"jtag/drivers/ftdi: Use correct command error"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2023-11-09 09:12:51.000000000","tz":60},"committer":{"name":"Marc Schink","email":"dev@zapb.de","date":"2023-11-12 10:20:18.000000000","tz":60},"subject":"jtag/drivers/jtag_vpi: Remove redundant error messages","message":"jtag/drivers/jtag_vpi: Remove redundant error messages\n\nThe correct syntax is already suggested due to the return\nvalue used.\n\nChange-Id: I971a579014c1eaf13b1932f7fa87c020a8eba69c\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}
