)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"968e6a7c1a9b94820dff61acf1848a593a5ad2c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"396f03fc_ad2c377d","updated":"2023-10-26 19:45:28.000000000","message":"Changes are LGTM. Thanks @Ian","commit_id":"2db27311858d7db8bafbfca766184cccb5a75911"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"ca9a54aa900bdef793eacd40793543e60bcb9088","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"48673706_eaa6a908","updated":"2023-11-05 17:55:25.000000000","message":"The new function xtensa_dm_regaddr_to_id() is never used.\nI periodically scan the code to drop unreferenced symbols, so think about adding a user for it.","commit_id":"2db27311858d7db8bafbfca766184cccb5a75911"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"5d43fb2eb09586d36024b1e75687097824f293d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"95feeb7f_aa449c4b","updated":"2023-10-20 21:38:30.000000000","message":"Would very much appreciate your time to review these minor changes...thanks in advance.","commit_id":"2db27311858d7db8bafbfca766184cccb5a75911"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"34cdee6b49fc472bb2cd0d3ad512096dfa0ffaaa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b405cc05_638850c2","updated":"2023-11-09 17:53:53.000000000","message":"@antonio thanks for the suggestion.  I\u0027ve added a new pair of commands for reading and writing Xtensa Debug Module (DM) registers using the new translation function.  This will be helpful beyond this review as well, since it allows users to peek and poke DM state without having to halt the core.\n\nReady for review...thanks again.","commit_id":"3f38a117538afe4ee5b9ffe04fb55c5594ca1fdd"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"48516291087020dfe0e2619994aa8d62a99830b2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c694d82a_82f72465","updated":"2023-11-10 00:16:00.000000000","message":"Thanks for the suggestions...incorporated both.","commit_id":"3f38a117538afe4ee5b9ffe04fb55c5594ca1fdd"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"bad22353da4386cd113ec3a0598df432f54f9fd9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"bb605ea9_3af1c1da","updated":"2023-11-12 18:00:46.000000000","message":"Ian,\nI\u0027m OK with the code, but suddenly I realized that the new command \"xtensa dm\" should also be documented in doc/openocd.texi\nSorry for not noticing it earlier","commit_id":"c0f6bc6d40c5982b62697fd33bfc02f1333aceda"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"e7873921ebcf8a2f6de65d1f5b4c91418a21a656","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a5e2bc6a_93bd4c70","in_reply_to":"bb605ea9_3af1c1da","updated":"2023-11-14 18:12:01.000000000","message":"Sorry for not including it earlier!  Good catch.  Thanks, Antonio.\n\nUpdated texi file, but not sure whether jenkins will trigger a new build if there aren\u0027t any source code changes in this patchset?","commit_id":"c0f6bc6d40c5982b62697fd33bfc02f1333aceda"}],"src/target/xtensa/xtensa.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"03da4ac8e5d58185626b26cd6955b8f70225fcba","unresolved":true,"context_lines":[{"line_number":4275,"context_line":"\t\t.handler \u003d xtensa_cmd_dm_rw,"},{"line_number":4276,"context_line":"\t\t.mode \u003d COMMAND_ANY,"},{"line_number":4277,"context_line":"\t\t.help \u003d \"Xtensa DM read/write\","},{"line_number":4278,"context_line":"\t\t.usage \u003d \"[read \u003caddr\u003e] | [write \u003caddr\u003e \u003cvalue\u003e]\""},{"line_number":4279,"context_line":"\t},"},{"line_number":4280,"context_line":"\t{"},{"line_number":4281,"context_line":"\t\t.name \u003d \"perfmon_enable\","}],"source_content_type":"text/x-csrc","patch_set":2,"id":"e5b66d8c_e0bd1924","line":4278,"updated":"2023-11-09 22:18:40.000000000","message":"in most cases, similar OpenOCD commands use the syntax equivalent to:\nxtensa dm addr [value]\nwhere the presence of \"value\" determines if the command is a read or a write.\nDo you think it could make sense here too?","commit_id":"3f38a117538afe4ee5b9ffe04fb55c5594ca1fdd"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"48516291087020dfe0e2619994aa8d62a99830b2","unresolved":false,"context_lines":[{"line_number":4275,"context_line":"\t\t.handler \u003d xtensa_cmd_dm_rw,"},{"line_number":4276,"context_line":"\t\t.mode \u003d COMMAND_ANY,"},{"line_number":4277,"context_line":"\t\t.help \u003d \"Xtensa DM read/write\","},{"line_number":4278,"context_line":"\t\t.usage \u003d \"[read \u003caddr\u003e] | [write \u003caddr\u003e \u003cvalue\u003e]\""},{"line_number":4279,"context_line":"\t},"},{"line_number":4280,"context_line":"\t{"},{"line_number":4281,"context_line":"\t\t.name \u003d \"perfmon_enable\","}],"source_content_type":"text/x-csrc","patch_set":2,"id":"f39ba271_77d5223d","line":4278,"in_reply_to":"037f8fba_3385072a","updated":"2023-11-10 00:16:00.000000000","message":"Done","commit_id":"3f38a117538afe4ee5b9ffe04fb55c5594ca1fdd"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"56e68af0583e4f705ce57dd3513d998b4883d76f","unresolved":true,"context_lines":[{"line_number":4275,"context_line":"\t\t.handler \u003d xtensa_cmd_dm_rw,"},{"line_number":4276,"context_line":"\t\t.mode \u003d COMMAND_ANY,"},{"line_number":4277,"context_line":"\t\t.help \u003d \"Xtensa DM read/write\","},{"line_number":4278,"context_line":"\t\t.usage \u003d \"[read \u003caddr\u003e] | [write \u003caddr\u003e \u003cvalue\u003e]\""},{"line_number":4279,"context_line":"\t},"},{"line_number":4280,"context_line":"\t{"},{"line_number":4281,"context_line":"\t\t.name \u003d \"perfmon_enable\","}],"source_content_type":"text/x-csrc","patch_set":2,"id":"037f8fba_3385072a","line":4278,"in_reply_to":"e5b66d8c_e0bd1924","updated":"2023-11-09 22:46:14.000000000","message":"yes, good idea.  i will make that change shortly","commit_id":"3f38a117538afe4ee5b9ffe04fb55c5594ca1fdd"}],"src/target/xtensa/xtensa_debug_module.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"03da4ac8e5d58185626b26cd6955b8f70225fcba","unresolved":true,"context_lines":[{"line_number":34,"context_line":"static const struct xtensa_dm_reg_offsets xdm_regs[XDMREG_NUM] \u003d"},{"line_number":35,"context_line":"\tXTENSA_DM_REG_OFFSETS;"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"enum xtensa_dm_reg xtensa_dm_regaddr_to_id(uint32_t addr)"},{"line_number":38,"context_line":"{"},{"line_number":39,"context_line":"\tenum xtensa_dm_reg id;"},{"line_number":40,"context_line":"\tuint32_t addr_masked \u003d (addr \u0026 (XTENSA_DM_APB_ALIGN - 1));"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"c2543efe_18b5ddb4","line":37,"updated":"2023-11-09 22:18:40.000000000","message":"can be static?\nignore my comment if you plan to use it soon in some other file.","commit_id":"3f38a117538afe4ee5b9ffe04fb55c5594ca1fdd"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"786382eb7026d2a5247430b27c5ce9cadaf9f299","unresolved":true,"context_lines":[{"line_number":34,"context_line":"static const struct xtensa_dm_reg_offsets xdm_regs[XDMREG_NUM] \u003d"},{"line_number":35,"context_line":"\tXTENSA_DM_REG_OFFSETS;"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"enum xtensa_dm_reg xtensa_dm_regaddr_to_id(uint32_t addr)"},{"line_number":38,"context_line":"{"},{"line_number":39,"context_line":"\tenum xtensa_dm_reg id;"},{"line_number":40,"context_line":"\tuint32_t addr_masked \u003d (addr \u0026 (XTENSA_DM_APB_ALIGN - 1));"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"e96fa860_5d5c0f74","line":37,"in_reply_to":"c2543efe_18b5ddb4","updated":"2023-11-09 22:44:52.000000000","message":"I do plan to use it in other files once we add support for xtensa trace, and it would make other forks cleaner to keep it globally-visible in the meantime.  But if you\u0027d rather I make it static until the calling references are pushed, I can do that.  What is your preference?","commit_id":"3f38a117538afe4ee5b9ffe04fb55c5594ca1fdd"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"fd1fe51ce6557fc297e1248896c6682aa6b4706a","unresolved":true,"context_lines":[{"line_number":34,"context_line":"static const struct xtensa_dm_reg_offsets xdm_regs[XDMREG_NUM] \u003d"},{"line_number":35,"context_line":"\tXTENSA_DM_REG_OFFSETS;"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"enum xtensa_dm_reg xtensa_dm_regaddr_to_id(uint32_t addr)"},{"line_number":38,"context_line":"{"},{"line_number":39,"context_line":"\tenum xtensa_dm_reg id;"},{"line_number":40,"context_line":"\tuint32_t addr_masked \u003d (addr \u0026 (XTENSA_DM_APB_ALIGN - 1));"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"fc81921f_5f2d72d5","line":37,"in_reply_to":"e96fa860_5d5c0f74","updated":"2023-11-09 22:49:54.000000000","message":"In my opinion, should be static to avoid Sparse tool warning.","commit_id":"3f38a117538afe4ee5b9ffe04fb55c5594ca1fdd"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"48516291087020dfe0e2619994aa8d62a99830b2","unresolved":false,"context_lines":[{"line_number":34,"context_line":"static const struct xtensa_dm_reg_offsets xdm_regs[XDMREG_NUM] \u003d"},{"line_number":35,"context_line":"\tXTENSA_DM_REG_OFFSETS;"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"enum xtensa_dm_reg xtensa_dm_regaddr_to_id(uint32_t addr)"},{"line_number":38,"context_line":"{"},{"line_number":39,"context_line":"\tenum xtensa_dm_reg id;"},{"line_number":40,"context_line":"\tuint32_t addr_masked \u003d (addr \u0026 (XTENSA_DM_APB_ALIGN - 1));"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"adeac90e_3920e8f9","line":37,"in_reply_to":"fc81921f_5f2d72d5","updated":"2023-11-10 00:16:00.000000000","message":"Done","commit_id":"3f38a117538afe4ee5b9ffe04fb55c5594ca1fdd"}]}