)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"bfd3affa981396e024c8dece124bc028c5b4f5c8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"379d435f_c62b6da8","updated":"2024-01-29 20:05:16.000000000","message":"Tanks!","commit_id":"482a06e49e1000a5a27e960ddf29be14e1a73b34"},{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"6a05d15d1c6543ee9d9586d61922587742cc9911","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"1ebee8a5_52ad061e","updated":"2024-02-18 21:28:45.000000000","message":"Again, thanks a lot for your help!","commit_id":"38bd790e3ab7edb72e41f2900ccd0a019d6ad5c1"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"bb80b79524c0905ca44641f5e5ff11a85ec82270","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"e0fb68c7_468298fc","updated":"2024-03-03 17:54:17.000000000","message":"Thanks!","commit_id":"01b331c53e3759b37fe8bbf8b4fd3e6e010d7d41"},{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"998bbb45d48d095f720ca5bdcd8ee59d045cb4e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"5ab52791_7785ecd4","in_reply_to":"e0fb68c7_468298fc","updated":"2024-03-07 17:22:33.000000000","message":"Thanks to you!","commit_id":"01b331c53e3759b37fe8bbf8b4fd3e6e010d7d41"}],"doc/openocd.texi":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"93c3a150b8f9ff4eb0ec9e6c54754fd8cedc8fb7","unresolved":true,"context_lines":[{"line_number":12049,"context_line":"@end example"},{"line_number":12050,"context_line":"Stops the server for tool 1 (data_up_1/data_down_1)."},{"line_number":12051,"context_line":""},{"line_number":12052,"context_line":"@deffn {Command} {ipdbg queuing} @option{-tap @var{tapname}} @option{-hub @var{ir_value}} [@option{-vir [@var{vir_value} [@var{length} [@var{instr_code}]]]}] -size @var{size}"},{"line_number":12053,"context_line":"Configure the queuing between IPDBG JTAG-Host and Hub. Arguments can be specified in any order."},{"line_number":12054,"context_line":""},{"line_number":12055,"context_line":"@itemize @bullet"}],"source_content_type":"text/x-texinfo","patch_set":2,"id":"2876084b_df60c3d7","line":12052,"updated":"2023-12-17 20:41:36.000000000","message":"It\u0027s not clear to me why this new command again takes all the parameter of start and stop\nDoes it replace start?\nCan be converted in a simple -queue-size parameter to start command?\nIs it valid for \"start -pld\" too?","commit_id":"7626aa829df2378871609eb3aa8e567a1522cb65"},{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"835af6c7842d42b414251890ca5d23c6baec2c06","unresolved":true,"context_lines":[{"line_number":12049,"context_line":"@end example"},{"line_number":12050,"context_line":"Stops the server for tool 1 (data_up_1/data_down_1)."},{"line_number":12051,"context_line":""},{"line_number":12052,"context_line":"@deffn {Command} {ipdbg queuing} @option{-tap @var{tapname}} @option{-hub @var{ir_value}} [@option{-vir [@var{vir_value} [@var{length} [@var{instr_code}]]]}] -size @var{size}"},{"line_number":12053,"context_line":"Configure the queuing between IPDBG JTAG-Host and Hub. Arguments can be specified in any order."},{"line_number":12054,"context_line":""},{"line_number":12055,"context_line":"@itemize @bullet"}],"source_content_type":"text/x-texinfo","patch_set":2,"id":"70a13413_13957e6a","line":12052,"in_reply_to":"2876084b_df60c3d7","updated":"2023-12-18 21:24:35.000000000","message":"Yes this can be converted in a simple -queue-size parameter to start. Yes it is valid for -pld too. \nAs you mentioned in 7979 \"it\u0027s confusing\", there are so many parameters and lot of optionals. \nSo I thought before I add another parameter to start, it\u0027s time to \"simplify\"... maybe not the right approach yet. I think we should proceed here when found/agreed a solution in 7979.","commit_id":"7626aa829df2378871609eb3aa8e567a1522cb65"},{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"a67942c935a0128c340fbc8cc41501e04a47df73","unresolved":false,"context_lines":[{"line_number":12049,"context_line":"@end example"},{"line_number":12050,"context_line":"Stops the server for tool 1 (data_up_1/data_down_1)."},{"line_number":12051,"context_line":""},{"line_number":12052,"context_line":"@deffn {Command} {ipdbg queuing} @option{-tap @var{tapname}} @option{-hub @var{ir_value}} [@option{-vir [@var{vir_value} [@var{length} [@var{instr_code}]]]}] -size @var{size}"},{"line_number":12053,"context_line":"Configure the queuing between IPDBG JTAG-Host and Hub. Arguments can be specified in any order."},{"line_number":12054,"context_line":""},{"line_number":12055,"context_line":"@itemize @bullet"}],"source_content_type":"text/x-texinfo","patch_set":2,"id":"6b55802a_eeff30f3","line":12052,"in_reply_to":"70a13413_13957e6a","updated":"2024-01-09 23:27:36.000000000","message":"So, after the rework of 7979 this was much simpler to implement and use afterwards.\n\ncommand: NAME.ipdbghub queuing -size size","commit_id":"7626aa829df2378871609eb3aa8e567a1522cb65"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"8cad8d96819aa3e533d07921a9a2d34fa02531e8","unresolved":true,"context_lines":[{"line_number":12188,"context_line":"The TAP and ir value used to reach the JTAG Hub is given by the pld driver."},{"line_number":12189,"context_line":""},{"line_number":12190,"context_line":"@deffn {Command} {$hub_name queuing} @option{-size @var{size}}"},{"line_number":12191,"context_line":"Configure the queuing between IPDBG JTAG-Host and Hub."},{"line_number":12192,"context_line":""},{"line_number":12193,"context_line":"@itemize @bullet"},{"line_number":12194,"context_line":"@item @option{-size @var{size}} max number of transfers in the queue."}],"source_content_type":"text/x-texinfo","patch_set":6,"id":"d6ceef14_0790e94e","line":12191,"updated":"2024-01-27 17:35:16.000000000","message":"does it makes sense to add that the default is 1024?","commit_id":"1c787e1b98e19d86cd9fd95e4a30a55f3d1e1e0f"},{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"bfd3affa981396e024c8dece124bc028c5b4f5c8","unresolved":false,"context_lines":[{"line_number":12188,"context_line":"The TAP and ir value used to reach the JTAG Hub is given by the pld driver."},{"line_number":12189,"context_line":""},{"line_number":12190,"context_line":"@deffn {Command} {$hub_name queuing} @option{-size @var{size}}"},{"line_number":12191,"context_line":"Configure the queuing between IPDBG JTAG-Host and Hub."},{"line_number":12192,"context_line":""},{"line_number":12193,"context_line":"@itemize @bullet"},{"line_number":12194,"context_line":"@item @option{-size @var{size}} max number of transfers in the queue."}],"source_content_type":"text/x-texinfo","patch_set":6,"id":"b1bf9049_41ef5cc8","line":12191,"in_reply_to":"d6ceef14_0790e94e","updated":"2024-01-29 20:05:16.000000000","message":"Done","commit_id":"1c787e1b98e19d86cd9fd95e4a30a55f3d1e1e0f"}],"src/server/ipdbg.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"668d736da133c1462cbdf8d60744d01933160dfb","unresolved":true,"context_lines":[{"line_number":905,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":906,"context_line":""},{"line_number":907,"context_line":"\tif (hub-\u003eactive_connections) {"},{"line_number":908,"context_line":"\t\tLOG_ERROR(\"Configuration change not allowed when hub has active connections\");"},{"line_number":909,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":910,"context_line":"\t}"},{"line_number":911,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":7,"id":"43a5efaf_21175a94","line":908,"updated":"2024-02-17 21:54:17.000000000","message":"this should be a command_print()\nTo get here the required CMD, or you simply inline this function in handle_ipdbg_cfg_queuing_command\nor you re-define this function as:\n```\nstatic COMMAND_HELPER(ipdbg_config_queuing, struct ipdbg_hub *hub, unsigned int size)\n{\n  ...\n}\n```\nand you call it with\n```\nreturn CALL_COMMAND_HANDLER(ipdbg_config_queuing, hub, size);\n```","commit_id":"482a06e49e1000a5a27e960ddf29be14e1a73b34"},{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"6a05d15d1c6543ee9d9586d61922587742cc9911","unresolved":false,"context_lines":[{"line_number":905,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":906,"context_line":""},{"line_number":907,"context_line":"\tif (hub-\u003eactive_connections) {"},{"line_number":908,"context_line":"\t\tLOG_ERROR(\"Configuration change not allowed when hub has active connections\");"},{"line_number":909,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":910,"context_line":"\t}"},{"line_number":911,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":7,"id":"b9633b6f_8b19c34a","line":908,"in_reply_to":"43a5efaf_21175a94","updated":"2024-02-18 21:28:45.000000000","message":"Done","commit_id":"482a06e49e1000a5a27e960ddf29be14e1a73b34"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"668d736da133c1462cbdf8d60744d01933160dfb","unresolved":true,"context_lines":[{"line_number":910,"context_line":"\t}"},{"line_number":911,"context_line":""},{"line_number":912,"context_line":"\tif (size \u003d\u003d 0 || size \u003e IPDBG_SCRATCH_MEMORY_SIZE) {"},{"line_number":913,"context_line":"\t\tLOG_ERROR(\"queuing size out of range! Must be 0 \u003c size \u003c\u003d %d\", IPDBG_SCRATCH_MEMORY_SIZE);"},{"line_number":914,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":915,"context_line":"\t}"},{"line_number":916,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":7,"id":"84cb38c9_30c08444","line":913,"updated":"2024-02-17 21:54:17.000000000","message":"this also a command_print() and the return value below ERRCODE_INVALID_PARAMETER","commit_id":"482a06e49e1000a5a27e960ddf29be14e1a73b34"},{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"f22d63537211f1eb1c71a5e5d6cb50cdd03ffb16","unresolved":false,"context_lines":[{"line_number":910,"context_line":"\t}"},{"line_number":911,"context_line":""},{"line_number":912,"context_line":"\tif (size \u003d\u003d 0 || size \u003e IPDBG_SCRATCH_MEMORY_SIZE) {"},{"line_number":913,"context_line":"\t\tLOG_ERROR(\"queuing size out of range! Must be 0 \u003c size \u003c\u003d %d\", IPDBG_SCRATCH_MEMORY_SIZE);"},{"line_number":914,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":915,"context_line":"\t}"},{"line_number":916,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":7,"id":"e3a421f2_1f3e278a","line":913,"in_reply_to":"4477eaae_adffd09b","updated":"2024-02-18 22:45:31.000000000","message":"I think the right one is ERROR_COMMAND_ARGUMENT_INVALID.","commit_id":"482a06e49e1000a5a27e960ddf29be14e1a73b34"},{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"f29a9549c013fe0ef7077d95d5f56bcdaf419df0","unresolved":false,"context_lines":[{"line_number":910,"context_line":"\t}"},{"line_number":911,"context_line":""},{"line_number":912,"context_line":"\tif (size \u003d\u003d 0 || size \u003e IPDBG_SCRATCH_MEMORY_SIZE) {"},{"line_number":913,"context_line":"\t\tLOG_ERROR(\"queuing size out of range! Must be 0 \u003c size \u003c\u003d %d\", IPDBG_SCRATCH_MEMORY_SIZE);"},{"line_number":914,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":915,"context_line":"\t}"},{"line_number":916,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":7,"id":"4477eaae_adffd09b","line":913,"in_reply_to":"83e349fc_cc8f7ad4","updated":"2024-02-18 21:30:28.000000000","message":"Done","commit_id":"482a06e49e1000a5a27e960ddf29be14e1a73b34"},{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"6a05d15d1c6543ee9d9586d61922587742cc9911","unresolved":true,"context_lines":[{"line_number":910,"context_line":"\t}"},{"line_number":911,"context_line":""},{"line_number":912,"context_line":"\tif (size \u003d\u003d 0 || size \u003e IPDBG_SCRATCH_MEMORY_SIZE) {"},{"line_number":913,"context_line":"\t\tLOG_ERROR(\"queuing size out of range! Must be 0 \u003c size \u003c\u003d %d\", IPDBG_SCRATCH_MEMORY_SIZE);"},{"line_number":914,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":915,"context_line":"\t}"},{"line_number":916,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":7,"id":"83e349fc_cc8f7ad4","line":913,"in_reply_to":"84cb38c9_30c08444","updated":"2024-02-18 21:28:45.000000000","message":"where is ERRCODE_INVALID_PARAMETER defined? Shall i define it locally in ipdbg.c?\nShall I include versaloon_include.h?","commit_id":"482a06e49e1000a5a27e960ddf29be14e1a73b34"}]}
