)]}'
{"src/jtag/drivers/angie.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"421341d3564406c792f7d08230947df06c8b7e07","unresolved":true,"context_lines":[{"line_number":434,"context_line":"\t}"},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"\tchar gpifcnt[4];"},{"line_number":437,"context_line":"\tgpifcnt[0] \u003d (uint8_t)(((uint32_t)(bitstream_size) \u003e\u003e 24) \u0026 0xFF);"},{"line_number":438,"context_line":"\tgpifcnt[1] \u003d (uint8_t)(((uint32_t)(bitstream_size) \u003e\u003e 16) \u0026 0xFF);"},{"line_number":439,"context_line":"\tgpifcnt[2] \u003d (uint8_t)(((uint32_t)(bitstream_size) \u003e\u003e 8) \u0026 0xFF);"},{"line_number":440,"context_line":"\tgpifcnt[3] \u003d (uint8_t)(bitstream_size \u0026 0xFF);"},{"line_number":441,"context_line":""},{"line_number":442,"context_line":"\t/* CFGopen */"},{"line_number":443,"context_line":"\tret \u003d jtag_libusb_control_transfer(device-\u003eusb_device_handle,"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"924d3b29_8d043edc","line":440,"range":{"start_line":437,"start_character":1,"end_line":440,"end_character":47},"updated":"2023-12-30 17:31:08.000000000","message":"It\u0027s preferred to replace this with the include on top\n#include \u003chelper/types.h\u003e\nand here\nh_u32_to_be((uint8_t *)gpifcnt, bitstream_size);\n\nThe cast is not nice, but we need to change, later, the prototype of jtag_libusb_control_transfer() and then the cast could be dropped.\n\nActually I prefer you use:\nuint8_t gpifcnt[4];\nh_u32_to_be(gpifcnt, bitstream_size);\nand below\nret \u003d jtag_libusb_control_transfer(..., (char *)gpifcnt, ...);\nso when we will change the prototype of jtag_libusb_control_transfer() it would be easily cleaned at the same time.","commit_id":"264bbd7c5209457ae0f13db5015a04605a215417"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"c1e5ed18cc63282d556df6a0d4a4a383253b716a","unresolved":false,"context_lines":[{"line_number":434,"context_line":"\t}"},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"\tchar gpifcnt[4];"},{"line_number":437,"context_line":"\tgpifcnt[0] \u003d (uint8_t)(((uint32_t)(bitstream_size) \u003e\u003e 24) \u0026 0xFF);"},{"line_number":438,"context_line":"\tgpifcnt[1] \u003d (uint8_t)(((uint32_t)(bitstream_size) \u003e\u003e 16) \u0026 0xFF);"},{"line_number":439,"context_line":"\tgpifcnt[2] \u003d (uint8_t)(((uint32_t)(bitstream_size) \u003e\u003e 8) \u0026 0xFF);"},{"line_number":440,"context_line":"\tgpifcnt[3] \u003d (uint8_t)(bitstream_size \u0026 0xFF);"},{"line_number":441,"context_line":""},{"line_number":442,"context_line":"\t/* CFGopen */"},{"line_number":443,"context_line":"\tret \u003d jtag_libusb_control_transfer(device-\u003eusb_device_handle,"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"390ae733_5ae4b725","line":440,"range":{"start_line":437,"start_character":1,"end_line":440,"end_character":47},"in_reply_to":"819b7f99_a689116e","updated":"2024-01-02 09:53:07.000000000","message":"Ack","commit_id":"264bbd7c5209457ae0f13db5015a04605a215417"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"81d1fc88d7bb208e8cb5788a6aa80d53e4ab7aed","unresolved":true,"context_lines":[{"line_number":434,"context_line":"\t}"},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"\tchar gpifcnt[4];"},{"line_number":437,"context_line":"\tgpifcnt[0] \u003d (uint8_t)(((uint32_t)(bitstream_size) \u003e\u003e 24) \u0026 0xFF);"},{"line_number":438,"context_line":"\tgpifcnt[1] \u003d (uint8_t)(((uint32_t)(bitstream_size) \u003e\u003e 16) \u0026 0xFF);"},{"line_number":439,"context_line":"\tgpifcnt[2] \u003d (uint8_t)(((uint32_t)(bitstream_size) \u003e\u003e 8) \u0026 0xFF);"},{"line_number":440,"context_line":"\tgpifcnt[3] \u003d (uint8_t)(bitstream_size \u0026 0xFF);"},{"line_number":441,"context_line":""},{"line_number":442,"context_line":"\t/* CFGopen */"},{"line_number":443,"context_line":"\tret \u003d jtag_libusb_control_transfer(device-\u003eusb_device_handle,"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"819b7f99_a689116e","line":440,"range":{"start_line":437,"start_character":1,"end_line":440,"end_character":47},"in_reply_to":"924d3b29_8d043edc","updated":"2024-01-02 09:49:35.000000000","message":"Okay, yes good approach.","commit_id":"264bbd7c5209457ae0f13db5015a04605a215417"}]}