)]}'
{"id":"openocd~master~Ic597a70d0427832547f6b539864c24ce20a18c64","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1002151":{"account":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"last_update":"2024-01-13 14:47:31.000000000","reason":"Change was submitted"},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2024-01-07 14:15:58.000000000","reason":"\u003cGERRIT_ACCOUNT_1000021\u003e replied on the change","reason_account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}},"hashtags":[],"change_id":"Ic597a70d0427832547f6b539864c24ce20a18c64","subject":"contrib/firmware: Add direction control for \u0027SCL\u0027 i2c signal","status":"MERGED","created":"2023-12-19 09:42:47.000000000","updated":"2024-01-13 14:47:31.000000000","submitted":"2024-01-13 14:47:31.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7989","meta_rev_id":"9b15ac937163de75241121ed974e2f9fc30b5170","_number":7989,"owner":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-01-13 14:47:31.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-01-13 14:47:31.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-12-19 10:13:12.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-12-30 17:38:19.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"3748a601a71b4dfce8f36217a5fad35db7d88257","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"real_author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"date":"2023-12-19 09:42:47.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"56b9fc0c8977c30a7400a68519078b9688ac29ee","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-12-19 10:13:12.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19101/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18265/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"ad790e7cef68a6b4760f6489fbc7857af636c3d1","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-12-30 17:38:19.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"baa8e0cdc694e25801fe835b632162c0f19ba0ec","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"real_author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"date":"2024-01-04 10:35:28.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.\n\nOutdated Votes:\n* Code-Review+1 (copy condition: \"changekind:NO_CHANGE OR is:MIN\")\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"fd015633ef9c80c0f8e202b0861d7a44728a0377","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"real_author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"date":"2024-01-04 10:59:19.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.","accounts_in_message":[],"_revision_number":3},{"id":"6edc32bd71376a4ff73ed448ce8f7458cda742f1","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-01-04 10:59:37.000000000","message":"Patch Set 2: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit-build/18355/ : ABORTED\n\nhttps://build.openocd.org/job/openocd-gerrit/19190/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"0de8e3d782a2dadf2440fadf7a9f0afbff68130d","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-01-04 12:11:07.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19199/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18360/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"4bcbf548bb9af353b05d0f2b56a68af44575cbfb","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-01-07 14:15:58.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"6830ef3d896d0ce89337f3fb94a149acf5eba174","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-01-13 14:47:28.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"9b15ac937163de75241121ed974e2f9fc30b5170","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-01-13 14:47:31.000000000","message":"Change has been successfully cherry-picked as c7073853ebcbb8a94af0ef405cb05f94b7fd02e5","accounts_in_message":[],"_revision_number":4}],"current_revision":"c7073853ebcbb8a94af0ef405cb05f94b7fd02e5","revisions":{"f532e04bf6ea000dadaebfd3eb6b4bbb49ce80b8":{"kind":"REWORK","_number":1,"created":"2023-12-19 09:42:47.000000000","uploader":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"ref":"refs/changes/89/7989/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/89/7989/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/89/7989/1 \u0026\u0026 git checkout -b change-7989 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/89/7989/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/89/7989/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/89/7989/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/89/7989/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/89/7989/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"264bbd7c5209457ae0f13db5015a04605a215417","subject":"jtag/drivers: send bitstream size to firmware via libusb"}],"author":{"name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","date":"2023-11-29 14:21:27.000000000","tz":60},"committer":{"name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","date":"2023-12-19 09:19:20.000000000","tz":60},"subject":"contrib/firmware: Add direction control for \u0027SCL\u0027 i2c signal","message":"contrib/firmware: Add direction control for \u0027SCL\u0027 i2c signal\n\nWe want to keep the tri-state buffers located between the FPGA\nand the board, in \u0027Z\u0027 state until we launch an i2c connection.\n\nWe launch an i2c start condition, make the SCL\ndirection \u0027OUT\u0027 to start the i2c protocol and at the end\nof the i2c connection at the stop condition, we re-make\nthe tri-state buffers at \u0027Z\u0027 state.\n\nChange-Id: Ic597a70d0427832547f6b539864c24ce20a18c64\nSigned-off-by: Ahmed BOUDJELIDA \u003caboudjelida@nanoxplore.com\u003e\n"}},"8f3d7765457d8e9ac0df6ed705601ffc3f89a9c0":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2024-01-04 10:59:19.000000000","uploader":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"ref":"refs/changes/89/7989/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/89/7989/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/89/7989/3 \u0026\u0026 git checkout -b change-7989 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/89/7989/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/89/7989/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/89/7989/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/89/7989/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/89/7989/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7f8ddf68507d6bf0b310a4331d611d1996f0f60c","subject":"jtag/drivers: send bitstream size to firmware via libusb"}],"author":{"name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","date":"2023-11-29 14:21:27.000000000","tz":60},"committer":{"name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","date":"2024-01-04 10:59:04.000000000","tz":60},"subject":"contrib/firmware: Add direction control for \u0027SCL\u0027 i2c signal","message":"contrib/firmware: Add direction control for \u0027SCL\u0027 i2c signal\n\nWe want to keep the tri-state buffers located between the FPGA\nand the board, in \u0027Z\u0027 state until we launch an i2c connection.\n\nWe launch an i2c start condition, make the SCL\ndirection \u0027OUT\u0027 to start the i2c protocol and at the end\nof the i2c connection at the stop condition, we re-make\nthe tri-state buffers at \u0027Z\u0027 state.\n\nChange-Id: Ic597a70d0427832547f6b539864c24ce20a18c64\nSigned-off-by: Ahmed BOUDJELIDA \u003caboudjelida@nanoxplore.com\u003e\n"}},"84fc8d3e1b4024ae03a4144526253074e103ed8d":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2024-01-04 10:35:28.000000000","uploader":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"ref":"refs/changes/89/7989/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/89/7989/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/89/7989/2 \u0026\u0026 git checkout -b change-7989 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/89/7989/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/89/7989/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/89/7989/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/89/7989/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/89/7989/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"65c7927aef4dbef861bc7de3f9fde3d7d4f7c836","subject":"jtag/drivers: send bitstream size to firmware via libusb"}],"author":{"name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","date":"2023-11-29 14:21:27.000000000","tz":60},"committer":{"name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","date":"2024-01-02 10:08:46.000000000","tz":60},"subject":"contrib/firmware: Add direction control for \u0027SCL\u0027 i2c signal","message":"contrib/firmware: Add direction control for \u0027SCL\u0027 i2c signal\n\nWe want to keep the tri-state buffers located between the FPGA\nand the board, in \u0027Z\u0027 state until we launch an i2c connection.\n\nWe launch an i2c start condition, make the SCL\ndirection \u0027OUT\u0027 to start the i2c protocol and at the end\nof the i2c connection at the stop condition, we re-make\nthe tri-state buffers at \u0027Z\u0027 state.\n\nChange-Id: Ic597a70d0427832547f6b539864c24ce20a18c64\nSigned-off-by: Ahmed BOUDJELIDA \u003caboudjelida@nanoxplore.com\u003e\n"}},"c7073853ebcbb8a94af0ef405cb05f94b7fd02e5":{"kind":"REWORK","_number":4,"created":"2024-01-13 14:47:31.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/89/7989/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/89/7989/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/89/7989/4 \u0026\u0026 git checkout -b change-7989 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/89/7989/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/89/7989/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/89/7989/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/89/7989/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/89/7989/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"995a7af21d6f97f628382e26dc21dc38e4fa846e","subject":"jtag/drivers: send bitstream size to firmware via libusb"}],"author":{"name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","date":"2023-11-29 14:21:27.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-01-13 14:47:31.000000000","tz":0},"subject":"contrib/firmware: Add direction control for \u0027SCL\u0027 i2c signal","message":"contrib/firmware: Add direction control for \u0027SCL\u0027 i2c signal\n\nWe want to keep the tri-state buffers located between the FPGA\nand the board, in \u0027Z\u0027 state until we launch an i2c connection.\n\nWe launch an i2c start condition, make the SCL\ndirection \u0027OUT\u0027 to start the i2c protocol and at the end\nof the i2c connection at the stop condition, we re-make\nthe tri-state buffers at \u0027Z\u0027 state.\n\nChange-Id: Ic597a70d0427832547f6b539864c24ce20a18c64\nSigned-off-by: Ahmed BOUDJELIDA \u003caboudjelida@nanoxplore.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7989\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}