)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"a71c0146066fbe50160cf5a1ffb04fdf975dc5d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d4e6ada8_aa71b269","updated":"2023-11-11 15:03:48.000000000","message":"Marc, thanks for this patch, I fully agree.\nReviewing it I see some additional improvement that could be in this same patch, or, if you prefer, in a following one.","commit_id":"1f8c3cdb1541ffaeb2fa23c786fd38c928e22632"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"2a1d84468c4ba7a049a58b2587e9a5214aabcbe3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e5a8ea41_a311e324","updated":"2023-11-12 16:10:54.000000000","message":"Thanks","commit_id":"7dfdd00ac6ccac22d2be7e68b8cbfda4ed8461e1"}],"src/flash/nor/stm32f2x.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"a71c0146066fbe50160cf5a1ffb04fdf975dc5d6","unresolved":true,"context_lines":[{"line_number":1540,"context_line":""},{"line_number":1541,"context_line":"COMMAND_HANDLER(stm32x_handle_mass_erase_command)"},{"line_number":1542,"context_line":"{"},{"line_number":1543,"context_line":"\tif (CMD_ARGC \u003c 1)"},{"line_number":1544,"context_line":"\t\treturn ERROR_COMMAND_SYNTAX_ERROR;"},{"line_number":1545,"context_line":""},{"line_number":1546,"context_line":"\tstruct flash_bank *bank;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"09cf40f8_42b06c1e","line":1543,"updated":"2023-11-11 15:03:48.000000000","message":"I think the right check here should be\nif (CMD_ARGC !\u003d 1)\nIt\u0027s not strictly part of your change, but could be good to fix it directly here or in a following change","commit_id":"1f8c3cdb1541ffaeb2fa23c786fd38c928e22632"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"2a1d84468c4ba7a049a58b2587e9a5214aabcbe3","unresolved":false,"context_lines":[{"line_number":1540,"context_line":""},{"line_number":1541,"context_line":"COMMAND_HANDLER(stm32x_handle_mass_erase_command)"},{"line_number":1542,"context_line":"{"},{"line_number":1543,"context_line":"\tif (CMD_ARGC \u003c 1)"},{"line_number":1544,"context_line":"\t\treturn ERROR_COMMAND_SYNTAX_ERROR;"},{"line_number":1545,"context_line":""},{"line_number":1546,"context_line":"\tstruct flash_bank *bank;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"8bd266c0_5dc89d06","line":1543,"in_reply_to":"09cf40f8_42b06c1e","updated":"2023-11-12 16:10:54.000000000","message":"Done","commit_id":"1f8c3cdb1541ffaeb2fa23c786fd38c928e22632"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"a71c0146066fbe50160cf5a1ffb04fdf975dc5d6","unresolved":true,"context_lines":[{"line_number":1698,"context_line":""},{"line_number":1699,"context_line":"COMMAND_HANDLER(stm32x_handle_otp_command)"},{"line_number":1700,"context_line":"{"},{"line_number":1701,"context_line":"\tif (CMD_ARGC \u003c 2)"},{"line_number":1702,"context_line":"\t\treturn ERROR_COMMAND_SYNTAX_ERROR;"},{"line_number":1703,"context_line":""},{"line_number":1704,"context_line":"\tstruct flash_bank *bank;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"dc5f2703_387c2a6f","line":1701,"updated":"2023-11-11 15:03:48.000000000","message":"Maybe\nif (CMD_ARGC !\u003d 2)","commit_id":"1f8c3cdb1541ffaeb2fa23c786fd38c928e22632"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"2a1d84468c4ba7a049a58b2587e9a5214aabcbe3","unresolved":false,"context_lines":[{"line_number":1698,"context_line":""},{"line_number":1699,"context_line":"COMMAND_HANDLER(stm32x_handle_otp_command)"},{"line_number":1700,"context_line":"{"},{"line_number":1701,"context_line":"\tif (CMD_ARGC \u003c 2)"},{"line_number":1702,"context_line":"\t\treturn ERROR_COMMAND_SYNTAX_ERROR;"},{"line_number":1703,"context_line":""},{"line_number":1704,"context_line":"\tstruct flash_bank *bank;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"15287a19_bfc8bf29","line":1701,"in_reply_to":"dc5f2703_387c2a6f","updated":"2023-11-12 16:10:54.000000000","message":"Done","commit_id":"1f8c3cdb1541ffaeb2fa23c786fd38c928e22632"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"a71c0146066fbe50160cf5a1ffb04fdf975dc5d6","unresolved":true,"context_lines":[{"line_number":1772,"context_line":"\t\t.name \u003d \"otp\","},{"line_number":1773,"context_line":"\t\t.handler \u003d stm32x_handle_otp_command,"},{"line_number":1774,"context_line":"\t\t.mode \u003d COMMAND_EXEC,"},{"line_number":1775,"context_line":"\t\t.usage \u003d \"bank_id\","},{"line_number":1776,"context_line":"\t\t.help \u003d \"OTP (One Time Programmable) memory write enable/disable.\","},{"line_number":1777,"context_line":"\t},"},{"line_number":1778,"context_line":"\tCOMMAND_REGISTRATION_DONE"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"a64cd572_e1981916","line":1775,"updated":"2023-11-11 15:03:48.000000000","message":".usage \u003d \"bank_id (enable|disable|show)\",","commit_id":"1f8c3cdb1541ffaeb2fa23c786fd38c928e22632"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"2a1d84468c4ba7a049a58b2587e9a5214aabcbe3","unresolved":false,"context_lines":[{"line_number":1772,"context_line":"\t\t.name \u003d \"otp\","},{"line_number":1773,"context_line":"\t\t.handler \u003d stm32x_handle_otp_command,"},{"line_number":1774,"context_line":"\t\t.mode \u003d COMMAND_EXEC,"},{"line_number":1775,"context_line":"\t\t.usage \u003d \"bank_id\","},{"line_number":1776,"context_line":"\t\t.help \u003d \"OTP (One Time Programmable) memory write enable/disable.\","},{"line_number":1777,"context_line":"\t},"},{"line_number":1778,"context_line":"\tCOMMAND_REGISTRATION_DONE"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"6c1d4df0_d15ad988","line":1775,"in_reply_to":"a64cd572_e1981916","updated":"2023-11-12 16:10:54.000000000","message":"Done","commit_id":"1f8c3cdb1541ffaeb2fa23c786fd38c928e22632"}]}