)]}'
{"id":"openocd~master~I676e2ebf5714c850a436854a32c2e9d2f181d537","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000853":{"account":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"last_update":"2023-11-18 11:32:40.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I676e2ebf5714c850a436854a32c2e9d2f181d537","subject":"flash/nor/stm32f2x: Remove redundant error messages","status":"MERGED","created":"2023-11-11 09:29:45.000000000","updated":"2023-11-18 11:32:40.000000000","submitted":"2023-11-18 11:32:40.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":8,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7999","meta_rev_id":"62a775e1f13eeb5176b48b51d83294863c243e7d","_number":7999,"owner":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-11-18 11:32:40.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-11-18 11:32:40.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-11-18 11:32:40.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-11-11 09:49:22.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-11-11 15:03:48.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"CC"},{"updated":"2023-11-12 16:10:54.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"},{"updated":"2023-11-12 20:21:25.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"}],"messages":[{"id":"36996ac2d43d598abddb025419f135789f0b8d5a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2023-11-11 09:29:45.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"635a96403ba0ced631744f435b05710b62640d3f","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-11-11 09:49:22.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/18701/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/17885/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"a71c0146066fbe50160cf5a1ffb04fdf975dc5d6","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-11-11 15:03:48.000000000","message":"Patch Set 1:\n\n(4 comments)","accounts_in_message":[],"_revision_number":1},{"id":"0deb031e5203d0b642d960e113d96773b0b6de98","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2023-11-12 10:20:49.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"f7a20552bf1bc3b30d6ed964989e33cbfdda937a","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-11-12 11:04:02.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/18715/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/17897/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"2a1d84468c4ba7a049a58b2587e9a5214aabcbe3","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-11-12 16:10:54.000000000","message":"Patch Set 2: Code-Review+1\n\n(4 comments)","accounts_in_message":[],"_revision_number":2},{"id":"75e4c34092d09eff3833f39be8fe4b732e067073","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-11-12 20:21:25.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"62a775e1f13eeb5176b48b51d83294863c243e7d","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-11-18 11:32:40.000000000","message":"Change has been successfully cherry-picked as 738f1e1f72f64839462c6da97ea4ab7eba56e337","accounts_in_message":[],"_revision_number":3}],"current_revision":"738f1e1f72f64839462c6da97ea4ab7eba56e337","revisions":{"7dfdd00ac6ccac22d2be7e68b8cbfda4ed8461e1":{"kind":"REWORK","_number":2,"created":"2023-11-12 10:20:49.000000000","uploader":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"ref":"refs/changes/99/7999/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/99/7999/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/99/7999/2 \u0026\u0026 git checkout -b change-7999 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/99/7999/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/99/7999/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/99/7999/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/99/7999/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/99/7999/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a882ca3d224a6edd4cd0f4233462ceb7d789b7d6","subject":"jtag/drivers/rshim: Remove redundant error message"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2023-11-11 09:17:45.000000000","tz":60},"committer":{"name":"Marc Schink","email":"dev@zapb.de","date":"2023-11-12 10:20:18.000000000","tz":60},"subject":"flash/nor/stm32f2x: Remove redundant error messages","message":"flash/nor/stm32f2x: Remove redundant error messages\n\nThe correct syntax is already suggested due to the return\nvalue used.\n\nWhile at it, apply some minor code improvements.\n\nChange-Id: I676e2ebf5714c850a436854a32c2e9d2f181d537\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\n"}},"738f1e1f72f64839462c6da97ea4ab7eba56e337":{"kind":"REWORK","_number":3,"created":"2023-11-18 11:32:40.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/99/7999/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/99/7999/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/99/7999/3 \u0026\u0026 git checkout -b change-7999 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/99/7999/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/99/7999/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/99/7999/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/99/7999/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/99/7999/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1df35d92fe59eac4603f28a2e1c6e5ee1d56e7da","subject":"jtag/drivers/rshim: Remove redundant error message"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2023-11-11 09:17:45.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-11-18 11:32:40.000000000","tz":0},"subject":"flash/nor/stm32f2x: Remove redundant error messages","message":"flash/nor/stm32f2x: Remove redundant error messages\n\nThe correct syntax is already suggested due to the return\nvalue used.\n\nWhile at it, apply some minor code improvements.\n\nChange-Id: I676e2ebf5714c850a436854a32c2e9d2f181d537\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7999\nTested-by: jenkins\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"1f8c3cdb1541ffaeb2fa23c786fd38c928e22632":{"kind":"REWORK","_number":1,"created":"2023-11-11 09:29:45.000000000","uploader":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"ref":"refs/changes/99/7999/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/99/7999/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/99/7999/1 \u0026\u0026 git checkout -b change-7999 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/99/7999/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/99/7999/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/99/7999/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/99/7999/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/99/7999/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"cf19d580f47ec74d1b54ec1651ddbf122aa830c0","subject":"jtag/drivers/rshim: Remove redundant error message"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2023-11-11 09:17:45.000000000","tz":60},"committer":{"name":"Marc Schink","email":"dev@zapb.de","date":"2023-11-11 09:18:26.000000000","tz":60},"subject":"flash/nor/stm32f2x: Remove redundant error messages","message":"flash/nor/stm32f2x: Remove redundant error messages\n\nThe correct syntax is already suggested due to the return\nvalue used.\n\nChange-Id: I676e2ebf5714c850a436854a32c2e9d2f181d537\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}