)]}'
{"id":"openocd~master~Idf3d7a46ddecd70823e06bc3997f41fcdb8e501f","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000853":{"account":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"last_update":"2023-11-18 11:33:09.000000000","reason":"Change was submitted"},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2023-11-12 20:34:58.000000000","reason":"\u003cGERRIT_ACCOUNT_1000021\u003e replied on the change","reason_account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}},"hashtags":[],"change_id":"Idf3d7a46ddecd70823e06bc3997f41fcdb8e501f","subject":"flash/nor/stm32h7x: Remove redundant error messages","status":"MERGED","created":"2023-11-11 09:29:45.000000000","updated":"2023-11-18 11:33:09.000000000","submitted":"2023-11-18 11:33:09.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":11,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8000","meta_rev_id":"9a4caf60065aff7cd7074c697a47732e55f5b5d9","_number":8000,"owner":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-11-18 11:33:09.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-11-18 11:33:09.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-11-18 11:33:09.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-11-11 10:37:20.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-11-11 15:07:06.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"CC"},{"updated":"2023-11-12 20:24:43.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"},{"updated":"2023-11-12 20:34:58.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"23cf033a7e0a7235890583b46b6f23c2efedc2ba","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2023-11-11 09:29:45.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"834a101b68040b1bced365a925e59a26b6bd9e5a","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-11-11 10:37:20.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/18703/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/17888/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"94ee51c1187efcedde5ccf28ddd473d1422ff8ac","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-11-11 15:07:06.000000000","message":"Patch Set 1:\n\n(4 comments)","accounts_in_message":[],"_revision_number":1},{"id":"e6fea96b561845d661e2d258b9fa1449e9c5a1dc","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2023-11-12 10:20:49.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"c3e47487eaa5b07a3d9cb42bb7bcb17d75f479de","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-11-12 11:17:47.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/18716/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/17898/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"3fc340fd6c780911bcd158c49115ec3d3ce38940","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-11-12 16:14:06.000000000","message":"Patch Set 2:\n\n(3 comments)","accounts_in_message":[],"_revision_number":2},{"id":"96fc0a303ccd85da1859331f2cc85482e133b268","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2023-11-12 18:19:38.000000000","message":"Uploaded patch set 3.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"2d732945dd9a76aa7aff9b62de37b8f04f4dbdfc","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2023-11-12 18:20:13.000000000","message":"Patch Set 3:\n\n(2 comments)","accounts_in_message":[],"_revision_number":3},{"id":"cf19ea2d1dc606636394ce67ed2f9843a3f5f9f4","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-11-12 18:32:10.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/18722/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/17906/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"685d32ffbeb717bd491d3315f68a753764943f68","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-11-12 20:24:43.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"d7821a3944f9ef64302084a0bf3fcdaaa224e007","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-11-12 20:34:58.000000000","message":"Patch Set 3: Code-Review+1\n\n(2 comments)","accounts_in_message":[],"_revision_number":3},{"id":"9a4caf60065aff7cd7074c697a47732e55f5b5d9","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-11-18 11:33:09.000000000","message":"Change has been successfully cherry-picked as b310b3ba9d89a059e0edc4f374a31632ec1c58fd","accounts_in_message":[],"_revision_number":4}],"current_revision":"b310b3ba9d89a059e0edc4f374a31632ec1c58fd","revisions":{"b310b3ba9d89a059e0edc4f374a31632ec1c58fd":{"kind":"REWORK","_number":4,"created":"2023-11-18 11:33:09.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/00/8000/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/00/8000/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/00/8000/4 \u0026\u0026 git checkout -b change-8000 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/00/8000/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/00/8000/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/00/8000/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/00/8000/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/00/8000/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"738f1e1f72f64839462c6da97ea4ab7eba56e337","subject":"flash/nor/stm32f2x: Remove redundant error messages"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2023-11-11 09:18:53.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-11-18 11:33:09.000000000","tz":0},"subject":"flash/nor/stm32h7x: Remove redundant error messages","message":"flash/nor/stm32h7x: Remove redundant error messages\n\nThe correct syntax is already suggested due to the return\nvalue used.\n\nWhile at it, apply some minor code improvements.\n\nChange-Id: Idf3d7a46ddecd70823e06bc3997f41fcdb8e501f\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8000\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nTested-by: jenkins\n"}},"92021f6f5d0c9c1dde24063b428204c48112b589":{"kind":"REWORK","_number":2,"created":"2023-11-12 10:20:49.000000000","uploader":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"ref":"refs/changes/00/8000/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/00/8000/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/00/8000/2 \u0026\u0026 git checkout -b change-8000 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/00/8000/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/00/8000/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/00/8000/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/00/8000/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/00/8000/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7dfdd00ac6ccac22d2be7e68b8cbfda4ed8461e1","subject":"flash/nor/stm32f2x: Remove redundant error messages"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2023-11-11 09:18:53.000000000","tz":60},"committer":{"name":"Marc Schink","email":"dev@zapb.de","date":"2023-11-12 10:20:18.000000000","tz":60},"subject":"flash/nor/stm32h7x: Remove redundant error messages","message":"flash/nor/stm32h7x: Remove redundant error messages\n\nThe correct syntax is already suggested due to the return\nvalue used.\n\nWhile at it, apply some minor code improvements.\n\nChange-Id: Idf3d7a46ddecd70823e06bc3997f41fcdb8e501f\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\n"}},"90159f5f70ffeaa43b1459b8e4cc60329f6914aa":{"kind":"REWORK","_number":3,"created":"2023-11-12 18:19:38.000000000","uploader":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"ref":"refs/changes/00/8000/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/00/8000/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/00/8000/3 \u0026\u0026 git checkout -b change-8000 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/00/8000/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/00/8000/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/00/8000/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/00/8000/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/00/8000/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b388f4805c3ce6e0b7ce7e5995c9305529db8e46","subject":"OpenOCD memory leak in `hwthread_update_threads()`"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2023-11-11 09:18:53.000000000","tz":60},"committer":{"name":"Marc Schink","email":"dev@zapb.de","date":"2023-11-12 18:19:04.000000000","tz":60},"subject":"flash/nor/stm32h7x: Remove redundant error messages","message":"flash/nor/stm32h7x: Remove redundant error messages\n\nThe correct syntax is already suggested due to the return\nvalue used.\n\nWhile at it, apply some minor code improvements.\n\nChange-Id: Idf3d7a46ddecd70823e06bc3997f41fcdb8e501f\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\n"}},"330011b756d4173c36357e78c393326a41033c26":{"kind":"REWORK","_number":1,"created":"2023-11-11 09:29:45.000000000","uploader":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"ref":"refs/changes/00/8000/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/00/8000/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/00/8000/1 \u0026\u0026 git checkout -b change-8000 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/00/8000/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/00/8000/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/00/8000/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/00/8000/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/00/8000/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1f8c3cdb1541ffaeb2fa23c786fd38c928e22632","subject":"flash/nor/stm32f2x: Remove redundant error messages"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2023-11-11 09:18:53.000000000","tz":60},"committer":{"name":"Marc Schink","email":"dev@zapb.de","date":"2023-11-11 09:18:53.000000000","tz":60},"subject":"flash/nor/stm32h7x: Remove redundant error messages","message":"flash/nor/stm32h7x: Remove redundant error messages\n\nThe correct syntax is already suggested due to the return\nvalue used.\n\nChange-Id: Idf3d7a46ddecd70823e06bc3997f41fcdb8e501f\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}
