)]}'
{"id":"openocd~master~Id32440cdd531077008abd679add32246c4249eb2","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000853":{"account":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"last_update":"2023-11-18 11:33:53.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Id32440cdd531077008abd679add32246c4249eb2","subject":"flash/nor/stm32l4x: Remove redundant error messages","status":"MERGED","created":"2023-11-11 09:29:45.000000000","updated":"2023-11-18 11:33:53.000000000","submitted":"2023-11-18 11:33:53.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":14,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8001","meta_rev_id":"dddeabb6a8775f028a4c963478395f39254c8a18","_number":8001,"owner":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-11-18 11:33:53.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-11-18 11:33:53.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-11-18 11:33:53.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-11-11 10:22:33.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-11-11 15:13:01.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"CC"},{"updated":"2023-11-12 16:15:54.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"},{"updated":"2023-11-12 20:28:04.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"}],"messages":[{"id":"4576756473931b1eb7af806ab731627ba4704a17","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2023-11-11 09:29:45.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"01a330e533b40cfd2395e9e68967308b2b8f38dd","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-11-11 10:22:33.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/18702/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/17887/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"71a764a3b8502729a3afd0e1c5be1f0b9b0e1fc2","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-11-11 15:13:01.000000000","message":"Patch Set 1:\n\n(7 comments)","accounts_in_message":[],"_revision_number":1},{"id":"bd70969747f1b94395c0c5b39251c08dfac6327b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2023-11-12 10:20:49.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"67ade715640e4718d087aa792badcce0d41f248b","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-11-12 11:30:31.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/18717/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/17899/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"c70551652f53b4ec3bc8e6bb9242ac16365ee65d","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-11-12 16:15:54.000000000","message":"Patch Set 2: Code-Review+1\n\n(7 comments)","accounts_in_message":[],"_revision_number":2},{"id":"8fe4d0d156f930c39ee029ec7cbddea58a2177f3","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-11-12 20:28:04.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"dddeabb6a8775f028a4c963478395f39254c8a18","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-11-18 11:33:53.000000000","message":"Change has been successfully cherry-picked as ea07b3c53a5538dfd9732bb9a5a70f1b1c7c7308","accounts_in_message":[],"_revision_number":3}],"current_revision":"ea07b3c53a5538dfd9732bb9a5a70f1b1c7c7308","revisions":{"510cdad909358188eec19879a4e3f5a705b720af":{"kind":"REWORK","_number":2,"created":"2023-11-12 10:20:49.000000000","uploader":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"ref":"refs/changes/01/8001/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/01/8001/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/01/8001/2 \u0026\u0026 git checkout -b change-8001 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/01/8001/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/01/8001/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/01/8001/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/01/8001/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/01/8001/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"92021f6f5d0c9c1dde24063b428204c48112b589","subject":"flash/nor/stm32h7x: Remove redundant error messages"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2023-11-11 09:19:43.000000000","tz":60},"committer":{"name":"Marc Schink","email":"dev@zapb.de","date":"2023-11-12 10:20:18.000000000","tz":60},"subject":"flash/nor/stm32l4x: Remove redundant error messages","message":"flash/nor/stm32l4x: Remove redundant error messages\n\nThe correct syntax is already suggested due to the return\nvalue used.\n\nWhile at it, apply some minor code improvements.\n\nChange-Id: Id32440cdd531077008abd679add32246c4249eb2\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\n"}},"ea07b3c53a5538dfd9732bb9a5a70f1b1c7c7308":{"kind":"REWORK","_number":3,"created":"2023-11-18 11:33:53.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/01/8001/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/01/8001/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/01/8001/3 \u0026\u0026 git checkout -b change-8001 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/01/8001/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/01/8001/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/01/8001/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/01/8001/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/01/8001/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b310b3ba9d89a059e0edc4f374a31632ec1c58fd","subject":"flash/nor/stm32h7x: Remove redundant error messages"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2023-11-11 09:19:43.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-11-18 11:33:53.000000000","tz":0},"subject":"flash/nor/stm32l4x: Remove redundant error messages","message":"flash/nor/stm32l4x: Remove redundant error messages\n\nThe correct syntax is already suggested due to the return\nvalue used.\n\nWhile at it, apply some minor code improvements.\n\nChange-Id: Id32440cdd531077008abd679add32246c4249eb2\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8001\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nTested-by: jenkins\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"bce0c59bc8827def0983056d4df7a020e266bf54":{"kind":"REWORK","_number":1,"created":"2023-11-11 09:29:45.000000000","uploader":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"ref":"refs/changes/01/8001/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/01/8001/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/01/8001/1 \u0026\u0026 git checkout -b change-8001 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/01/8001/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/01/8001/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/01/8001/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/01/8001/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/01/8001/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"330011b756d4173c36357e78c393326a41033c26","subject":"flash/nor/stm32h7x: Remove redundant error messages"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2023-11-11 09:19:43.000000000","tz":60},"committer":{"name":"Marc Schink","email":"dev@zapb.de","date":"2023-11-11 09:19:43.000000000","tz":60},"subject":"flash/nor/stm32l4x: Remove redundant error messages","message":"flash/nor/stm32l4x: Remove redundant error messages\n\nThe correct syntax is already suggested due to the return\nvalue used.\n\nChange-Id: Id32440cdd531077008abd679add32246c4249eb2\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}