)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"0bc3a170bf22bc1f4502e384b2e5ff50c25232aa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"88fbc257_018108eb","updated":"2023-11-13 22:18:00.000000000","message":"Thanks for the patch.\nI\u0027m not expert of this flash part of OpenOCD, so I would not run a deep review.\nBut I have two comments, below","commit_id":"e0eae3d1719b46bcfdd37b96fcb73ff54ae0d5a8"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"d314138f420cc63d4d6a5473168b410ffa640a25","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"e85deb04_1cba35f0","updated":"2023-12-06 17:15:21.000000000","message":"Thanks Carlos.\n\nThe code looks good - although I don\u0027t have a device to test.\nI commented just couple of minor issues.\n\nPlease update doc/openocd.texi, chapter `12.5.2 Internal Flash (Microcontrollers)`. Please make clear what is supported and what is not (NVM?)","commit_id":"2a88d32888540db37d08998d4f3bcdb311190960"},{"author":{"_account_id":1002207,"name":"Carlos Sanchez","email":"carlossanchez@geotab.com","username":"carlossanchez"},"change_message_id":"700528c25bc170192431d8adeb0c29a7c67873e6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ba5ade53_90a5c279","in_reply_to":"3b501792_a1ba2569","updated":"2023-12-28 10:34:18.000000000","message":"Agreed with your latest comments and changed accordingly. Tested again on my devices (S32K and other non-kinetis), no errors detected.","commit_id":"2a88d32888540db37d08998d4f3bcdb311190960"},{"author":{"_account_id":1002207,"name":"Carlos Sanchez","email":"carlossanchez@geotab.com","username":"carlossanchez"},"change_message_id":"a92af32c97404920a4c5102c742c1bf919f580bc","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3b501792_a1ba2569","in_reply_to":"e85deb04_1cba35f0","updated":"2023-12-15 13:21:08.000000000","message":"Thanks Tomas, I was on vacation and just saw your answer. Let me do the changes on my side, test it on my setup for a couple of day to make sure nothing breaks, and I will update the patch.","commit_id":"2a88d32888540db37d08998d4f3bcdb311190960"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"a7e2ca83002ff2870df68c97614d7bd681f6fac9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"47a14a50_610df37c","updated":"2023-12-28 16:15:18.000000000","message":"Looks good, just the last nit","commit_id":"b397adcdb78d03c98ffa50cc3508503cfd102922"}],"src/flash/nor/kinetis.c":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"d314138f420cc63d4d6a5473168b410ffa640a25","unresolved":true,"context_lines":[{"line_number":2089,"context_line":"\tint result;"},{"line_number":2090,"context_line":"\tuint8_t fcfg1_eesize, fcfg1_depart;"},{"line_number":2091,"context_line":"\tuint32_t ee_size \u003d 0;"},{"line_number":2092,"context_line":"\tuint8_t generation \u003d 0, subseries \u003d 0, derivate \u003d 0;"},{"line_number":2093,"context_line":""},{"line_number":2094,"context_line":"\tstruct target *target \u003d k_chip-\u003etarget;"},{"line_number":2095,"context_line":"\tk_chip-\u003eprobed \u003d false;"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"43a91830_f1a1d0b1","line":2092,"range":{"start_line":2092,"start_character":1,"end_line":2092,"end_character":8},"updated":"2023-12-06 17:15:21.000000000","message":"Native type unsigned int will ease printing later","commit_id":"2a88d32888540db37d08998d4f3bcdb311190960"},{"author":{"_account_id":1002207,"name":"Carlos Sanchez","email":"carlossanchez@geotab.com","username":"carlossanchez"},"change_message_id":"700528c25bc170192431d8adeb0c29a7c67873e6","unresolved":false,"context_lines":[{"line_number":2089,"context_line":"\tint result;"},{"line_number":2090,"context_line":"\tuint8_t fcfg1_eesize, fcfg1_depart;"},{"line_number":2091,"context_line":"\tuint32_t ee_size \u003d 0;"},{"line_number":2092,"context_line":"\tuint8_t generation \u003d 0, subseries \u003d 0, derivate \u003d 0;"},{"line_number":2093,"context_line":""},{"line_number":2094,"context_line":"\tstruct target *target \u003d k_chip-\u003etarget;"},{"line_number":2095,"context_line":"\tk_chip-\u003eprobed \u003d false;"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"a8608bc6_299ad9d4","line":2092,"range":{"start_line":2092,"start_character":1,"end_line":2092,"end_character":8},"in_reply_to":"3e01f308_31cf2a75","updated":"2023-12-28 10:34:18.000000000","message":"Done","commit_id":"2a88d32888540db37d08998d4f3bcdb311190960"},{"author":{"_account_id":1002207,"name":"Carlos Sanchez","email":"carlossanchez@geotab.com","username":"carlossanchez"},"change_message_id":"cd7de4b0ff2a9d7f9dd895bdb09702eb546705da","unresolved":true,"context_lines":[{"line_number":2089,"context_line":"\tint result;"},{"line_number":2090,"context_line":"\tuint8_t fcfg1_eesize, fcfg1_depart;"},{"line_number":2091,"context_line":"\tuint32_t ee_size \u003d 0;"},{"line_number":2092,"context_line":"\tuint8_t generation \u003d 0, subseries \u003d 0, derivate \u003d 0;"},{"line_number":2093,"context_line":""},{"line_number":2094,"context_line":"\tstruct target *target \u003d k_chip-\u003etarget;"},{"line_number":2095,"context_line":"\tk_chip-\u003eprobed \u003d false;"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"ddb42e9a_c28f4c7f","line":2092,"range":{"start_line":2092,"start_character":1,"end_line":2092,"end_character":8},"in_reply_to":"43a91830_f1a1d0b1","updated":"2023-12-27 16:41:17.000000000","message":"Agreed, changing to native char.","commit_id":"2a88d32888540db37d08998d4f3bcdb311190960"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"2406f2a70d1ce9e8ecbe44e73dd7465a3836d5c5","unresolved":true,"context_lines":[{"line_number":2089,"context_line":"\tint result;"},{"line_number":2090,"context_line":"\tuint8_t fcfg1_eesize, fcfg1_depart;"},{"line_number":2091,"context_line":"\tuint32_t ee_size \u003d 0;"},{"line_number":2092,"context_line":"\tuint8_t generation \u003d 0, subseries \u003d 0, derivate \u003d 0;"},{"line_number":2093,"context_line":""},{"line_number":2094,"context_line":"\tstruct target *target \u003d k_chip-\u003etarget;"},{"line_number":2095,"context_line":"\tk_chip-\u003eprobed \u003d false;"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"3e01f308_31cf2a75","line":2092,"range":{"start_line":2092,"start_character":1,"end_line":2092,"end_character":8},"in_reply_to":"ddb42e9a_c28f4c7f","updated":"2023-12-27 21:02:22.000000000","message":"I recommended \u0027unsigned int\u0027, certainly not \u0027char\u0027!\nSee our style guide https://openocd.org/doc/doxygen/html/stylec.html#styletypes\nIn this case the type size is NOT important and value is NOT signed.","commit_id":"2a88d32888540db37d08998d4f3bcdb311190960"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"d314138f420cc63d4d6a5473168b410ffa640a25","unresolved":true,"context_lines":[{"line_number":2093,"context_line":""},{"line_number":2094,"context_line":"\tstruct target *target \u003d k_chip-\u003etarget;"},{"line_number":2095,"context_line":"\tk_chip-\u003eprobed \u003d false;"},{"line_number":2096,"context_line":"\tk_chip-\u003esim_base \u003d SIM_BASE;"},{"line_number":2097,"context_line":"\tk_chip-\u003epflash_sector_size \u003d 0;"},{"line_number":2098,"context_line":"\tk_chip-\u003epflash_base \u003d 0;"},{"line_number":2099,"context_line":"\tk_chip-\u003envm_base \u003d 0x10000000;"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"57df3c5f_b779fdbc","line":2096,"updated":"2023-12-06 17:15:21.000000000","message":"Wouldn\u0027t be better to set default base only if k_chip-\u003esim_base !\u003d 0\nto keep -sim-base option working? (Although the option is not needed for S32K)","commit_id":"2a88d32888540db37d08998d4f3bcdb311190960"},{"author":{"_account_id":1002207,"name":"Carlos Sanchez","email":"carlossanchez@geotab.com","username":"carlossanchez"},"change_message_id":"cd7de4b0ff2a9d7f9dd895bdb09702eb546705da","unresolved":true,"context_lines":[{"line_number":2093,"context_line":""},{"line_number":2094,"context_line":"\tstruct target *target \u003d k_chip-\u003etarget;"},{"line_number":2095,"context_line":"\tk_chip-\u003eprobed \u003d false;"},{"line_number":2096,"context_line":"\tk_chip-\u003esim_base \u003d SIM_BASE;"},{"line_number":2097,"context_line":"\tk_chip-\u003epflash_sector_size \u003d 0;"},{"line_number":2098,"context_line":"\tk_chip-\u003epflash_base \u003d 0;"},{"line_number":2099,"context_line":"\tk_chip-\u003envm_base \u003d 0x10000000;"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"dfcf5432_3fd8cd12","line":2096,"in_reply_to":"57df3c5f_b779fdbc","updated":"2023-12-27 16:41:17.000000000","message":"I think you mean set default when k_chip-\u003esim_base \u003d\u003d 0 (meaning the explicit option was not given)","commit_id":"2a88d32888540db37d08998d4f3bcdb311190960"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"2406f2a70d1ce9e8ecbe44e73dd7465a3836d5c5","unresolved":false,"context_lines":[{"line_number":2093,"context_line":""},{"line_number":2094,"context_line":"\tstruct target *target \u003d k_chip-\u003etarget;"},{"line_number":2095,"context_line":"\tk_chip-\u003eprobed \u003d false;"},{"line_number":2096,"context_line":"\tk_chip-\u003esim_base \u003d SIM_BASE;"},{"line_number":2097,"context_line":"\tk_chip-\u003epflash_sector_size \u003d 0;"},{"line_number":2098,"context_line":"\tk_chip-\u003epflash_base \u003d 0;"},{"line_number":2099,"context_line":"\tk_chip-\u003envm_base \u003d 0x10000000;"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"e3679e40_6caf9445","line":2096,"in_reply_to":"dfcf5432_3fd8cd12","updated":"2023-12-27 21:02:22.000000000","message":"Yes, I meant \u003d\u003d 0","commit_id":"2a88d32888540db37d08998d4f3bcdb311190960"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"d314138f420cc63d4d6a5473168b410ffa640a25","unresolved":true,"context_lines":[{"line_number":2223,"context_line":"\t\t\tk_chip-\u003edflash_size \u003d 0;"},{"line_number":2224,"context_line":"\t}"},{"line_number":2225,"context_line":""},{"line_number":2226,"context_line":"\tsnprintf(k_chip-\u003ename, sizeof(k_chip-\u003ename), \"S32K%u%u%u\","},{"line_number":2227,"context_line":"\t\t generation, subseries, derivate);"},{"line_number":2228,"context_line":""},{"line_number":2229,"context_line":"\tLOG_INFO(\"%s detected: %u flash blocks\", k_chip-\u003ename, k_chip-\u003enum_pflash_blocks + k_chip-\u003enum_nvm_blocks);"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"92e4686c_fe0052a5","line":2226,"range":{"start_line":2226,"start_character":51,"end_line":2226,"end_character":57},"updated":"2023-12-06 17:15:21.000000000","message":"Should be PRIu8 - but better alternative is native type of generation, subseries and derivate","commit_id":"2a88d32888540db37d08998d4f3bcdb311190960"},{"author":{"_account_id":1002207,"name":"Carlos Sanchez","email":"carlossanchez@geotab.com","username":"carlossanchez"},"change_message_id":"1a13a66475cc224471a2ef683843ae1d3b98e13d","unresolved":false,"context_lines":[{"line_number":2223,"context_line":"\t\t\tk_chip-\u003edflash_size \u003d 0;"},{"line_number":2224,"context_line":"\t}"},{"line_number":2225,"context_line":""},{"line_number":2226,"context_line":"\tsnprintf(k_chip-\u003ename, sizeof(k_chip-\u003ename), \"S32K%u%u%u\","},{"line_number":2227,"context_line":"\t\t generation, subseries, derivate);"},{"line_number":2228,"context_line":""},{"line_number":2229,"context_line":"\tLOG_INFO(\"%s detected: %u flash blocks\", k_chip-\u003ename, k_chip-\u003enum_pflash_blocks + k_chip-\u003enum_nvm_blocks);"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"e5690df3_e5aaabe7","line":2226,"range":{"start_line":2226,"start_character":51,"end_line":2226,"end_character":57},"in_reply_to":"92e4686c_fe0052a5","updated":"2023-12-27 16:45:35.000000000","message":"Done","commit_id":"2a88d32888540db37d08998d4f3bcdb311190960"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"d314138f420cc63d4d6a5473168b410ffa640a25","unresolved":true,"context_lines":[{"line_number":2227,"context_line":"\t\t generation, subseries, derivate);"},{"line_number":2228,"context_line":""},{"line_number":2229,"context_line":"\tLOG_INFO(\"%s detected: %u flash blocks\", k_chip-\u003ename, k_chip-\u003enum_pflash_blocks + k_chip-\u003enum_nvm_blocks);"},{"line_number":2230,"context_line":"\tLOG_INFO(\"%u PFlash banks: %\" PRIu32 \" KiB total\", k_chip-\u003enum_pflash_blocks, k_chip-\u003epflash_size / 1024);"},{"line_number":2231,"context_line":""},{"line_number":2232,"context_line":"\tif (k_chip-\u003enum_nvm_blocks) {"},{"line_number":2233,"context_line":"\t\tLOG_INFO(\"%u FlexNVM banks: %\" PRIu32 \" KiB total, %\" PRIu32 \" KiB available as data flash, %\""}],"source_content_type":"text/x-csrc","patch_set":5,"id":"0b01b27c_fa702f98","line":2230,"range":{"start_line":2230,"start_character":31,"end_line":2230,"end_character":37},"updated":"2023-12-06 17:15:21.000000000","message":"The formatting macro expect uint32_t but the division result gets extended on 64-bit host - see integer promotion rules in C.\nThe safest method is to assign the result to a temporary variable as was used in the original kinetis_probe_chip() code.","commit_id":"2a88d32888540db37d08998d4f3bcdb311190960"},{"author":{"_account_id":1002207,"name":"Carlos Sanchez","email":"carlossanchez@geotab.com","username":"carlossanchez"},"change_message_id":"cd7de4b0ff2a9d7f9dd895bdb09702eb546705da","unresolved":true,"context_lines":[{"line_number":2227,"context_line":"\t\t generation, subseries, derivate);"},{"line_number":2228,"context_line":""},{"line_number":2229,"context_line":"\tLOG_INFO(\"%s detected: %u flash blocks\", k_chip-\u003ename, k_chip-\u003enum_pflash_blocks + k_chip-\u003enum_nvm_blocks);"},{"line_number":2230,"context_line":"\tLOG_INFO(\"%u PFlash banks: %\" PRIu32 \" KiB total\", k_chip-\u003enum_pflash_blocks, k_chip-\u003epflash_size / 1024);"},{"line_number":2231,"context_line":""},{"line_number":2232,"context_line":"\tif (k_chip-\u003enum_nvm_blocks) {"},{"line_number":2233,"context_line":"\t\tLOG_INFO(\"%u FlexNVM banks: %\" PRIu32 \" KiB total, %\" PRIu32 \" KiB available as data flash, %\""}],"source_content_type":"text/x-csrc","patch_set":5,"id":"52d27325_b9e6a9a5","line":2230,"range":{"start_line":2230,"start_character":31,"end_line":2230,"end_character":37},"in_reply_to":"0b01b27c_fa702f98","updated":"2023-12-27 16:41:17.000000000","message":"True, fixed.","commit_id":"2a88d32888540db37d08998d4f3bcdb311190960"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"2406f2a70d1ce9e8ecbe44e73dd7465a3836d5c5","unresolved":false,"context_lines":[{"line_number":2227,"context_line":"\t\t generation, subseries, derivate);"},{"line_number":2228,"context_line":""},{"line_number":2229,"context_line":"\tLOG_INFO(\"%s detected: %u flash blocks\", k_chip-\u003ename, k_chip-\u003enum_pflash_blocks + k_chip-\u003enum_nvm_blocks);"},{"line_number":2230,"context_line":"\tLOG_INFO(\"%u PFlash banks: %\" PRIu32 \" KiB total\", k_chip-\u003enum_pflash_blocks, k_chip-\u003epflash_size / 1024);"},{"line_number":2231,"context_line":""},{"line_number":2232,"context_line":"\tif (k_chip-\u003enum_nvm_blocks) {"},{"line_number":2233,"context_line":"\t\tLOG_INFO(\"%u FlexNVM banks: %\" PRIu32 \" KiB total, %\" PRIu32 \" KiB available as data flash, %\""}],"source_content_type":"text/x-csrc","patch_set":5,"id":"814343e3_00e6aef6","line":2230,"range":{"start_line":2230,"start_character":31,"end_line":2230,"end_character":37},"in_reply_to":"52d27325_b9e6a9a5","updated":"2023-12-27 21:02:22.000000000","message":"Done","commit_id":"2a88d32888540db37d08998d4f3bcdb311190960"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"d314138f420cc63d4d6a5473168b410ffa640a25","unresolved":true,"context_lines":[{"line_number":2230,"context_line":"\tLOG_INFO(\"%u PFlash banks: %\" PRIu32 \" KiB total\", k_chip-\u003enum_pflash_blocks, k_chip-\u003epflash_size / 1024);"},{"line_number":2231,"context_line":""},{"line_number":2232,"context_line":"\tif (k_chip-\u003enum_nvm_blocks) {"},{"line_number":2233,"context_line":"\t\tLOG_INFO(\"%u FlexNVM banks: %\" PRIu32 \" KiB total, %\" PRIu32 \" KiB available as data flash, %\""},{"line_number":2234,"context_line":"\t\t\t PRIu32 \" bytes FlexRAM\","},{"line_number":2235,"context_line":"\t\t\t k_chip-\u003enum_nvm_blocks, k_chip-\u003envm_size / 1024, k_chip-\u003edflash_size / 1024, ee_size);"},{"line_number":2236,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"b4a9d391_0235f56d","line":2233,"range":{"start_line":2233,"start_character":33,"end_line":2233,"end_character":62},"updated":"2023-12-06 17:15:21.000000000","message":"Same here","commit_id":"2a88d32888540db37d08998d4f3bcdb311190960"},{"author":{"_account_id":1002207,"name":"Carlos Sanchez","email":"carlossanchez@geotab.com","username":"carlossanchez"},"change_message_id":"1a13a66475cc224471a2ef683843ae1d3b98e13d","unresolved":false,"context_lines":[{"line_number":2230,"context_line":"\tLOG_INFO(\"%u PFlash banks: %\" PRIu32 \" KiB total\", k_chip-\u003enum_pflash_blocks, k_chip-\u003epflash_size / 1024);"},{"line_number":2231,"context_line":""},{"line_number":2232,"context_line":"\tif (k_chip-\u003enum_nvm_blocks) {"},{"line_number":2233,"context_line":"\t\tLOG_INFO(\"%u FlexNVM banks: %\" PRIu32 \" KiB total, %\" PRIu32 \" KiB available as data flash, %\""},{"line_number":2234,"context_line":"\t\t\t PRIu32 \" bytes FlexRAM\","},{"line_number":2235,"context_line":"\t\t\t k_chip-\u003enum_nvm_blocks, k_chip-\u003envm_size / 1024, k_chip-\u003edflash_size / 1024, ee_size);"},{"line_number":2236,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"b6143afa_62c97a48","line":2233,"range":{"start_line":2233,"start_character":33,"end_line":2233,"end_character":62},"in_reply_to":"b4a9d391_0235f56d","updated":"2023-12-27 16:45:35.000000000","message":"Done","commit_id":"2a88d32888540db37d08998d4f3bcdb311190960"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"d314138f420cc63d4d6a5473168b410ffa640a25","unresolved":true,"context_lines":[{"line_number":2961,"context_line":"\t\treturn ERROR_FLASH_BANK_INVALID;"},{"line_number":2962,"context_line":"\t}"},{"line_number":2963,"context_line":""},{"line_number":2964,"context_line":"\t/* S32K1xx does not implemen FCFG2 register. Skip checks. */"},{"line_number":2965,"context_line":"\tif (k_chip-\u003esim_fcfg2 \u003d\u003d 0)"},{"line_number":2966,"context_line":"\t\tgoto skip_maxaddr;"},{"line_number":2967,"context_line":"\tfcfg2_pflsh \u003d (uint8_t)((k_chip-\u003esim_fcfg2 \u003e\u003e 23) \u0026 0x01);"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"1b0f0447_eb553adc","line":2964,"range":{"start_line":2964,"start_character":21,"end_line":2964,"end_character":29},"updated":"2023-12-06 17:15:21.000000000","message":"implement","commit_id":"2a88d32888540db37d08998d4f3bcdb311190960"},{"author":{"_account_id":1002207,"name":"Carlos Sanchez","email":"carlossanchez@geotab.com","username":"carlossanchez"},"change_message_id":"1a13a66475cc224471a2ef683843ae1d3b98e13d","unresolved":false,"context_lines":[{"line_number":2961,"context_line":"\t\treturn ERROR_FLASH_BANK_INVALID;"},{"line_number":2962,"context_line":"\t}"},{"line_number":2963,"context_line":""},{"line_number":2964,"context_line":"\t/* S32K1xx does not implemen FCFG2 register. Skip checks. */"},{"line_number":2965,"context_line":"\tif (k_chip-\u003esim_fcfg2 \u003d\u003d 0)"},{"line_number":2966,"context_line":"\t\tgoto skip_maxaddr;"},{"line_number":2967,"context_line":"\tfcfg2_pflsh \u003d (uint8_t)((k_chip-\u003esim_fcfg2 \u003e\u003e 23) \u0026 0x01);"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"a4199e45_7a913306","line":2964,"range":{"start_line":2964,"start_character":21,"end_line":2964,"end_character":29},"in_reply_to":"1b0f0447_eb553adc","updated":"2023-12-27 16:45:35.000000000","message":"Done","commit_id":"2a88d32888540db37d08998d4f3bcdb311190960"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"18c1a1a48a10342c45c9526413203193baa0671f","unresolved":true,"context_lines":[{"line_number":2962,"context_line":"\t}"},{"line_number":2963,"context_line":""},{"line_number":2964,"context_line":"\t/* S32K1xx does not implemen FCFG2 register. Skip checks. */"},{"line_number":2965,"context_line":"\tif (k_chip-\u003esim_fcfg2 \u003d\u003d 0)"},{"line_number":2966,"context_line":"\t\tgoto skip_maxaddr;"},{"line_number":2967,"context_line":"\tfcfg2_pflsh \u003d (uint8_t)((k_chip-\u003esim_fcfg2 \u003e\u003e 23) \u0026 0x01);"},{"line_number":2968,"context_line":"\tfcfg2_maxaddr0 \u003d (uint8_t)((k_chip-\u003esim_fcfg2 \u003e\u003e 24) \u0026 0x7f);"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"6665163d_d706f200","line":2965,"updated":"2023-12-06 18:04:29.000000000","message":"In a corner case (SWD/JTAG read error not detected by parity check - not unlikely if WDOG repeatedly fires reset on a device with a clean flash) we can get zero sim_fcfg2 even on an old Kinetis. To make the code robust I would recommend adding a new enum to k_chip to distinguish Kinetis from S32K devices.\nIt may be set directly on detecting -s32k option and may replace probe_chip pointer.","commit_id":"2a88d32888540db37d08998d4f3bcdb311190960"},{"author":{"_account_id":1002207,"name":"Carlos Sanchez","email":"carlossanchez@geotab.com","username":"carlossanchez"},"change_message_id":"700528c25bc170192431d8adeb0c29a7c67873e6","unresolved":false,"context_lines":[{"line_number":2962,"context_line":"\t}"},{"line_number":2963,"context_line":""},{"line_number":2964,"context_line":"\t/* S32K1xx does not implemen FCFG2 register. Skip checks. */"},{"line_number":2965,"context_line":"\tif (k_chip-\u003esim_fcfg2 \u003d\u003d 0)"},{"line_number":2966,"context_line":"\t\tgoto skip_maxaddr;"},{"line_number":2967,"context_line":"\tfcfg2_pflsh \u003d (uint8_t)((k_chip-\u003esim_fcfg2 \u003e\u003e 23) \u0026 0x01);"},{"line_number":2968,"context_line":"\tfcfg2_maxaddr0 \u003d (uint8_t)((k_chip-\u003esim_fcfg2 \u003e\u003e 24) \u0026 0x7f);"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"05e07145_583fa6ba","line":2965,"in_reply_to":"62e08628_dbd6f723","updated":"2023-12-28 10:34:18.000000000","message":"Done","commit_id":"2a88d32888540db37d08998d4f3bcdb311190960"},{"author":{"_account_id":1002207,"name":"Carlos Sanchez","email":"carlossanchez@geotab.com","username":"carlossanchez"},"change_message_id":"cd7de4b0ff2a9d7f9dd895bdb09702eb546705da","unresolved":true,"context_lines":[{"line_number":2962,"context_line":"\t}"},{"line_number":2963,"context_line":""},{"line_number":2964,"context_line":"\t/* S32K1xx does not implemen FCFG2 register. Skip checks. */"},{"line_number":2965,"context_line":"\tif (k_chip-\u003esim_fcfg2 \u003d\u003d 0)"},{"line_number":2966,"context_line":"\t\tgoto skip_maxaddr;"},{"line_number":2967,"context_line":"\tfcfg2_pflsh \u003d (uint8_t)((k_chip-\u003esim_fcfg2 \u003e\u003e 23) \u0026 0x01);"},{"line_number":2968,"context_line":"\tfcfg2_maxaddr0 \u003d (uint8_t)((k_chip-\u003esim_fcfg2 \u003e\u003e 24) \u0026 0x7f);"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"e350e4d8_8c8152e6","line":2965,"in_reply_to":"6665163d_d706f200","updated":"2023-12-27 16:41:17.000000000","message":"I agree, the check for 0 here is not robust. Instead of adding an enum, I check probe_chip against the s32k-specific probing function, which is set when -s32k option is given. We save creating the enum this way. I can use an enum if you prefer.\nAn enum could be much more handy if we commonalized both proving functions, but I think it is not worth it as most of the code would be branching based on the enum.","commit_id":"2a88d32888540db37d08998d4f3bcdb311190960"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"2406f2a70d1ce9e8ecbe44e73dd7465a3836d5c5","unresolved":true,"context_lines":[{"line_number":2962,"context_line":"\t}"},{"line_number":2963,"context_line":""},{"line_number":2964,"context_line":"\t/* S32K1xx does not implemen FCFG2 register. Skip checks. */"},{"line_number":2965,"context_line":"\tif (k_chip-\u003esim_fcfg2 \u003d\u003d 0)"},{"line_number":2966,"context_line":"\t\tgoto skip_maxaddr;"},{"line_number":2967,"context_line":"\tfcfg2_pflsh \u003d (uint8_t)((k_chip-\u003esim_fcfg2 \u003e\u003e 23) \u0026 0x01);"},{"line_number":2968,"context_line":"\tfcfg2_maxaddr0 \u003d (uint8_t)((k_chip-\u003esim_fcfg2 \u003e\u003e 24) \u0026 0x7f);"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"62e08628_dbd6f723","line":2965,"in_reply_to":"e350e4d8_8c8152e6","updated":"2023-12-27 21:02:22.000000000","message":"Please introduce and use the enum. The test will be easily readable.\nSuch unexpected side effect of a variable could result in a bug after a future change (let\u0027s say a new probe func is introduced).\nIf you want you may also dispatch the probe variant according to the enum instead of storing probe func address.","commit_id":"2a88d32888540db37d08998d4f3bcdb311190960"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"d314138f420cc63d4d6a5473168b410ffa640a25","unresolved":true,"context_lines":[{"line_number":2963,"context_line":""},{"line_number":2964,"context_line":"\t/* S32K1xx does not implemen FCFG2 register. Skip checks. */"},{"line_number":2965,"context_line":"\tif (k_chip-\u003esim_fcfg2 \u003d\u003d 0)"},{"line_number":2966,"context_line":"\t\tgoto skip_maxaddr;"},{"line_number":2967,"context_line":"\tfcfg2_pflsh \u003d (uint8_t)((k_chip-\u003esim_fcfg2 \u003e\u003e 23) \u0026 0x01);"},{"line_number":2968,"context_line":"\tfcfg2_maxaddr0 \u003d (uint8_t)((k_chip-\u003esim_fcfg2 \u003e\u003e 24) \u0026 0x7f);"},{"line_number":2969,"context_line":"\tfcfg2_maxaddr1 \u003d (uint8_t)((k_chip-\u003esim_fcfg2 \u003e\u003e 16) \u0026 0x7f);"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"caa4361d_95fbf19c","line":2966,"updated":"2023-12-06 17:15:21.000000000","message":"Use a conditional block instead of goto","commit_id":"2a88d32888540db37d08998d4f3bcdb311190960"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"2406f2a70d1ce9e8ecbe44e73dd7465a3836d5c5","unresolved":false,"context_lines":[{"line_number":2963,"context_line":""},{"line_number":2964,"context_line":"\t/* S32K1xx does not implemen FCFG2 register. Skip checks. */"},{"line_number":2965,"context_line":"\tif (k_chip-\u003esim_fcfg2 \u003d\u003d 0)"},{"line_number":2966,"context_line":"\t\tgoto skip_maxaddr;"},{"line_number":2967,"context_line":"\tfcfg2_pflsh \u003d (uint8_t)((k_chip-\u003esim_fcfg2 \u003e\u003e 23) \u0026 0x01);"},{"line_number":2968,"context_line":"\tfcfg2_maxaddr0 \u003d (uint8_t)((k_chip-\u003esim_fcfg2 \u003e\u003e 24) \u0026 0x7f);"},{"line_number":2969,"context_line":"\tfcfg2_maxaddr1 \u003d (uint8_t)((k_chip-\u003esim_fcfg2 \u003e\u003e 16) \u0026 0x7f);"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"dce1a4aa_0aef824b","line":2966,"in_reply_to":"9a1cc801_730a204a","updated":"2023-12-27 21:02:22.000000000","message":"Done","commit_id":"2a88d32888540db37d08998d4f3bcdb311190960"},{"author":{"_account_id":1002207,"name":"Carlos Sanchez","email":"carlossanchez@geotab.com","username":"carlossanchez"},"change_message_id":"cd7de4b0ff2a9d7f9dd895bdb09702eb546705da","unresolved":true,"context_lines":[{"line_number":2963,"context_line":""},{"line_number":2964,"context_line":"\t/* S32K1xx does not implemen FCFG2 register. Skip checks. */"},{"line_number":2965,"context_line":"\tif (k_chip-\u003esim_fcfg2 \u003d\u003d 0)"},{"line_number":2966,"context_line":"\t\tgoto skip_maxaddr;"},{"line_number":2967,"context_line":"\tfcfg2_pflsh \u003d (uint8_t)((k_chip-\u003esim_fcfg2 \u003e\u003e 23) \u0026 0x01);"},{"line_number":2968,"context_line":"\tfcfg2_maxaddr0 \u003d (uint8_t)((k_chip-\u003esim_fcfg2 \u003e\u003e 24) \u0026 0x7f);"},{"line_number":2969,"context_line":"\tfcfg2_maxaddr1 \u003d (uint8_t)((k_chip-\u003esim_fcfg2 \u003e\u003e 16) \u0026 0x7f);"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"9a1cc801_730a204a","line":2966,"in_reply_to":"caa4361d_95fbf19c","updated":"2023-12-27 16:41:17.000000000","message":"Sure, I did not like this too much, I just used a goto to minimize the patchset and make it obvious there was no functional change here (just a skip). Changing.","commit_id":"2a88d32888540db37d08998d4f3bcdb311190960"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"18c1a1a48a10342c45c9526413203193baa0671f","unresolved":true,"context_lines":[{"line_number":3132,"context_line":""},{"line_number":3133,"context_line":"\tk_chip \u003d kinetis_get_chip(target);"},{"line_number":3134,"context_line":""},{"line_number":3135,"context_line":"\tif (k_chip-\u003esim_fcfg2 \u003d\u003d 0) {"},{"line_number":3136,"context_line":"\t\tLOG_ERROR(\"NVM partition not supported on S32K1xx (yet).\");"},{"line_number":3137,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":3138,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"b145f1ac_e7612a83","line":3135,"range":{"start_line":3135,"start_character":13,"end_line":3135,"end_character":22},"updated":"2023-12-06 18:04:29.000000000","message":"Kind of abusing fcfg2 - an enum distinguishing Kinetis/S32K would be handy...","commit_id":"2a88d32888540db37d08998d4f3bcdb311190960"},{"author":{"_account_id":1002207,"name":"Carlos Sanchez","email":"carlossanchez@geotab.com","username":"carlossanchez"},"change_message_id":"1a13a66475cc224471a2ef683843ae1d3b98e13d","unresolved":false,"context_lines":[{"line_number":3132,"context_line":""},{"line_number":3133,"context_line":"\tk_chip \u003d kinetis_get_chip(target);"},{"line_number":3134,"context_line":""},{"line_number":3135,"context_line":"\tif (k_chip-\u003esim_fcfg2 \u003d\u003d 0) {"},{"line_number":3136,"context_line":"\t\tLOG_ERROR(\"NVM partition not supported on S32K1xx (yet).\");"},{"line_number":3137,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":3138,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"c49968d4_f67a181a","line":3135,"range":{"start_line":3135,"start_character":13,"end_line":3135,"end_character":22},"in_reply_to":"b145f1ac_e7612a83","updated":"2023-12-27 16:45:35.000000000","message":"Done","commit_id":"2a88d32888540db37d08998d4f3bcdb311190960"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"2406f2a70d1ce9e8ecbe44e73dd7465a3836d5c5","unresolved":true,"context_lines":[{"line_number":3132,"context_line":""},{"line_number":3133,"context_line":"\tk_chip \u003d kinetis_get_chip(target);"},{"line_number":3134,"context_line":""},{"line_number":3135,"context_line":"\tif (k_chip-\u003esim_fcfg2 \u003d\u003d 0) {"},{"line_number":3136,"context_line":"\t\tLOG_ERROR(\"NVM partition not supported on S32K1xx (yet).\");"},{"line_number":3137,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":3138,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"e5c1c03a_0d712c67","line":3135,"range":{"start_line":3135,"start_character":13,"end_line":3135,"end_character":22},"in_reply_to":"c49968d4_f67a181a","updated":"2023-12-27 21:02:22.000000000","message":"Same as above","commit_id":"2a88d32888540db37d08998d4f3bcdb311190960"},{"author":{"_account_id":1002207,"name":"Carlos Sanchez","email":"carlossanchez@geotab.com","username":"carlossanchez"},"change_message_id":"700528c25bc170192431d8adeb0c29a7c67873e6","unresolved":false,"context_lines":[{"line_number":3132,"context_line":""},{"line_number":3133,"context_line":"\tk_chip \u003d kinetis_get_chip(target);"},{"line_number":3134,"context_line":""},{"line_number":3135,"context_line":"\tif (k_chip-\u003esim_fcfg2 \u003d\u003d 0) {"},{"line_number":3136,"context_line":"\t\tLOG_ERROR(\"NVM partition not supported on S32K1xx (yet).\");"},{"line_number":3137,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":3138,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"1e1c9465_6cf1a059","line":3135,"range":{"start_line":3135,"start_character":13,"end_line":3135,"end_character":22},"in_reply_to":"e5c1c03a_0d712c67","updated":"2023-12-28 10:34:18.000000000","message":"Done","commit_id":"2a88d32888540db37d08998d4f3bcdb311190960"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"a7e2ca83002ff2870df68c97614d7bd681f6fac9","unresolved":true,"context_lines":[{"line_number":302,"context_line":"\t      CT_KINETIS \u003d 0,"},{"line_number":303,"context_line":"\t      CT_S32K,"},{"line_number":304,"context_line":"\t} chip_type;"},{"line_number":305,"context_line":"\tenum {"},{"line_number":306,"context_line":"\t\tFS_PROGRAM_SECTOR \u003d 1,"},{"line_number":307,"context_line":"\t\tFS_PROGRAM_LONGWORD \u003d 2,"},{"line_number":308,"context_line":"\t\tFS_PROGRAM_PHRASE \u003d 4,\t\t/* Unsupported */"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"bf3e354e_049a109f","line":305,"updated":"2023-12-28 16:15:18.000000000","message":"An empty line please.","commit_id":"b397adcdb78d03c98ffa50cc3508503cfd102922"},{"author":{"_account_id":1002207,"name":"Carlos Sanchez","email":"carlossanchez@geotab.com","username":"carlossanchez"},"change_message_id":"d6901c4131a851c21d909f789fa4b8a801899255","unresolved":false,"context_lines":[{"line_number":302,"context_line":"\t      CT_KINETIS \u003d 0,"},{"line_number":303,"context_line":"\t      CT_S32K,"},{"line_number":304,"context_line":"\t} chip_type;"},{"line_number":305,"context_line":"\tenum {"},{"line_number":306,"context_line":"\t\tFS_PROGRAM_SECTOR \u003d 1,"},{"line_number":307,"context_line":"\t\tFS_PROGRAM_LONGWORD \u003d 2,"},{"line_number":308,"context_line":"\t\tFS_PROGRAM_PHRASE \u003d 4,\t\t/* Unsupported */"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"b9490a76_dbca6224","line":305,"in_reply_to":"bf3e354e_049a109f","updated":"2023-12-28 16:25:37.000000000","message":"Done","commit_id":"b397adcdb78d03c98ffa50cc3508503cfd102922"}],"tcl/target/kx.cfg":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"0bc3a170bf22bc1f4502e384b2e5ff50c25232aa","unresolved":true,"context_lines":[{"line_number":40,"context_line":"$_TARGETNAME configure -work-area-phys 0x20000000 -work-area-size $_WORKAREASIZE -work-area-backup 0"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"set _FLASHNAME $_CHIPNAME.pflash"},{"line_number":43,"context_line":"flash bank $_FLASHNAME kinetis 0 0 0 0 $_TARGETNAME -chipname $_CHIPNAME"},{"line_number":44,"context_line":"kinetis create_banks"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"adapter speed 1000"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"c1d57094_57c20ec9","line":43,"updated":"2023-11-13 22:18:00.000000000","message":"The variable _CHIPNAME cannot be used to select the type of device.\nIn fact, if you put two devices of the same type on one board and you want to debug them both with the same OpenOCD (in JTAG daisy-chain), you are forced to rename one of them.\nApparently in your code you read a device ID. Can such device ID be used to automatically detect the device type? Look at stm32l4_parts[] in flash/nor/stm32l4x.c, probably can help.","commit_id":"e0eae3d1719b46bcfdd37b96fcb73ff54ae0d5a8"},{"author":{"_account_id":1002207,"name":"Carlos Sanchez","email":"carlossanchez@geotab.com","username":"carlossanchez"},"change_message_id":"b5e01d8bf3019861044e9efc9d8f91de23685c39","unresolved":false,"context_lines":[{"line_number":40,"context_line":"$_TARGETNAME configure -work-area-phys 0x20000000 -work-area-size $_WORKAREASIZE -work-area-backup 0"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"set _FLASHNAME $_CHIPNAME.pflash"},{"line_number":43,"context_line":"flash bank $_FLASHNAME kinetis 0 0 0 0 $_TARGETNAME -chipname $_CHIPNAME"},{"line_number":44,"context_line":"kinetis create_banks"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"adapter speed 1000"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"d123dd0d_1003c3d8","line":43,"in_reply_to":"21fe5922_5a192c60","updated":"2023-11-19 21:55:38.000000000","message":"Ack","commit_id":"e0eae3d1719b46bcfdd37b96fcb73ff54ae0d5a8"},{"author":{"_account_id":1002207,"name":"Carlos Sanchez","email":"carlossanchez@geotab.com","username":"carlossanchez"},"change_message_id":"bec6dd599316e683f4c1c7f0fd59ad13d7c2d28e","unresolved":true,"context_lines":[{"line_number":40,"context_line":"$_TARGETNAME configure -work-area-phys 0x20000000 -work-area-size $_WORKAREASIZE -work-area-backup 0"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"set _FLASHNAME $_CHIPNAME.pflash"},{"line_number":43,"context_line":"flash bank $_FLASHNAME kinetis 0 0 0 0 $_TARGETNAME -chipname $_CHIPNAME"},{"line_number":44,"context_line":"kinetis create_banks"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"adapter speed 1000"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"21fe5922_5a192c60","line":43,"in_reply_to":"80b08d81_150aa0b4","updated":"2023-11-15 13:52:36.000000000","message":"We can not probe because the SDID register has an incompatible structure. One option would be to use a totally different flash driver, but the mechanics are quite similar and that would be a duplication of a lot of code. I think it still make sense to place this into kinetis.c; I use a parameter (but not related to chipname) to indicate S32K is to be detected instead of normal Kinetis flash.\nI reworked the patch so it is smaller and touches almost nothing of previously existing code. I think it should be easier to review now.","commit_id":"e0eae3d1719b46bcfdd37b96fcb73ff54ae0d5a8"},{"author":{"_account_id":1002207,"name":"Carlos Sanchez","email":"carlossanchez@geotab.com","username":"carlossanchez"},"change_message_id":"434696c779203a35935a0a80cbe2f805c8c14362","unresolved":true,"context_lines":[{"line_number":40,"context_line":"$_TARGETNAME configure -work-area-phys 0x20000000 -work-area-size $_WORKAREASIZE -work-area-backup 0"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"set _FLASHNAME $_CHIPNAME.pflash"},{"line_number":43,"context_line":"flash bank $_FLASHNAME kinetis 0 0 0 0 $_TARGETNAME -chipname $_CHIPNAME"},{"line_number":44,"context_line":"kinetis create_banks"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"adapter speed 1000"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"80b08d81_150aa0b4","line":43,"in_reply_to":"c1d57094_57c20ec9","updated":"2023-11-14 16:08:49.000000000","message":"Agreed, we should probe this. I am reworking the patch.","commit_id":"e0eae3d1719b46bcfdd37b96fcb73ff54ae0d5a8"}],"tcl/target/s32k.cfg":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"0bc3a170bf22bc1f4502e384b2e5ff50c25232aa","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"set CHIPNAME s32k"},{"line_number":8,"context_line":"set CPUTAPID 0x0995001d"},{"line_number":9,"context_line":"source [find target/kx.cfg]"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"c364364c_dde29d0f","line":9,"updated":"2023-11-13 22:18:00.000000000","message":"missing newline at the end of the line\nGerrit file-diff show it too","commit_id":"e0eae3d1719b46bcfdd37b96fcb73ff54ae0d5a8"},{"author":{"_account_id":1002207,"name":"Carlos Sanchez","email":"carlossanchez@geotab.com","username":"carlossanchez"},"change_message_id":"b5e01d8bf3019861044e9efc9d8f91de23685c39","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"set CHIPNAME s32k"},{"line_number":8,"context_line":"set CPUTAPID 0x0995001d"},{"line_number":9,"context_line":"source [find target/kx.cfg]"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"0912805f_5bf94cea","line":9,"in_reply_to":"40cb3282_ea151fcf","updated":"2023-11-19 21:55:38.000000000","message":"Ack","commit_id":"e0eae3d1719b46bcfdd37b96fcb73ff54ae0d5a8"},{"author":{"_account_id":1002207,"name":"Carlos Sanchez","email":"carlossanchez@geotab.com","username":"carlossanchez"},"change_message_id":"bec6dd599316e683f4c1c7f0fd59ad13d7c2d28e","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"set CHIPNAME s32k"},{"line_number":8,"context_line":"set CPUTAPID 0x0995001d"},{"line_number":9,"context_line":"source [find target/kx.cfg]"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"40cb3282_ea151fcf","line":9,"in_reply_to":"c364364c_dde29d0f","updated":"2023-11-15 13:52:36.000000000","message":"I finally make s32kx.cfg an edited copy instead of kx.cfg instead of sourcing it inside.","commit_id":"e0eae3d1719b46bcfdd37b96fcb73ff54ae0d5a8"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"d314138f420cc63d4d6a5473168b410ffa640a25","unresolved":true,"context_lines":[{"line_number":36,"context_line":"$_TARGETNAME configure -work-area-phys 0x20000000 -work-area-size $_WORKAREASIZE -work-area-backup 0"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"set _FLASHNAME $_CHIPNAME.pflash"},{"line_number":39,"context_line":"flash bank $_FLASHNAME kinetis 0 0 0 0 $_TARGETNAME -chipname $_CHIPNAME -s32k"},{"line_number":40,"context_line":"kinetis create_banks"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"adapter speed 1000"}],"source_content_type":"text/x-ttcn-cfg","patch_set":5,"id":"a7a8209e_771242e0","line":39,"range":{"start_line":39,"start_character":52,"end_line":39,"end_character":72},"updated":"2023-12-06 17:15:21.000000000","message":"A leftover from the previous version?","commit_id":"2a88d32888540db37d08998d4f3bcdb311190960"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"2406f2a70d1ce9e8ecbe44e73dd7465a3836d5c5","unresolved":false,"context_lines":[{"line_number":36,"context_line":"$_TARGETNAME configure -work-area-phys 0x20000000 -work-area-size $_WORKAREASIZE -work-area-backup 0"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"set _FLASHNAME $_CHIPNAME.pflash"},{"line_number":39,"context_line":"flash bank $_FLASHNAME kinetis 0 0 0 0 $_TARGETNAME -chipname $_CHIPNAME -s32k"},{"line_number":40,"context_line":"kinetis create_banks"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"adapter speed 1000"}],"source_content_type":"text/x-ttcn-cfg","patch_set":5,"id":"35bec242_a7dac65a","line":39,"range":{"start_line":39,"start_character":52,"end_line":39,"end_character":72},"in_reply_to":"88b374e4_f6281c51","updated":"2023-12-27 21:02:22.000000000","message":"Done","commit_id":"2a88d32888540db37d08998d4f3bcdb311190960"},{"author":{"_account_id":1002207,"name":"Carlos Sanchez","email":"carlossanchez@geotab.com","username":"carlossanchez"},"change_message_id":"cd7de4b0ff2a9d7f9dd895bdb09702eb546705da","unresolved":true,"context_lines":[{"line_number":36,"context_line":"$_TARGETNAME configure -work-area-phys 0x20000000 -work-area-size $_WORKAREASIZE -work-area-backup 0"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"set _FLASHNAME $_CHIPNAME.pflash"},{"line_number":39,"context_line":"flash bank $_FLASHNAME kinetis 0 0 0 0 $_TARGETNAME -chipname $_CHIPNAME -s32k"},{"line_number":40,"context_line":"kinetis create_banks"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"adapter speed 1000"}],"source_content_type":"text/x-ttcn-cfg","patch_set":5,"id":"88b374e4_f6281c51","line":39,"range":{"start_line":39,"start_character":52,"end_line":39,"end_character":72},"in_reply_to":"a7a8209e_771242e0","updated":"2023-12-27 16:41:17.000000000","message":"Yes, removed.","commit_id":"2a88d32888540db37d08998d4f3bcdb311190960"}]}