)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"change_message_id":"0830e178a20846b2961f9ae96b78aa621eebe5f3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"29297da7_b8ce2ad8","updated":"2023-11-20 08:52:31.000000000","message":"I have just one minor suggestion, otherwise this is nice improvement.","commit_id":"16bbd39c649b88066ca88366a8c53e1e9e426791"},{"author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"change_message_id":"3da82d19e06198b97df2f91e9f59fe62e50fbb77","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b6e53f05_eaec9b57","updated":"2023-11-20 11:37:07.000000000","message":"Thank you.","commit_id":"53a06ddd0e0d05824599f8e953c92e74f112a890"}],"src/target/target.c":[{"author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"change_message_id":"0830e178a20846b2961f9ae96b78aa621eebe5f3","unresolved":true,"context_lines":[{"line_number":717,"context_line":""},{"line_number":718,"context_line":"\tint retval \u003d target-\u003etype-\u003eexamine(target);"},{"line_number":719,"context_line":"\tif (retval !\u003d ERROR_OK) {"},{"line_number":720,"context_line":"\t\tLOG_TARGET_ERROR(target, \"Examination failed. examine() -\u003e %d\", retval);"},{"line_number":721,"context_line":"\t\ttarget_reset_examined(target);"},{"line_number":722,"context_line":"\t\ttarget_call_event_callbacks(target, TARGET_EVENT_EXAMINE_FAIL);"},{"line_number":723,"context_line":"\t\treturn retval;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"a78fea17_74a1a9ca","line":720,"updated":"2023-11-20 08:52:31.000000000","message":"If believe it is good idea to keep the return code in the error message, you can say the following to make it clear what the number means:\n\n```\nLOG_TARGET_ERROR(target, \"Examination failed. examine() returned %d\", retval);\n```\n\nIn my opinion, it is better to not show the return code to the user so directly. If you agree, you can use something like this:\n\n```\nLOG_TARGET_ERROR(target, \"Examination failed.\");\nLOG_TARGET_DEBUG(target, \"examine() returned error code %d\", retval);\n```","commit_id":"16bbd39c649b88066ca88366a8c53e1e9e426791"},{"author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"change_message_id":"4bc4b7ef3db8876166d8be2f408256e08dfd8d59","unresolved":true,"context_lines":[{"line_number":717,"context_line":""},{"line_number":718,"context_line":"\tint retval \u003d target-\u003etype-\u003eexamine(target);"},{"line_number":719,"context_line":"\tif (retval !\u003d ERROR_OK) {"},{"line_number":720,"context_line":"\t\tLOG_TARGET_ERROR(target, \"Examination failed. examine() -\u003e %d\", retval);"},{"line_number":721,"context_line":"\t\ttarget_reset_examined(target);"},{"line_number":722,"context_line":"\t\ttarget_call_event_callbacks(target, TARGET_EVENT_EXAMINE_FAIL);"},{"line_number":723,"context_line":"\t\treturn retval;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"c9d021fe_ad5c66b7","line":720,"in_reply_to":"a78fea17_74a1a9ca","updated":"2023-11-20 08:53:21.000000000","message":"Typo correction:\n\nIf you believe ...","commit_id":"16bbd39c649b88066ca88366a8c53e1e9e426791"},{"author":{"_account_id":1002152,"name":"Kirill Radkin","email":"kirill.radkin@syntacore.com","username":"kr-sc"},"change_message_id":"0502d2d8a1b99ccf1235989b139bd9ac244d5bea","unresolved":true,"context_lines":[{"line_number":717,"context_line":""},{"line_number":718,"context_line":"\tint retval \u003d target-\u003etype-\u003eexamine(target);"},{"line_number":719,"context_line":"\tif (retval !\u003d ERROR_OK) {"},{"line_number":720,"context_line":"\t\tLOG_TARGET_ERROR(target, \"Examination failed. examine() -\u003e %d\", retval);"},{"line_number":721,"context_line":"\t\ttarget_reset_examined(target);"},{"line_number":722,"context_line":"\t\ttarget_call_event_callbacks(target, TARGET_EVENT_EXAMINE_FAIL);"},{"line_number":723,"context_line":"\t\treturn retval;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"f023bdaf_b2304895","line":720,"in_reply_to":"c9d021fe_ad5c66b7","updated":"2023-11-20 10:32:35.000000000","message":"I think second option is better, thank you. Addressed.","commit_id":"16bbd39c649b88066ca88366a8c53e1e9e426791"},{"author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"change_message_id":"3da82d19e06198b97df2f91e9f59fe62e50fbb77","unresolved":false,"context_lines":[{"line_number":717,"context_line":""},{"line_number":718,"context_line":"\tint retval \u003d target-\u003etype-\u003eexamine(target);"},{"line_number":719,"context_line":"\tif (retval !\u003d ERROR_OK) {"},{"line_number":720,"context_line":"\t\tLOG_TARGET_ERROR(target, \"Examination failed. examine() -\u003e %d\", retval);"},{"line_number":721,"context_line":"\t\ttarget_reset_examined(target);"},{"line_number":722,"context_line":"\t\ttarget_call_event_callbacks(target, TARGET_EVENT_EXAMINE_FAIL);"},{"line_number":723,"context_line":"\t\treturn retval;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"ee5faaa2_c290da70","line":720,"in_reply_to":"f023bdaf_b2304895","updated":"2023-11-20 11:37:07.000000000","message":"Done","commit_id":"16bbd39c649b88066ca88366a8c53e1e9e426791"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"489c1a3c1a816d89e7c47c571b3c4a4ee35bd2a5","unresolved":true,"context_lines":[{"line_number":711,"context_line":" * Keep in sync */"},{"line_number":712,"context_line":"int target_examine_one(struct target *target)"},{"line_number":713,"context_line":"{"},{"line_number":714,"context_line":"\tLOG_TARGET_INFO(target, \"Examination started.\");"},{"line_number":715,"context_line":""},{"line_number":716,"context_line":"\ttarget_call_event_callbacks(target, TARGET_EVENT_EXAMINE_START);"},{"line_number":717,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":2,"id":"64aa360c_1214b80d","line":714,"updated":"2023-11-20 21:28:30.000000000","message":"Please remove the period to be consistent with all other messages","commit_id":"53a06ddd0e0d05824599f8e953c92e74f112a890"},{"author":{"_account_id":1002152,"name":"Kirill Radkin","email":"kirill.radkin@syntacore.com","username":"kr-sc"},"change_message_id":"c17684ff750d3aafa780012f07de207aba602baf","unresolved":true,"context_lines":[{"line_number":711,"context_line":" * Keep in sync */"},{"line_number":712,"context_line":"int target_examine_one(struct target *target)"},{"line_number":713,"context_line":"{"},{"line_number":714,"context_line":"\tLOG_TARGET_INFO(target, \"Examination started.\");"},{"line_number":715,"context_line":""},{"line_number":716,"context_line":"\ttarget_call_event_callbacks(target, TARGET_EVENT_EXAMINE_START);"},{"line_number":717,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":2,"id":"87c0b1c0_1ea56bdc","line":714,"in_reply_to":"64aa360c_1214b80d","updated":"2023-11-21 12:52:53.000000000","message":"Done","commit_id":"53a06ddd0e0d05824599f8e953c92e74f112a890"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"abcfaf541c7b7ddb585f950f7a32859be509b461","unresolved":false,"context_lines":[{"line_number":711,"context_line":" * Keep in sync */"},{"line_number":712,"context_line":"int target_examine_one(struct target *target)"},{"line_number":713,"context_line":"{"},{"line_number":714,"context_line":"\tLOG_TARGET_INFO(target, \"Examination started.\");"},{"line_number":715,"context_line":""},{"line_number":716,"context_line":"\ttarget_call_event_callbacks(target, TARGET_EVENT_EXAMINE_START);"},{"line_number":717,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":2,"id":"33ac83de_a77a1c20","line":714,"in_reply_to":"87c0b1c0_1ea56bdc","updated":"2023-11-27 09:55:38.000000000","message":"Done","commit_id":"53a06ddd0e0d05824599f8e953c92e74f112a890"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"489c1a3c1a816d89e7c47c571b3c4a4ee35bd2a5","unresolved":true,"context_lines":[{"line_number":717,"context_line":""},{"line_number":718,"context_line":"\tint retval \u003d target-\u003etype-\u003eexamine(target);"},{"line_number":719,"context_line":"\tif (retval !\u003d ERROR_OK) {"},{"line_number":720,"context_line":"\t\tLOG_TARGET_ERROR(target, \"Examination failed.\");"},{"line_number":721,"context_line":"\t\tLOG_TARGET_DEBUG(target, \"examine() returned error code %d\", retval);"},{"line_number":722,"context_line":"\t\ttarget_reset_examined(target);"},{"line_number":723,"context_line":"\t\ttarget_call_event_callbacks(target, TARGET_EVENT_EXAMINE_FAIL);"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"22234647_4a794886","line":720,"updated":"2023-11-20 21:28:30.000000000","message":"Same","commit_id":"53a06ddd0e0d05824599f8e953c92e74f112a890"},{"author":{"_account_id":1002152,"name":"Kirill Radkin","email":"kirill.radkin@syntacore.com","username":"kr-sc"},"change_message_id":"c17684ff750d3aafa780012f07de207aba602baf","unresolved":true,"context_lines":[{"line_number":717,"context_line":""},{"line_number":718,"context_line":"\tint retval \u003d target-\u003etype-\u003eexamine(target);"},{"line_number":719,"context_line":"\tif (retval !\u003d ERROR_OK) {"},{"line_number":720,"context_line":"\t\tLOG_TARGET_ERROR(target, \"Examination failed.\");"},{"line_number":721,"context_line":"\t\tLOG_TARGET_DEBUG(target, \"examine() returned error code %d\", retval);"},{"line_number":722,"context_line":"\t\ttarget_reset_examined(target);"},{"line_number":723,"context_line":"\t\ttarget_call_event_callbacks(target, TARGET_EVENT_EXAMINE_FAIL);"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"a42b16df_a1625bc9","line":720,"in_reply_to":"22234647_4a794886","updated":"2023-11-21 12:52:53.000000000","message":"Done","commit_id":"53a06ddd0e0d05824599f8e953c92e74f112a890"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"abcfaf541c7b7ddb585f950f7a32859be509b461","unresolved":false,"context_lines":[{"line_number":717,"context_line":""},{"line_number":718,"context_line":"\tint retval \u003d target-\u003etype-\u003eexamine(target);"},{"line_number":719,"context_line":"\tif (retval !\u003d ERROR_OK) {"},{"line_number":720,"context_line":"\t\tLOG_TARGET_ERROR(target, \"Examination failed.\");"},{"line_number":721,"context_line":"\t\tLOG_TARGET_DEBUG(target, \"examine() returned error code %d\", retval);"},{"line_number":722,"context_line":"\t\ttarget_reset_examined(target);"},{"line_number":723,"context_line":"\t\ttarget_call_event_callbacks(target, TARGET_EVENT_EXAMINE_FAIL);"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"b58391f6_9c05b674","line":720,"in_reply_to":"a42b16df_a1625bc9","updated":"2023-11-27 09:55:38.000000000","message":"Done","commit_id":"53a06ddd0e0d05824599f8e953c92e74f112a890"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"9aa6f5c444d816f1e472c3506a1c34bdd83248d0","unresolved":true,"context_lines":[{"line_number":711,"context_line":" * Keep in sync */"},{"line_number":712,"context_line":"int target_examine_one(struct target *target)"},{"line_number":713,"context_line":"{"},{"line_number":714,"context_line":"\tLOG_TARGET_INFO(target, \"Examination started\");"},{"line_number":715,"context_line":""},{"line_number":716,"context_line":"\ttarget_call_event_callbacks(target, TARGET_EVENT_EXAMINE_START);"},{"line_number":717,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":3,"id":"a5c127d3_a27dcbf7","line":714,"updated":"2023-11-25 10:42:53.000000000","message":"I think user would be more interested to know the result of the examination instead of having this \"... started\" following by nothing that implicitly means \"success\".\nThis line should removed or converted to LOG_TARGET_DEBUG(), while below, before exit ERROR_OK, adding a\nLOG_TARGET_INFO(target, \"Examined\");\nso we have one INFO for error and one for success.\n\nI don\u0027t know if on some target type this would result in excessive logs, but that would probably means that target type runs examine too often and should be fixed.","commit_id":"d68b4c4fe1d2989a0ced0bb95a46ad838cdd1d8f"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"abcfaf541c7b7ddb585f950f7a32859be509b461","unresolved":false,"context_lines":[{"line_number":711,"context_line":" * Keep in sync */"},{"line_number":712,"context_line":"int target_examine_one(struct target *target)"},{"line_number":713,"context_line":"{"},{"line_number":714,"context_line":"\tLOG_TARGET_INFO(target, \"Examination started\");"},{"line_number":715,"context_line":""},{"line_number":716,"context_line":"\ttarget_call_event_callbacks(target, TARGET_EVENT_EXAMINE_START);"},{"line_number":717,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":3,"id":"b0a7abe7_7498025c","line":714,"in_reply_to":"5ea9204a_2a7cb3a1","updated":"2023-11-27 09:55:38.000000000","message":"Done","commit_id":"d68b4c4fe1d2989a0ced0bb95a46ad838cdd1d8f"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"500ade1fd6e5505c36d5b87b346db7c62192d9ae","unresolved":true,"context_lines":[{"line_number":711,"context_line":" * Keep in sync */"},{"line_number":712,"context_line":"int target_examine_one(struct target *target)"},{"line_number":713,"context_line":"{"},{"line_number":714,"context_line":"\tLOG_TARGET_INFO(target, \"Examination started\");"},{"line_number":715,"context_line":""},{"line_number":716,"context_line":"\ttarget_call_event_callbacks(target, TARGET_EVENT_EXAMINE_START);"},{"line_number":717,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":3,"id":"5ea9204a_2a7cb3a1","line":714,"in_reply_to":"a5c127d3_a27dcbf7","updated":"2023-11-25 15:50:47.000000000","message":"Yep, +1","commit_id":"d68b4c4fe1d2989a0ced0bb95a46ad838cdd1d8f"}]}