)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000622,"name":"Jörg Wunsch","email":"openocd@uriah.heep.sax.de","username":"dl8dtl"},"change_message_id":"477a6771342f1043f4a7db18b03c6a5c9b8e62c4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7a3d4000_04651ca9","updated":"2023-11-16 05:33:24.000000000","message":"Looks good to me.","commit_id":"e6f8ccf5aaf0e5775cc28682edaba87ac95b81c5"},{"author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"change_message_id":"16b900a8e32f26fc3cd6f8b10a1f4b60da22e6c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"188e6052_679f1ee4","updated":"2023-11-16 20:47:47.000000000","message":"Thank you!","commit_id":"8279eaf2ebc35f2bf414bf93b7f77b614780828c"}],"tcl/target/at91sama5d2.cfg":[{"author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"change_message_id":"5582c87d85173b0ed32b186df32e7ab6fcf222c2","unresolved":true,"context_lines":[{"line_number":27,"context_line":"\tjtag newtap $_CHIPNAME cpu -irlen 4 -ircapture 0x01 -irmask 0x0f \\"},{"line_number":28,"context_line":"\t\t-expected-id 0x5ba00477"},{"line_number":29,"context_line":"} else {"},{"line_number":30,"context_line":"\tswd newdap $_CHIPNAME cpu -expected-id 0x5ba00477"},{"line_number":31,"context_line":"}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# Cortex-A5 target"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"017e01c9_a06bff2c","line":30,"range":{"start_line":30,"start_character":40,"end_line":30,"end_character":50},"updated":"2023-11-16 18:20:03.000000000","message":"My guess is that the ID reported over SWD won\u0027t match this, and you\u0027ll get an error with this config trying to connect with e.g. stlink v2.","commit_id":"e6f8ccf5aaf0e5775cc28682edaba87ac95b81c5"},{"author":{"_account_id":1000577,"name":"Peter Lawrence","email":"majbthrd@gmail.com","username":"majbthrd"},"change_message_id":"7916033bd4084606000ae27aaf7bdcbd71fcf354","unresolved":true,"context_lines":[{"line_number":27,"context_line":"\tjtag newtap $_CHIPNAME cpu -irlen 4 -ircapture 0x01 -irmask 0x0f \\"},{"line_number":28,"context_line":"\t\t-expected-id 0x5ba00477"},{"line_number":29,"context_line":"} else {"},{"line_number":30,"context_line":"\tswd newdap $_CHIPNAME cpu -expected-id 0x5ba00477"},{"line_number":31,"context_line":"}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# Cortex-A5 target"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"42afddf7_19cc1361","line":30,"range":{"start_line":30,"start_character":40,"end_line":30,"end_character":50},"in_reply_to":"017e01c9_a06bff2c","updated":"2023-11-16 18:28:18.000000000","message":"Are you saying that the ID is ignored on pods other than the stlink v2?  The config works for me with CMSIS-DAP for both JTAG and SWD modes.","commit_id":"e6f8ccf5aaf0e5775cc28682edaba87ac95b81c5"},{"author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"change_message_id":"dfd2f254fb8c6e05698667ce76e5cb11b8a35c7b","unresolved":true,"context_lines":[{"line_number":27,"context_line":"\tjtag newtap $_CHIPNAME cpu -irlen 4 -ircapture 0x01 -irmask 0x0f \\"},{"line_number":28,"context_line":"\t\t-expected-id 0x5ba00477"},{"line_number":29,"context_line":"} else {"},{"line_number":30,"context_line":"\tswd newdap $_CHIPNAME cpu -expected-id 0x5ba00477"},{"line_number":31,"context_line":"}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# Cortex-A5 target"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"976c3306_e187bf3b","line":30,"range":{"start_line":30,"start_character":40,"end_line":30,"end_character":50},"in_reply_to":"42afddf7_19cc1361","updated":"2023-11-16 19:32:49.000000000","message":"I think yes, and stlink-v2 is the only common HLA adapter and there is explicit check for the SWD ID there. For regular SWD accesss it\u0027s still read and reported in log line as `SWD DPIDR` but it\u0027s not checked against the expected-id.","commit_id":"e6f8ccf5aaf0e5775cc28682edaba87ac95b81c5"},{"author":{"_account_id":1000577,"name":"Peter Lawrence","email":"majbthrd@gmail.com","username":"majbthrd"},"change_message_id":"f58b52340cd604e06721cf186ef4a53d83f41a33","unresolved":false,"context_lines":[{"line_number":27,"context_line":"\tjtag newtap $_CHIPNAME cpu -irlen 4 -ircapture 0x01 -irmask 0x0f \\"},{"line_number":28,"context_line":"\t\t-expected-id 0x5ba00477"},{"line_number":29,"context_line":"} else {"},{"line_number":30,"context_line":"\tswd newdap $_CHIPNAME cpu -expected-id 0x5ba00477"},{"line_number":31,"context_line":"}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# Cortex-A5 target"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"41925949_70d707b7","line":30,"range":{"start_line":30,"start_character":40,"end_line":30,"end_character":50},"in_reply_to":"976c3306_e187bf3b","updated":"2023-11-16 20:32:50.000000000","message":"Thanks.  I\u0027ve harvested the SWD ID from the log and updated the patch.","commit_id":"e6f8ccf5aaf0e5775cc28682edaba87ac95b81c5"},{"author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"change_message_id":"5582c87d85173b0ed32b186df32e7ab6fcf222c2","unresolved":true,"context_lines":[{"line_number":28,"context_line":"\t\t-expected-id 0x5ba00477"},{"line_number":29,"context_line":"} else {"},{"line_number":30,"context_line":"\tswd newdap $_CHIPNAME cpu -expected-id 0x5ba00477"},{"line_number":31,"context_line":"}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# Cortex-A5 target"},{"line_number":34,"context_line":"set _TARGETNAME $_CHIPNAME.cpu_a5"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"5c19203f_0b2b3b71","line":31,"updated":"2023-11-16 18:20:03.000000000","message":"Why not `swj_newdap` ?","commit_id":"e6f8ccf5aaf0e5775cc28682edaba87ac95b81c5"},{"author":{"_account_id":1000577,"name":"Peter Lawrence","email":"majbthrd@gmail.com","username":"majbthrd"},"change_message_id":"7916033bd4084606000ae27aaf7bdcbd71fcf354","unresolved":true,"context_lines":[{"line_number":28,"context_line":"\t\t-expected-id 0x5ba00477"},{"line_number":29,"context_line":"} else {"},{"line_number":30,"context_line":"\tswd newdap $_CHIPNAME cpu -expected-id 0x5ba00477"},{"line_number":31,"context_line":"}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# Cortex-A5 target"},{"line_number":34,"context_line":"set _TARGETNAME $_CHIPNAME.cpu_a5"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"f1cbb0d9_4ff8bad1","line":31,"in_reply_to":"5c19203f_0b2b3b71","updated":"2023-11-16 18:28:18.000000000","message":"I adopted the conventions used in other files in ./tcl/target that I had prior experience with; there are uses of \"swd newdap\", and it appears also \"swj_newdap\".","commit_id":"e6f8ccf5aaf0e5775cc28682edaba87ac95b81c5"},{"author":{"_account_id":1000577,"name":"Peter Lawrence","email":"majbthrd@gmail.com","username":"majbthrd"},"change_message_id":"f58b52340cd604e06721cf186ef4a53d83f41a33","unresolved":false,"context_lines":[{"line_number":28,"context_line":"\t\t-expected-id 0x5ba00477"},{"line_number":29,"context_line":"} else {"},{"line_number":30,"context_line":"\tswd newdap $_CHIPNAME cpu -expected-id 0x5ba00477"},{"line_number":31,"context_line":"}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# Cortex-A5 target"},{"line_number":34,"context_line":"set _TARGETNAME $_CHIPNAME.cpu_a5"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"e780053f_50250fbc","line":31,"in_reply_to":"f0cef20f_ea94292b","updated":"2023-11-16 20:32:50.000000000","message":"patch has been updated to follow the swj_newdap convention","commit_id":"e6f8ccf5aaf0e5775cc28682edaba87ac95b81c5"},{"author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"change_message_id":"dfd2f254fb8c6e05698667ce76e5cb11b8a35c7b","unresolved":true,"context_lines":[{"line_number":28,"context_line":"\t\t-expected-id 0x5ba00477"},{"line_number":29,"context_line":"} else {"},{"line_number":30,"context_line":"\tswd newdap $_CHIPNAME cpu -expected-id 0x5ba00477"},{"line_number":31,"context_line":"}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# Cortex-A5 target"},{"line_number":34,"context_line":"set _TARGETNAME $_CHIPNAME.cpu_a5"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"f0cef20f_ea94292b","line":31,"in_reply_to":"f1cbb0d9_4ff8bad1","updated":"2023-11-16 19:32:49.000000000","message":"swj_newdap is supposed to do the right thing for ARM targets so I\u0027d recommend using it even though you\u0027d still need another `if` to provide different expected-id for SWD mode as e.g. stm32f1x.cfg does.","commit_id":"e6f8ccf5aaf0e5775cc28682edaba87ac95b81c5"}]}