)]}'
{"src/target/breakpoints.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"e2e593af55dc42f80c1f4ec96b76918b92f150a9","unresolved":true,"context_lines":[{"line_number":282,"context_line":""},{"line_number":283,"context_line":"\t/* Locate the breakpoint and the preceding pointer to it."},{"line_number":284,"context_line":"\t * This is needed for deletion of the item from the linked list. */"},{"line_number":285,"context_line":"\twhile (breakpoint) {"},{"line_number":286,"context_line":"\t\tif (breakpoint \u003d\u003d breakpoint_to_remove)"},{"line_number":287,"context_line":"\t\t\tbreak;"},{"line_number":288,"context_line":"\t\tbreakpoint_p \u003d \u0026breakpoint-\u003enext;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"f659206d_43481799","line":285,"updated":"2023-11-29 10:28:11.000000000","message":"here we scan the list of breakpoints for a second time, because it is a handmade single linked list (the .next field) and we need to find the preceding element to update the list.\nWhy not simplifying all by replacing target-\u003ebreakpoints and struct breakpoint with a list defined in src/helper/list.h ?\nWe have there helpers to remove an element from the list without all these extra effort and code.","commit_id":"9ebd67e5a889ac7741f0a633539a6efd21c8e4b5"},{"author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"change_message_id":"a74a6d2d3e7d26b0f3f8d55abd195d5186e2eb9c","unresolved":true,"context_lines":[{"line_number":282,"context_line":""},{"line_number":283,"context_line":"\t/* Locate the breakpoint and the preceding pointer to it."},{"line_number":284,"context_line":"\t * This is needed for deletion of the item from the linked list. */"},{"line_number":285,"context_line":"\twhile (breakpoint) {"},{"line_number":286,"context_line":"\t\tif (breakpoint \u003d\u003d breakpoint_to_remove)"},{"line_number":287,"context_line":"\t\t\tbreak;"},{"line_number":288,"context_line":"\t\tbreakpoint_p \u003d \u0026breakpoint-\u003enext;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"44fb570a_9d4ac088","line":285,"in_reply_to":"5a10858a_b9fdadc4","updated":"2023-11-29 15:41:20.000000000","message":"Thanks for your opinion. I will rewrite this to use the list_head, then. I will take some time for me to submit that patch. \n\nThis merge request I am closing.","commit_id":"9ebd67e5a889ac7741f0a633539a6efd21c8e4b5"},{"author":{"_account_id":1002152,"name":"Kirill Radkin","email":"kirill.radkin@syntacore.com","username":"kr-sc"},"change_message_id":"058b22596a1163d4ef7975a7c01d6466c4673daf","unresolved":true,"context_lines":[{"line_number":282,"context_line":""},{"line_number":283,"context_line":"\t/* Locate the breakpoint and the preceding pointer to it."},{"line_number":284,"context_line":"\t * This is needed for deletion of the item from the linked list. */"},{"line_number":285,"context_line":"\twhile (breakpoint) {"},{"line_number":286,"context_line":"\t\tif (breakpoint \u003d\u003d breakpoint_to_remove)"},{"line_number":287,"context_line":"\t\t\tbreak;"},{"line_number":288,"context_line":"\t\tbreakpoint_p \u003d \u0026breakpoint-\u003enext;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"5a10858a_b9fdadc4","line":285,"in_reply_to":"5de4d0e2_e8125ff0","updated":"2023-11-29 12:38:39.000000000","message":"+1, agreed with Antonio\u0027s suggestion.","commit_id":"9ebd67e5a889ac7741f0a633539a6efd21c8e4b5"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"8ffed52f9704ac5afc9f8cddc476248835496966","unresolved":true,"context_lines":[{"line_number":282,"context_line":""},{"line_number":283,"context_line":"\t/* Locate the breakpoint and the preceding pointer to it."},{"line_number":284,"context_line":"\t * This is needed for deletion of the item from the linked list. */"},{"line_number":285,"context_line":"\twhile (breakpoint) {"},{"line_number":286,"context_line":"\t\tif (breakpoint \u003d\u003d breakpoint_to_remove)"},{"line_number":287,"context_line":"\t\t\tbreak;"},{"line_number":288,"context_line":"\t\tbreakpoint_p \u003d \u0026breakpoint-\u003enext;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"5de4d0e2_e8125ff0","line":285,"in_reply_to":"7a03ffd5_2920d067","updated":"2023-11-29 11:09:57.000000000","message":"I don\u0027t know if this patch would still be needed once the list_head is used.\nIf you want to investigate, I let you decide","commit_id":"9ebd67e5a889ac7741f0a633539a6efd21c8e4b5"},{"author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"change_message_id":"7e9caf4b62149c0346134dcf00ec4983d6c8e268","unresolved":true,"context_lines":[{"line_number":282,"context_line":""},{"line_number":283,"context_line":"\t/* Locate the breakpoint and the preceding pointer to it."},{"line_number":284,"context_line":"\t * This is needed for deletion of the item from the linked list. */"},{"line_number":285,"context_line":"\twhile (breakpoint) {"},{"line_number":286,"context_line":"\t\tif (breakpoint \u003d\u003d breakpoint_to_remove)"},{"line_number":287,"context_line":"\t\t\tbreak;"},{"line_number":288,"context_line":"\t\tbreakpoint_p \u003d \u0026breakpoint-\u003enext;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"7a03ffd5_2920d067","line":285,"in_reply_to":"f659206d_43481799","updated":"2023-11-29 10:54:25.000000000","message":"That sounds like a nice cleanup. Would you like me to do it like that instead of this patch?","commit_id":"9ebd67e5a889ac7741f0a633539a6efd21c8e4b5"}]}