)]}'
{"id":"openocd~master~Iec7ef4288c6bfe7cf9778b93960fdfddb350df11","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1001667":{"account":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"last_update":"2023-11-29 13:10:52.000000000","reason":"Change was abandoned"},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2023-11-29 13:10:52.000000000","reason":"Change was abandoned"},"1002152":{"account":{"_account_id":1002152,"name":"Kirill Radkin","email":"kirill.radkin@syntacore.com","username":"kr-sc"},"last_update":"2023-11-29 12:38:39.000000000","reason":"\u003cGERRIT_ACCOUNT_1002152\u003e replied on the change","reason_account":{"_account_id":1002152,"name":"Kirill Radkin","email":"kirill.radkin@syntacore.com","username":"kr-sc"}},"1001839":{"account":{"_account_id":1001839,"name":"Antonio Borneo","email":"antonio.borneo@st.com"},"last_update":"2023-11-29 13:10:52.000000000","reason":"Change was abandoned"}},"hashtags":[],"change_id":"Iec7ef4288c6bfe7cf9778b93960fdfddb350df11","subject":"breakpoints: Remove dead code - two \"if\" blocks","status":"ABANDONED","created":"2023-11-29 09:43:50.000000000","updated":"2023-11-29 15:41:20.000000000","total_comment_count":5,"unresolved_comment_count":1,"has_review_started":true,"meta_rev_id":"a74a6d2d3e7d26b0f3f8d55abd195d5186e2eb9c","_number":8023,"owner":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"_account_id":1002152,"name":"Kirill Radkin","email":"kirill.radkin@syntacore.com","username":"kr-sc"},{"_account_id":1001839,"name":"Antonio Borneo","email":"antonio.borneo@st.com"},{"tag":"autogenerated:jenkins-gerrit-trigger","value":1,"date":"2023-11-29 09:59:50.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1002152,"name":"Kirill Radkin","email":"kirill.radkin@syntacore.com","username":"kr-sc"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1001839,"name":"Antonio Borneo","email":"antonio.borneo@st.com"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}],"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1001839,"name":"Antonio Borneo","email":"antonio.borneo@st.com"},{"_account_id":1002152,"name":"Kirill Radkin","email":"kirill.radkin@syntacore.com","username":"kr-sc"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-11-29 09:44:40.000000000","updated_by":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"reviewer":{"_account_id":1001839,"name":"Antonio Borneo","email":"antonio.borneo@st.com"},"state":"REVIEWER"},{"updated":"2023-11-29 09:44:40.000000000","updated_by":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"reviewer":{"_account_id":1002152,"name":"Kirill Radkin","email":"kirill.radkin@syntacore.com","username":"kr-sc"},"state":"REVIEWER"},{"updated":"2023-11-29 09:59:50.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-11-29 10:28:11.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"CC"}],"messages":[{"id":"cf2b59dabcf31b90660faa0948755952df0cbeb0","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2023-11-29 09:43:50.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"35229a93c61c3e75b04edb0715cbe5c69199cb19","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-11-29 09:59:50.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/18924/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18094/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"e2e593af55dc42f80c1f4ec96b76918b92f150a9","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-11-29 10:28:11.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"7e9caf4b62149c0346134dcf00ec4983d6c8e268","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2023-11-29 10:54:25.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"8ffed52f9704ac5afc9f8cddc476248835496966","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-11-29 11:09:57.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"058b22596a1163d4ef7975a7c01d6466c4673daf","author":{"_account_id":1002152,"name":"Kirill Radkin","email":"kirill.radkin@syntacore.com","username":"kr-sc"},"real_author":{"_account_id":1002152,"name":"Kirill Radkin","email":"kirill.radkin@syntacore.com","username":"kr-sc"},"date":"2023-11-29 12:38:39.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"36d443a8324e0bfc3874eb75c7973caf7dbc89d7","tag":"autogenerated:gerrit:abandon","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2023-11-29 13:10:52.000000000","message":"Abandoned\n\nA different approach was agreed on: Rewrite the breakpoint and watchpoint lists to use ht utilities from list.h.","accounts_in_message":[],"_revision_number":1},{"id":"a74a6d2d3e7d26b0f3f8d55abd195d5186e2eb9c","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2023-11-29 15:41:20.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1}],"current_revision":"9ebd67e5a889ac7741f0a633539a6efd21c8e4b5","revisions":{"9ebd67e5a889ac7741f0a633539a6efd21c8e4b5":{"kind":"REWORK","_number":1,"created":"2023-11-29 09:43:50.000000000","uploader":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"ref":"refs/changes/23/8023/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/23/8023/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/23/8023/1 \u0026\u0026 git checkout -b change-8023 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/23/8023/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/23/8023/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/23/8023/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/23/8023/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/23/8023/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1b0b07baab2b23318ddc484a58d66214f0c2a0d2","subject":"target: Throw error in \u0027debug_reason\u0027 command"}],"author":{"name":"Jan Matyas","email":"jan.matyas@codasip.com","date":"2023-11-29 09:31:31.000000000","tz":60},"committer":{"name":"Jan Matyas","email":"jan.matyas@codasip.com","date":"2023-11-29 09:43:30.000000000","tz":60},"subject":"breakpoints: Remove dead code - two \"if\" blocks","message":"breakpoints: Remove dead code - two \"if\" blocks\n\nRemoved two \"if\" blocks from breakpoint.c whose condition could\nnever be true (dead code) and replaced them by assertions.\n\nAlso added few related comments.\n\nChange-Id: Iec7ef4288c6bfe7cf9778b93960fdfddb350df11\nSigned-off-by: Jan Matyas \u003cjan.matyas@codasip.com\u003e\n"}}},"requirements":[],"submit_records":[],"submit_requirements":[]}