)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"f172a79d4c839736f8d22f33da3084d0366bc8bd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9c799f99_fde915a2","updated":"2023-12-17 15:45:41.000000000","message":"Thanks for the patch. Looks ok, apart from some minor comment below","commit_id":"bfd0e3e46e234bc4dac49d7304372960690550fd"}],"doc/openocd.texi":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"f172a79d4c839736f8d22f33da3084d0366bc8bd","unresolved":true,"context_lines":[{"line_number":4406,"context_line":"register during initial examination and when checking the sticky error bit."},{"line_number":4407,"context_line":"This bit is normally checked after setting the CSYSPWRUPREQ bit, but some"},{"line_number":4408,"context_line":"devices do not set the ack bit until sometime later."},{"line_number":4409,"context_line":"@item @code{-ir-bypass}"},{"line_number":4410,"context_line":"@*Vendor specific bypass instruction, required by some hierarchical JTAG"},{"line_number":4411,"context_line":"routers where the normal BYPASS instruction bypasses the whole router and"},{"line_number":4412,"context_line":"a vendor specific bypass instruction is required to access child nodes."}],"source_content_type":"text/x-texinfo","patch_set":4,"id":"4bb918c4_dcc1153a","line":4409,"updated":"2023-12-17 15:45:41.000000000","message":"you pass a value after -ir-bypass. What about\n@item @code{-ir-bypass} @var{NUMBER}","commit_id":"bfd0e3e46e234bc4dac49d7304372960690550fd"},{"author":{"_account_id":1002216,"name":"Henrik Nordström","email":"henrik.nordstrom@wires.se","username":"hno-addiva"},"change_message_id":"d40becd85f9c88c632cb7751f01dc6550f767838","unresolved":false,"context_lines":[{"line_number":4406,"context_line":"register during initial examination and when checking the sticky error bit."},{"line_number":4407,"context_line":"This bit is normally checked after setting the CSYSPWRUPREQ bit, but some"},{"line_number":4408,"context_line":"devices do not set the ack bit until sometime later."},{"line_number":4409,"context_line":"@item @code{-ir-bypass}"},{"line_number":4410,"context_line":"@*Vendor specific bypass instruction, required by some hierarchical JTAG"},{"line_number":4411,"context_line":"routers where the normal BYPASS instruction bypasses the whole router and"},{"line_number":4412,"context_line":"a vendor specific bypass instruction is required to access child nodes."}],"source_content_type":"text/x-texinfo","patch_set":4,"id":"ae49acff_3b25c7ab","line":4409,"in_reply_to":"4bb918c4_dcc1153a","updated":"2023-12-17 16:41:19.000000000","message":"Done","commit_id":"bfd0e3e46e234bc4dac49d7304372960690550fd"}],"src/jtag/tcl.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"f172a79d4c839736f8d22f33da3084d0366bc8bd","unresolved":true,"context_lines":[{"line_number":762,"context_line":"\t\t\t\"[\u0027-expected_id\u0027 number] \""},{"line_number":763,"context_line":"\t\t\t\"[\u0027-ignore-version\u0027] \""},{"line_number":764,"context_line":"\t\t\t\"[\u0027-ignore-bypass\u0027] \""},{"line_number":765,"context_line":"\t\t\t\"[\u0027-ircapture\u0027 number] \""},{"line_number":766,"context_line":"\t\t\t\"[\u0027-mask\u0027 number]\","},{"line_number":767,"context_line":"\t},"},{"line_number":768,"context_line":"\t{"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"f92777d4_754f0db8","line":765,"updated":"2023-12-17 15:45:41.000000000","message":"please add also\n\"[-ir-bypass number] \"\n\nThe same handle_jtag_newtap is also referenced 5 times in other files that require .usage to be updated too:\nsrc/target/adi_v5_swd.c\nsrc/target/adi_v5_dapdirect.c\nsrc/jtag/hla/hla_transport.c","commit_id":"bfd0e3e46e234bc4dac49d7304372960690550fd"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"73870e6a7ad56da0d54f92d4bb90436f06e8822d","unresolved":true,"context_lines":[{"line_number":762,"context_line":"\t\t\t\"[\u0027-expected_id\u0027 number] \""},{"line_number":763,"context_line":"\t\t\t\"[\u0027-ignore-version\u0027] \""},{"line_number":764,"context_line":"\t\t\t\"[\u0027-ignore-bypass\u0027] \""},{"line_number":765,"context_line":"\t\t\t\"[\u0027-ircapture\u0027 number] \""},{"line_number":766,"context_line":"\t\t\t\"[\u0027-mask\u0027 number]\","},{"line_number":767,"context_line":"\t},"},{"line_number":768,"context_line":"\t{"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"4bb9e7dd_86a71d39","line":765,"in_reply_to":"1f39b3e1_f72d3aed","updated":"2023-12-17 21:00:15.000000000","message":"We wrap the \"newtap\" command using tcl/target/swj-dp.tcl, so the same syntax can be used for any transport.\n\nSeveral flags here are valid on JTAG only: -irlen, -irmask, -ignore-bypass, -ircapture, ...\n\nThe same C code for these commands is shared and is used in all the transport. The flags are ignored by non-JTAG transports, but are present and the command checks for them.\nIf we say that -ir-bypass is valid on JTAG only, we force the user to use:\nif {[using_jtag]} {\njtag newtap XXX -ir-bypass YYY\n} else {\nnon-jtag command\n}\nHaving the same syntax simplifies all.","commit_id":"bfd0e3e46e234bc4dac49d7304372960690550fd"},{"author":{"_account_id":1002216,"name":"Henrik Nordström","email":"henrik.nordstrom@wires.se","username":"hno-addiva"},"change_message_id":"bbb6c5b647abc344eeee0bd6ae1b6e83f9556a5f","unresolved":false,"context_lines":[{"line_number":762,"context_line":"\t\t\t\"[\u0027-expected_id\u0027 number] \""},{"line_number":763,"context_line":"\t\t\t\"[\u0027-ignore-version\u0027] \""},{"line_number":764,"context_line":"\t\t\t\"[\u0027-ignore-bypass\u0027] \""},{"line_number":765,"context_line":"\t\t\t\"[\u0027-ircapture\u0027 number] \""},{"line_number":766,"context_line":"\t\t\t\"[\u0027-mask\u0027 number]\","},{"line_number":767,"context_line":"\t},"},{"line_number":768,"context_line":"\t{"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"a2b3d591_1066c38c","line":765,"in_reply_to":"4bb9e7dd_86a71d39","updated":"2023-12-17 22:21:09.000000000","message":"An I would argue that makes sense as --ir-bypass is very JTAG specific, part of the low level JTAG chain configuration, and any taps requiring it would not be mentioned when not using a JTAG transport.\n\nBut I\u0027ll add them there as well if you say it\u0027s OpenOCD style. But I presonally find it more confusing than helpful.","commit_id":"bfd0e3e46e234bc4dac49d7304372960690550fd"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"e9c069aa475a727c6ddd08973d7a5d015309d3a9","unresolved":false,"context_lines":[{"line_number":762,"context_line":"\t\t\t\"[\u0027-expected_id\u0027 number] \""},{"line_number":763,"context_line":"\t\t\t\"[\u0027-ignore-version\u0027] \""},{"line_number":764,"context_line":"\t\t\t\"[\u0027-ignore-bypass\u0027] \""},{"line_number":765,"context_line":"\t\t\t\"[\u0027-ircapture\u0027 number] \""},{"line_number":766,"context_line":"\t\t\t\"[\u0027-mask\u0027 number]\","},{"line_number":767,"context_line":"\t},"},{"line_number":768,"context_line":"\t{"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"14069da1_6c528cd8","line":765,"in_reply_to":"a2b3d591_1066c38c","updated":"2023-12-17 22:30:17.000000000","message":"Thanks.\nI\u0027m checking the documentation. Actually only \"swd newdap\" and \"jatg newtap\" are documented. The text for swd is:\nParameters are currently the same as \"jtag newtap\" but this is expected to change.\n\nAll other commands should be documented too, and that is the place to write that the parameters are the same but only \u003clist\u003e is valid for this transport.\nAdded to my TODO list ...","commit_id":"bfd0e3e46e234bc4dac49d7304372960690550fd"},{"author":{"_account_id":1002216,"name":"Henrik Nordström","email":"henrik.nordstrom@wires.se","username":"hno-addiva"},"change_message_id":"d40becd85f9c88c632cb7751f01dc6550f767838","unresolved":true,"context_lines":[{"line_number":762,"context_line":"\t\t\t\"[\u0027-expected_id\u0027 number] \""},{"line_number":763,"context_line":"\t\t\t\"[\u0027-ignore-version\u0027] \""},{"line_number":764,"context_line":"\t\t\t\"[\u0027-ignore-bypass\u0027] \""},{"line_number":765,"context_line":"\t\t\t\"[\u0027-ircapture\u0027 number] \""},{"line_number":766,"context_line":"\t\t\t\"[\u0027-mask\u0027 number]\","},{"line_number":767,"context_line":"\t},"},{"line_number":768,"context_line":"\t{"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"1f39b3e1_f72d3aed","line":765,"in_reply_to":"f92777d4_754f0db8","updated":"2023-12-17 16:41:19.000000000","message":"Done the first.\n\nNot sure it\u0027s meaningful on the other three. While it might be technically possible to pass the value to those as well I don\u0027t think it makes sense to ever override the bypass instruction there, if bypass is at all used there. \n\nswd do not use bypass instruction at all from what I know. It directly accesses the DAP, not using JTAG.\ndapdirect is also directly accessing the DAP, not actually using JTAG, and bypass should not be relevant.\nI am not familiar with HLA. But from what I can tell it also provides some kind of direct access and I don\u0027t think JTAG bypass applies there either.","commit_id":"bfd0e3e46e234bc4dac49d7304372960690550fd"}]}