)]}'
{"id":"openocd~master~I754b27a59c6087cde729496be42609d2a7145b0c","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2023-12-16 17:49:26.000000000","reason":"\u003cGERRIT_ACCOUNT_1000021\u003e replied on the change","reason_account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}},"hashtags":[],"change_id":"I754b27a59c6087cde729496be42609d2a7145b0c","subject":"helper/command: drop unused variables","status":"MERGED","created":"2023-12-16 15:13:16.000000000","updated":"2024-01-13 14:42:39.000000000","submitted":"2024-01-13 14:42:39.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8053","meta_rev_id":"dced0b7f523fbc5373a46f23eb956a0ddfe14c5f","_number":8053,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-01-13 14:42:39.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-01-13 14:42:39.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-12-16 15:32:23.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"b8276995ffc11dc340c53dd9e3921e33b38a0aa5","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-12-16 15:13:16.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"cfc60a1bd2a3121a5223bd539c5a389556dd45af","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-12-16 15:32:23.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19069/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18233/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"8af647bee8c67cbfaa2432218d5ea4829d12d33d","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-12-16 16:57:48.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"9043a06942105fe5ce7c1f6f81b00f3abef95090","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-12-16 17:48:45.000000000","message":"Uploaded patch set 2: Commit message was updated.\n\nOutdated Votes:\n* Code-Review+1 (copy condition: \"changekind:NO_CHANGE OR is:MIN\")\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"e0ebbfe43291a05f8cfd1e7f4d9803b175f79f9d","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-12-16 17:49:26.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"c4307221efd9044edb10d19da68777c2d99e54b1","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-12-16 18:05:12.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19083/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18245/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"8083fbcd718ca7faabf29889324e5037304513a3","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-01-13 14:42:32.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"dced0b7f523fbc5373a46f23eb956a0ddfe14c5f","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-01-13 14:42:39.000000000","message":"Change has been successfully cherry-picked as 5e1468da186e65029316a359493e2d2353e21512","accounts_in_message":[],"_revision_number":3}],"current_revision":"5e1468da186e65029316a359493e2d2353e21512","revisions":{"8ce85065a9e0cc4d8ac6d7b13ef99f7177d116a9":{"kind":"REWORK","_number":1,"created":"2023-12-16 15:13:16.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/53/8053/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/53/8053/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/53/8053/1 \u0026\u0026 git checkout -b change-8053 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/53/8053/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/53/8053/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/53/8053/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/53/8053/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/53/8053/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7776438d45e3b3a8fcef66163547f389249b6277","subject":"target: drop deprecated code for mem2array and array2mem"}],"author":{"name":"Antonio Borneo","email":"antonio.borneo@foss.st.com","date":"2023-08-06 08:40:03.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-12-16 15:12:04.000000000","tz":60},"subject":"helper/command: drop unused variables","message":"helper/command: drop unused variables\n\nIn both functions script_debug() and script_command_args_alloc()\nthe variable len is never used, and Jim_GetString() does not\nmandate it.\n\nDrop the variable and pass NULL to Jim_GetString().\n\nChange-Id: I754b27a59c6087cde729496be42609d2a7145b0c\nSigned-off-by: Antonio Borneo \u003cantonio.borneo@foss.st.com\u003e\n"}},"cd72a3c0bb7d23cf5545f22a2ec5e599b93a27cd":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2023-12-16 17:48:45.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/53/8053/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/53/8053/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/53/8053/2 \u0026\u0026 git checkout -b change-8053 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/53/8053/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/53/8053/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/53/8053/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/53/8053/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/53/8053/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7776438d45e3b3a8fcef66163547f389249b6277","subject":"target: drop deprecated code for mem2array and array2mem"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-08-06 08:40:03.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-12-16 17:45:47.000000000","tz":60},"subject":"helper/command: drop unused variables","message":"helper/command: drop unused variables\n\nIn both functions script_debug() and script_command_args_alloc()\nthe variable len is never used, and Jim_GetString() does not\nmandate it.\n\nDrop the variable and pass NULL to Jim_GetString().\n\nChange-Id: I754b27a59c6087cde729496be42609d2a7145b0c\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"5e1468da186e65029316a359493e2d2353e21512":{"kind":"REWORK","_number":3,"created":"2024-01-13 14:42:39.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/53/8053/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/53/8053/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/53/8053/3 \u0026\u0026 git checkout -b change-8053 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/53/8053/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/53/8053/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/53/8053/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/53/8053/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/53/8053/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6e6d486de2c668e14f9534fab820eea305826753","subject":"target: drop deprecated code for mem2array and array2mem"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-08-06 08:40:03.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-01-13 14:42:39.000000000","tz":0},"subject":"helper/command: drop unused variables","message":"helper/command: drop unused variables\n\nIn both functions script_debug() and script_command_args_alloc()\nthe variable len is never used, and Jim_GetString() does not\nmandate it.\n\nDrop the variable and pass NULL to Jim_GetString().\n\nChange-Id: I754b27a59c6087cde729496be42609d2a7145b0c\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8053\nTested-by: jenkins\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}