)]}'
{"id":"openocd~master~I3e21ed7da50ca0bd072edbd49fca9740c81f95b0","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2023-12-16 17:49:48.000000000","reason":"\u003cGERRIT_ACCOUNT_1000021\u003e replied on the change","reason_account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}},"hashtags":[],"change_id":"I3e21ed7da50ca0bd072edbd49fca9740c81f95b0","subject":"helper/command: simplify exec_command()","status":"MERGED","created":"2023-12-16 15:13:16.000000000","updated":"2024-01-13 14:43:29.000000000","submitted":"2024-01-13 14:43:29.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8055","meta_rev_id":"4d7f4e435ec7d4bceaf93543ee4be5f3710828d8","_number":8055,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-01-13 14:43:29.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-01-13 14:43:29.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-12-16 16:04:54.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"d44bec0da72b6493f8efedf8066ea558cbcd804f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-12-16 15:13:16.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"95c94c52a83f807cef1122253c26582aa14a3776","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-12-16 16:04:54.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19070/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18235/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"d54bfb49dd9986d4c713e81f223007eeb4eadaf1","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-12-16 16:53:02.000000000","message":"Uploaded patch set 2: New patch set was added with same tree, parent tree, and commit message as Patch Set 1.\n\nCopied Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"068a137724582e7bf57999c5aa856463e5a62802","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-12-16 17:22:21.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19078/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18241/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"8673912d3f0b59ebd1dc7100a6f1d0f18a691fdd","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-12-16 17:41:17.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"ab778eb2718088a4d9917154495d14bc631f623d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-12-16 17:48:45.000000000","message":"Uploaded patch set 3: Commit message was updated.\n\nOutdated Votes:\n* Code-Review+1 (copy condition: \"changekind:NO_CHANGE OR is:MIN\")\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"7e2867e5e6f85cbd4e2fb3228f919d7f3fe02ac3","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-12-16 17:49:48.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"8b834efe49c356f103de04eb6d217053717a6797","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-12-16 18:32:12.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19081/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18247/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"438cd2a6240f84f53c502d26c8730d32a3505aab","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-01-13 14:43:25.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"4d7f4e435ec7d4bceaf93543ee4be5f3710828d8","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-01-13 14:43:29.000000000","message":"Change has been successfully cherry-picked as f9ea9ce24cf4423111a7fa033f8ceff61d17aa5b","accounts_in_message":[],"_revision_number":4}],"current_revision":"f9ea9ce24cf4423111a7fa033f8ceff61d17aa5b","revisions":{"633c27db769179bf7ecc89393d8930eb0f4fb843":{"kind":"REWORK","_number":1,"created":"2023-12-16 15:13:16.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/55/8055/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/55/8055/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/55/8055/1 \u0026\u0026 git checkout -b change-8055 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/55/8055/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/55/8055/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/55/8055/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/55/8055/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/55/8055/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e39ee7f0e70f40f0dd8824fb302f5a15c723b7e2","subject":"helper/command: simplify script_command_args_alloc()"}],"author":{"name":"Antonio Borneo","email":"antonio.borneo@foss.st.com","date":"2023-08-06 09:34:28.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-12-16 15:12:04.000000000","tz":60},"subject":"helper/command: simplify exec_command()","message":"helper/command: simplify exec_command()\n\nThe jimtcl interpreter guarantees that the Jim objects in argv[]\nare not deallocated during the command execution. Thus, there is\nno need to copy the string content of argv[].\n\nSimplify exec_command() by inlining its two sub-functions and\ndropping the strdup().\n\nWhile there, add a LOG_ERROR() for out of memory.\n\nChange-Id: I3e21ed7da50ca0bd072edbd49fca9740c81f95b0\nSigned-off-by: Antonio Borneo \u003cantonio.borneo@foss.st.com\u003e\n"}},"55b0bab79c1cb29a467e501780372554e8549e64":{"kind":"NO_CHANGE","_number":2,"created":"2023-12-16 16:53:02.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/55/8055/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/55/8055/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/55/8055/2 \u0026\u0026 git checkout -b change-8055 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/55/8055/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/55/8055/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/55/8055/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/55/8055/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/55/8055/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"596ffc95606ad1613d9b0f9b733aff80cce18f4b","subject":"helper/command: simplify script_command_args_alloc()"}],"author":{"name":"Antonio Borneo","email":"antonio.borneo@foss.st.com","date":"2023-08-06 09:34:28.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-12-16 16:52:21.000000000","tz":60},"subject":"helper/command: simplify exec_command()","message":"helper/command: simplify exec_command()\n\nThe jimtcl interpreter guarantees that the Jim objects in argv[]\nare not deallocated during the command execution. Thus, there is\nno need to copy the string content of argv[].\n\nSimplify exec_command() by inlining its two sub-functions and\ndropping the strdup().\n\nWhile there, add a LOG_ERROR() for out of memory.\n\nChange-Id: I3e21ed7da50ca0bd072edbd49fca9740c81f95b0\nSigned-off-by: Antonio Borneo \u003cantonio.borneo@foss.st.com\u003e\n"}},"44d57bb7deb65cb3c165ac91114224321de45047":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2023-12-16 17:48:45.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/55/8055/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/55/8055/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/55/8055/3 \u0026\u0026 git checkout -b change-8055 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/55/8055/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/55/8055/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/55/8055/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/55/8055/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/55/8055/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f69c0ba1e8b2eb8f5d879e36cda55d754eed591a","subject":"helper/command: simplify script_command_args_alloc()"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-08-06 09:34:28.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-12-16 17:46:19.000000000","tz":60},"subject":"helper/command: simplify exec_command()","message":"helper/command: simplify exec_command()\n\nThe jimtcl interpreter guarantees that the Jim objects in argv[]\nare not deallocated during the command execution. Thus, there is\nno need to copy the string content of argv[].\n\nSimplify exec_command() by inlining its two sub-functions and\ndropping the strdup().\n\nWhile there, add a LOG_ERROR() for out of memory.\n\nChange-Id: I3e21ed7da50ca0bd072edbd49fca9740c81f95b0\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"f9ea9ce24cf4423111a7fa033f8ceff61d17aa5b":{"kind":"REWORK","_number":4,"created":"2024-01-13 14:43:29.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/55/8055/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/55/8055/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/55/8055/4 \u0026\u0026 git checkout -b change-8055 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/55/8055/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/55/8055/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/55/8055/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/55/8055/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/55/8055/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"712c1244e8486bb4519ad0144a03c3c48c030214","subject":"helper/command: simplify script_command_args_alloc()"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-08-06 09:34:28.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-01-13 14:43:29.000000000","tz":0},"subject":"helper/command: simplify exec_command()","message":"helper/command: simplify exec_command()\n\nThe jimtcl interpreter guarantees that the Jim objects in argv[]\nare not deallocated during the command execution. Thus, there is\nno need to copy the string content of argv[].\n\nSimplify exec_command() by inlining its two sub-functions and\ndropping the strdup().\n\nWhile there, add a LOG_ERROR() for out of memory.\n\nChange-Id: I3e21ed7da50ca0bd072edbd49fca9740c81f95b0\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8055\nTested-by: jenkins\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}