)]}'
{"id":"openocd~master~If37c5f20e9a71349f77ba1571baf1e6778e28aa5","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2023-12-16 17:50:01.000000000","reason":"\u003cGERRIT_ACCOUNT_1000021\u003e replied on the change","reason_account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}},"hashtags":[],"change_id":"If37c5f20e9a71349f77ba1571baf1e6778e28aa5","subject":"helper/command: pass command arguments also as Jim_Obj","status":"MERGED","created":"2023-12-16 15:13:16.000000000","updated":"2024-01-13 14:44:32.000000000","submitted":"2024-01-13 14:44:32.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8057","meta_rev_id":"f87bdc8ddc200d7f31b3efb7736e750892b20b22","_number":8057,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-01-13 14:44:32.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-01-13 14:44:32.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-12-16 16:53:19.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"af95c7d5db73a5d5b78112f276e66f610a91e836","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-12-16 15:13:16.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"4767e4f19094f8fcdf0d8ff69bed9d45448b36c4","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-12-16 16:53:02.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"7f8b9e825b8018f6bdae6893f0b1227d3f9fd343","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-12-16 16:53:19.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit-build/18237/ : ABORTED\n\nhttps://build.openocd.org/job/openocd-gerrit/19071/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"5e41584eea8befaf1c0edea35be6b5c50593ee70","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-12-16 17:47:25.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19079/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18243/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"81398dbdfa8d668f00d6befc28def697e33ec51f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-12-16 17:48:45.000000000","message":"Uploaded patch set 3: Commit message was updated.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"c9efd09e980b4f0c1d30321b3027daf8dddbfe1e","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-12-16 17:50:01.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"2152f7b853004b11a18b05bed805b60a85a50533","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-12-16 18:45:20.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19085/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18248/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"689e4c026ea283ff3616ee6f454095993665a5ae","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-01-13 14:44:27.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"f87bdc8ddc200d7f31b3efb7736e750892b20b22","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-01-13 14:44:32.000000000","message":"Change has been successfully cherry-picked as e680841fd276439844ecf340f4005860d6e22582","accounts_in_message":[],"_revision_number":4}],"current_revision":"e680841fd276439844ecf340f4005860d6e22582","revisions":{"e680841fd276439844ecf340f4005860d6e22582":{"kind":"REWORK","_number":4,"created":"2024-01-13 14:44:32.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/57/8057/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/57/8057/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/57/8057/4 \u0026\u0026 git checkout -b change-8057 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/57/8057/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/57/8057/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/57/8057/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/57/8057/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/57/8057/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f857db98bd2a3d97ada208a8137c48c47e9d3a78","subject":"helper/command: inline run_command() in exec_command()"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-08-06 10:38:54.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-01-13 14:44:32.000000000","tz":0},"subject":"helper/command: pass command arguments also as Jim_Obj","message":"helper/command: pass command arguments also as Jim_Obj\n\nSome OpenOCD command gets fragment of TCL scripts as command-line\nargument, fragments that will be kept and executed later on.\nE.g. the command \u0027configure\u0027 gets the body of an OpenOCD event:\n\t$TARGET configure -event halted {TCL code}\n\nThese commands store the argument as a Jim_Obj and pass it to the\njimtcl interpreter when the TCL fragment has to be executed.\nUsing Jim_Obj as storage is relevant to let the jimtcl interpreter\nto recover extra info of the TCL fragment, like the file-name and\nthe line-number that contain the fragment, that will be printed\nout in case of run-time errors.\n\nWhile converting the commands to COMMAND_HANDLER, we should avoid\nstoring the argument as C strings otherwise we will loose precious\ninfo in case of run-time errors making challenging the debugging\nof such TCL fragments.\n\nExtend the struct command_invocation to contain the array that\npoints to the Jim_Obj of the command arguments.\nThis will be used while converting commands to COMMAND_HANDLER.\n\nChange-Id: If37c5f20e9a71349f77ba1571baf1e6778e28aa5\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8057\nTested-by: jenkins\n"}},"4326886533af217f36a20ed137c88d8c588aff80":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2023-12-16 17:48:45.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/57/8057/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/57/8057/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/57/8057/3 \u0026\u0026 git checkout -b change-8057 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/57/8057/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/57/8057/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/57/8057/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/57/8057/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/57/8057/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6ff9a5e89b1f9805f4e3f306760a79b615c45ac1","subject":"helper/command: inline run_command() in exec_command()"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-08-06 10:38:54.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-12-16 17:47:23.000000000","tz":60},"subject":"helper/command: pass command arguments also as Jim_Obj","message":"helper/command: pass command arguments also as Jim_Obj\n\nSome OpenOCD command gets fragment of TCL scripts as command-line\nargument, fragments that will be kept and executed later on.\nE.g. the command \u0027configure\u0027 gets the body of an OpenOCD event:\n\t$TARGET configure -event halted {TCL code}\n\nThese commands store the argument as a Jim_Obj and pass it to the\njimtcl interpreter when the TCL fragment has to be executed.\nUsing Jim_Obj as storage is relevant to let the jimtcl interpreter\nto recover extra info of the TCL fragment, like the file-name and\nthe line-number that contain the fragment, that will be printed\nout in case of run-time errors.\n\nWhile converting the commands to COMMAND_HANDLER, we should avoid\nstoring the argument as C strings otherwise we will loose precious\ninfo in case of run-time errors making challenging the debugging\nof such TCL fragments.\n\nExtend the struct command_invocation to contain the array that\npoints to the Jim_Obj of the command arguments.\nThis will be used while converting commands to COMMAND_HANDLER.\n\nChange-Id: If37c5f20e9a71349f77ba1571baf1e6778e28aa5\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"642e748c6537d50e1e35e4839c6e1581e07e334e":{"kind":"REWORK","_number":2,"created":"2023-12-16 16:53:02.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/57/8057/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/57/8057/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/57/8057/2 \u0026\u0026 git checkout -b change-8057 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/57/8057/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/57/8057/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/57/8057/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/57/8057/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/57/8057/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d0669d2f68bf08ed29f5d9f05ae38a2266557eda","subject":"helper/command: inline run_command() in exec_command()"}],"author":{"name":"Antonio Borneo","email":"antonio.borneo@foss.st.com","date":"2023-08-06 10:38:54.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-12-16 16:52:21.000000000","tz":60},"subject":"helper/command: pass command arguments also as Jim_Obj","message":"helper/command: pass command arguments also as Jim_Obj\n\nSome OpenOCD command gets fragment of TCL scripts as command-line\nargument, fragments that will be kept and executed later on.\nE.g. the command \u0027configure\u0027 gets the body of an OpenOCD event:\n\t$TARGET configure -event halted {TCL code}\n\nThese commands store the argument as a Jim_Obj and pass it to the\njimtcl interpreter when the TCL fragment has to be executed.\nUsing Jim_Obj as storage is relevant to let the jimtcl interpreter\nto recover extra info of the TCL fragment, like the file-name and\nthe line-number that contain the fragment, that will be printed\nout in case of run-time errors.\n\nWhile converting the commands to COMMAND_HANDLER, we should avoid\nstoring the argument as C strings otherwise we will loose precious\ninfo in case of run-time errors making challenging the debugging\nof such TCL fragments.\n\nExtend the struct command_invocation to contain the array that\npoints to the Jim_Obj of the command arguments.\nThis will be used while converting commands to COMMAND_HANDLER.\n\nChange-Id: If37c5f20e9a71349f77ba1571baf1e6778e28aa5\nSigned-off-by: Antonio Borneo \u003cantonio.borneo@foss.st.com\u003e\n"}},"b310a992403dec562b37792817ba1dee15e9a6c2":{"kind":"REWORK","_number":1,"created":"2023-12-16 15:13:16.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/57/8057/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/57/8057/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/57/8057/1 \u0026\u0026 git checkout -b change-8057 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/57/8057/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/57/8057/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/57/8057/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/57/8057/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/57/8057/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c8aa198bb2905cf87c4e3ebe26510360f4fc4564","subject":"helper/command: inline run_command() in exec_command()"}],"author":{"name":"Antonio Borneo","email":"antonio.borneo@foss.st.com","date":"2023-08-06 10:38:54.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-12-16 15:12:04.000000000","tz":60},"subject":"helper/command: pass command arguments also as Jim_Obj","message":"helper/command: pass command arguments also as Jim_Obj\n\nSome OpenOCD command gets fragment of TCL scripts as command-line\nargument, fragments that will be kept and executed later on.\nE.g. the command \u0027configure\u0027 gets the body of an OpenOCD event:\n\t$TARGET configure -event halted {TCL code}\n\nThese commands store the argument as a Jim_Obj and pass it to the\njimtcl interpreter when the TCL fragment has to be executed.\nUsing Jim_Obj as storage is relevant to let the jimtcl interpreter\nto recover extra info of the TCL fragment, like the file-name and\nthe line-number that contain the fragment, that will be printed\nout in case of run-time errors.\n\nWhile converting the commands to COMMAND_HANDLER, we should avoid\nstoring the argument as C strings otherwise we will loose precious\ninfo in case of run-time errors making challenging the debugging\nof such TCL fragments.\n\nExtend the struct command_invocation to contain the array that\npoints to the Jim_Obj of the command arguments.\nThis will be used while converting commands to COMMAND_HANDLER.\n\nChange-Id: If37c5f20e9a71349f77ba1571baf1e6778e28aa5\nSigned-off-by: Antonio Borneo \u003cantonio.borneo@foss.st.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}