)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"25130170840ee4350f56a505b6de9f154c1f0ab8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d0cd488b_380682c5","updated":"2023-12-27 21:40:52.000000000","message":"Thanks for noticing it!","commit_id":"db588d06dc537fcf3df4fac21a7eb96215a5c84c"},{"author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"change_message_id":"cb719b1c20e5c067db19fad122c5257f2af4ceed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7b2f6f30_fa59a42e","updated":"2024-01-02 07:12:14.000000000","message":"LGTM, thanks.","commit_id":"adc0f7e8a41d5a97e8eed0835bba487b263d8973"},{"author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"change_message_id":"d18a51eee7e3a944008335aa12e44edf9a42937d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2fd608c1_a3e866ff","updated":"2023-12-28 13:20:34.000000000","message":"Thank you for the review! I have addressed your concerns about the meaning of `address` option. Please, take a look.","commit_id":"adc0f7e8a41d5a97e8eed0835bba487b263d8973"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"0eb91099ff3d91a517d2e0449d76def0fd0d13ae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3aaf1314_bc78077e","updated":"2023-12-28 16:06:02.000000000","message":"Thanks!","commit_id":"adc0f7e8a41d5a97e8eed0835bba487b263d8973"}],"doc/openocd.texi":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"25130170840ee4350f56a505b6de9f154c1f0ab8","unresolved":true,"context_lines":[{"line_number":9336,"context_line":"separately."},{"line_number":9337,"context_line":"@end deffn"},{"line_number":9338,"context_line":""},{"line_number":9339,"context_line":"@deffn {Command} {load_image} filename [address [@option{bin}|@option{ihex}|@option{elf}|@option{s19} [@option{min_addr} [@option{max_length}]]]]"},{"line_number":9340,"context_line":"Load image from file @var{filename} to target memory offset by @var{address} from its load address."},{"line_number":9341,"context_line":"The file format may optionally be specified"},{"line_number":9342,"context_line":"(@option{bin}, @option{ihex}, @option{elf}, or @option{s19})."}],"source_content_type":"text/x-texinfo","patch_set":1,"id":"3d18e3cb_44783a35","line":9339,"range":{"start_line":9339,"start_character":49,"end_line":9339,"end_character":99},"updated":"2023-12-27 21:40:52.000000000","message":"Not related to this change: I noticed that some format options tested in identify_image_type() are not listed here","commit_id":"db588d06dc537fcf3df4fac21a7eb96215a5c84c"},{"author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"change_message_id":"d18a51eee7e3a944008335aa12e44edf9a42937d","unresolved":true,"context_lines":[{"line_number":9336,"context_line":"separately."},{"line_number":9337,"context_line":"@end deffn"},{"line_number":9338,"context_line":""},{"line_number":9339,"context_line":"@deffn {Command} {load_image} filename [address [@option{bin}|@option{ihex}|@option{elf}|@option{s19} [@option{min_addr} [@option{max_length}]]]]"},{"line_number":9340,"context_line":"Load image from file @var{filename} to target memory offset by @var{address} from its load address."},{"line_number":9341,"context_line":"The file format may optionally be specified"},{"line_number":9342,"context_line":"(@option{bin}, @option{ihex}, @option{elf}, or @option{s19})."}],"source_content_type":"text/x-texinfo","patch_set":1,"id":"92f682eb_9ba8f18c","line":9339,"range":{"start_line":9339,"start_character":49,"end_line":9339,"end_character":99},"in_reply_to":"3d18e3cb_44783a35","updated":"2023-12-28 13:20:34.000000000","message":"This is true. Though I didn\u0027t find any uses of `mem` and `build` formats in the code base, so I\u0027m not sure if these are stable/tested enough to be exposed in the interface.","commit_id":"db588d06dc537fcf3df4fac21a7eb96215a5c84c"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"0eb91099ff3d91a517d2e0449d76def0fd0d13ae","unresolved":true,"context_lines":[{"line_number":9336,"context_line":"separately."},{"line_number":9337,"context_line":"@end deffn"},{"line_number":9338,"context_line":""},{"line_number":9339,"context_line":"@deffn {Command} {load_image} filename [address [@option{bin}|@option{ihex}|@option{elf}|@option{s19} [@option{min_addr} [@option{max_length}]]]]"},{"line_number":9340,"context_line":"Load image from file @var{filename} to target memory offset by @var{address} from its load address."},{"line_number":9341,"context_line":"The file format may optionally be specified"},{"line_number":9342,"context_line":"(@option{bin}, @option{ihex}, @option{elf}, or @option{s19})."}],"source_content_type":"text/x-texinfo","patch_set":1,"id":"b66256aa_ea410304","line":9339,"range":{"start_line":9339,"start_character":49,"end_line":9339,"end_character":99},"in_reply_to":"92f682eb_9ba8f18c","updated":"2023-12-28 16:06:02.000000000","message":"Well `mem` format is kind of mystery even for me.\nI searched gitweb blame and found very little info:\n```\nCommit 3d026ce94393e5e53cccb5d5364f9d500d5b3733\nAuthor: drath\nDate: 15/06/2007\n\n- added support for pseudo image type \"mem\", currently only used for etm analysis: \"etm image \u003ctarget#\u003e \u003cdummy base address\u003e mem\"\n```\n\n`build` format is internal and used for handling gdb load remote commands vFlash...\n\nSo just `s19` is really missing in test_image, verify_image and verify_image_checksum.","commit_id":"db588d06dc537fcf3df4fac21a7eb96215a5c84c"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"25130170840ee4350f56a505b6de9f154c1f0ab8","unresolved":true,"context_lines":[{"line_number":9337,"context_line":"@end deffn"},{"line_number":9338,"context_line":""},{"line_number":9339,"context_line":"@deffn {Command} {load_image} filename [address [@option{bin}|@option{ihex}|@option{elf}|@option{s19} [@option{min_addr} [@option{max_length}]]]]"},{"line_number":9340,"context_line":"Load image from file @var{filename} to target memory offset by @var{address} from its load address."},{"line_number":9341,"context_line":"The file format may optionally be specified"},{"line_number":9342,"context_line":"(@option{bin}, @option{ihex}, @option{elf}, or @option{s19})."},{"line_number":9343,"context_line":"In addition the following arguments may be specified:"}],"source_content_type":"text/x-texinfo","patch_set":1,"id":"452b7c2a_1fc8e4a6","line":9340,"range":{"start_line":9340,"start_character":0,"end_line":9340,"end_character":99},"updated":"2023-12-27 21:40:52.000000000","message":"IMO this text deserves some extension to state what happens without address.\nThe description might be split for binary file (address is the real load address)\nand other formats (address is used as an offset to the file format defined addressing)","commit_id":"db588d06dc537fcf3df4fac21a7eb96215a5c84c"},{"author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"change_message_id":"d18a51eee7e3a944008335aa12e44edf9a42937d","unresolved":true,"context_lines":[{"line_number":9337,"context_line":"@end deffn"},{"line_number":9338,"context_line":""},{"line_number":9339,"context_line":"@deffn {Command} {load_image} filename [address [@option{bin}|@option{ihex}|@option{elf}|@option{s19} [@option{min_addr} [@option{max_length}]]]]"},{"line_number":9340,"context_line":"Load image from file @var{filename} to target memory offset by @var{address} from its load address."},{"line_number":9341,"context_line":"The file format may optionally be specified"},{"line_number":9342,"context_line":"(@option{bin}, @option{ihex}, @option{elf}, or @option{s19})."},{"line_number":9343,"context_line":"In addition the following arguments may be specified:"}],"source_content_type":"text/x-texinfo","patch_set":1,"id":"a5161e50_9476f86d","line":9340,"range":{"start_line":9340,"start_character":0,"end_line":9340,"end_character":99},"in_reply_to":"452b7c2a_1fc8e4a6","updated":"2023-12-28 13:20:34.000000000","message":"Addressed.","commit_id":"db588d06dc537fcf3df4fac21a7eb96215a5c84c"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"0eb91099ff3d91a517d2e0449d76def0fd0d13ae","unresolved":false,"context_lines":[{"line_number":9337,"context_line":"@end deffn"},{"line_number":9338,"context_line":""},{"line_number":9339,"context_line":"@deffn {Command} {load_image} filename [address [@option{bin}|@option{ihex}|@option{elf}|@option{s19} [@option{min_addr} [@option{max_length}]]]]"},{"line_number":9340,"context_line":"Load image from file @var{filename} to target memory offset by @var{address} from its load address."},{"line_number":9341,"context_line":"The file format may optionally be specified"},{"line_number":9342,"context_line":"(@option{bin}, @option{ihex}, @option{elf}, or @option{s19})."},{"line_number":9343,"context_line":"In addition the following arguments may be specified:"}],"source_content_type":"text/x-texinfo","patch_set":1,"id":"3c6c27cd_21e8b0a1","line":9340,"range":{"start_line":9340,"start_character":0,"end_line":9340,"end_character":99},"in_reply_to":"a5161e50_9476f86d","updated":"2023-12-28 16:06:02.000000000","message":"Done","commit_id":"db588d06dc537fcf3df4fac21a7eb96215a5c84c"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"25130170840ee4350f56a505b6de9f154c1f0ab8","unresolved":true,"context_lines":[{"line_number":9362,"context_line":"@end deffn"},{"line_number":9363,"context_line":""},{"line_number":9364,"context_line":"@deffn {Command} {verify_image} filename [address [@option{bin}|@option{ihex}|@option{elf}]]"},{"line_number":9365,"context_line":"Verify @var{filename} against target memory starting at @var{address}."},{"line_number":9366,"context_line":"The file format may optionally be specified"},{"line_number":9367,"context_line":"(@option{bin}, @option{ihex}, or @option{elf})"},{"line_number":9368,"context_line":"This will first attempt a comparison using a CRC checksum, if this fails it will try a binary compare."}],"source_content_type":"text/x-texinfo","patch_set":1,"id":"afec196d_b0441129","line":9365,"range":{"start_line":9365,"start_character":44,"end_line":9365,"end_character":70},"updated":"2023-12-27 21:40:52.000000000","message":"Also very vague...","commit_id":"db588d06dc537fcf3df4fac21a7eb96215a5c84c"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"0eb91099ff3d91a517d2e0449d76def0fd0d13ae","unresolved":false,"context_lines":[{"line_number":9362,"context_line":"@end deffn"},{"line_number":9363,"context_line":""},{"line_number":9364,"context_line":"@deffn {Command} {verify_image} filename [address [@option{bin}|@option{ihex}|@option{elf}]]"},{"line_number":9365,"context_line":"Verify @var{filename} against target memory starting at @var{address}."},{"line_number":9366,"context_line":"The file format may optionally be specified"},{"line_number":9367,"context_line":"(@option{bin}, @option{ihex}, or @option{elf})"},{"line_number":9368,"context_line":"This will first attempt a comparison using a CRC checksum, if this fails it will try a binary compare."}],"source_content_type":"text/x-texinfo","patch_set":1,"id":"82668b53_720c1956","line":9365,"range":{"start_line":9365,"start_character":44,"end_line":9365,"end_character":70},"in_reply_to":"8264be0d_619d25ef","updated":"2023-12-28 16:06:02.000000000","message":"Done","commit_id":"db588d06dc537fcf3df4fac21a7eb96215a5c84c"},{"author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"change_message_id":"d18a51eee7e3a944008335aa12e44edf9a42937d","unresolved":true,"context_lines":[{"line_number":9362,"context_line":"@end deffn"},{"line_number":9363,"context_line":""},{"line_number":9364,"context_line":"@deffn {Command} {verify_image} filename [address [@option{bin}|@option{ihex}|@option{elf}]]"},{"line_number":9365,"context_line":"Verify @var{filename} against target memory starting at @var{address}."},{"line_number":9366,"context_line":"The file format may optionally be specified"},{"line_number":9367,"context_line":"(@option{bin}, @option{ihex}, or @option{elf})"},{"line_number":9368,"context_line":"This will first attempt a comparison using a CRC checksum, if this fails it will try a binary compare."}],"source_content_type":"text/x-texinfo","patch_set":1,"id":"8264be0d_619d25ef","line":9365,"range":{"start_line":9365,"start_character":44,"end_line":9365,"end_character":70},"in_reply_to":"afec196d_b0441129","updated":"2023-12-28 13:20:34.000000000","message":"Addressed.","commit_id":"db588d06dc537fcf3df4fac21a7eb96215a5c84c"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"25130170840ee4350f56a505b6de9f154c1f0ab8","unresolved":true,"context_lines":[{"line_number":9369,"context_line":"@end deffn"},{"line_number":9370,"context_line":""},{"line_number":9371,"context_line":"@deffn {Command} {verify_image_checksum} filename [address [@option{bin}|@option{ihex}|@option{elf}]]"},{"line_number":9372,"context_line":"Verify @var{filename} against target memory starting at @var{address}."},{"line_number":9373,"context_line":"The file format may optionally be specified"},{"line_number":9374,"context_line":"(@option{bin}, @option{ihex}, or @option{elf})"},{"line_number":9375,"context_line":"This perform a comparison using a CRC checksum only"}],"source_content_type":"text/x-texinfo","patch_set":1,"id":"63260d99_00c77a4e","line":9372,"range":{"start_line":9372,"start_character":44,"end_line":9372,"end_character":69},"updated":"2023-12-27 21:40:52.000000000","message":"Same as above","commit_id":"db588d06dc537fcf3df4fac21a7eb96215a5c84c"},{"author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"change_message_id":"d18a51eee7e3a944008335aa12e44edf9a42937d","unresolved":true,"context_lines":[{"line_number":9369,"context_line":"@end deffn"},{"line_number":9370,"context_line":""},{"line_number":9371,"context_line":"@deffn {Command} {verify_image_checksum} filename [address [@option{bin}|@option{ihex}|@option{elf}]]"},{"line_number":9372,"context_line":"Verify @var{filename} against target memory starting at @var{address}."},{"line_number":9373,"context_line":"The file format may optionally be specified"},{"line_number":9374,"context_line":"(@option{bin}, @option{ihex}, or @option{elf})"},{"line_number":9375,"context_line":"This perform a comparison using a CRC checksum only"}],"source_content_type":"text/x-texinfo","patch_set":1,"id":"89867588_975ef8fd","line":9372,"range":{"start_line":9372,"start_character":44,"end_line":9372,"end_character":69},"in_reply_to":"63260d99_00c77a4e","updated":"2023-12-28 13:20:34.000000000","message":"Addressed.","commit_id":"db588d06dc537fcf3df4fac21a7eb96215a5c84c"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"0eb91099ff3d91a517d2e0449d76def0fd0d13ae","unresolved":false,"context_lines":[{"line_number":9369,"context_line":"@end deffn"},{"line_number":9370,"context_line":""},{"line_number":9371,"context_line":"@deffn {Command} {verify_image_checksum} filename [address [@option{bin}|@option{ihex}|@option{elf}]]"},{"line_number":9372,"context_line":"Verify @var{filename} against target memory starting at @var{address}."},{"line_number":9373,"context_line":"The file format may optionally be specified"},{"line_number":9374,"context_line":"(@option{bin}, @option{ihex}, or @option{elf})"},{"line_number":9375,"context_line":"This perform a comparison using a CRC checksum only"}],"source_content_type":"text/x-texinfo","patch_set":1,"id":"52eb1396_2b472df3","line":9372,"range":{"start_line":9372,"start_character":44,"end_line":9372,"end_character":69},"in_reply_to":"89867588_975ef8fd","updated":"2023-12-28 16:06:02.000000000","message":"Done","commit_id":"db588d06dc537fcf3df4fac21a7eb96215a5c84c"}]}